- Dillo-dev - lists.mailman3.com

Test (for posting problems), please ignore
by onepoint＠starurchin.org Oct. 27, 2007

Oct. 27, 2007

Lets see if Jorge has has fixed whatever it was that stopped my posts getting through... Jeremy Henty

1 0

directory listings?
by hans＠stare.cz Oct. 22, 2007

Oct. 22, 2007

On Oct 19 19:33:56, dillo-dev-bounces(a)dillo.org wrote: > On Thu, Oct 18, 2007 at 02:27:57PM +0200, Jan Stary wrote: > > Hi all, > > > > dillo-fltk http://stare.cz/~hans/foto/ gives me a directory > > listing as it should. It's full of subdirectories, and they > > are all the same (just contain JPEGs). > > > > Now when I click on _some_ of the links, I get a correct directory > > listing again (of the subdirectory). When I click on _some_ others > > I get nothing, just a blank page (gray). > > > > [...] > > Please try the CVS code on this. With current code, I cannot even test it, because dillo keeps "Connecting to server" forever, giving the following message: $ dillo-fltk http://stare.cz/~hans/foto/ prefs: Can't open dillorc2 file: /home/hans/.dillo/dillorc2 prefs: Can't open dillorc2 file: /usr/local/etc/dillorc prefs: Using internal defaults. dillo_dns_init: Here we go! (threaded) Enabling cookies as from cookiesrc... Nav_open_url: Url=>http://stare.cz/~hans/foto/< Dns_server [0]: stare.cz is 0x7f7b8640 Connecting to 88.208.90.43 ** ERROR **: IO_fd_write_cb: call on already closed io! a_UIcmd_close_bw ... until I kill it. (The server is acessible, the same URL can be browsed with lynx.) Jan

2 1

drag scrolling as in good old dillo1
by Johannes.Hofmann＠gmx.de Oct. 21, 2007

Oct. 21, 2007

Hi, here is a patch to enable drag scrolling with the middle mouse button as in dillo1. For me from now only the "Backspace" hotkey is missing for daily browsing - apart from the occasional crashes of course :-) Johannes diff --git a/dw/fltkviewport.cc b/dw/fltkviewport.cc --- a/dw/fltkviewport.cc +++ b/dw/fltkviewport.cc @@ -47,6 +47,7 @@ FltkViewport::FltkViewport (int x, int y vscrollbar->callback (vscrollbarCallback, this); scrollX = scrollY = 0; + dragScrolling = 0; gadgetOrientation[0] = GADGET_HORIZONTAL; gadgetOrientation[1] = GADGET_HORIZONTAL; @@ -202,6 +203,34 @@ int FltkViewport::handle (int event) /** \bug Undraw focus box. */ return 1; + case ::fltk::PUSH: + if (::fltk::event_button() == ::fltk::MiddleButton) { + dragScrolling = 1; + dragX = ::fltk::event_x(); + dragY = ::fltk::event_y(); + /* pass event so that middle click can open link in new window */ + FltkWidgetView::handle (event); + return 1; + } + break; + + case ::fltk::DRAG: + if (::fltk::event_button() == ::fltk::MiddleButton) { + if (dragScrolling) { + scroll(dragX - ::fltk::event_x(), dragY - ::fltk::event_y()); + dragX = ::fltk::event_x(); + dragY = ::fltk::event_y(); + return 1; + } + } + break; + + case ::fltk::RELEASE: + if (::fltk::event_button() == ::fltk::MiddleButton) { + dragScrolling = 0; + } + break; + case ::fltk::SHORTCUT: switch (::fltk::event_key()) { case PageUpKey: @@ -236,12 +265,9 @@ int FltkViewport::handle (int event) scrollTo (canvasWidth, canvasHeight); /* gets adjusted in scroll() */ return 1; } + } - return FltkWidgetView::handle (event); - - default: - return FltkWidgetView::handle (event); - } + return FltkWidgetView::handle (event); } // ---------------------------------------------------------------------- diff --git a/dw/fltkviewport.hh b/dw/fltkviewport.hh --- a/dw/fltkviewport.hh +++ b/dw/fltkviewport.hh @@ -21,6 +21,7 @@ private: int scrollX, scrollY; int scrollDX, scrollDY; + int dragScrolling, dragX, dragY; ::fltk::Scrollbar *vscrollbar, *hscrollbar;

2 1

bug: non-ascii characters not displayed correctly in the title bar
by matthias.franz＠ujf-grenoble.fr Oct. 20, 2007

Oct. 20, 2007

Hi, by default, I use Latin1 encoding on my machine, not UTF-8. Dillo2 does not do UTF-8 -> Latin1 conversion for the title bar. Here is an example: <title>dillô</title> <body> dillô </body> You don't get "dill?" in the title bar, but "dill??". Cheers, -- Matthias Franz

2 2

directory listings?
by hans＠stare.cz Oct. 20, 2007

Oct. 20, 2007

Hi all, dillo-fltk http://stare.cz/~hans/foto/ gives me a directory listing as it should. It's full of subdirectories, and they are all the same (just contain JPEGs). Now when I click on _some_ of the links, I get a correct directory listing again (of the subdirectory). When I click on _some_ others I get nothing, just a blank page (gray). Dillo obviously knows the page source, because it shows nonzero bugs in the bug button, consistently saying ([num of jpegs in the subdirectory] + 3); for example, clicking on http://stare.cz/~hans/foto/20071010-Barunka gives HTML warning: line 8, <pre> is not allowed to contain <img> HTML warning: line 9, <pre> is not allowed to contain <hr>. -- closing <pre> HTML warning: line 10, <pre> is not allowed to contain <img> HTML warning: line 11, <pre> is not allowed to contain <img> HTML warning: line 12, <pre> is not allowed to contain <img> HTML warning: line 13, <pre> is not allowed to contain <img> (for other subdirs of http://stare.cz/~hans/foto/ the number of bug lines just differs by the number of JPEGs); but the content of the page itself is blank. Then again, for some other subdir (which just contains different JPEGs and has a different name, but is otherwise equivalent), dillo shows the correct listing (including two spacing "dots" and a "parent directory" icon, which probably make for the +3 bugs; which is another dillo bug possibly :-) A listing of subdirectory such as http://stare.cz/~hans/foto/20071010-Barunka/ is always displayed correctly if I just issue $ dillo-fltk http://stare.cz/~hans/foto/20071010-Barunka on the command line. The above only happens when I _click_ on a (sub)directory link in a (parent)directory listing. Also, listings of _some_ of the subdirectories (if they get listed at all) jump to the very bottom of the page, as when clicking on http://stare.cz/~hans/foto/2005-Metheny/ (obviously, this can only be seen if the directory listing is long enough). Again, this never happens when I acccess the listing directly from commandline. Jan

2 2

dillo crashes on (incorrect) tables
by matthias.franz＠ujf-grenoble.fr Oct. 19, 2007

Oct. 19, 2007

Hi, the following (syntactically incorrect) HTML code makes dillo2 crash on my machine. Dillo1 is fine. <html> <table> <tr></tr> <tr><td colspan="3"></td></tr> <td colspan="3"> </table> </html> Cheers, -- Matthias Franz

1 0

Re: receiver patch: html page menu working, image menu present but not called.
by place＠gobigwest.com Oct. 19, 2007

Oct. 19, 2007

Jorge wrote: > On Thu, Oct 18, 2007 at 10:56:39PM +0000, place wrote: > > > The fact of the linkblock not being freed in current code (see warning > > > from compiling html.cc) is just because I haven't found the clean & proper > > > place to hook Html_lb_free() (to widget destruction probably). IIRC there > > > was a ...connect_after() hook in GTK that worked ok after deletion of the > > > object (which I haven't yet found an analog in FLTK2). > > > > So I should regard "linkblock" as "the bag of event handling stuff"? Okay. > > It's a bag for links, form data etc... > > I've longed to get rid of it several times, but I don't see a > much cleaner approach. This may be the time, or maybe not. > > For instance, if the linkblock data is put inside the html > struct, and the whole turned into a class, it would look much > cleaner. It would also be clearer in the case of plain text (it > also receives the signal for page menu), and having a separate > linkblock or receiver for it seems odd. > > OTOH, the data that now belongs to the html-struct is freed > when parsing finishes, and it would remain inside the class, > which is a bit untidy, but if we make this part a pointer inside > the shiny new class, it could go NULL at freeing time. This looks > cleaner. Indeed. > > I now have new code for image signals. In an effort not to add an extra argument > > to the signals (which seemed hacky -- either an image_vs_link sort of argument, > > or an image_number sort of argument), I ended up making a vector of image > > receivers, one per image. I can't decide whether that is bad or reasonably > > sensible. If a better solution is obvious to you, please let me know. > > Not obvious, but I think of the case of pages with hundreds or > thousands of images (e.g.): > > http://chlamydia.fs.ei.tum.de/pub/DragonFly/packages/stable/DragonFly-1.10/… > > Memory consumption for this vector may grow too much. A single > int value working as an index to the proper URL/data from within > a single image signal receiver looks cleaner (from a distance :-) All right. > > So the image menu works, an ugly little button toggles image loading, and > > click-to-load works, though I don't have any placeholder image. > > More than enough for a start! And an opportunity for people who say "I'd love to help dillo, but don't know how to write code" to make a little tiny button... I was going to try having a single patch for all of that, but it was already teetering on the edge between small-enough and too-much. I think I'll try to pull out the menu and the button to send you first, since they're harmless, and then the rest after I redo it. > > (if only forms worked well enough to perform search queries, > > I just about wouldn't need my old dillo around anymore!) > > I know what you mean. Given that, plus the scrolling bug, > search text inside pages and anchors, it'd looks very sexy to me! > > > > BTW, not that it really matters at present, but I discovered that > > in Html_write_raw(), you can get token_start to be greater than bufsize. > > Go through the verbatim part at the top until token_start = buf_index = bufsize, > > then have the isspace() test right below it be true. > > It looks like this is why my iconv buffer code crashed often on me. > > Thanks for the report, I'll look at it when I find some time. > > > BTW, this duscussion is more than worth to have in dillo-dev. > Can I take it there? *cc:s dillo-dev, resists urge to trim quotes*

1 0

./configure confused about FLTK version
by hans＠stare.cz Oct. 19, 2007

Oct. 19, 2007

Hi all, it seems that the ./configure script as generated by ./autogen.sh of current cvs tree will happily go with fltk < 2, giving compilation errors later. Jan $ uname -a OpenBSD dell.stare.cz 4.1 GENERIC#0 i386 $ pkg_info | grep fltk fltk-1.1.7 Fast-Light Tool Kit $ pwd /home/hans/src $ cvs -z3 -d:pserver:anonymous@auriga.wearlab.de:/sfhome/cvs/dillo co dillo2 cvs checkout: Updating dillo2 [...] $ cvs -z3 -d:pserver:anonymous@auriga.wearlab.de:/sfhome/cvs/dillo co dw2 cvs checkout: Updating dw2 [...] $ ln -s dw2 dw-testbed $ cd dw-testbed $ export AUTOCONF_VERSION=2.61 $ export AUTOMAKE_VERSION=1.9 $ ./autogen.sh aclocal found autoheader found autoconf found automake found [Checks passed] Generating... [...] $ ./configure [...] checking FLTK2... yes [...] config.status: executing depfiles commands $ $ gmake [...] if g++ -DPACKAGE_NAME=\"\" -DPACKAGE_TARNAME=\"\" -DPACKAGE_VERSION=\"\" -DPACKAGE_STRING=\"\" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE=\"dw-testbed\" -DVERSION=\"0.0.43j\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_FCNTL_H=1 -DHAVE_UNISTD_H=1 -DHAVE_SYS_UIO_H=1 -I. -I. -I/usr/local/include -O2 -pipe -I/usr/local/include -I/usr/X11R6/include -g -O2 -D_REENTRANT -D_THREAD_SAFE -Wall -W -Wno-unused-parameter -MT libDw_fltk_a-fltkcomplexbutton.o -MD -MP -MF ".deps/libDw_fltk_a-fltkcomplexbutton.Tpo" -c -o libDw_fltk_a-fltkcomplexbutton.o `test -f 'fltkcomplexbutton.cc' || echo './'`fltkcomplexbutton.cc; \ then mv -f ".deps/libDw_fltk_a-fltkcomplexbutton.Tpo" ".deps/libDw_fltk_a-fltkcomplexbutton.Po"; else rm -f ".deps/libDw_fltk_a-fltkcomplexbutton.Tpo"; exit 1; fi fltkcomplexbutton.cc:23:25: fltk/events.h: No such file or directory fltkcomplexbutton.cc:24:25: fltk/damage.h: No such file or directory fltkcomplexbutton.cc:25:24: fltk/Group.h: No such file or directory fltkcomplexbutton.cc:26:22: fltk/Box.h: No such file or directory In file included from fltkcomplexbutton.cc:29: fltkcomplexbutton.hh:28:24: fltk/Group.h: No such file or directory In file included from fltkcomplexbutton.cc:29: fltkcomplexbutton.hh:34: error: `fltk' is not a class or namespace fltkcomplexbutton.hh:35: error: `Group' is not a class or namespace fltkcomplexbutton.hh:35: error: invalid base-class specification fltkcomplexbutton.hh:43: error: syntax error before `&' token fltkcomplexbutton.hh:45: error: syntax error before `::' token [...]

3 5

[patch] CPU usage when moving mouse on large page
by Johannes.Hofmann＠gmx.de Oct. 19, 2007

Oct. 19, 2007

Hi, here is another patch regarding the performance of dillo-fltk. It addresses the high CPU usage when moving the cursor on a large page especially if it contains many links and images. See http://chlamydia.fs.ei.tum.de/pub/DragonFly/packages/stable/DragonFly-1.10/… as an example. Note, that also dillo1 uses quite some CPU when moving the mouse on that page. The patch moves Layout::getWidgetAtPoint0() to Widget::getWidgetAtPoint() and makes it virtual so that widgets can provide an own optimzed version of that method. For the Textblock widget an optimized version is implemented that uses findLineIndex(). This patch is a bit more invasive than the scroll-patch, so I would appreciate comments from the dw author(s). Johannes diff --git a/dw/layout.cc b/dw/layout.cc --- a/dw/layout.cc +++ b/dw/layout.cc @@ -703,47 +703,6 @@ void Layout::leaveNotify (View *view, Bu } } -/** - * \brief Search recursively through widget. - * - * Used by dw::core::Layout:getWidgetAtPoint. - */ -Widget *Layout::getWidgetAtPoint0 (Widget *widget, int x, int y, int level) -{ - Iterator *it; - Widget *childAtPoint; - - //_MSG ("%*s-> examining the %s %p (%d, %d, %d x (%d + %d))\n", - // 3 * level, "", gtk_type_name (GTK_OBJECT_TYPE (widget)), widget, - // widget->allocation.x, widget->allocation.y, - // widget->allocation.width, widget->allocation.ascent, - // widget->allocation.descent); - - if (x >= widget->allocation.x && - y >= widget->allocation.y && - x <= widget->allocation.x + widget->allocation.width && - y <= widget->allocation.y + widget->getHeight ()) { - //_MSG ("%*s -> inside\n", 3 * level, ""); - /* - * Iterate over the children of this widget. Test recursively, whether - * the point is within the child (or one of its children...). If there - * is such a child, it is returned. Otherwise, this widget is returned. - */ - childAtPoint = NULL; - it = widget->iterator (Content::WIDGET, false); - - while (childAtPoint == NULL && it->next ()) - childAtPoint = getWidgetAtPoint0 (it->getContent()->widget, - x, y, level + 1); - - if (childAtPoint) - return childAtPoint; - else - return widget; - } else - return NULL; -} - /* * Return the widget at position (x, y). Return NULL, if there is no widget. */ @@ -752,7 +711,7 @@ Widget *Layout::getWidgetAtPoint (int x, //_MSG ("------------------------------------------------------------\n"); //_MSG ("widget at (%d, %d)\n", x, y); if (topLevel) - return getWidgetAtPoint0 (topLevel, x, y, 0); + return topLevel->getWidgetAtPoint (x, y, 0); else return NULL; } diff --git a/dw/layout.hh b/dw/layout.hh --- a/dw/layout.hh +++ b/dw/layout.hh @@ -87,7 +87,6 @@ private: enum ButtonEventType { BUTTON_PRESS, BUTTON_RELEASE, MOTION_NOTIFY }; - Widget *getWidgetAtPoint0 (Widget *widget, int x, int y, int level); Widget *getWidgetAtPoint (int x, int y); void moveToWidget (Widget *newWidgetAtPoint, ButtonState state); diff --git a/dw/textblock.cc b/dw/textblock.cc --- a/dw/textblock.cc +++ b/dw/textblock.cc @@ -1730,6 +1730,50 @@ void Textblock::addLinebreak (core::styl wordWrap (words->size () - 1); } + +/** + * \brief Search recursively through widget. + * + * This is an optimized version of the general + * dw::core::Widget::getWidgetAtPoint method. + */ +core::Widget *Textblock::getWidgetAtPoint(int x, int y, int level) +{ + int lineIndex, wordIndex; + Line *line; + + if (x < allocation.x || + y < allocation.y || + x > allocation.x + allocation.width || + y > allocation.y + getHeight ()) { + return NULL; + } + + lineIndex = findLineIndex (y - allocation.y); + + if (lineIndex < 0 || lineIndex >= lines->size ()) { + return this; + } + + line = lines->getRef (lineIndex); + + for (wordIndex = line->firstWord; wordIndex < line->lastWord; wordIndex++) { + Word *word = words->getRef (wordIndex); + + if (word->content.type == core::Content::WIDGET) { + core::Widget * childAtPoint; + childAtPoint = word->content.widget->getWidgetAtPoint (x, y, + level + 1); + if (childAtPoint) { + return childAtPoint; + } + } + } + + return this; +} + + /** * This function "hands" the last break of a page "over" to a parent * page. This is used for "collapsing spaces". diff --git a/dw/textblock.hh b/dw/textblock.hh --- a/dw/textblock.hh +++ b/dw/textblock.hh @@ -366,6 +366,7 @@ public: void addParbreak (int space, core::style::Style *style); void addLinebreak (core::style::Style *style); + core::Widget *getWidgetAtPoint (int x, int y, int level); void handOverBreak (core::style::Style *style); void changeLinkColor (int link, int newColor); void changeWordStyle (int from, int to, core::style::Style *style, diff --git a/dw/widget.cc b/dw/widget.cc --- a/dw/widget.cc +++ b/dw/widget.cc @@ -676,6 +676,48 @@ Widget *Widget::getNearestCommonAncestor } +/** + * \brief Search recursively through widget. + * + * Used by dw::core::Layout:getWidgetAtPoint. + */ +Widget *Widget::getWidgetAtPoint (int x, int y, int level) +{ + Iterator *it; + Widget *childAtPoint; + + //_MSG ("%*s-> examining the %s %p (%d, %d, %d x (%d + %d))\n", + // 3 * level, "", gtk_type_name (GTK_OBJECT_TYPE (widget)), widget, + // allocation.x, allocation.y, + // allocation.width, allocation.ascent, + // allocation.descent); + + if (x >= allocation.x && + y >= allocation.y && + x <= allocation.x + allocation.width && + y <= allocation.y + getHeight ()) { + //_MSG ("%*s -> inside\n", 3 * level, ""); + /* + * Iterate over the children of this widget. Test recursively, whether + * the point is within the child (or one of its children...). If there + * is such a child, it is returned. Otherwise, this widget is returned. + */ + childAtPoint = NULL; + it = iterator (Content::WIDGET, false); + + while (childAtPoint == NULL && it->next ()) + childAtPoint = it->getContent()->widget->getWidgetAtPoint (x, y, + level + 1); + + if (childAtPoint) + return childAtPoint; + else + return this; + } else + return NULL; +} + + void Widget::scrollTo (HPosition hpos, VPosition vpos, int x, int y, int width, int height) { diff --git a/dw/widget.hh b/dw/widget.hh --- a/dw/widget.hh +++ b/dw/widget.hh @@ -405,6 +405,8 @@ public: inline Layout *getLayout () { return layout; } + virtual Widget *getWidgetAtPoint (int x, int y, int level); + void scrollTo (HPosition hpos, VPosition vpos, int x, int y, int width, int height);

1 0

Dillo FLTK2 alpha release for developers
by None Oct. 18, 2007

Oct. 18, 2007

Hi there, This is an alpha release of the next generation of the Dillo web browser. The code underwent a major rewrite: significant parts of the codebase were ported to C++, and the rendering engine now uses the FLTK2 library instead of GTK1. Please read the README inside dillo's tarball. Developers willing to join the project and contribute are highly encouraged. Sebastian did an excellent work documenting the new dillo widget engine (just run doxygen inside DW tree). This is a good milestone in the project's history, we hope to be able to continue working on it. This is one step ahead, and we need other developers help. Please note that this code is under GPL3! BTW, if you want to know what antialiased utf-8 is, just go to: http://www.gnu.org/home.fa.html after compiling dillo-fltk. Here are the instructions on how to get it working: --------------- Get these files --------------- wget http://www.dillo.org/dillo2/fltk-2.0.x-r5917.tar.bz2 wget http://www.dillo.org/dillo2/dw-testbed-0.0.43j.tar.bz2 wget http://www.dillo.org/dillo2/dillo-f15f.tar.bz2 ----- FLTK2 ----- tar jxvf fltk-2.0.x-r5917.tar.bz2 cd fltk-2.0.x-r5917 make // Should compile cleanly if you have the // necessary development packages... cd test; ./demo // You can play with it too! cd .. su make install // Install FLTK2 libraries exit cd .. ---------- dw-0.0.43j ---------- tar jxvf dw-testbed-0.0.43j.tar.bz2 cd dw-testbed-0.0.43j ./configure make cd test // You can test it from here cd ../.. doxygen // Excellent documentation in html cd html; dillo index.html // (start browsing docs here) cd ../.. ln -s dw-testbed-0.0.43j dw-testbed // Don't forget this link ---------- dillo f15j ---------- tar jxvf dillo-f15f.tar.bz2 cd dillo-f15 ./configure make su make install // Needed for dpis exit cd src ./dillo-fltk // This is is it! cd .. -------- dillorc2 -------- There's a "dillorc2" file inside the tarball's top directory: cp dillorc2 ~/.dillo/ that will let you use the new and old dillo without trouble. -- Cheers Jorge.-

10 22