- Dillo-dev - lists.mailman3.com

patch: multipart/form-data encoding for form submission
by place＠gobigwest.com March 2, 2008

March 2, 2008

Currently, dillo always submits forms using url encoding regardless of the encoding specified by the form. Wikipedia, for example, specifies multipart/form-data because the user may submit huge blocks of text in languages where url encoding will be very inefficient. - This patch always uses the same boundary, but a different one REALLY should be used for every form submission. At the least, the string should be scrambled up somehow. - It adds a URL_MultipartEnc flag. - For the Content-type header, I pull the boundary out of URL_DATA because I didn't want to clutter up the URL with a field for something not commonly used. ----------------------------------------------------------- For multipart/form-data, a submission goes like: [headers] Content-type: multipart/form-data; boundary="[boundary]" --[boundary] Content-Disposition: form-data; name="[name1]" [value1] --[boundary] Content-Disposition: form-data; name="[name2]" [value2] --[boundary] ...and eventually... Content-Disposition: form-data; name="[namen]" [valuen] --[boundary]--

2 7

What shall we do with the buggy RFC?
by onepoint＠starurchin.org March 1, 2008

March 1, 2008

Dillo is buggy because RFC2396 is buggy! An outrageous claim, I know, but hear me out! The problem appears when resolving a relative URI reference such as "?foo=bar" relative to a URI such as "http://a.b.c/e/f". Dillo resolves this to "http://a.b.c/e?foo=bar" ie. it loses the last path component. This is clearly wrong, and it breaks pages such as http://www.guardian.co.uk/business/gallery/2008/jan/18/1?picture=332092597 (trying clicking on the big picture - you won't get the next one in the gallery). Clearly Dillo should only lose the last path component of the base URI when the path of the relative is non-empty. Nevertheless, this broken behaviour *is* RFC compliant! If we study the 7 steps in "5.2. Resolving Relative References to Absolute Form" of RFC2396 we see a problem in step 6, which begins: a) All but the last segment of the base URI's path component is copied to the buffer. In other words, any characters after the last (right-most) slash character, if any, are excluded. So we are instructed to lose the last path component in all cases. Unfortunately we get to step 6 if the URI reference is "?foo=bar". Hence the breakage. Patch attached. Jeremy Henty

2 5

[patch] redraw optimization now including tables
by Johannes.Hofmann＠gmx.de Feb. 29, 2008

Feb. 29, 2008

Hello, below is an improved version of the redraw optimization. It now also covers table based pages - at least to some point. The challenge is to make the already commited optimization work recursively. Other than I originally thought topLevel is always a Textblock. Table based pages simply consist of a Textblock with a huge Table as child widget. Textblock now needs to avoid redrawing the child area when the table size increases. The redrawing is left to the Table-code, which then can be optimized. Please test carefully and report any anomalies you find. Regards, Johannes

2 3

[patch] use CURSOR_MOVE when drag scrolling
by jcid＠dillo.org Feb. 29, 2008

Feb. 29, 2008

Hi, > the patch below disallows drag scrolling over links where the middle > mouse button is used to open the link in a new window. It also > changes the cursor to CURSOR_MOVE when drag scrolling. Committed. -- Cheers Jorge.-

1 0

Re: patch: not-a-png message
by jcid＠dillo.org Feb. 29, 2008

Feb. 29, 2008

On Fri, Feb 29, 2008 at 04:42:05PM +0000, place wrote: > Just noticed this in my tree while making multipart diffs. I'd forgotten > about it... Committed. -- Cheers Jorge.-

1 0

[patch] add ctrl-f shortcut for findText
by Johannes.Hofmann＠gmx.de Feb. 29, 2008

Feb. 29, 2008

Hi, patch below adds ctrl-f shortcut for findText. BTW, shouldn't ctrl-b open the bookmarks page as it did in dillo1? Cheers, Johannes diff -r 44838cc1f38d src/ui.cc --- a/src/ui.cc Sun Feb 24 23:15:53 2008 +0100 +++ b/src/ui.cc Thu Feb 28 22:43:22 2008 +0100 @@ -702,7 +702,10 @@ int UI::handle(int event) // Handle these shortcuts here. if (event == SHORTCUT) { if (event_state(CTRL)) { - if (k == 'l') { + if (k == 'f') { + a_UIcmd_findtext_dialog((BrowserWindow*) user_data ()); + ret = 1; + } else if (k == 'l') { a_UIcmd_open_url_dialog(user_data()); ret = 1; } else if (k == 'n') {

2 1

[patch] use CURSOR_MOVE when drag scrolling
by Johannes.Hofmann＠gmx.de Feb. 28, 2008

Feb. 28, 2008

Hi, the patch below disallows drag scrolling over links where the middle mouse button is used to open the link in a new window. It also changes the cursor to CURSOR_MOVE when drag scrolling. Cheers, Johannes diff --git a/dw/fltkviewport.cc b/dw/fltkviewport.cc --- a/dw/fltkviewport.cc +++ b/dw/fltkviewport.cc @@ -233,11 +233,13 @@ int FltkViewport::handle (int event) case ::fltk::PUSH: take_focus(); if (::fltk::event_button() == ::fltk::MiddleButton) { - dragScrolling = 1; - dragX = ::fltk::event_x(); - dragY = ::fltk::event_y(); /* pass event so that middle click can open link in new window */ - FltkWidgetView::handle (event); + if (FltkWidgetView::handle (event) == 0) { + dragScrolling = 1; + dragX = ::fltk::event_x(); + dragY = ::fltk::event_y(); + setCursor (core::style::CURSOR_MOVE); + } return 1; } break; @@ -260,6 +262,7 @@ int FltkViewport::handle (int event) case ::fltk::RELEASE: if (::fltk::event_button() == ::fltk::MiddleButton) { dragScrolling = 0; + setCursor (core::style::CURSOR_DEFAULT); } break;

1 0

PATCH: small improvement to the "can't start dpid daemon" error message
by onepoint＠starurchin.org Feb. 24, 2008

Feb. 24, 2008

A common cause of the "can't start dpid daemon" error is clicking on a link with a typo'ed HREF that has an invalid URL scheme (eg. 'ttp://' instead of 'http://', to cite the real-life example that prompted this patch). But the error message gives *no* context that would help to diagnose the problem. If it cited the URL scheme it would save a lot of time. (I had to start Firefox before I realised what the problem was!) Here's a patch to do that. Jeremy Henty

2 1

[patch] fix redraw problem with findText
by Johannes.Hofmann＠gmx.de Feb. 24, 2008

Feb. 24, 2008

Hello, the patch below fixes the redraw problem with findText found by place that was introduced with my textblock optimization. Partial redraws were interfering with scrolling. The findText method is a nice test for this code path! I'm now experimenting with a redraw optimization that covers table based pages too. It's looking promising, but it needs some more work. Cheers, Johannes diff --git a/dw/fltkviewbase.cc b/dw/fltkviewbase.cc --- a/dw/fltkviewbase.cc +++ b/dw/fltkviewbase.cc @@ -85,6 +85,7 @@ void FltkViewBase::draw () } } + drawRegion.clear (); d &= ~DAMAGE_VALUE; } @@ -110,9 +111,12 @@ void FltkViewBase::draw () area.width = rect.w(); area.height = rect.h(); theLayout->expose (this, &area); + + if (! (d & DAMAGE_SCROLL)) { + drawRegion.clear (); + } } - drawRegion.clear (); } void FltkViewBase::drawChildWidgets () { diff --git a/dw/fltkviewport.cc b/dw/fltkviewport.cc --- a/dw/fltkviewport.cc +++ b/dw/fltkviewport.cc @@ -185,6 +185,7 @@ void FltkViewport::draw () int d = damage(); if (d & DAMAGE_SCROLL) { + set_damage (DAMAGE_SCROLL); scrollrect(cr, -scrollDX, -scrollDY, draw_area, this); d &= ~DAMAGE_SCROLL; set_damage (d);

2 1

[patch] optimize redraw after resize for textblocks
by Johannes.Hofmann＠gmx.de Feb. 21, 2008

Feb. 21, 2008

Hello, here comes my attempt to avoid unnecessary redraws caused by images that are not visible. The first patch makes some minor optimizations to the drawing code and disables the use of the asap parameter for better testing. The second patch replaces the general queueDrawTotal() in Layout::resizeIdle () with more specific redraw calls in widgets that can be topLevel. Currently only Textblock is optimized. The idea is that resizing child widgets in a textblock don't affect the layout of the textblock above the resizing widget. So only the area below needs to be redrawn. I think that does not hold for tables, but perhaps other optimizations are possible here? Ideas anyone? The effect is visible e.g. on http://chlamydia.fs.ei.tum.de/pub/DragonFly/packages/stable/DragonFly-1.10.… but not on table based pages. Cheers, Johannes

2 1