- Dillo-dev - lists.mailman3.com

Bug in meta tag refresh code [with cause]
by nick＠linicks.net May 10, 2016

May 10, 2016

I have been looking at this for about 5 hours now, and it has fried my brain. Reading the code, and then reading the email thread about depreciated meta tag 'refresh', I agree with Dillo's actions. But what I found was that on some sites (mine included), if there was a tag: <meta http-equiv="refresh" content="15" /> Dillo reports and the warning message reports: The author wanted you to go _here_ after 10 seconds. What happens now is the link (_here_) gets appended with the refresh value, so for example: www.example.com/refesh.html becomes: www.example.com/10 (or 15 or whatever the refresh value is). I have found that if the meta tag is right: <meta http-equiv="refresh" content="5;URL='./index.html'" /> then the code creates the right URL (but it's not seen as no warning is given. html.cc from line 3218 if the meta tag refresh is correct HTML on the web page, mr_url returns the correct path to the refresh. If it isn't, then mr_url returns the value of the refresh - which fubars the warning messages link. I tested this running dillo from the commandline with this insertion and testing the correct and wrong meta tags: } /* Skip to anything after "URL=" or ";" if "URL=" is not found */ if ((p = dStriAsciiStr(content, "url="))) content = p + strlen("url="); else if ((p = strstr(content, ";"))) content = p + strlen(";"); /* Handle the case of a quoted URL */ if (*content == '"' || *content == '\'') { if ((p = strchr(content + 1, *content))) mr_url = dStrndup(content + 1, p - content - 1); else mr_url = dStrdup(content + 1); } else { mr_url = dStrdup(content); } //nick printf ("%s\n", mr_url); new_url = a_Html_url_new(html, mr_url, NULL, 0); // new_url = a_Html_url_new(html, ".", NULL, 0); Not being very good with C++, I can't work out what goes wrong here - but it looks like that if 'URL=' or';' isn't found, then the code still looks for quotes - which does something to the string? I have two pages you can test on - one with the proper meta tag, and one with out: http://irpi.linicks.net:8080/static_simple.html <- good http://fishpi.linicks.net:8081/static_simple.html <- bad - that shows the bug If possible view both with that printf I put in - you can see what mr_url returns. Phew* Nick -- Gosh that takes me back... or is it forward? That's the trouble with time travel, you never can tell." -- Doctor Who "Androids of Tara"

4 6

image overlaps text
by sgeerken＠dillo.org May 9, 2016

May 9, 2016

Hi Alexander and others, On Mo, Mai 09, 2016, Alexander Voigt wrote: > Dear Sebastian, > > I think one of your recent commits (probably 4543:3cb86de1861a) > introduced a problem with hyphenation. See for example the rendering > of > > debian.org This commit fixes a problem which has hidden another problem which now shows up. I'm working on it. If you want a halfway usable recent version, stick to revision 4542. Sebastian

1 0

Minor bug in test/cookies.c
by nick＠linicks.net May 1, 2016

May 1, 2016

Hi Jorge, I saw the two minor fixes you done today - here's another: :~/slackbuilds/dillo/hg/dillo$ grep -Rin "} if" * test/cookies.c:426: } if ((ret = Dpi_blocking_read(sock_fd)) == NULL) { Nick -- Gosh that takes me back... or is it forward? That's the trouble with time travel, you never can tell." -- Doctor Who "Androids of Tara"

2 1

dillo redraws part II
by jcid＠dillo.org April 29, 2016

April 29, 2016

Hi there, Just committed the second part of this patch. It further reduces the number of redraws (see details in hg). The debug messages are active and will be shut after a brief testing period. Screen drawing *feels* cleaner here! :-) YMMV. -- Cheers Jorge.-

1 0

https://www.google.com/search?ie=UTF-8&oe=UTF-8&q=dillo
by sgeerken＠dillo.org April 24, 2016

April 24, 2016

Hi! Since we do not have a tracking system, I suggest a new thread for every issue, with some identifier (e. g. a URL) as subject. Please focus on regressions: bugs not present in dillo 3.0.5. As for <https://www.google.com/search?ie=UTF-8&oe=UTF-8&q=dillo>, the problem are floating inline-blocks (see Johannes' posting and my answer). Floats positioned side by-side are not an issue for the next release, so I see two possibilities: 1. Leave it as it is, and start on an other positioning after the next release. 2. Deactivate inline-blocks for the next release, and re-activate as soon as side-by-side positioning of floats is implemented. This way, dillo 3.1 would render Google like 3.0.5. The latter is rather simple: diff -r 7c2e27119432 src/html.cc --- a/src/html.cc Sun Apr 24 12:21:07 2016 +0200 +++ b/src/html.cc Sun Apr 24 13:23:10 2016 +0200 @@ -4036,7 +4036,7 @@ Html_display_block(html); break; case DISPLAY_INLINE_BLOCK: - Html_display_inline_block(html); + //Html_display_inline_block(html); break; case DISPLAY_LIST_ITEM: Html_display_listitem(html); What do you think? Sebastian

2 1

GROWS fixes
by sgeerken＠dillo.org April 23, 2016

April 23, 2016

Hi! After the recent changes, dillo handles 'height' specially for tables and textblocks: now, it is not possible anymore that the height of table or a textblock is less than the inherent height. This fixes - <http://forums.thinkbroadband.com> and - <https://linicks.net/AnAdIc/> (looks as with dillo 3.0.5). For tables, dillo behaves the same way as Firefox; for textblock not quite, but somewhat similar as dillo 3.0.5. This means that there is no regression, and that texblock heights may be worked on after the next release. Sebastian

3 2

Dillo_grows merged
by sgeerken＠dillo.org April 23, 2016

April 23, 2016

Hi! The dillo_grows repository has just been merged into the main repository at <http://hg.dillo.org/dillo>. Hopefully, this will mean that all these changes will soon make it into a new release. Sebastian

8 14

Dillo not displaying some PNG in the page, but displays it separately.
by francis＠daoine.org April 22, 2016

April 22, 2016

[ Adding dillo-dev back to Cc: ] On Fri, Apr 22, 2016 at 04:15:49PM +0300, John Found wrote: > On Fri, 22 Apr 2016 13:49:33 +0100 Francis Daly <francis at daoine.org> wrote: Hi there, > > The image link is /!avatar/nestava?v= which returns a redirection. > > > > Well, yes, I forgot about the redirection. It is because "anon.png" is the fallback image for the users that have no avatar image set in their account. Yes. If you wanted to change your site to make it look prettier in old-and-current-dillo, you could change the piece that sends that redirection to instead send the content of the image. It probably is not worth doing that, though. > But I am not very agree with the assumption from the FAQ, that "These have a strong tendency to be advertisements." I suspect that the FAQ describes the author's thoughts at the time, and describes the state of current-dillo. > At first it depends whether it is redirection to the same domain or the 3rd party ad-provider. If you can encourage someone to design and implement the code to handle that, I expect it will be welcomed either into stock-dillo or as an external patch. > At second, such fragmentary "ad-blocking" will not stop the ads at all, but combined with the Dillo not finished state, it looks more like a bug that like an ad-block effort. I'd consider it "convenience" rather than "ad-block effort"; but I already expect many web pages not to be "fully functional" with a browser which doesn't do exactly what they want, so I accept it. Cheers, f -- Francis Daly francis at daoine.org

2 1

Dillo not displaying some PNG in the page, but displays it separately.
by johnfound＠asm32.info April 22, 2016

April 22, 2016

The image in question is this: http://board.asm32.info/images/anon.png It can (actually can't) be seen in a page as the default avatar image in my forum engine. For example, see the post: http://board.asm32.info/iztriwane_na_temi_52/#15109 "Isolate the image" from the context menu works and the image is displayed. "Open image in new tab" also works. P.S. BTW, is there a way to make SVG images to be displayed in Dillo? Regards. -- http://fresh.flatassembler.net http://asm32.info John Found <johnfound at asm32.info>

4 6

FW: Commands on Dillo
by marcos-escola＠outlook.com April 21, 2016

April 21, 2016

Let me explain: I'm using DIllo on Ubuntu 12.04.I can't paste URL to address bar, for example.Or, I can't copy text from a page on Dillo to a notepad... Marcos D. > On 21/04/2016, Marcos D. <marcos-escola at outlook.com> wrote: > > Hi; > > > > I'm not sure if this happens only on my device, but, I can't Copy and > > Paste in Dillo (3.0.2 and 3.0.5). > > There is a way to enable this commands, or it's going to be available in > > a future version? > > > > Thanks; > > Marcos D. > > > > Twitter: @marcos_5000 > >

3 2