- Dillo-dev - lists.mailman3.com

Proposal: United Dillo
by Indan Zupancic Nov. 24, 2003

Nov. 24, 2003

Hello, With "united Dillo" I mean that there is always just one Dillo running per user, so when you start Dillo while it is already running, then the current one will open a new window. I made a patch as proof of concept, see: http://www.xs4all.nl/~dorinek/dillo This approach has two big advantages: 1) Always one Dillo has less overhead than running multiple instances at the same time. 2) Automatic synchronization/no need for synchronization anymore. First advantage is in the spirit of Dillo, wanting to be small, light and fast. Second advantage means that doing certain things will be much simpler, like having always cookies, no need to synchronize plugins, meaning that dpid is not really needed anymore, because most of the points from the problem list are solved (see Dpid.txt). Problems that aren't solved: * Forks can be expensive (Dillo had to fork its dpis). But dpid does much more than simply forking: it forks and then starts up an external program (which often also forks and starts up wget). Beside, if Dillo uses library plugins then there is no need to fork at all. * It increments dillo's core size. The patch adds about 70 lines of code to dillo.c and increases dillo with about 1 K. It is true that if you get rid of dpid then more code is needed in Dillo's core. But that's only moving the code to some other place, no real increase if you ask me. Having a seperate dpid has much more overhead at runtime (seperate process versus bigger executable). You can always make a plugin handling library, then it isn't part of Dillo's core. Of course a united Dillo has problems/disadvantages too: It is sometimes still needed to synchronize multiple windows. If it's not implemented carefully, you may lose functionality (aka command line options). A user can't run more than one Dillo instance. Sometimes it's wanted to run multiple Dillo's, for instance two different versions. But that isn't possible at all, or if version awareness is added, without losing synchronization. What do you think about it? Greetings, Indan

6 13

[PATCH] Version 5 of kbnav patch is ready
by Frank de Lange Nov. 24, 2003

Nov. 24, 2003

Hi'all, The next version (5) of my keyboard navigation patch is ready. See the end of this message for download instructions. Do note that the tab/frame patch already contains this functionality, so there is no need (and no way) to apply this patch on top of that or the other way around. This release does not add any new features, it is mainly a bug fix and CVS resync release. For more info on what this patch does, see the doc/Keyboard_Navigation.txt document (after applying the patch, naturally...) Fixed bugs ---------- - erroneously highlighted link after leaving a form element, was caused by wrong function call order in focus_next_link. Fixed. CVS date/time ============= The patch is made against CVS as it was on 20031124@13:18 GMT. It should apply against CVS as it was on 20031121(a)21.33 GMT and later. For those who can not or do not want to use CVS, a snapshot can be found here: http://www.geocities.com/ikbenfrank/dillo-200311241318.tar.gz Download instructions ===================== There is currently only one version of the patch, made against 2003124@13:18GMT CVS. As always, have a look at the patch website (http://www.geocities.com/ikbenfrank/) for the latest version of the patch. This patch does NOT apply on top of the tab/frame patch, and the tab/frame patch does not apply on top of this one! The tab/frame patch already contains this functionality, so it is not needed. http://www.geocities.com/ikbenfrank/dillo-200311241458-kbnav.patch.gz size: 30633 bytes (gzipped, as downloaded) 152984 bytes (uncompressed) md5sum: 0ed60695cab750669f3d50c201bdf217 (gzipped, as downloaded) 20aeb6b96e551cd8f4fa65ac5d74ef9e (uncompressed) Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]

1 0

RPM Latest Frame tabs patch with basic authentication:
by Ronald W. Henderson Nov. 24, 2003

Nov. 24, 2003

Folks: Could someone direct me to a location that has a RPM built with the latest Frame and Tabs patch but also basic authenitcation code. I find dillo as an excellent browser but the lack of basic authentication as a standard built in feature limits my use. Today, many networking Vendor's support a web interface for administation of their product and typically require basic authentication for login. I would like to use dillo as my browser for administration purposes. I appreciate your support on this excellent browser! ---Ron Henderson

1 0

Re: [Dillo-dev] [PATCH] Version 15 of tab/frame/kbnav/etc patch, now with keywords and more...
by Frank de Lange Nov. 24, 2003

Nov. 24, 2003

Paul Pelzl wrote: > Now that I look at the problem again, I appear to have misdiagnosed it. > >It looks like the problem is with multiple spaces between keywords, not >with newlines. I've attached an example that causes a segfault after >entering any URL in the location bar. > >keywords = "s:http://www.google.com/search?q=%s ~:file:~" > > OK, solved this one as well. g_strsplit creates an empty string when two or more consecutive split-characters are encountered (quite reasonable behaviour, but not what I want for keywords) and the keywords processing code was not prepared for empty keywords (this in constrast to keywords with empty URLs which were handled OK). Is fixed in my code now, I'll release a new version of the patch with all recent fixes, made against the most recent version of CVS today or tomorrow. Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]

1 0

Sigh... CVS out of sync 5 minutes after I upload my patches
by Frank de Lange Nov. 23, 2003

Nov. 23, 2003

It is as if the devil plays with it... 5 minutes after I upload my latest patches, CVS gets updated and the patch does not apply anymore. Well, this time I was prepared for that. Anyone who wants to try tab/frame patch no. 15 can download the CVS source on which it is based from the patch site: http://www.geocities.com/ikbenfrank/dillo-200311191409.tar.gz This is the UNPATCHED CVS code that was used to create the patch. To get a working tabbed/frames/etc browser, download this tarball and the patch, then apply the patch. From now on I will always include the CVS code on which the patch was based to get around these irritating synchronisation problems. Indan, if you want to update your HTTPS patch, may I suggest you use this source code tarball instead of current Dillo CVS? This way we are less dependent on the state of CVS... Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]

3 4

latest commit: cleanup on glib ids
by Jorge Arellano Cid Nov. 21, 2003

Nov. 21, 2003

Hi Sebastian! While making the latest patch (now in CVS), I finally had the time to track gtk_timeout_add, gtk_idle_add and g_io_add_watch inside gtk/gdk/glib sources. The interesting part is that after the related wrappers, they all end using g_source_add; this function uses hook_id (ghook.h) which gets the id from seq_id. :-) In short: seq_id starts from 1 and hook_id is largely used with zero as a non-used/non-active/non-valid value! I updated dillo accordingly and eliminated the uneasy feel of initializing a guint with -1 as an invalid value. Regards Jorge.-

1 0

Re: [Dillo-dev] [PATCH] Version 15 of tab/frame/kbnav/etc patch, now with key words an more...
by Billy Nov. 21, 2003

Nov. 21, 2003

In src/prefs.h you specify DILLO_SPLASH as file:/usr/share/dillo/dillo.html We don't install into that prefix. I made 2 changes. Added a dep for prefs.h and a rule which fixes the splash path as well as changing DILLO_SPLASH to file%%PREFIX%%/share... It's an ugle Makefile hack, but I didn't want to wade through the morass of autoconf for the correct solution. --- src/Makefile.am Fri Nov 21 09:35:45 2003 +++ src/Makefile.am.orig Tue Nov 11 07:13:59 2003 @@ -1,9 +1,3 @@ -.fixed_splash_path: - cp prefs.h x && cat x | sed 's@%%PREFIX%%@$(prefix)@' > prefs.h && rm -f x - touch .fixed_splash_path - -prefs.h: .fixed_splash_path - AM_CPPFLAGS=-DDILLORC_SYS='"$(sysconfdir)/dillorc"' SUBDIRS = IO @@ -24,8 +18,6 @@ capi.c \ capi.h \ debug.h \ - doc.c \ - doc.h \ dw.h \ dw.c \ dw_aligned_page.c \ @@ -68,18 +60,12 @@ dw_tooltip.h \ dw_widget.c \ dw_widget.h \ - gtkframeset.c \ - gtkframeset.h \ findtext.c \ findtext.h \ selection.c \ selection.h \ - focus.c \ - focus.h \ web.c \ web.h \ - pagemark.c \ - pagemark.h \ progressbar.c \ progressbar.h \ dillo.c \ @@ -100,8 +86,6 @@ image.h \ misc.c \ misc.h \ - tab.c \ - tab.h \ interface.h \ interface.c \ history.c \ --- src/prefs.h Fri Nov 21 09:35:11 2003 +++ src/prefs.h.orig Sat Nov 15 14:13:03 2003 @@ -8,8 +8,6 @@ #endif /* __cplusplus */ #define DILLO_HOME "http://www.dillo.org/" -#define DILLO_SPLASH "file:%%PREFIX%%/share/dillo/dillo.html" - #define D_GEOMETRY_DEFAULT_WIDTH 640 #define D_GEOMETRY_DEFAULT_HEIGHT 550 @@ -19,15 +17,6 @@ #define DW_COLOR_DEFAULT_PURPLE 0x800080 #define DW_COLOR_DEFAULT_BGND 0xd6d6c0 -#define COMPRESS_COMMON_PREFIXES "index of ;re: ;fwd: ;www.;welcome to ;the " - -/* target enumeration */ -enum { - TARGET_SELF, - TARGET_TAB, - TARGET_WINDOW -}; - /* define enumeration values to be returned */ enum { PARSE_OK = 0, @@ -49,8 +38,6 @@ DRC_TOKEN_TEXT_COLOR, DRC_TOKEN_USE_OBLIQUE, DRC_TOKEN_HOME, - DRC_TOKEN_SPLASH, - DRC_TOKEN_KEY_BINDINGS, DRC_TOKEN_PANEL_SIZE, DRC_TOKEN_SMALL_ICONS, DRC_TOKEN_FONT_FACTOR, @@ -69,10 +56,8 @@ DRC_TOKEN_SHOW_URL, DRC_TOKEN_SHOW_SEARCH, DRC_TOKEN_SHOW_PROGRESS_BOX, - DRC_TOKEN_SHOW_POPUP_NAVIGATION, DRC_TOKEN_FULLWINDOW_START, DRC_TOKEN_TRANSIENT_DIALOGS, - DRC_TOKEN_POPUP_DIALOGS, DRC_TOKEN_FW_FONT, DRC_TOKEN_VW_FONT, DRC_TOKEN_GENERATE_SUBMIT, @@ -81,14 +66,6 @@ DRC_TOKEN_SHOW_HTML_WARNINGS, DRC_TOKEN_SHOW_MSG, DRC_TOKEN_USE_OLD_PARSER, - DRC_TOKEN_KEYWORDS, - DRC_TOKEN_TARGET_BLANK, - DRC_TOKEN_TAB_LOAD_IN_BACKGROUND, - DRC_TOKEN_TAB_BAR_SHOW_FULLSCREEN, - DRC_TOKEN_TAB_BAR_SHOW_SINGLE_TAB, - DRC_TOKEN_TAB_BAR_SCROLLER, - DRC_TOKEN_TAB_TITLE_COMPRESS, - DRC_TOKEN_COMPRESS_COMMON_PREFIXES, DRC_TOKEN_LAST } Dillo_Rc_TokenType; @@ -102,8 +79,6 @@ gchar *no_proxy; gchar **no_proxy_vec; DilloUrl *home; - gchar *splash; - gboolean show_splash; guint32 link_color; guint32 visited_color; guint32 bg_color; @@ -130,10 +105,8 @@ gboolean show_url; gboolean show_search; gboolean show_progress_box; - gboolean show_popup_navigation; gboolean fullwindow_start; gboolean transient_dialogs; - gboolean popup_dialogs; gchar *vw_fontname; gchar *fw_fontname; gboolean generate_submit; @@ -142,16 +115,6 @@ gboolean show_html_warnings; gboolean show_msg; gboolean use_old_parser; - gchar *keywords; - gchar **keywords_vec; - gint target_blank; - gboolean tab_load_in_background; - gboolean tab_bar_show_fullscreen; - gboolean tab_bar_show_single_tab; - gboolean tab_bar_scroller; - gboolean tab_title_compress; - gchar *compress_common_prefixes; - gchar **compress_common_prefixes_vec; }; -- billy "Who get's bigger evertime you void, It's Hank the Happy Hemorroid."

3 3

[PATCH] Version 4 of kbnav patch is ready
by Frank de Lange Nov. 21, 2003

Nov. 21, 2003

Hi'all, The next version (4) of my keyboard navigation patch is ready. See the end of this message for download instructions. Do note that the tab/frame patch already contains this functionality, so there is no need (and no way) to apply this patch on top of that or the other way around. This release does not add many new features. It does however fix most known bugs, which is a good enough reason for applying it I'd say... One new feature is that is is now possible to popup context menus with keyboard navigation. The default key binding is Alt-Enter (and Alt-KP_Enter), this can of course be changed using the appropriate preference incantation. For more info on what this patch does, see the doc/Keyboard_Navigation.txt document (after applying the patch, naturally...) Fixed bugs ---------- - all known segfaults - most 'weird navigation order' problems - related issue (now fixed in CVS): a_Findtext_search returned FALSE (instead of FINDTEXT_NOT_FOUND) when a search was performed on an empty page. Since this function is supposed to return a FindtextResult enum value (and the first value in that enum is FINDTEXT_SUCCESS) this made the focus code try to focus a link in an empty page leading to a segfault in the scrolled_window. TODO ==== - add x scrolling capability to Dillo (change anchors, URL_POS, scrolling functions, iterators, etc...). This is needed for better keyboard navigation on wide pages. Download instructions ===================== There is currently only one version of the patch, made against 2003119@14:09GMT CVS. As always, have a look at the patch website (http://www.geocities.com/ikbenfrank/) for the latest version of the patch. This patch does NOT apply on top of the tab/frame patch, and the tab/frame patch does not apply on top of this one! The tab/frame patch already contains this functionality, so it is not needed. http://www.geocities.com/ikbenfrank/dillo-200311211558-kbnav.patch.gz size: 30615 bytes (gzipped, as downloaded) 152903 bytes (uncompressed) md5sum: 29aa01c8c5eabe3c7294b975155255ce (gzipped, as downloaded) 5c848e7f0e281e3135392522c8a7f980 (uncompressed) Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]

1 0

RE: [Dillo-dev] FLTK
by Eric Gaudet Nov. 21, 2003

Nov. 21, 2003

I will give it a try. > -----Original Message----- > From: Sebastian Geerken [mailto:s.geerken@ping.de] > Sent: Tuesday, October 14, 2003 1:55 PM > To: Dillo mailing list > Subject: Re: [Dillo-dev] FLTK > > > Hi! > > To have some facts for this discussion, there is a (basicly working) > patch for the Gtk2 port, at > <http://www.dillo.org/misc_files/gtk2.diff.gz>. > It is a slightly modified version of a patch, which Jörgen sent me > some time ago, and compiles with the current CVS (probably not with > 0.7.3). > > Sebastian > > _______________________________________________ > Dillo-dev mailing list > Dillo-dev(a)lists.auriga.wearlab.de > http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev >

8 10

Re: kbnav3 patch test
by Jorge Arellano Cid Nov. 21, 2003

Nov. 21, 2003

Frank, > Jorge Arellano Cid wrote: > > >Hi Frank, > > > > After waiting for a week as you suggested, today I gave a > >review to the new kbnav patch. It feels good! > > > > After some testing I came across a page that produces a > >segfault. The attached patch is against today's CVS + a couple of > >compiler-warning removals. The page is also attached. Beware that > >the segfault is only caught when the new parser is used, and that > >the page has bad-html. The case is interesting though, because a > >weird widget tree is generated and iterators should be able to > >handle/survive them! > > > > Please give it a look. > > > > Cheers > > Jorge.- > > > I have taken a look at your patch-to-my-patch, but did not apply it to > the version I will publish later today. :-o > I did do some manual > reformatting to correct some tab-related problems Good! > (Emacs' use of tabs > messes up things sometimes, and the 2-space indent it uses are not > consistent with Dillo's conventions). Thanks, we strive to be style consistent. BTW, I didn't try to fix indentation in the patch, it was just to do a test run. > Some files seem to be missing from > the patch you sent me, I guess you did not make any changes to those? My mistake. > > I did not see anything in your patch which would have corrected any > compiler warnings by that way, with a possible exception for the > disputed URL_ILLEGAL_CHARS_ macro. In my patch I used > URL_ILLEGAL_CHARS_(u) in html.c, while you use URL_ILLEGAL_CHARS(u). In > the current patch I use URL_ILLEGAL_CHARS(u) as well. The end result > should be the same however now that both versions exist. What compiler > warnings did you get which were corrected by your modifications to my patch? focus.c: In function `Focus_state_find_list': focus.c:268: warning: `list' might be used uninitialized in this function focus.c: In function `Focus_state_find_link': focus.c:465: warning: `list' might be used uninitialized in this function gcc version 3.2.3 > > On that Tarot-page you added to the message, I can say that navigation > is still quirky. But so is the page, it produces 9 warnings about > misplaced </a> tags. If you look at the source, you'll notice that it > misses several closing </A> tags (causing Dillo to allocate links all > over the page). It also contains some links with <BR> in them, which > used to crash patched Dillo because of the problem with > a_Dw_page_construct_iterator (which used to always set the mask to > DW_CONTENT_ALL, I changed this to a user-settable mask like all other > iterators have). I guess you attached the page because of those crashes? Yes, for you to have a way to reproduce it. BTW, that is what I meant with: "page has bad-html". > I will probably publish a new version of the patch (4) today, together > with a new version of the tab/frame patch. That version should be more > or less ready to commit, as no serious problems have cropped up for > several days now. See the list for problems found and corrected > (including the one causing the Tarot page to crash by the way - see my > message dated Wed, 12 Nov 2003 11:00:58 +0100). Oh, I didn't find anything about it at GMANE !? Cheers Jorge.-

3 3