Dillo-dev

Download

dillo-dev@mailman3.com

April 2024

5 participants
11 discussions

[PATCH] Reverse scroll wheel tab switching
by Rodrigo Arias April 5, 2024

April 5, 2024

Hi Alex, We have a mailing list for patches at <dillo-dev(a)mailman3.com>, maybe I should add a comment to the README too. Regarding your patch, I find that behavior unintuitive :-) But we shouldn't expect people to agree on those, so I think this should be implemented as a configuration option. Check the PR of the tab switching[1] to see how to add another option yourself. [1]: https://github.com/dillo-browser/dillo/pull/62/files Otherwise I can work on it after the 3.1.0 release. I opened an issue: https://github.com/dillo-browser/dillo/issues/122 Best, Rodrigo. ----- Forwarded message from Alex ----- Hello, In my opinion the behavior of the mouse wheel tab switching is backwards. Scrolling up switches to the previous tab, and down goes to the next tab. This seems unintuitive and I find myself frequently scrolling in the wrong direction. Sorry I don't have a github account to do a pull request, but here is a diff that reverses the direction: --- uicmd.cc Fri Apr 5 10:59:06 2024 +++ uicmd.cc Fri Apr 5 10:59:21 2024 @@ -255,9 +255,9 @@ int dir = dy ? dy : dx; if (dir > 0) - next_tab(); - else if (dir < 0) prev_tab(); + else if (dir < 0) + next_tab(); ret = 1; } Dillo for life! Alex ----- End forwarded message -----

2 2