October 2024 - Dillo-dev - lists.mailman3.com

Towards 3.2.0
by Rodrigo Arias Dec. 19, 2024

Dec. 19, 2024

Hi, I'm planning to close the feature window shortly, so I will need to think what else to include for 3.2.0 before it is closed. One of the features I would like to include is the ability to open a link with an external handler. We have a proof of concept that uses the rule file, but I think it is too complex for now: https://github.com/dillo-browser/dillo/pull/199 I'm thinking it may be better to add an easier variant first, that we can extend later. I'm considering adding these to dillorc: actions="default Open with external tool" actions="firefox Open with Firefox" actions="mpv Open with MPV" actions="mpv-audio Open with MPV (audio)" handler="/bin/the-handler" Where you can define multiple "actions" but only one "handler". The actions have a label at the beginning (first word) and a human readable text that will be presented in the menu. Then, your handler will be invoked using the label as: /bin/the-handler <URL> <action-label> And you do whatever you find convenient in your handler, so you have more context to decide the proper action based on the label. I think this would cover most of the use cases of opening URLs with other programs without being too convoluted. Best, Rodrigo.

4 7

[PATCH] make downloads.dpi use http_user_agent from dillorc
by a1ex＠dismail.de Dec. 10, 2024

Dec. 10, 2024

Hi, Here is a patch which allows wget called from downloads.dpi to use the user agent provided in dillorc, and fallback to the hardcoded Dillo/version agent if not defined. Regards, Alex diff -upr a/dlib/dlib.c b/dlib/dlib.c --- a/dlib/dlib.c Sun Aug 11 22:21:59 2024 +++ b/dlib/dlib.c Tue Sep 3 13:49:00 2024 @@ -922,6 +922,45 @@ char *dGethomedir (void) } /** + * Return the http_user_agent value in a static string + */ +char *dGetuseragent (void) +{ + static char *dillorc = NULL; + dillorc = dStrconcat(dGethomedir(), "/", ".dillo/dillorc", NULL); + FILE *In; + int len; + char *rcline = NULL, *value = NULL, *p; + if ((In = fopen(dillorc, "r")) == NULL) { + DLIB_MSG("dGetuseragent: unable to open dillorc.\n"); + return ("Dillo/" VERSION); + } + while ((rcline = dGetline(In)) != NULL) { + if (strncmp(rcline, "http_user_agent", 15) == 0) + break; + dFree(rcline); + } + fclose(In); + if (!rcline) { + value = ("Dillo/" VERSION); + DLIB_MSG("dGetuseragent: no 'http_user_agent' in dillorc.\n"); + } else { + len = (int) strlen(rcline); + if (len && rcline[len - 1] == '\n') + rcline[len - 1] = 0; + if ((p = strchr(rcline, '='))) { + while (*++p == ' '); + value = dStrdup(p); + } else { + value = ("Dillo/" VERSION); + DLIB_MSG("dGetuseragent: error parsing value in dillorc.\n"); + } + } + dFree(rcline); + return (value); +} + +/** * Get a line from a FILE stream. * Return value: read line on success, NULL on EOF. */ diff -upr a/dlib/dlib.h b/dlib/dlib.h --- a/dlib/dlib.h Sun Aug 11 22:21:59 2024 +++ b/dlib/dlib.h Tue Sep 3 13:49:00 2024 @@ -175,6 +175,7 @@ void dLib_show_messages(bool_t show); */ char *dGetcwd(void); char *dGethomedir(void); +char *dGetuseragent(void); char *dGetline(FILE *stream); int dClose(int fd); int dUsleep(unsigned long us); diff -upr a/dpi/downloads.cc b/dpi/downloads.cc --- a/dpi/downloads.cc Sun Aug 11 22:21:59 2024 +++ b/dpi/downloads.cc Tue Sep 3 13:49:06 2024 @@ -45,6 +45,7 @@ #include "config.h" #include "dpiutil.h" #include "../dpip/dpip.h" +#include "../dlib/dlib.h" /* * Debugging macros @@ -324,7 +325,7 @@ DLItem::DLItem(const char *full_filename, const char * cookies_path = dStrconcat(dGethomedir(), "/.dillo/cookies.txt", NULL); dl_argv = new char*[10]; int i = 0; - const char *user_agent = "Dillo/" VERSION; + const char *user_agent = dGetuseragent(); dl_argv[i++] = (char*)"wget"; if (stat(fullname, &ss) == 0) init_bytesize = (int)ss.st_size;

2 4

[PATCH] Hide tab close button
by a1ex＠dismail.de Oct. 28, 2024

Oct. 28, 2024

Hi list, In an attempt to keep the UI as configurable as possible for accessibility and themeing purposes, here is an example patch to hide the close tab button. Since we can already close the tab with the right or middle mouse button click, the button might be useless for some users, and may also be taking up valuable horizontal real-estate in the tab bar. Maybe it seems silly, but when using Dillo on a constrained portrait display, this can be useful. It can probably be made into a dillorc option if there is any interest. --- a/src/uicmd.cc Mon Oct 28 19:01:28 2024 +++ b/src/uicmd.cc Mon Oct 28 19:01:57 2024 @@ -142,7 +142,7 @@ class CustTabs : public Fl_Group { (public) Fl_Group(0,0,ww,th,lbl) { Pack = NULL; focus_counter = 0; - tab_w = 50, tab_h = th, ctab_h = 1, btn_w = 20, ctl_w = 1*btn_w+2; + tab_w = 50, tab_h = th, ctab_h = 1, btn_w = 20; resize(0,0,ww,ctab_h); /* tab buttons go inside a pack within a scroll */ Scroll = new Fl_Scroll(0,0,ww-ctl_w,ctab_h); I've also done some preliminary work to theme the tab bar, scroll bar, url bar, icons, and ui highlights. Dillo isn't really designed for that, so to create a proper user configurable theme-engine will probably be quite a lot of work, and not something that I can handle alone. Regards, Alex

1 0

[WIP PATCH] Use SIGUSR1 to reload the page
by a1ex＠dismail.de Oct. 25, 2024

Oct. 25, 2024

Hi Rodrigo, I find your recent idea[0] to refresh the page on local file changes interesting, and it could be a quite useful feature. [0] https://github.com/dillo-browser/dillo/issues/255 I imagine it can be triggered with a tool like entr[1]: ls /tmp/test.html | entr 'pkill -SIGUSR1 dillo' [1] http://eradman.com/entrproject/ So far, I have a working signal handler which will act upon receipt of a SIGUSR1 signal. It just prints the signal # to the console right now. I am trying to make it perform an 'a_UIcmd_reload', but haven't been successful yet: dillo.cc:389:19: error: use of undeclared identifier 'vbw' a_UIcmd_reload(*vbw); ^ 1 error generated bw.h and uicmd.hh are defined in dillo.cc, so its probably a skill issue on my end :) Any hints would be appreciated! Regards, Alex --- a/src/dillo.cc Sun Aug 11 22:21:59 2024 +++ b/src/dillo.cc Mon Sep 2 14:21:08 2024 @@ -381,6 +381,14 @@ static DilloUrl *makeStartUrl(char *str, bool local) } /* + * Use SIGUSR1 to reload the page + */ +static void reload_handler(int signum) +{ + MSG("signum=%d\n\n", signum); +} + +/* * MAIN */ int main(int argc, char **argv) @@ -579,6 +587,10 @@ int main(int argc, char **argv) a_Url_free(start_url); } } + + // Reload page on SIGUSR1 + if (signal (SIGUSR1, reload_handler) == SIG_IGN) + signal (SIGUSR1, SIG_IGN); Fl::run();

2 5

Rendering issue with view source and large embedded images
by a1ex＠dismail.de Oct. 19, 2024

Oct. 19, 2024

Hi, There is a small rendering glitch when trying to view the source of a page which has larger embedded data uri images. See attached screenshot. This is an example of a page which uses large embedded jpegs: https://www.da.vidbuchanan.co.uk/blog/dram-emfi.html When you view the source in Dillo, the issue should be evident. Since the encoded image is just one super-long line in the html, the vsource dpi probably isn't designed to handle that. I don't think its typical that a site will embed large images into the page like this, but maybe its still worth considering. Regards, Alex

2 20

Navigation by pages
by a1ex＠dismail.de Oct. 18, 2024

Oct. 18, 2024

Hi Rodrigo, I saw your recent issue on GH: https://github.com/dillo-browser/dillo/issues/268 This is something I have thought about for quite a while. Basically, scrolling sucks, and it would be nice to be able to move up and down the page more cleanly. Obviously we can use PgUP/PgDN keys and spacebar, but I always wanted a way to do this with mouse-only. In the past I had scripted a small window which sits on-top of Dillo in the corner, which had 2 buttons: up and down. This works, but is a bit clunky. So, while I don't have a quick solution to the layout / pagination issues you mentioned, I created a simple toolbar icon which allows page navigation with the mouse. I think it really makes it easier when reading a long page. Patch and screenshot attached. Regards, Alex

2 8

scroll_step description
by Kevin Koster Oct. 17, 2024

Oct. 17, 2024

There's a new "scroll_step" option in the example configuration file for 3.1.0-rc1. The comment "Mouse wheel scroll step in pixels" suggests that this only affects the mouse wheel, but it also changes the distance the page moves when the arrow keys are pressed and the overlap of previous page content that's left when you press Page Up/Down. I think that's a little confusing, especially as the value has changed since the default behaviour in 3.0.5 (the old value seems to have been about 25).

2 6

Scrollbar themeing
by a1ex＠dismail.de Oct. 13, 2024

Oct. 13, 2024

Hi, When using a dark theme, the scrollbar can be very hard to see: https://alex.envs.net/test/scroll-theme-stock1.png I made some changes and now the scrollbar looks nicer and is more visible: https://alex.envs.net/test/scroll-theme-mod1.png If someone wants to try it, here is a patch which also includes some commented lines which you can use to further customize the appearance of the scrollbar. -Alex --- a/dw/fltkviewport.cc Sat Oct 12 22:05:30 2024 +++ b/dw/fltkviewport.cc Sun Oct 13 16:23:06 2024 @@ -59,12 +59,20 @@ FltkViewport::FltkViewport (int X, int Y, int W, int H hscrollbar = new CustScrollbar (x (), y (), 1, 1); hscrollbar->type(FL_HORIZONTAL); + // Horizontal scrollbar theme options: + // hscrollbar->color(FL_BLUE, FL_YELLOW); + // hscrollbar->box(FL_ENGRAVED_BOX); + hscrollbar->slider(FL_PLASTIC_DOWN_BOX); hscrollbar->callback (hscrollbarCallback, this); hscrollbar->hide(); add (hscrollbar); vscrollbar = new Fl_Scrollbar (x (), y(), 1, 1); vscrollbar->type(FL_VERTICAL); + // Vertical scrollbar theme options: + // vscrollbar->color(FL_BLUE, FL_YELLOW); + // vscrollbar->box(FL_ENGRAVED_BOX); + vscrollbar->slider(FL_PLASTIC_DOWN_BOX); vscrollbar->callback (vscrollbarCallback, this); vscrollbar->hide(); add (vscrollbar);

2 1

Issue 187: "Configure should stop when no compiler is found"
by a1ex＠dismail.de Oct. 6, 2024

Oct. 6, 2024

Hi Rodrigo, Regarding this issue[1], I have found couple of ways to address this: The easiest way is to do AC_PROG_CXX before AC_PROG_CC: --- a/configure.ac Sat Oct 5 13:15:28 2024 +++ b/configure.ac Sat Oct 5 13:15:48 2024 @@ -124,8 +124,8 @@ if test "x$enable_ssl" != "x"; then AC_MSG_ERROR([The flag --enable-ssl is deprecated, use --enable-tls]) fi -AC_PROG_CC AC_PROG_CXX +AC_PROG_CC AC_PROG_RANLIB AC_PROG_CPP Which now errors out when no working compiler is found: 'configure: error: C++ compiler cannot create executables' Alternately, we can add a check to verify if the complier actually exists, and if not, exit. Something like this: dnl ------------------------------------------------------------ dnl AC_PROG_CXX will set CXX=g++ even if it finds no useable C++ dnl compiler, so we have to check whether the program named by dnl CXX exists. dnl ------------------------------------------------------------ dnl AC_PROG_CXX AC_PATH_PROG(REAL_CXX, $CXX) HAVE_CXX=no if test -n "$REAL_CXX"; then HAVE_CXX=yes fi if HAVE_CXX="no"; then echo "Error: No working C++ compiler found!" exit 1 fi If either of these solutions work for you, I can create a pull request. [1] https://github.com/dillo-browser/dillo/issues/187 Regards, Alex

2 3

CSS extra units
by Rodrigo Arias Oct. 5, 2024

Oct. 5, 2024

Hi, This PR adds support for extra CSS units (ch, rem, vw, vh, vmin and vmax) from the mobilized fork: https://github.com/dillo-browser/dillo/pull/264 I tested it with a few sites, and overall it improves the rending layout, but it would be nice if you can test it with more sites before it gets merged. Best, Rodrigo.

2 2