March 2009 - Dillo-dev - lists.mailman3.com

[patch]: fix compiler warning in CustShrinkTabPager
by onepoint＠starurchin.org 19 Mar '09

19 Mar '09

The CustShrinkTabPager class generates a gcc warning because it has virtual functions but its destructor is not virtual. This patch adds the virtual destructor and stops the warning. NB: there may be a case for rejecting this patch if we're really concerned about the performance of virtual functions (one extra indirection per call). FLTK deliberately avoids virtual destructors whenever possible for just this reason. I seriously doubt that this patch makes any impact on Dillo, but that's just IMHO. Regards, Jeremy Henty

2 2

Re: Approval
by jcid＠dillo.org 19 Mar '09

19 Mar '09

Hi, On Sun, Mar 15, 2009 at 10:34:53PM +0000, Tim Nieradzik wrote: > Hi Jorge, > > > Please send it to me and I'll send you a dillo.org based URL > > so you can refer to it. > > Unfortunately I had already deleted the mail but here are some > information from my maildrop log that might be useful for you: > > Date: Mon Mar 9 17:00:12 2009 > From: dillo-dev-bounces(a)dillo.org > Subj: Your message to Dillo-dev awaits moderator approval > Size: 1902 Message found and approved. > By the way, I think I have found three bugs in Dillo. Whenever I > visit the site https://oss.gonicus.de/labs/gosa/wiki, it asks me > whether I want to accept the certificate about 10 times (probably > for each picture and CSS file). A way to solve it would be to > remember the selection for all links on this page but this could > become to a big security risk as people could misuse this behaviour > for phishing sites. This is BUG#868 in the tracker. The solution is to turn the https dpi into a server (it's a filter now). This is not complex but takes time. I don't want to delay the next release even more so most probably it will be in the release after dillo-2.1. > The other bug appears on http://urldecode.info/ where no pictures > are displayed. My vague assumption is that Dillo cannot handle > images whose headers contain a "Location" header. Dillo just checks > whether the Content-Length header contains anything (this is why it > works for 0). It seems to me that Dillo downloads the picture > properly but does not show it because it thinks the size is supposed > to be 0. Yes, historically dillo doesn't follow image redirections. Over time this has helped to reduce advertising (most image redirections are advertising). > [...] > A possible solution would be to overwrite all headers by the ones > from the redirected URL ("Location" header). Or would it be better > to delete all available headers when a "Location" headers was found? For "root" URLs, redirection is working, the same/similar method my be re-used for images. The point is whether it's desirable to do it. For instance, with a load_remote_images pref, it would work, but lot's of advertising would pass too. When disabled, sites as the one you cite won't work. If we let the user toggle this pref from "Tools" it would feel clumsy to do it for a favorite site. Now, we may solve all this with URL filtering. Let's say filtering has higher priority, and we have "allow" and "deny" options (just think of hosts not RE by now to discard performance issues). In the above described case I'd choose to set: allow file content = urldecode.info load_image_redirections = NO meaning that when visiting urldecode.info, remote image redirections will be loaded. The API should allow setting this automatically from the tools menu (e.g. "allow remote images" option with a short dialog: Do you want to enable remote image loading permanently for site xxx.yyy.zzz? [Allow] [Cancel]) URL filtering based on regular expressions is expensive in CPU terms, that's why I like the idea of HOST-based filtering. With it you can deny as a general rule and have some allow exceptions. (BTW, as a last resource if all this is not enough, RE support may be added on top). > The third issue (which only occurs in the Hg tree) looks like a > timing bug. When visiting http://www.golem.de/0903/65726.html not > all of the pictures are shown but when reloading the page, they are. > Interestingly, it works perfectly if I save the page to disk and > then view it manually in Dillo. This needs some ivestigation... > When is the final version planned to be released? I'll have more time in April, so probably April. > In my opinion we > should wait a few weeks because Dillo crashes regularly on my > machines (always running the trunk version). This is strange, I very seldom get a dillo crash. Can you post example URLs, more details of your OS/FLTK-version/settings? > Therefore a release > candidate every two would be useful for the users to give feedback > and to report further bugs. After all of the major bugs have been > fixed, we could announce the final version. That's the idea. > Is it planned to include > the key bindings patch into this version? This should not be a big > deal for the users as the configuration files are backward > compatible. No, it's not planned. Now if the patch is simple, clean and straightforward and I can review it before rc1, and behaves well in testing, then it may go in. > What really annoys me is that when Dillo crashes, the CPU usage > climbs onto 100%. The only way I can fix this is to kill all > Dillo-related processes. This way, I lose my tabs. A session-saver > like in Mozilla Firefox would be a useful feature but I am not sure > whether it is worth the "bloatage". AFAIS, one of the main features of Dillo is its stability, so please give us more information on this. > PS: What is the accurate way to find those memory leaks? I remember > Jeremy speaking about Valgrind which he used to create his "crash > reports". Valgrind is cetainly a great tool for the job. -- Cheers Jorge.-

2 1

[patch]: remove the BW_* flags
by onepoint＠starurchin.org 19 Mar '09

19 Mar '09

a_Bw_stop_clients() is always called with the BW_Root and BW_Img flags set, so we can remove those flags. That leaves only the BW_Force flag, so we can remove that too and change the flags argument to a boolean that indicates whether to force. Regards, Jeremy Henty

3 6

[patch]: fix comment for DLWin::del()
by onepoint＠starurchin.org 18 Mar '09

18 Mar '09

The comment for DLWin::del() was copied and pasted from DLWin::new(), but never corrected! Regards, Jeremy Henty

2 2

My valgrind logs, for all to see.
by onepoint＠starurchin.org 17 Mar '09

17 Mar '09

For your information. http://starurchin.org/dillo/valgrind.html It lists the valgrind errors from my most recent Dillo sessions. It's just one big static HTML page at the moment. Feel free to suggest how it could be more useful. You can see we're still getting lots of small leaks from the CSS parser, though the big ones have been fixed by recent commits. Regards, Jeremy Henty

3 16

Too busy...
by jcid＠dillo.org 15 Mar '09

15 Mar '09

Hi, Please excuse me for being silent these days. It's being full of activities for me. Besides the regular job, I'm moving to another place and have a trip out of the city the next weekend. Rolling a release needs more than a couple spare days so, it will have to wait. I'll surely have more time when April starts, if I have some time before that, I'll try to answer the pending emails. The current repo is almost rc1. After the "instant META redirection" patch goes in, it'll be rc1, and the release procedures will start. -- Cheers Jorge.-

1 0

[PATCH 0 of 3] tweaking the dillo ui for embedded devices
by 4winter＠informatik.uni-hamburg.de 13 Mar '09

13 Mar '09

Hey folks :) I've got a new toy (the Neo FreeRunner) and dillo2 runs quite nicely on that little device, but there are some problems: * there is no way to create bookmarks Adressed in the second patch which adds an add bookmark button to the main toolbar. * the scrollbars are unusable without a stylus A more natural way of scrolling on embedded devices with touchscreens is finger scrolling. A proof of concept is attached as the third patch. Acceleration would be a nice feature for big pages. * buttons on dialogs are too small Proposed solution: There is code for creating dialogs in src/dialog.cc for a_Dialog_choice5 that creates the dialog window without relying on fltks choice(). We could generalize that and use it for all dialogs. This way we could resize the buttons and stack them vertically on top of each other. What do you think? Justus ps: the first patch is a small cleanup patch. all three patches should apply cleanly independently in spite of being a patch set)

4 8

[PATCH 3 of 3] Easy panning with the left mouse button
by darirf＠yahoo.es 12 Mar '09

12 Mar '09

Hi! As this is my first post to the list: hello, I'm the one that ported (or broke, depending on your the point of view) dillo 0.8.6 for the iRex iLiad e-book reader; my alias in mobileread.com is Antartica. I've been reading the lists for some time now, but didn't thought I had anything to share yet. But... I agree with Justus in that panning is the easiest method to scroll in embedded devices; the scroll bar is very small and enlarging it wastes too much screen state. For the iliad port of dillo 0.8.6 I did exactly what Justus is proposing of left-button-does-panning (albeit in a hackish way, as I hardcoded that behaviour). For reference, the patch to old dillo 0.8.6 is in: http://projects.mobileread.com/iliad/users/antartica/dillo/dillo-patch-spli… I was actually doing the same for dillo2, but only have it partly-done (see attach). I would love to have Justus code merged in mainline, as it implements that functionality neatly and it would alleviate me from finishing my hack :). Right now I can't test Justus patch, but I had one error to fix in mine: it didn't pan when showing images. Its worth checking if Justus patch have that right. Anyway, you all are doing an excellent job in keeping dillo relevant. It is really a nice piece of work :). Congrats. Regards, Dario. --- El lun, 9/3/09, Justus Winter <4winter(a)informatik.uni-hamburg.de> escribi?: > De: Justus Winter <4winter(a)informatik.uni-hamburg.de> > Asunto: [Dillo-dev] [PATCH 3 of 3] Easy panning with the left mouse button > Para: dillo-dev(a)dillo.org > Fecha: lunes, 9 marzo, 2009 5:59 > # HG changeset patch > # User Justus Winter > <justus.winter(a)informatik.uni-hamburg.de> > # Date 1236616924 -3600 > # Node ID 46c62dde8967ae87914d0fbcc0ba7df61853750c > # Parent 78c0fa261c84df53da7f69cc8f33dc85fa152f9c > Easy panning with the left mouse button > > This is particulary useful for embedded devices with touch > screens. > In order to select text you have to double click and drag > the pointer. > > Note that this functionality is disabled by default and can > be enabled > by the easy_panning directive in the configuration file > with the > exception of the selection behavior which is located in > dw/selection.cc > and lacks a reference to the prefs struct by design (dw is > a toolkit and > frontend agnostic). > > I think that dw needs an interface to tweak it's > behaviour > ie dw_config(DW_DOUBLECLICK_TO_SELECT, true). Any ideas? > [...]

1 0

Holiday week
by jcid＠dillo.org 11 Mar '09

11 Mar '09

Hi there, I happen to be enjoying a much needed holiday week! :-) The plan is to come back around near wednesday 25. In the meanwhile, I leave you with the following issues lurking in my list to be considered. Maybe all of them can be left to the release after 2.1, but maybe not: [ ] https dialog bombing issue. BUG#868 When enabled, multiple https requests to the same site result in dialog bombing. The https dpi is disabled by default in Dillo. Anyway, in Debian, there's a security warning against dillo for not checking certificates (I don't know what version of dillo they use, nor why they enable https.) [ ] Jump to #anchor doesn't work correctly. The idle timeout doesn't work reliably (an old bug). [ ] Implement @import statement in STYLE element. [ ] What will we do with xhtml? FF doesn't validate. BUG#732 This would be interesting to define. (already suggested as discussion material in another thread). [ ] "-fno-rtti -fno-exceptions" gcc: 64KB less. Enabling this switches reduces the binary size. [ ] dpi for "view page source" (it re-uses search capability). Waiting since a long time... [-] BUG#892 prefs bg_color is not working Johannes was working on related things... [ ] META refresh: "instant client-side redirect". [ ] META refresh: URL='<URI>' case. I plan to implement both when I'm back (and to include them in dillo-2.1). BTW, I want to welcome Tim Nieradzik as a new developer and to tell Joao that the bug in the find-text iterator is not that much important. Just focus on something more urgent. -- Cheers Jorge.-

4 5

Server-side CSS detection?
by rn214＠cam.ac.uk 07 Mar '09

07 Mar '09

Dear All, I've just joined this list, so I hope I'm posting this in the right place. I'm a webmaster, and I want to make sure that my site works properly in all browsers including dillo. However, some of the new code (*) in my site relies on CSS properties such as display:none and does not gracefully degrade. If a browser has no CSS support, the newest stuff breaks in a very ugly manner, whereas most of the CSS I've written to date fails gracefully (we don't really care if some text-colour is wrong). So my question is, how can I detect CSS support server-side? I don't need to know precise details of the CSS-support; I just want a simple yes/no. So Netscape 4.6 would be "yes", whereas Dillo 0.8, and links/lynx/w3m/googlebot would be "no". I don't want to do it by user-agent sniffing, and, if at all possible, I don't want to rely on javascript (there are plenty of people who have CSS-capable browsers with JS turned off). I've had no luck from google, so I thought I'd ask here, as you'll know the best way to do this. Thank you for your help, Regards, Richard (*) for example, I display HTML tooltips like this: span.tool { position: relative; cursor: help; } span.tool span.tip { display: none;} span.tool:hover span.tip { display: block; z-index: 100; position: absolute; top: 1.6em; left: 0; width: auto; padding: 6px; border: #F00;} this is the link Here is some html for the tooltip i.e. the tool.tip is normally hidden by display:none, but is displayed as result of the hover action. If a browser doesn't support the CSS display:none property, that will render in a very ugly way, with the tooltip contents displayed inline. So I want to have a way to fall-back (server-side) to: this is the link My intention is to do this server-side, using a session-variable after testing whether the client supports CSS. But how?

2 1