February 2008 - Dillo-dev - lists.mailman3.com

Re: patch: cookies string leak
by jcid＠dillo.org 20 Mar '08

20 Mar '08

On Fri, Feb 01, 2008 at 06:26:56PM +0000, place wrote: > Also, what would you think of me either > > - stuffing the "Cookie2: $Version=\"1\"\r\n" header into a_Cookies_get(url) OK. Basically the same way referer is handled. > or > - adding a function to http.c to accomplish the same thing? > ...with a_Cookies_get() changed to show a distinction between > don't-want-cookies and don't-have-cookies. > > I almost never have any cookies enabled, so I'd prefer not to send > the Cookie2 header all of the time when I don't want their cookies. No problem. Leak patch committed. -- Cheers Jorge.-

4 7

From the FLTK devs: [dejan.lekic@gmail.com: Re: [fltk.development] This year GSOC]
by onepoint＠starurchin.org 08 Mar '08

08 Mar '08

Just to make sure no-one misses this, some love from the FLTK guys! Jeremy Henty ----- Forwarded message from Dejan Lekic <dejan.lekic(a)gmail.com> ----- From: Dejan Lekic <dejan.lekic(a)gmail.com> To: fltk-dev(a)easysw.com Subject: Re: [fltk.development] This year GSOC Date: Thu, 28 Feb 2008 08:25:55 -0800 Personally, the thing I most anticipate and would like to see improved, which is related to FLTK, is the Dillo port to FLTK2. Seriously, if Dillo2 could be done as a library, and provide a Group widget which is directly embeddable into any FLTK2 application, that would be IMHO a huuuuuge thing. So, I hope someone would help Dillo guys either via GSoC, or other way(s). More information: http://www.dillo.org . Get the fresh FLTK2 port of Dillo from CVS: :pserver:anonymous@auriga.wearlab.de:/sfhome/cvs/dillo Kind regards _______________________________________________ fltk-dev mailing list fltk-dev(a)easysw.com http://lists.easysw.com/mailman/listinfo/fltk-dev ----- End forwarded message -----

3 2

patch: multipart/form-data encoding for form submission
by place＠gobigwest.com 02 Mar '08

02 Mar '08

Currently, dillo always submits forms using url encoding regardless of the encoding specified by the form. Wikipedia, for example, specifies multipart/form-data because the user may submit huge blocks of text in languages where url encoding will be very inefficient. - This patch always uses the same boundary, but a different one REALLY should be used for every form submission. At the least, the string should be scrambled up somehow. - It adds a URL_MultipartEnc flag. - For the Content-type header, I pull the boundary out of URL_DATA because I didn't want to clutter up the URL with a field for something not commonly used. ----------------------------------------------------------- For multipart/form-data, a submission goes like: [headers] Content-type: multipart/form-data; boundary="[boundary]" --[boundary] Content-Disposition: form-data; name="[name1]" [value1] --[boundary] Content-Disposition: form-data; name="[name2]" [value2] --[boundary] ...and eventually... Content-Disposition: form-data; name="[namen]" [valuen] --[boundary]--

2 7

[patch] redraw optimization now including tables
by Johannes.Hofmann＠gmx.de 29 Feb '08

29 Feb '08

Hello, below is an improved version of the redraw optimization. It now also covers table based pages - at least to some point. The challenge is to make the already commited optimization work recursively. Other than I originally thought topLevel is always a Textblock. Table based pages simply consist of a Textblock with a huge Table as child widget. Textblock now needs to avoid redrawing the child area when the table size increases. The redrawing is left to the Table-code, which then can be optimized. Please test carefully and report any anomalies you find. Regards, Johannes

2 3

[patch] use CURSOR_MOVE when drag scrolling
by jcid＠dillo.org 29 Feb '08

29 Feb '08

Hi, > the patch below disallows drag scrolling over links where the middle > mouse button is used to open the link in a new window. It also > changes the cursor to CURSOR_MOVE when drag scrolling. Committed. -- Cheers Jorge.-

1 0

Re: patch: not-a-png message
by jcid＠dillo.org 29 Feb '08

29 Feb '08

On Fri, Feb 29, 2008 at 04:42:05PM +0000, place wrote: > Just noticed this in my tree while making multipart diffs. I'd forgotten > about it... Committed. -- Cheers Jorge.-

1 0

[patch] add ctrl-f shortcut for findText
by Johannes.Hofmann＠gmx.de 29 Feb '08

29 Feb '08

Hi, patch below adds ctrl-f shortcut for findText. BTW, shouldn't ctrl-b open the bookmarks page as it did in dillo1? Cheers, Johannes diff -r 44838cc1f38d src/ui.cc --- a/src/ui.cc Sun Feb 24 23:15:53 2008 +0100 +++ b/src/ui.cc Thu Feb 28 22:43:22 2008 +0100 @@ -702,7 +702,10 @@ int UI::handle(int event) // Handle these shortcuts here. if (event == SHORTCUT) { if (event_state(CTRL)) { - if (k == 'l') { + if (k == 'f') { + a_UIcmd_findtext_dialog((BrowserWindow*) user_data ()); + ret = 1; + } else if (k == 'l') { a_UIcmd_open_url_dialog(user_data()); ret = 1; } else if (k == 'n') {

2 1

[patch] use CURSOR_MOVE when drag scrolling
by Johannes.Hofmann＠gmx.de 28 Feb '08

28 Feb '08

Hi, the patch below disallows drag scrolling over links where the middle mouse button is used to open the link in a new window. It also changes the cursor to CURSOR_MOVE when drag scrolling. Cheers, Johannes diff --git a/dw/fltkviewport.cc b/dw/fltkviewport.cc --- a/dw/fltkviewport.cc +++ b/dw/fltkviewport.cc @@ -233,11 +233,13 @@ int FltkViewport::handle (int event) case ::fltk::PUSH: take_focus(); if (::fltk::event_button() == ::fltk::MiddleButton) { - dragScrolling = 1; - dragX = ::fltk::event_x(); - dragY = ::fltk::event_y(); /* pass event so that middle click can open link in new window */ - FltkWidgetView::handle (event); + if (FltkWidgetView::handle (event) == 0) { + dragScrolling = 1; + dragX = ::fltk::event_x(); + dragY = ::fltk::event_y(); + setCursor (core::style::CURSOR_MOVE); + } return 1; } break; @@ -260,6 +262,7 @@ int FltkViewport::handle (int event) case ::fltk::RELEASE: if (::fltk::event_button() == ::fltk::MiddleButton) { dragScrolling = 0; + setCursor (core::style::CURSOR_DEFAULT); } break;

1 0

PATCH: small improvement to the "can't start dpid daemon" error message
by onepoint＠starurchin.org 24 Feb '08

24 Feb '08

A common cause of the "can't start dpid daemon" error is clicking on a link with a typo'ed HREF that has an invalid URL scheme (eg. 'ttp://' instead of 'http://', to cite the real-life example that prompted this patch). But the error message gives *no* context that would help to diagnose the problem. If it cited the URL scheme it would save a lot of time. (I had to start Firefox before I realised what the problem was!) Here's a patch to do that. Jeremy Henty

2 1

[patch] fix redraw problem with findText
by Johannes.Hofmann＠gmx.de 24 Feb '08

24 Feb '08

Hello, the patch below fixes the redraw problem with findText found by place that was introduced with my textblock optimization. Partial redraws were interfering with scrolling. The findText method is a nice test for this code path! I'm now experimenting with a redraw optimization that covers table based pages too. It's looking promising, but it needs some more work. Cheers, Johannes diff --git a/dw/fltkviewbase.cc b/dw/fltkviewbase.cc --- a/dw/fltkviewbase.cc +++ b/dw/fltkviewbase.cc @@ -85,6 +85,7 @@ void FltkViewBase::draw () } } + drawRegion.clear (); d &= ~DAMAGE_VALUE; } @@ -110,9 +111,12 @@ void FltkViewBase::draw () area.width = rect.w(); area.height = rect.h(); theLayout->expose (this, &area); + + if (! (d & DAMAGE_SCROLL)) { + drawRegion.clear (); + } } - drawRegion.clear (); } void FltkViewBase::drawChildWidgets () { diff --git a/dw/fltkviewport.cc b/dw/fltkviewport.cc --- a/dw/fltkviewport.cc +++ b/dw/fltkviewport.cc @@ -185,6 +185,7 @@ void FltkViewport::draw () int d = damage(); if (d & DAMAGE_SCROLL) { + set_damage (DAMAGE_SCROLL); scrollrect(cr, -scrollDX, -scrollDY, draw_area, this); d &= ~DAMAGE_SCROLL; set_damage (d);

2 1