December 2007 - Dillo-dev - lists.mailman3.com

patch: color shading
by place＠gobigwest.com Jan. 3, 2008

Jan. 3, 2008

This should make shading better...

2 4

Re: Colspan and table percentages
by place＠gobigwest.com Jan. 2, 2008

Jan. 2, 2008

I've noticed that sometimes people will make a table with two columns for the purpose of indenting their text, specifying only the width of the first column as some percentage. When they do this, dillo squishes everything to the right. Tiny example: <html><head><title></title></head><body> <table width=500 border=3> <tr> <td width="50%">Is explicitly 50%</td> <td>should be 50%</td> </tr> </table> </body></html>

2 1

[patch] fix hanging stop button
by Johannes.Hofmann＠gmx.de Jan. 2, 2008

Jan. 2, 2008

Hello, when pressing the stop button, it get's deactivated properly, but seems to get stuck in the pressed position. The patch below fixes the problem here. For the back- and forward- buttons it's not really necessary, because the url change seems to cause the necessary redraw anyway. However I added it there too for consistency. Regards, Johannes --- a/src/ui.cc Fri Dec 28 18:33:50 2007 +0100 +++ b/src/ui.cc Sat Dec 29 10:36:50 2007 +0100 @@ -21,6 +21,7 @@ #include <fltk/Input.h> #include <fltk/Output.h> #include <fltk/run.h> +#include <fltk/damage.h> #include <fltk/BarGroup.h> #include <fltk/PackedGroup.h> #include <fltk/xpmImage.h> @@ -996,12 +997,15 @@ void UI::button_set_sens(UIButton btn, i switch (btn) { case UI_BACK: (sens) ? Back->activate() : Back->deactivate(); + Back->redraw(DAMAGE_HIGHLIGHT); break; case UI_FORW: (sens) ? Forw->activate() : Forw->deactivate(); + Forw->redraw(DAMAGE_HIGHLIGHT); break; case UI_STOP: (sens) ? Stop->activate() : Stop->deactivate(); + Stop->redraw(DAMAGE_HIGHLIGHT); break; default: break;

2 1

[patch] make TopGroup a PackedGroup
by Johannes.Hofmann＠gmx.de Jan. 2, 2008

Jan. 2, 2008

Hello, as I didn't get any feedback from Sebastian yet on my proposal to make the scrollbars part of UI instead of FltkViewport, I decided to split my initial patch. Below is a version that still uses a PackedGroup in UI, but leaves the scrollbars in FltkViewport. Here comes the details: * Make scrollbars really children of FltkViewport, as it was probabely intended. * Use widget local coordinates in FltkViewport::adjustScrollbarsAndGadgets. * Adjust draw() and handle() so that scrollbars work properly. * As a consequence replace() now works properly, so remove the workaround. * Make TopGroup a PackedGroup and let it do the layout. * Simplify fullscreen mode. This also fixes annoying problems with the statusbar when new windows are created in fullscreen mode. Cheers, Johannes

3 8

[PATCH] SELECT form controls
by onepoint＠starurchin.org Jan. 1, 2008

Jan. 1, 2008

This patch adds (partial) support for SELECT controls in forms. Please note: * SELECTED and DISABLED are supported. * If no item is selected in the HTML source then the first item is selected by default. This means the code must delay adding any items until the SELECT is closed, since the DW API forces us to choose whether to select an item when creating it and won't let us change that later. * MULTI and SIZE are not supported: we render all SELECT controls as option menus that allow only one choice. I believe more work needs to be done on the DW ListResource before we can support multiple selections. * I added IN_OPTION to the HTML parsing flags. The code is also more careful than before to set/unset IN_FORM, IN_TEXTAREA, IN_SELECT and IN_OPTION. This may be a little redundant but I wanted to be sure that HTML tag soup can't make the flags inconsistent. I doubt the overhead of the extra bit-flipping is significant. Regards, Jeremy Henty

4 6

Re: patch: here are some consts for pixmaps.h
by jcid＠dillo.org Dec. 31, 2007

Dec. 31, 2007

Committed. -- Cheers Jorge.-

1 0

Re: patch: removing extraneous header inclusion
by jcid＠dillo.org Dec. 31, 2007

Dec. 31, 2007

On Sat, Dec 29, 2007 at 12:54:05AM +0000, place wrote: > Removed some where I couldn't see that they were being used for anything in > that file. > In one case, I added a prefs.h include (I had deleted a msg.h include, > and prefs.h is included in msg.h). > Committed. -- Cheers Jorge.-

1 0

Re: patch: here are a few more statics for dpi
by jcid＠dillo.org Dec. 31, 2007

Dec. 31, 2007

Committed. -- Cheers Jorge.-

1 0

patch: just hooking up panel preferences (panel_size, small_icons)
by place＠gobigwest.com Dec. 29, 2007

Dec. 29, 2007

Interestingly, the default was and is Tiny if panel_size is not mentioned in the rc, the default was and is Small in dillorc2, the initial value had been Medium in ui.cc, and the default was and is Large if the panel_size value is not understood.

3 2

[PATCH] dw::fltk::ui::FltkOptionMenuResource::isSelected()
by onepoint＠starurchin.org Dec. 28, 2007

Dec. 28, 2007

This patch provides a correct implementation of dw::fltk::ui::FltkOptionMenuResource::isSelected(), replacing the current stub. It is necessary for dillo2 to support SELECT controls in forms. Notes: * We implement Johannes' suggestion of modifying createNewMenu, using a single callback for each menu and calling item() to get the selected item. This gives a very clean implementation that doesn't add any new data members or virtual methods to the base classes. * We use FLTK widgets' user_data() to attach dw objects to FLTK widgets so that the FLTK callback can retrieve those dw objects from its arguments. This works very nicely and saves code since we don't have to add new data members to existing classes. * To avoid making identical changes everywhere an Item is created we refactored and created a new Item::createNewWidget() method. * For consistency of style we also refactored and created Item::createNewGroupWidget() and FltkSelectionResource::createNewItem(). (Despite their simplicity these refactorings actually account for most of the patch.) I should finish polishing the dillo2 SELECT patch soon. Then I'll be able to set comment thresholds on Slashdot! (These days that's the thing that most often forces me to quit dillo2 and start another browser, so this is a big itch to scratch.) Regards, Jeremy Henty

2 1