Dillo-dev

Download

By thread

dillo-dev@mailman3.com

3 participants
11667 messages

[Dillo-dev]selection patch (was: Patch review: Frank de Lange patch (20031124))

by Sebastian Geerken

Hi Bastiaan, On Thu, Jan 20, Bastiaan Jacques wrote: > The following patch does does two things in selection.c: > - - make a_Selection_set_dclick_callback replace the callback instead of > returning when the callback was already set. > * This function is called only once in the code (in interface.c); the > callback pointer always points to the same function. So I don't see a > point in merging this first hunk, although it won't do any harm. Thoughts? I'd rather leave it the current way, since changing the callback as in your patch would mean, that the old callback would be silently deactivated. To extend the current functionality, a remove function may be useful (to make deactivation explicit), or even a list of callbacks, so that the functions do not have to be removed (unless they should so). Anyway, there is currently no demand for an extended functionality, so I'd leave it as simple as it is now. > - - Replace three comparison operators (==) with bitwise AND.. > * This only works as expected when either lvalue and rvalue have exactly > one or zero bits set to 1. Although this currently is true, this may > change in the future; thus, I don't think these three hunks should be > merged. This (that only one bit set) will also be true in the future. If contents will be extended to contain multiple types (which is not planned at all), the whole design must be changed anyway (at least, the unions will have to replaced by structs), so grepping over the code is anyway necessary. Until then, your suggestion would only make the code more confusing. Sebastian

Feb. 2, 2005

Re: [Dillo-dev]Refresh patch for 0.8.4

by Roberto A. Foglietta

robert w hall wrote: > In message <7ff5668305012822047c7c59a5(a)mail.gmail.com>, Kelly Price > <strredwolf(a)gmail.com> writes > >>Heya. New here. Glad someone's working on Dillo. Hope it comes >>full-featured like Firefox is with less than half the bloat! > > > well some of us want NO bloat, and would err on the side of something > less than fully-featured to ensure that. > > If others really require a firefox-competitor, perhaps we are heading > for a dillo-lite... > Robert you have some problems but because I'm here as software developer and not as puppy mainteiner I will avoid to explain you why you missed THE point of that mail. But you still missed! ;-) However if some patches doesn't meet the strict requirements of the core dillo developers team doesn't mean that patches are crap or useless to others people. I still remember you that free software is for free people who have the right of choice and not to be forced to use 'dillo' as you imagined. Because you could be a genius but your imagination, by definition of genius as human being element, is still limitated. Because there are some patches out of there AT LEAST could be interesting for dillo users and for the project itself have a page collecting all these contribute AS patches. "AT LEAST for project itself too" exactly means "to reduce the risk of a fork". Which it could be not so difficult as you think, that could be less difficult than still sticky to YOUR limnitated-imagination-dillo. :-) Cheers, -- Roberto A. Foglietta Analista Programmatore GNU/Linux SAD Trasporto Locale S.p.a. Corso Italia 13/N 39100 BOLZANO (I) Tel. +39/0471-450.261 Fax +39/0471-450.253

Jan. 31, 2005

Re: [Dillo-dev]Refresh patch for 0.8.4

by Roberto A. Foglietta

Kelly Price wrote: > Heya. New here. Glad someone's working on Dillo. Hope it comes > full-featured like Firefox is with less than half the bloat! > > I'm attaching a fixed patch for 0.8.4 that allows meta-http refreshes. > This is quite common with web chats (including Tag-Board). I've > test-compiled and ran it, and so far so good. > > The next thing we'll need is the frames/iframes code now! > Here you are the refresh patch for dillo 0.8.4 from the author (me) http://www.roberto.foglietta.name/pub/dillo-0.8.4-refresh.patch.bz2 please don't spread modified patch which containing my name (and so people are let to refer at me like the original author) WITHOUT commenting the code about your modifies to adapt it to new releases. That patch cointaining ONLY the code necessary to use refresh option. Most of others changes (like in the patch you have submitted) doesn't make any sense (or not make sensa anymore). Thank you for your patience, -- Roberto A. Foglietta Analista Programmatore GNU/Linux SAD Trasporto Locale S.p.a. Corso Italia 13/N 39100 BOLZANO (I) Tel. +39/0471-450.261 Fax +39/0471-450.253

Jan. 31, 2005

Re: [Dillo-dev]Refresh patch for 0.8.4

by Roberto A. Foglietta

Kelly Price wrote: > Heya. New here. Glad someone's working on Dillo. Hope it comes > full-featured like Firefox is with less than half the bloat! > > I'm attaching a fixed patch for 0.8.4 that allows meta-http refreshes. > This is quite common with web chats (including Tag-Board). I've > test-compiled and ran it, and so far so good. > > The next thing we'll need is the frames/iframes code now! > I'm the authoir of original patch. I developed it for 0.8.4 too reducing size of patch itself. I tried to talk with dillo author to evaluete if there was any chances to include it in the main branch but I didn't received any answer. If somebody else is using this patch I will put on my website and I will keep it uptodate. Let me know. :-) Cheers, -- Roberto A. Foglietta Analista Programmatore GNU/Linux SAD Trasporto Locale S.p.a. Corso Italia 13/N 39100 BOLZANO (I) Tel. +39/0471-450.261 Fax +39/0471-450.253

Jan. 31, 2005

Re: [Dillo-dev]Refresh patch for 0.8.4

by Patrick Shanahan

* higuita <higuita7(a)yahoo.co.uk> [01-30-05 03:16]: > uuhmm?! > are you sure? arent you thinking in the cookies? > i have https in every instance i try, the only problem > with https is the "always ask for the certificate" problem maybe ?? -- Patrick Shanahan Registered Linux User #207535 http://wahoo.no-ip.org @ http://counter.li.org HOG # US1244711 Photo Album: http://wahoo.no-ip.org/photos

Jan. 30, 2005

Re: [Dillo-dev]Refresh patch for 0.8.4

by higuita

On Sat, 29 Jan 2005 12:30:54 -0500, Patrick Shanahan <ptilopteri(a)gmail.com> wrote: > before complying. I use it exclusively. The only problem I have with > it is it's only available to *one* screen/instance at a time :^(. uuhmm?! are you sure? arent you thinking in the cookies? i have https in every instance i try, the only problem with https is the "always ask for the certificate" problem higuita -- Naturally the common people don't want war... but after all it is the leaders of a country who determine the policy, and it is always a simple matter to drag the people along, whether it is a democracy, or a fascist dictatorship, or a parliament, or a communist dictatorship. Voice or no voice, the people can always be brought to the bidding of the leaders. That is easy. All you have to do is tell them they are being attacked, and denounce the pacifists for lack of patriotism and exposing the country to danger. It works the same in every country. -- Hermann Goering, Nazi and war criminal, 1883-1946

Jan. 30, 2005

Re: [Dillo-dev]Refresh patch for 0.8.4

by Patrick Shanahan

* Brian Hechinger <wonko(a)4amlunch.net> [01-29-05 11:41]: > > through the use of dillo plug-ins, i think we should be fully capable of > keeping the core dillo small and light, while easily allowing the ability > to add features that some people need without increasing the core bloat. > > https is a perfect example of this for one. https is already available by merely commenting out one line of code before complying. I use it exclusively. The only problem I have with it is it's only available to *one* screen/instance at a time :^(. -- Patrick Shanahan Registered Linux User #207535 http://wahoo.no-ip.org @ http://counter.li.org HOG # US1244711 Photo Album: http://wahoo.no-ip.org/photos

Jan. 29, 2005

Re: [Dillo-dev]Refresh patch for 0.8.4

by Brian Hechinger

On Sat, Jan 29, 2005 at 01:46:13PM +0000, robert w hall wrote: > In message <7ff5668305012822047c7c59a5(a)mail.gmail.com>, Kelly Price > <strredwolf(a)gmail.com> writes > >Heya. New here. Glad someone's working on Dillo. Hope it comes > >full-featured like Firefox is with less than half the bloat! > > well some of us want NO bloat, and would err on the side of something > less than fully-featured to ensure that. > > If others really require a firefox-competitor, perhaps we are heading > for a dillo-lite... through the use of dillo plug-ins, i think we should be fully capable of keeping the core dillo small and light, while easily allowing the ability to add features that some people need without increasing the core bloat. https is a perfect example of this for one. -brian -- "Now you know why I got the everliving hell OUT of Windows administration. Knowing it doesn't make it any easier. It's just broken-as-designed."

Jan. 29, 2005

Re: [Dillo-dev]Refresh patch for 0.8.4

by robert w hall

In message <7ff5668305012822047c7c59a5(a)mail.gmail.com>, Kelly Price <strredwolf(a)gmail.com> writes >Heya. New here. Glad someone's working on Dillo. Hope it comes >full-featured like Firefox is with less than half the bloat! well some of us want NO bloat, and would err on the side of something less than fully-featured to ensure that. If others really require a firefox-competitor, perhaps we are heading for a dillo-lite... -- robert w hall

Jan. 29, 2005

[Dillo-dev]Refresh patch for 0.8.4

by Kelly Price

Heya. New here. Glad someone's working on Dillo. Hope it comes full-featured like Firefox is with less than half the bloat! I'm attaching a fixed patch for 0.8.4 that allows meta-http refreshes. This is quite common with web chats (including Tag-Board). I've test-compiled and ran it, and so far so good. The next thing we'll need is the frames/iframes code now! -- Kelly "STrRedWolf" Price http://strredwolf.furrynet.com

Jan. 29, 2005

Jump to page: