April 2010 - Dillo-dev - lists.mailman3.com

setting image buffer and queueing resize

by corvid＠lavabit.com

I had just fixed the dw simple image test that hadn't requested a resize when setting the imgbuf. And now I just found that one of the scaled2 test's images needs it as well. Perhaps we should make the resize argument to setBuffer() mandatory. But, better yet, how about if Image::setBuffer() just does a queueResize() if either of its dimensions are LENGTH_AUTO?

April 28, 2010

Re: style.css font-family misses redraw

by dennisn＠dennisn.dyndns.org

On Tue, 27 Apr 2010 20:54:37 +0200, Johannes Hofmann wrote: > On Sun, Apr 25, 2010 at 11:35:20AM -0400, Dennis Nezic wrote: > > On Fri, 23 Apr 2010 23:37:31 +0200, Johannes Hofmann wrote: > > > On Fri, Apr 23, 2010 at 10:55:23AM -0400, Dennis Nezic wrote: > > > > If you specify a font-family in ~/.dillo/style.css, such as: > > > > > > > > * { font-family:sans-serif } > > > > > > > > And then visit a page like: > > > > > > > > http://www.linuxfromscratch.org/lfs/downloads/6.6/ > > > > > > > > ... it will produce "ghost" lines from the previous rendering > > > > before the css was applied. Moving the window, or doing > > > > anything else that forces a redraw, cleans it up. (Let me know > > > > if you don't see this and I can provide a screenshot.) > > > > > > Hm, the page does not seem to contain any CSS, so it renders with > > > just the user agent style and the user style (~/.dillo/style.css) > > > even the first time it draws. Maybe it's because of the images > > > that change the layout once loaded? > > > Can you reproduce the issue with load_images=NO? > > > > > > I've alse seen "ghost" lines on some pages, but could never find > > > the real reason. I only remeber that it depended on timing > > > somehow. > > > > The issue does not appear with load_images=NO ... ie. when it only > > occurs when images are loaded, and the table cells redrawn, but > > apparently not rendered automatically. (Until one moves the window, > > etc.) > > > > http://dennisn.dyndns.org/guest/pubstuff/dillo-ghostlines.jpg > > http://dennisn.dyndns.org/guest/pubstuff/dillo-ghostlines-gone.jpg > > > > Can you please test this patch > http://flpsed.org/tmp/ghostlines.diff > It fixes the issue I could reproduce here. Problem solved! :D

April 28, 2010

Re: style.css font-family misses redraw

by Johannes.Hofmann＠gmx.de

On Sun, Apr 25, 2010 at 11:35:20AM -0400, Dennis Nezic wrote: > On Fri, 23 Apr 2010 23:37:31 +0200, Johannes Hofmann wrote: > > On Fri, Apr 23, 2010 at 10:55:23AM -0400, Dennis Nezic wrote: > > > If you specify a font-family in ~/.dillo/style.css, such as: > > > > > > * { font-family:sans-serif } > > > > > > And then visit a page like: > > > > > > http://www.linuxfromscratch.org/lfs/downloads/6.6/ > > > > > > ... it will produce "ghost" lines from the previous rendering before > > > the css was applied. Moving the window, or doing anything else that > > > forces a redraw, cleans it up. (Let me know if you don't see this > > > and I can provide a screenshot.) > > > > Hm, the page does not seem to contain any CSS, so it renders with > > just the user agent style and the user style (~/.dillo/style.css) > > even the first time it draws. Maybe it's because of the images that > > change the layout once loaded? > > Can you reproduce the issue with load_images=NO? > > > > I've alse seen "ghost" lines on some pages, but could never find > > the real reason. I only remeber that it depended on timing somehow. > > The issue does not appear with load_images=NO ... ie. when it only > occurs when images are loaded, and the table cells redrawn, but > apparently not rendered automatically. (Until one moves the window, > etc.) > > http://dennisn.dyndns.org/guest/pubstuff/dillo-ghostlines.jpg > http://dennisn.dyndns.org/guest/pubstuff/dillo-ghostlines-gone.jpg > Can you please test this patch http://flpsed.org/tmp/ghostlines.diff It fixes the issue I could reproduce here. Cheers, Johannes

April 27, 2010

Re: style.css font-family misses redraw

by Johannes.Hofmann＠gmx.de

On Tue, Apr 27, 2010 at 12:41:09PM +0000, corvid wrote: > Johannes wrote: > > On Sun, Apr 25, 2010 at 11:35:20AM -0400, Dennis Nezic wrote: > > > On Fri, 23 Apr 2010 23:37:31 +0200, Johannes Hofmann wrote: > > > > On Fri, Apr 23, 2010 at 10:55:23AM -0400, Dennis Nezic wrote: > > > > > If you specify a font-family in ~/.dillo/style.css, such as: > > > > > > > > > > * { font-family:sans-serif } > > > > > > > > > > And then visit a page like: > > > > > > > > > > http://www.linuxfromscratch.org/lfs/downloads/6.6/ > > > > > > > > > > ... it will produce "ghost" lines from the previous rendering before > > > > > the css was applied. Moving the window, or doing anything else that > > > > > forces a redraw, cleans it up. (Let me know if you don't see this > > > > > and I can provide a screenshot.) > > > > > > > > Hm, the page does not seem to contain any CSS, so it renders with > > > > just the user agent style and the user style (~/.dillo/style.css) > > > > even the first time it draws. Maybe it's because of the images that > > > > change the layout once loaded? > > > > Can you reproduce the issue with load_images=NO? > > > > > > > > I've alse seen "ghost" lines on some pages, but could never find > > > > the real reason. I only remeber that it depended on timing somehow. > > > > > > The issue does not appear with load_images=NO ... ie. when it only > > > occurs when images are loaded, and the table cells redrawn, but > > > apparently not rendered automatically. (Until one moves the window, > > > etc.) > > > > > > http://dennisn.dyndns.org/guest/pubstuff/dillo-ghostlines.jpg > > > http://dennisn.dyndns.org/guest/pubstuff/dillo-ghostlines-gone.jpg > > > > Is anyone else seeing this issue on that page? It seems to work fine > > here, but I know that there is a problem, it's just hard to > > reproduce. > > Dennis: Do you know when the problem was introduced? I can now see a similar issue with this HTML fragment: <img src="http://flpsed.org/tmp/blank.gif" alt="Ico"> Name But it depends on your font settings. The point seems to be that the alt text is almost the same width as the image itself, so you might need to tweak the alt text for your font settings.

April 27, 2010

Re: style.css font-family misses redraw

by corvid＠lavabit.com

Johannes wrote: > On Sun, Apr 25, 2010 at 11:35:20AM -0400, Dennis Nezic wrote: > > On Fri, 23 Apr 2010 23:37:31 +0200, Johannes Hofmann wrote: > > > On Fri, Apr 23, 2010 at 10:55:23AM -0400, Dennis Nezic wrote: > > > > If you specify a font-family in ~/.dillo/style.css, such as: > > > > > > > > * { font-family:sans-serif } > > > > > > > > And then visit a page like: > > > > > > > > http://www.linuxfromscratch.org/lfs/downloads/6.6/ > > > > > > > > ... it will produce "ghost" lines from the previous rendering before > > > > the css was applied. Moving the window, or doing anything else that > > > > forces a redraw, cleans it up. (Let me know if you don't see this > > > > and I can provide a screenshot.) > > > > > > Hm, the page does not seem to contain any CSS, so it renders with > > > just the user agent style and the user style (~/.dillo/style.css) > > > even the first time it draws. Maybe it's because of the images that > > > change the layout once loaded? > > > Can you reproduce the issue with load_images=NO? > > > > > > I've alse seen "ghost" lines on some pages, but could never find > > > the real reason. I only remeber that it depended on timing somehow. > > > > The issue does not appear with load_images=NO ... ie. when it only > > occurs when images are loaded, and the table cells redrawn, but > > apparently not rendered automatically. (Until one moves the window, > > etc.) > > > > http://dennisn.dyndns.org/guest/pubstuff/dillo-ghostlines.jpg > > http://dennisn.dyndns.org/guest/pubstuff/dillo-ghostlines-gone.jpg > > Is anyone else seeing this issue on that page? It seems to work fine > here, but I know that there is a problem, it's just hard to > reproduce. Dennis: Do you know when the problem was introduced?

April 27, 2010

Re: style.css font-family misses redraw

by Johannes.Hofmann＠gmx.de

On Sun, Apr 25, 2010 at 11:35:20AM -0400, Dennis Nezic wrote: > On Fri, 23 Apr 2010 23:37:31 +0200, Johannes Hofmann wrote: > > On Fri, Apr 23, 2010 at 10:55:23AM -0400, Dennis Nezic wrote: > > > If you specify a font-family in ~/.dillo/style.css, such as: > > > > > > * { font-family:sans-serif } > > > > > > And then visit a page like: > > > > > > http://www.linuxfromscratch.org/lfs/downloads/6.6/ > > > > > > ... it will produce "ghost" lines from the previous rendering before > > > the css was applied. Moving the window, or doing anything else that > > > forces a redraw, cleans it up. (Let me know if you don't see this > > > and I can provide a screenshot.) > > > > Hm, the page does not seem to contain any CSS, so it renders with > > just the user agent style and the user style (~/.dillo/style.css) > > even the first time it draws. Maybe it's because of the images that > > change the layout once loaded? > > Can you reproduce the issue with load_images=NO? > > > > I've alse seen "ghost" lines on some pages, but could never find > > the real reason. I only remeber that it depended on timing somehow. > > The issue does not appear with load_images=NO ... ie. when it only > occurs when images are loaded, and the table cells redrawn, but > apparently not rendered automatically. (Until one moves the window, > etc.) > > http://dennisn.dyndns.org/guest/pubstuff/dillo-ghostlines.jpg > http://dennisn.dyndns.org/guest/pubstuff/dillo-ghostlines-gone.jpg Is anyone else seeing this issue on that page? It seems to work fine here, but I know that there is a problem, it's just hard to reproduce.

April 27, 2010

Re: style.css font-family misses redraw

by Johannes.Hofmann＠gmx.de

On Sun, Apr 25, 2010 at 11:35:20AM -0400, Dennis Nezic wrote: > On Fri, 23 Apr 2010 23:37:31 +0200, Johannes Hofmann wrote: > > On Fri, Apr 23, 2010 at 10:55:23AM -0400, Dennis Nezic wrote: > > > If you specify a font-family in ~/.dillo/style.css, such as: > > > > > > * { font-family:sans-serif } > > > > > > And then visit a page like: > > > > > > http://www.linuxfromscratch.org/lfs/downloads/6.6/ > > > > > > ... it will produce "ghost" lines from the previous rendering before > > > the css was applied. Moving the window, or doing anything else that > > > forces a redraw, cleans it up. (Let me know if you don't see this > > > and I can provide a screenshot.) > > > > Hm, the page does not seem to contain any CSS, so it renders with > > just the user agent style and the user style (~/.dillo/style.css) > > even the first time it draws. Maybe it's because of the images that > > change the layout once loaded? > > Can you reproduce the issue with load_images=NO? > > > > I've alse seen "ghost" lines on some pages, but could never find > > the real reason. I only remeber that it depended on timing somehow. > > The issue does not appear with load_images=NO ... ie. when it only > occurs when images are loaded, and the table cells redrawn, but > apparently not rendered automatically. (Until one moves the window, > etc.) > > http://dennisn.dyndns.org/guest/pubstuff/dillo-ghostlines.jpg > http://dennisn.dyndns.org/guest/pubstuff/dillo-ghostlines-gone.jpg > I'm pretty sure it has to do with the redraw optimization. But it seems to be depending on download speed or timing somehow, as I don's see it here. I will try to find the problem, but I remember looking into a similar issue without success. Cheers, Johannes

April 26, 2010

Re: style.css font-family misses redraw

by dennisn＠dennisn.dyndns.org

On Fri, 23 Apr 2010 23:37:31 +0200, Johannes Hofmann wrote: > On Fri, Apr 23, 2010 at 10:55:23AM -0400, Dennis Nezic wrote: > > If you specify a font-family in ~/.dillo/style.css, such as: > > > > * { font-family:sans-serif } > > > > And then visit a page like: > > > > http://www.linuxfromscratch.org/lfs/downloads/6.6/ > > > > ... it will produce "ghost" lines from the previous rendering before > > the css was applied. Moving the window, or doing anything else that > > forces a redraw, cleans it up. (Let me know if you don't see this > > and I can provide a screenshot.) > > Hm, the page does not seem to contain any CSS, so it renders with > just the user agent style and the user style (~/.dillo/style.css) > even the first time it draws. Maybe it's because of the images that > change the layout once loaded? > Can you reproduce the issue with load_images=NO? > > I've alse seen "ghost" lines on some pages, but could never find > the real reason. I only remeber that it depended on timing somehow. The issue does not appear with load_images=NO ... ie. when it only occurs when images are loaded, and the table cells redrawn, but apparently not rendered automatically. (Until one moves the window, etc.) http://dennisn.dyndns.org/guest/pubstuff/dillo-ghostlines.jpg http://dennisn.dyndns.org/guest/pubstuff/dillo-ghostlines-gone.jpg

April 25, 2010

image background colors

by Johannes.Hofmann＠gmx.de

On Sat, Apr 24, 2010 at 07:43:38PM +0000, corvid wrote: > Johannes wrote: > > On Wed, Apr 21, 2010 at 10:28:46AM +0200, Johannes Hofmann wrote: > > > On Wed, Apr 21, 2010 at 05:01:11AM +0000, corvid wrote: > > > > Is this anywhere near correct? > > > > > > It is definately better than what we have now, but somehow this > > > image background handling is a bit of a hack all together. > > > Basically the Image Widget should get the background color via > > > Widget::getBgColor() at drawing time. > > > That would avoid any special handling in html.cc and would allow to > > > modify the background color by setting a different style. > > > However I can't see any easy way to achive this atm. > > > > It seems that dw/imgbuf.hh supports RGBA images already. We > > probabely want to use them instead of just RGB with merged in > > background color. Otherwise we will have problems as in the > > following example (due to the shared image buffer): > > I played with this some time ago > http://lists.auriga.wearlab.de/pipermail/dillo-dev/2008-May/004265.html > and had some difficulties. > > I'll have to see whether I still have that code around somewhere... That would be cool. I'd really like to remove the image background handling from src/* and use RGBA image buffers instead.

April 24, 2010

image background colors

by corvid＠lavabit.com

Johannes wrote: > On Wed, Apr 21, 2010 at 10:28:46AM +0200, Johannes Hofmann wrote: > > On Wed, Apr 21, 2010 at 05:01:11AM +0000, corvid wrote: > > > Is this anywhere near correct? > > > > It is definately better than what we have now, but somehow this > > image background handling is a bit of a hack all together. > > Basically the Image Widget should get the background color via > > Widget::getBgColor() at drawing time. > > That would avoid any special handling in html.cc and would allow to > > modify the background color by setting a different style. > > However I can't see any easy way to achive this atm. > > It seems that dw/imgbuf.hh supports RGBA images already. We > probabely want to use them instead of just RGB with merged in > background color. Otherwise we will have problems as in the > following example (due to the shared image buffer): I played with this some time ago http://lists.auriga.wearlab.de/pipermail/dillo-dev/2008-May/004265.html and had some difficulties. I'll have to see whether I still have that code around somewhere...

April 24, 2010