- Dillo-dev - lists.mailman3.com

[patch] make partial redraw requests work

by sgeerken＠dillo.org

Hi Johannes, I'm glad that someone is dealing with this problem. I'll write more about it, here just some first remarks, after only taking a glance at this and other patches. On Fri, Nov 09, Johannes Hofmann wrote: > Hi, > > this patch adds set(), isEmpty(), and merge() methods to > core::Rectangle. > These methods are then used to maintain a rectangle that contains > all screen areas for which a redraw was requested. > When fltk really draws to the screen, the drawing is limited to this > area. > The most obvious improvement is visible on pages with very large > images that take some time to load. While the image is loaded the > rest of the page is no longer flickering - at least if there is no > other stuff that requests complete redraws. You may take a look at the old implementation (gtk-based, somewhere in dw_viewport.c), combining the areas of different redraw requests is already implemented there. Perhaps it is better to adopt the old code, which has been working for a while. Some notes on the general problem. There are several cases when areas are to be redrawn, I hope this list is complete: 1. to react on expose events, 2. if a widget redraws itself, and 3. when scrolling. Regarding the problem, how to restrict drawing to a minimum, case 1 is probably neglectable, since the number of expose events is mostly rather small (only when moving windows, changing there order etc.). It seems that the following code: > + ::fltk::Rectangle rect (x(), y(), w(), h()); > + if (d == DAMAGE_VALUE) { may be used to distinguish it from the critical cases 2 and 3. For case 1, still the whole viewport is drawn, optimization should be secondary. Sebastian

Nov. 18, 2007

Re: patch: copy image/link location

by jcid＠dillo.org

On Sun, Nov 18, 2007 at 06:46:51PM +0000, place wrote: > patch: copy image/link location Committed. -- Cheers Jorge.-

Nov. 18, 2007

Re: fullscreen/maximize question

by Johannes.Hofmann＠gmx.de

On Sun, Nov 18, 2007 at 02:11:27PM -0300, Jorge Arellano Cid wrote: > Hi there, > > Here's a funny thing that I'd like to make some tests on. > In ui.cc:888 if you: > > - #if 0 > + #if 1 > > for me, there's the following problem: > > > > If I start dillo as a small window, then hide the panel (using the old > > > ctrl-find binding), then maximize the window, then unhide the panel with > > > the same trick, I get a control panel slightly higher than what I started > > > with. > > this happens to me with GNU/Linux and fltk2-r5975. > > but... > > > On Sun, Nov 18, 2007 at 01:26:09PM +0000, place wrote: > > > What FLTK2 version are you using? > > > > fltk-2.0.x-r5941 > > > > > > > > If I undertood right, this doesn't happen to you. > > > > right. > > > Does it happen to anyone else? Yes, I'm seeing this too. Did not know about this old ctrl-find binding until now. Nice, I really like the fullscreen mode. Johannes > > -- > Cheers > Jorge.- > > _______________________________________________ > Dillo-dev mailing list > Dillo-dev(a)dillo.org > http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev

Nov. 18, 2007

on copy and paste

by place＠gobigwest.com

Sebastian wrote: > Well, a clean solution is rather simple: this is exactly, what > dw::core::Platform is for. A patch is attached below (also > in CVS). Oh, the solution was right under my nose all along and I didn't notice it... I should stop fixing things myself and just make requests on the list :)

Nov. 18, 2007

[PATCH] improved image load button graphics

by place＠gobigwest.com

Jeremy wrote: > I thought that the graphics for the image load toggle button looked > rather scrappy, so I have made some new ones that I think are a little > smarter. Good, I was hoping that somebody would fix the ugly thing that I drew :)

Nov. 18, 2007

on copy and paste

by sgeerken＠dillo.org

To start with a simple one ... On Sun, Nov 18, place wrote: > The bottom of dw/selection.cc goes: > > /** \todo Actual Selection is platform dependant. */ > > printf ("Selected text:\n"); > printf ("--------------------------------------------------\n"); > printf (strbuf.getChars ()); > printf ("\n--------------------------------------------------\n"); > > > Now, suppose we violate the principles of dw, sticking > #include <fltk/events.h> > in the top of the file, and put > const char *buf = strbuf.getChars(); > fltk::copy(buf, strlen(buf), false); > in place of the above printf()s. Works. > > So if anyone knows the structure of dw well enough to know > how to go about making a proper little platform-independent > interface, there's nothing difficult here in principle.. Well, a clean solution is rather simple: this is exactly, what dw::core::Platform is for. A patch is attached below (also in CVS). Sebastian ---------- Index: dw/fltkplatform.cc =================================================================== RCS file: /sfhome/cvs/dillo/dw2/dw/fltkplatform.cc,v retrieving revision 1.2 diff -u -r1.2 fltkplatform.cc --- dw/fltkplatform.cc 17 Nov 2007 16:15:13 -0000 1.2 +++ dw/fltkplatform.cc 18 Nov 2007 17:16:51 -0000 @@ -24,6 +24,7 @@ #include <fltk/draw.h> #include <fltk/run.h> +#include <fltk/events.h> #include <stdio.h> namespace dw { @@ -379,6 +380,10 @@ return new FltkColor(color, core::style::Color::TYPE_SHADED); } +void FltkPlatform::copySelection(const char *text) +{ + fltk::copy(text, strlen(text), false); +} core::Imgbuf *FltkPlatform::createImgbuf (core::Imgbuf::Type type, int width, int height) Index: dw/fltkplatform.hh =================================================================== RCS file: /sfhome/cvs/dillo/dw2/dw/fltkplatform.hh,v retrieving revision 1.2 diff -u -r1.2 fltkplatform.hh --- dw/fltkplatform.hh 17 Nov 2007 16:15:13 -0000 1.2 +++ dw/fltkplatform.hh 18 Nov 2007 17:16:52 -0000 @@ -157,6 +157,8 @@ core::Imgbuf *createImgbuf (core::Imgbuf::Type type, int width, int height); + void copySelection(const char *text); + core::ui::ResourceFactory *getResourceFactory (); void attachResource (ui::FltkResource *resource); Index: dw/layout.cc =================================================================== RCS file: /sfhome/cvs/dillo/dw2/dw/layout.cc,v retrieving revision 1.4 diff -u -r1.4 layout.cc --- dw/layout.cc 13 Nov 2007 13:57:32 -0000 1.4 +++ dw/layout.cc 18 Nov 2007 17:16:52 -0000 @@ -101,6 +101,8 @@ DBG_OBJ_ASSOC (&selection, this); platform->setLayout (this); + + selectionState.setLayout(this); } Layout::~Layout () Index: dw/layout.hh =================================================================== RCS file: /sfhome/cvs/dillo/dw2/dw/layout.hh,v retrieving revision 1.2 diff -u -r1.2 layout.hh --- dw/layout.hh 19 Oct 2007 22:10:13 -0000 1.2 +++ dw/layout.hh 18 Nov 2007 17:16:52 -0000 @@ -223,6 +223,11 @@ return platform->createImgbuf (type, width, height); } + inline void copySelection(const char *text) + { + platform->copySelection(text); + } + inline ui::ResourceFactory *getResourceFactory () { return platform->getResourceFactory (); Index: dw/platform.hh =================================================================== RCS file: /sfhome/cvs/dillo/dw2/dw/platform.hh,v retrieving revision 1.1.1.1 diff -u -r1.1.1.1 platform.hh --- dw/platform.hh 6 Oct 2007 22:03:01 -0000 1.1.1.1 +++ dw/platform.hh 18 Nov 2007 17:16:52 -0000 @@ -188,6 +188,11 @@ virtual Imgbuf *createImgbuf (Imgbuf::Type type, int width, int height) = 0; /** + * \brief Copy selected text (0-terminated). + */ + virtual void copySelection(const char *text) = 0; + + /** * ... */ virtual ui::ResourceFactory *getResourceFactory () = 0; Index: dw/selection.cc =================================================================== RCS file: /sfhome/cvs/dillo/dw2/dw/selection.cc,v retrieving revision 1.3 diff -u -r1.3 selection.cc --- dw/selection.cc 1 Nov 2007 15:00:04 -0000 1.3 +++ dw/selection.cc 18 Nov 2007 17:16:52 -0000 @@ -44,6 +44,8 @@ SelectionState::SelectionState () { + layout = NULL; + selectionState = NONE; from = NULL; to = NULL; @@ -493,12 +495,7 @@ delete i; } - /** \todo Actual Selection is platform dependant. */ - - printf ("Selected text:\n"); - printf ("--------------------------------------------------\n"); - printf (strbuf.getChars ()); - printf ("\n--------------------------------------------------\n"); + layout->copySelection(strbuf.getChars()); } } Index: dw/selection.hh =================================================================== RCS file: /sfhome/cvs/dillo/dw2/dw/selection.hh,v retrieving revision 1.1.1.1 diff -u -r1.1.1.1 selection.hh --- dw/selection.hh 6 Oct 2007 22:03:01 -0000 1.1.1.1 +++ dw/selection.hh 18 Nov 2007 17:16:52 -0000 @@ -209,6 +209,8 @@ DoubleClickEmitter doubleClickEmitter; + Layout *layout; + // selection enum { NONE, @@ -248,6 +250,7 @@ SelectionState (); ~SelectionState (); + inline void setLayout (Layout *layout) { this->layout = layout; } void reset (); inline void connectDoubleClick (DoubleClickReceiver *receiver) { doubleClickEmitter.connectDoubleClick (receiver); }

Nov. 18, 2007

[PATCH] improved image load button graphics

by onepoint＠starurchin.org

I thought that the graphics for the image load toggle button looked rather scrappy, so I have made some new ones that I think are a little smarter. You can compare them at http://starurchin.org/dillo/img_load.html . The patch is appended here. Regards, Jeremy Henty Only in dillo2-cur/: Makefile Only in dillo2-cur/: Makefile.in Only in dillo2-cur/: aclocal.m4 Only in dillo2-cur/: autom4te.cache Only in dillo2-cur/: config.guess Only in dillo2-cur/: config.h Only in dillo2-cur/: config.log Only in dillo2-cur/: config.status Only in dillo2-cur/: config.sub Only in dillo2-cur/: configure Only in dillo2-cur/: d_size.h Only in dillo2-cur/: depcomp Only in dillo2-cur/dlib: .deps Only in dillo2-cur/dlib: Makefile Only in dillo2-cur/dlib: Makefile.in Only in dillo2-cur/doc: Makefile Only in dillo2-cur/doc: Makefile.in Only in dillo2-cur/dpi: .deps Only in dillo2-cur/dpi: Makefile Only in dillo2-cur/dpi: Makefile.in Only in dillo2-cur/dpid: .deps Only in dillo2-cur/dpid: Makefile Only in dillo2-cur/dpid: Makefile.in Only in dillo2-cur/dpip: .deps Only in dillo2-cur/dpip: Makefile Only in dillo2-cur/dpip: Makefile.in Only in dillo2-cur/: install-sh Only in dillo2-cur/: missing Only in dillo2-cur/src: .deps Only in dillo2-cur/src/IO: .deps Only in dillo2-cur/src/IO: Makefile Only in dillo2-cur/src/IO: Makefile.in Only in dillo2-cur/src: Makefile Only in dillo2-cur/src: Makefile.in diff -pru -- dillo2-ref/src/pixmaps.h dillo2-cur/src/pixmaps.h --- dillo2-ref/src/pixmaps.h 2007-11-03 09:30:39.000000000 +0000 +++ dillo2-cur/src/pixmaps.h 2007-11-18 14:49:51.000000000 +0000 @@ -1497,44 +1497,44 @@ static char * mini_ok_xpm[] = { /* XPM */ static char * imgload_on_xpm[] = { "15 15 2 1", -" c #00000000CF3C", -". c #FFFFFFFFFFFF", -" . . .........", -" . ... ..", -" . . ... ....", -" . ... .. .....", -" ..... . .. .", -"......... .. .", -".......... .", -"...............", -". ...........", -". . . .. ....", -". .. . ....", -". .. . . .....", -". . . .....", -"...............", -"..............."}; +" c #FFFFFFFFFFFF", +". c #00000000CF3C", +" ", +" ... . . .. ", +" . .. .. . . ", +" . . . . . ", +" . . . . . ", +" . . . . . ", +" ... . . .. ", +" ", +" .. . . ", +" . . .. . ", +" . . . . . ", +" . . . .. ", +" . . . . ", +" .. . . ", +" "}; /* XPM */ static char * imgload_off_xpm[] = { "15 15 2 1", -" c #CF3C00000000", -". c #FFFFFFFFFFFF", -" .. . .........", -" . .. ...", -" . . ......", -" . . . . .. ..", -" . ... .. ..", -" ........ ..", -"...............", -"...............", -"...............", -" .. . ....", -" . .. ..", -" . . .... .....", -" . . ...", -" .. ... ...", -".... .... ....."}; +" c #FFFFFFFFFFFF", +". c #CF3C00000000", +" ", +" ... . . .. ", +" . .. .. . . ", +" . . . . . ", +" . . . . . ", +" . . . . . ", +" ... . . .. ", +" ", +" .. ... ... ", +" . . . . ", +" . . ... ... ", +" . . . . ", +" . . . . ", +" .. . . ", +" "}; /* XPM */ static char *left_i_xpm[] = { Only in dillo2-cur/: stamp-h1

Nov. 18, 2007

Re: fullscreen/maximize question

by jcid＠dillo.org

Hi there, Here's a funny thing that I'd like to make some tests on. In ui.cc:888 if you: - #if 0 + #if 1 for me, there's the following problem: > > If I start dillo as a small window, then hide the panel (using the old > > ctrl-find binding), then maximize the window, then unhide the panel with > > the same trick, I get a control panel slightly higher than what I started > > with. this happens to me with GNU/Linux and fltk2-r5975. but... On Sun, Nov 18, 2007 at 01:26:09PM +0000, place wrote: > > What FLTK2 version are you using? > > fltk-2.0.x-r5941 > > > > > If I undertood right, this doesn't happen to you. > > right. Does it happen to anyone else? -- Cheers Jorge.-

Nov. 18, 2007

[PATCH] Ctrl-R reloads

by jcid＠dillo.org

On Sun, Nov 18, 2007 at 08:53:30AM +0000, Jeremy Henty wrote: > > This patch amkes Ctrl-R reload the page. Just like Dillo Classic! Committed. -- Cheers Jorge.-

Nov. 18, 2007

on copy and paste

by place＠gobigwest.com

The bottom of dw/selection.cc goes: /** \todo Actual Selection is platform dependant. */ printf ("Selected text:\n"); printf ("--------------------------------------------------\n"); printf (strbuf.getChars ()); printf ("\n--------------------------------------------------\n"); Now, suppose we violate the principles of dw, sticking #include <fltk/events.h> in the top of the file, and put const char *buf = strbuf.getChars(); fltk::copy(buf, strlen(buf), false); in place of the above printf()s. Works. So if anyone knows the structure of dw well enough to know how to go about making a proper little platform-independent interface, there's nothing difficult here in principle...

Nov. 18, 2007