- Dillo-dev - lists.mailman3.com

patch: color shading

by place＠gobigwest.com

Jorge wrote: > BTW, would you mind looking at this case? > > <table border=90> > <tr> <td>1 2 3 4 > <td>5 6 7 8 9 10 > <td>A > <tr> <td colspan="2" bgcolor=teal>cs=2 > <td>B > </table> > > It may use a bevel like firefox. I'll at least take a look. The code for drawing borders seems a bit opaque at first glance, but it might not be too bad... > Have you kept on working on the code to support charset decoding when > specified in the HEAD section? No.

Jan. 2, 2008

[patch] segfault when closing window while it is loading

by jcid＠dillo.org

On Wed, Jan 02, 2008 at 06:53:20PM +0100, Johannes Hofmann wrote: > > It looks OK, but I can't make mine crash... > > Do you have an example URL? > > Here it crashes with any remote URL, that takes long enough to load > so I can close the child window while it is still loading. > I'm using BSD, perhaps it does not happen on Linux? Committed! (Finally it segfaulted for me with: http://chlamydia.fs.ei.tum.de/pub/DragonFly/packages/stable/DragonFly-1.10.… ) -- Cheers Jorge.-

Jan. 2, 2008

[patch] segfault when closing window while it is loading

by Johannes.Hofmann＠gmx.de

On Wed, Jan 02, 2008 at 12:25:08PM -0300, Jorge Arellano Cid wrote: > On Tue, Jan 01, 2008 at 12:44:55PM +0100, Johannes Hofmann wrote: > > Happy new year! > > 8-) > > > Below is a small patch to fix a crash that happens when I open > > a new window (e.g. with the middle mouse button) and close it > > immediately while it is still loading the page. > > > > Johannes > > > > --- a/src/uicmd.cc Mon Dec 31 22:49:02 2007 +0100 > > +++ b/src/uicmd.cc Tue Jan 01 12:38:14 2008 +0100 > > @@ -125,6 +125,7 @@ void a_UIcmd_close_bw(void *vbw) > > Layout *layout = (Layout*)bw->render_layout; > > > > MSG("a_UIcmd_close_bw\n"); > > + a_Bw_stop_clients(bw, BW_Root + BW_Img + Bw_Force); > > ui->destroy(); > > delete(layout); > > a_Bw_free(bw); > > It looks OK, but I can't make mine crash... > Do you have an example URL? Here it crashes with any remote URL, that takes long enough to load so I can close the child window while it is still loading. I'm using BSD, perhaps it does not happen on Linux? Cheers, Johannes > > -- > Cheers > Jorge.- > > _______________________________________________ > Dillo-dev mailing list > Dillo-dev(a)dillo.org > http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev

Jan. 2, 2008

[patch] segfault when closing window while it is loading

by place＠gobigwest.com

Jorge wrote: > On Tue, Jan 01, 2008 at 12:44:55PM +0100, Johannes Hofmann wrote: > > Below is a small patch to fix a crash that happens when I open > > a new window (e.g. with the middle mouse button) and close it > > immediately while it is still loading the page. > It looks OK, but I can't make mine crash... > Do you have an example URL? I used to get this with any http url, but the patch fixes it for them. With file urls, there's something else that still breaks when the layout is being deleted. The interesting part of the backtrace for that goes: #4 0x40345f00 in abort () from /lib/libc.so.6 #5 0x0809928c in misc::assertNotReached () at misc.hh:67 #6 0x080a87cd in object::Object::equals (this=0x8356b00, other=0x8356b00) at object.cc:49 #7 0x080a526a in container::untyped::List::remove0 (this=0x827a678, element=0x8356b00, compare=true, doNotDeleteAtAll=false) at container.cc:254 #8 0x08084b7b in container::untyped::List::remove (this=0x827a678, element=0x8356b00) at ../lout/container.hh:169 #9 0x08084b9f in container::typed::List<dw::fltk::FltkPlatform::IdleFunc>::remove (this=0x827b260, element=0x8356b00) at ../lout/container.hh:376 #10 0x080823ec in dw::fltk::FltkPlatform::removeIdle (this=0x827ac08, idleId=4) at fltkplatform.cc:303 #11 0x0809af40 in ~Layout (this=0x827b660) at layout.cc:114 #12 0x08054937 in a_UIcmd_close_bw (vbw=0x827b210) at uicmd.cc:129

Jan. 2, 2008

Re: Colspan and table percentages

by jcid＠dillo.org

Hi, On Mon, Dec 24, 2007 at 06:56:26AM +0000, place wrote: > I've noticed that sometimes people will make a table with two columns > for the purpose of indenting their text, specifying only the > width of the first column as some percentage. > > When they do this, dillo squishes everything to the right. > > Tiny example: > > <html><head><title></title></head><body> > <table width=500 border=3> > <tr> > <td width="50%">Is explicitly 50%</td> > <td>should be 50%</td> > </tr> > </table> > </body></html> This has uncovered a whole family of bugs! After experimenting with new algorithms and a different way to compute tables, it works in most of my tests. Making it work in all of them may need major changes also. This is a very complex area so I'm taking my time to try to fix it. -- Cheers Jorge.-

Jan. 2, 2008

[patch] segfault when closing window while it is loading

by jcid＠dillo.org

On Tue, Jan 01, 2008 at 12:44:55PM +0100, Johannes Hofmann wrote: > Happy new year! 8-) > Below is a small patch to fix a crash that happens when I open > a new window (e.g. with the middle mouse button) and close it > immediately while it is still loading the page. > > Johannes > > --- a/src/uicmd.cc Mon Dec 31 22:49:02 2007 +0100 > +++ b/src/uicmd.cc Tue Jan 01 12:38:14 2008 +0100 > @@ -125,6 +125,7 @@ void a_UIcmd_close_bw(void *vbw) > Layout *layout = (Layout*)bw->render_layout; > > MSG("a_UIcmd_close_bw\n"); > + a_Bw_stop_clients(bw, BW_Root + BW_Img + Bw_Force); > ui->destroy(); > delete(layout); > a_Bw_free(bw); It looks OK, but I can't make mine crash... Do you have an example URL? -- Cheers Jorge.-

Jan. 2, 2008

hook up the limit_text_width pref

by jcid＠dillo.org

On Tue, Jan 01, 2008 at 02:41:48AM +0000, place wrote: > I'm not sure under what circumstances this pref. actually changes anything, > but here it is anyway. Committed. > (I didn't notice a difference when I enabled it in my old dillo either...) I'm also not sure of the internal state of this feature... -- Cheers Jorge.-

Jan. 2, 2008

patch: start_page and fullwindow_start prefs

by jcid＠dillo.org

Committed. -- Cheers Jorge.-

Jan. 2, 2008

patch: the position part of the geometry pref.

by jcid＠dillo.org

On Wed, Jan 02, 2008 at 02:55:14AM +0000, place wrote: > (That is, the X and Y of "geometry=WxH+X+Y") > > It appears that fltk just _guesses_ what the border size might be > rather than actually determining the value. > > So when I run this with no window mgr, it puts the window where it would be > if there were a 4-pixel-wide border and 21-pixel-high title bar. > Same with twm, which is suboptimal because twm doesn't use those dimensions. > As for fvwm2, which is the one I actually use -- and does appear to > have those dimensions -- somehow the window ends up eight pixels too far down. > But I'm regarding this as Not My Problem. Committed. -- Cheers Jorge.-

Jan. 2, 2008

[PATCH] image load graphics improvements

by jcid＠dillo.org

On Tue, Jan 01, 2008 at 05:08:38PM +0000, Jeremy Henty wrote: > > This patch tweaks the image load graphics: the spacing is nicer and > the 'G' in "IMG" is more legible. You can preview the changes at > http://starurchin.org/dillo/image_load/ . Committed. -- Cheers Jorge.-

Jan. 2, 2008