- Dillo-dev - lists.mailman3.com

[experimental patch] excessive redraws (again)

by jcid＠dillo.org

Hi Johannes, On Fri, Feb 01, 2008 at 07:11:31PM +0100, Johannes Hofmann wrote: > Hello, > > let's get more agressive regarding these excessive redraws :-) > > Below are two patches. The first one adds a own run method to > FltkPlatform. It is pretty similar to what fltk delivers, but this > way we can tweak it as we like. Especially when to call our idle > functions. I'm experimenting with another approach because AFAIU throttling FLTK idle functions not only affects drawing code. So far I have very good results. Stay tuned... > The other patch changes resizeIdle() a bit. As stated in the > comments, resizeIdle() can queue a new resizeIdle(). So instead of > drawing the preliminary layout, then change it and redraw again, we > now wait until the layout is settled and then draw it. Committed. -- Cheers Jorge.-

Feb. 3, 2008

patch: Re: [Dillo-dev] an experiment in widget coloring (with code)

by Johannes.Hofmann＠gmx.de

Hi, the following patch fixes the problem here: diff -r 4a9e0384d5ca dw/fltkviewbase.cc --- a/dw/fltkviewbase.cc Sat Feb 02 18:35:17 2008 +0100 +++ b/dw/fltkviewbase.cc Sun Feb 03 17:59:04 2008 +0100 @@ -64,7 +64,12 @@ void FltkViewBase::draw () translateCanvasYToViewY (rect->y), rect->width, rect->height); - viewRect.intersect(view); + viewRect.intersect (view); + + rect->x = translateViewXToCanvasX (viewRect.x ()); + rect->y = translateViewYToCanvasY (viewRect.y ()); + rect->width = viewRect.w (); + rect->height = viewRect.h (); if (!viewRect.empty ()) { push_clip (viewRect); It uses the rectangle that has been intersected with the current view area for expose(). But the real bug seems to be hidden somewhere in the table draw code. Without the patch, expose was called with a very high area (height was 106497!). This seems to cause problems. Perhaps some overflowing values? With the patch (which is a good optimization anyway), the height of the area that is passed to expose is limited by the current view size. Regards, Johannes On Sat, Feb 02, 2008 at 05:37:51PM -0300, Jorge Arellano Cid wrote: > On Sat, Feb 02, 2008 at 07:59:53PM +0000, place wrote: > > Jorge wrote: > > > BTW, Why when in the bookmarks' modify page, checking a section > > > gives a white mark while checking a URL gives a black one? > > > > > > I prefer the black one. It offers higher contrast. > > > > The > > > > int32_t c = bg->colors[FltkColor::SHADING_NORMAL]; > > int r = (c >> 24) & 0xff, g = (c >> 16) & 0xff, b = (c >> 8) & 0xff; > > bool light = r + g + b > 0x230; > > > > in FltkResource::setWidgetStyle() needs tweaking. > > I see. > > > Let's see... On my display, a test something like > > bool light = (r + g >= 0x150) || (r + g + b >= 0x180) > > might be about right. That's probably not the most > > mathematically concise way to describe that, but anyway... > > > > /* I'm too rusty at scripting languages, so: */ > > > > #include <stdio.h> > > int main(int argc, char **argv) { > > int red, green, blue; > > printf("<table>\n\n"); > > for (red = 0; red < 0x100; red += 0x10) { > > for (green = 0; green < 0x100; green += 0x10) { > > for (blue = 0; blue < 0x100; blue += 0x10) { > > printf("<tr bgcolor=#%02x%02x%02x> <td>\n", red, green, blue); > > printf("<form>\n"); > > printf("<input type=\"text\" value=\"%02x%02x%02x 0x%x\">\n", > > red,green,blue, red+green+blue); > > printf("</form>\n"); > > } > > } > > } > > printf("</table>\n"); > > return 0; > > } > > Funny how with that page I get serious problems with redrawing > widgets. If I load the page and left click the non-widget area, > the widgets dissapear under the bgcolor. If I click on the widgets, > partial redraws are got. > > I'm not yet testing with the latest drawing patch. > > Johannes: would you mind checking this? > > > -- > Cheers > Jorge.- > > _______________________________________________ > Dillo-dev mailing list > Dillo-dev(a)dillo.org > http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev

Feb. 3, 2008

a_Dialog_text_window() dimensions

by jcid＠dillo.org

On Sat, Feb 02, 2008 at 10:33:17PM +0000, place wrote: > (speaking of my ancient computer... > [it keeps not dying, so I keep not buying a new one]) > > a_Dialog_text_window() dimensions were recently increased to > int wh = 600, ww = 650, bh = 30; > > but my display is small enough that this puts the > close button below the bottom of the screen. > > Perhaps it should be limited by screen dimensions. > Or something based on prefs.height and prefs.width... You're right. Hardcoded numbers getting out of the screen are bad. I left it using prefs.height and prefs.width until someone has a better idea. -- Cheers Jorge.-

Feb. 3, 2008

a_Dialog_text_window() dimensions

by place＠gobigwest.com

(speaking of my ancient computer... [it keeps not dying, so I keep not buying a new one]) a_Dialog_text_window() dimensions were recently increased to int wh = 600, ww = 650, bh = 30; but my display is small enough that this puts the close button below the bottom of the screen. Perhaps it should be limited by screen dimensions. Or something based on prefs.height and prefs.width...

Feb. 2, 2008

[patch] fix size of select widgets

by jcid＠dillo.org

On Sat, Feb 02, 2008 at 07:27:20PM +0100, Johannes Hofmann wrote: > Here is a small patch to compute the size of select widgets similar > to the way it is computed for text input widgets. > The width is hardcoded to 10 * size of 'M' in the current font. I committed a different version that measures the string length (as dillo1 and FF). You can test with: http://www.dillo.org/bugtrack/Dinsert.html (adding a long string to a local copy is useful). I doubt that's the right way to do it, but at least it works. Please consider it experimental and give it a look. -- Cheers Jorge.-

Feb. 2, 2008

patch: Re: [Dillo-dev] an experiment in widget coloring (with code)

by place＠gobigwest.com

Johannes wrote: > BTW: have you tried opening that page in dillo1 - it takes ages :-) Wow... Measuring by clock time: dillo-fltk 0:07 /* clear_double_buffer(); */ dillo-fltk 1:03 clear_double_buffer(); dillo-0.8.1 2:20 firefox 2:35 Paging pretty hard the last 30 seconds. I did not dare to use the page after it finished. This does not count the other 22 seconds it takes just to start up for me.

Feb. 2, 2008

patch: Re: [Dillo-dev] an experiment in widget coloring (with code)

by Johannes.Hofmann＠gmx.de

On Sat, Feb 02, 2008 at 05:37:51PM -0300, Jorge Arellano Cid wrote: > > Funny how with that page I get serious problems with redrawing > widgets. If I load the page and left click the non-widget area, > the widgets dissapear under the bgcolor. If I click on the widgets, > partial redraws are got. > > I'm not yet testing with the latest drawing patch. > > Johannes: would you mind checking this? I see this as well. I will take a look at that. Here it even crashes with: Core was generated by `dillo-fltk'. Program terminated with signal 11, Segmentation fault. #0 0x08063df5 in Html_submit_form2 (html=0x28540b00, form=0x29865380, e_input_idx=1) at html.cc:3923 3923 if (DataStr->str[DataStr->len - 1] == '&') (gdb) bt #0 0x08063df5 in Html_submit_form2 (html=0x28540b00, form=0x29865380, e_input_idx=1) at html.cc:3923 #1 0x0808a88c in dw::core::ui::ButtonResource::ClickedEmitter::emitToReceiver (this=0x287ea310, receiver=0x287ee520, signalNo=0, argc=2, argv=0xbfbff32c) at ui.cc:165 #2 0x0808f771 in loutsignal::Emitter::emitVoid (this=0x287ea310, signalNo=0, argc=2, argv=0xbfbff32c) at signal.cc:81 #3 0x0808af58 in dw::core::ui::ButtonResource::ClickedEmitter::emitClicked (this=0x287ea310, resource=0x287ea300, buttonNo=1) at ui.cc:175 #4 0x0807d79a in dw::core::ui::ButtonResource::emitClicked (this=0x287ea300, buttonNo=1) at ui.hh:348 #5 0x08052c34 in fltk::Widget::do_callback (this=0x287ea340) at /home/hofmann/include/fltk/Widget.h:125 #6 0x08097e6c in fltk::Button::handle (this=0x287ea340, event=2, rectangle=@0xbfbff3e4) at Button.cxx:121 #7 0x080980d4 in fltk::Button::handle (this=0x287ea340, event=2) at Button.cxx:77 #8 0x080e6c2a in fltk::Widget::send (this=0x287ea340, event=2) at Widget.cxx:805 #9 0x080c44a6 in fltk::handle (event=2, window=0x28541000) at run.cxx:1258 #10 0x080caa68 in fltk::handle () at x11/run.cxx:1947 #11 0x080caaac in do_queued_events () at x11/run.cxx:396 #12 0x080cadc6 in fl_wait (time_to_wait=1.00000002e+20) at x11/run.cxx:456 #13 0x080cae61 in fltk::wait (time_to_wait=1.00000002e+20) at run.cxx:457 #14 0x080caf78 in fltk::run () at run.cxx:393 #15 0x0804eaf1 in main (argc=4096, argv=0xbfbff94c) at dillo.cc:106 (gdb) p DataStr->len $1 = 0 (gdb) Johannes BTW: have you tried opening that page in dillo1 - it takes ages :-) > > > -- > Cheers > Jorge.- > > _______________________________________________ > Dillo-dev mailing list > Dillo-dev(a)dillo.org > http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev

Feb. 2, 2008

patch: Re: [Dillo-dev] an experiment in widget coloring (with code)

by jcid＠dillo.org

On Sat, Feb 02, 2008 at 07:59:53PM +0000, place wrote: > Jorge wrote: > > BTW, Why when in the bookmarks' modify page, checking a section > > gives a white mark while checking a URL gives a black one? > > > > I prefer the black one. It offers higher contrast. > > The > > int32_t c = bg->colors[FltkColor::SHADING_NORMAL]; > int r = (c >> 24) & 0xff, g = (c >> 16) & 0xff, b = (c >> 8) & 0xff; > bool light = r + g + b > 0x230; > > in FltkResource::setWidgetStyle() needs tweaking. I see. > Let's see... On my display, a test something like > bool light = (r + g >= 0x150) || (r + g + b >= 0x180) > might be about right. That's probably not the most > mathematically concise way to describe that, but anyway... > > /* I'm too rusty at scripting languages, so: */ > > #include <stdio.h> > int main(int argc, char **argv) { > int red, green, blue; > printf("<table>\n\n"); > for (red = 0; red < 0x100; red += 0x10) { > for (green = 0; green < 0x100; green += 0x10) { > for (blue = 0; blue < 0x100; blue += 0x10) { > printf("<tr bgcolor=#%02x%02x%02x> <td>\n", red, green, blue); > printf("<form>\n"); > printf("<input type=\"text\" value=\"%02x%02x%02x 0x%x\">\n", > red,green,blue, red+green+blue); > printf("</form>\n"); > } > } > } > printf("</table>\n"); > return 0; > } Funny how with that page I get serious problems with redrawing widgets. If I load the page and left click the non-widget area, the widgets dissapear under the bgcolor. If I click on the widgets, partial redraws are got. I'm not yet testing with the latest drawing patch. Johannes: would you mind checking this? -- Cheers Jorge.-

Feb. 2, 2008

patch: Re: [Dillo-dev] an experiment in widget coloring (with code)

by place＠gobigwest.com

Jorge wrote: > BTW, Why when in the bookmarks' modify page, checking a section > gives a white mark while checking a URL gives a black one? > > I prefer the black one. It offers higher contrast. The int32_t c = bg->colors[FltkColor::SHADING_NORMAL]; int r = (c >> 24) & 0xff, g = (c >> 16) & 0xff, b = (c >> 8) & 0xff; bool light = r + g + b > 0x230; in FltkResource::setWidgetStyle() needs tweaking. Let's see... On my display, a test something like bool light = (r + g >= 0x150) || (r + g + b >= 0x180) might be about right. That's probably not the most mathematically concise way to describe that, but anyway... /* I'm too rusty at scripting languages, so: */ #include <stdio.h> int main(int argc, char **argv) { int red, green, blue; printf("<table>\n\n"); for (red = 0; red < 0x100; red += 0x10) { for (green = 0; green < 0x100; green += 0x10) { for (blue = 0; blue < 0x100; blue += 0x10) { printf("<tr bgcolor=#%02x%02x%02x> <td>\n", red, green, blue); printf("<form>\n"); printf("<input type=\"text\" value=\"%02x%02x%02x 0x%x\">\n", red,green,blue, red+green+blue); printf("</form>\n"); } } } printf("</table>\n"); return 0; }

Feb. 2, 2008

[patch] fix size of select widgets

by jcid＠dillo.org

On Sat, Feb 02, 2008 at 07:27:20PM +0100, Johannes Hofmann wrote: > Here is a small patch to compute the size of select widgets similar > to the way it is computed for text input widgets. > The width is hardcoded to 10 * size of 'M' in the current font. OK. It'd be good to use the length of the longest string (as dillo1 and FF). -- Cheers Jorge.-

Feb. 2, 2008