- Dillo-dev - lists.mailman3.com

From the BLFS project: [theoldfellow@gmail.com: Dillo - going, going....]

by onepoint＠starurchin.org

The Beyond Linux From Scratch project is removing Dillo Classic because they don't want to list unsupported GTK1 applications (in fact they are looking to ditch GTK1 completely). They seem pretty keen on Dillo-FLTK though! Jeremy Henty ----- Forwarded message from TheOldFellow <theoldfellow(a)gmail.com> ----- From: TheOldFellow <theoldfellow(a)gmail.com> To: blfs-dev(a)linuxfromscratch.org Subject: Dillo - going, going.... Date: Mon, 31 Mar 2008 11:14:42 +0100 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.1.1 Well no one screamed that it was their favourite web browser, so I'll comment it out of the book later today. As an aside, I built Dillo2, still very alpha, with FLTK2, in Beta. The result is quite good. Lightning fast, and some nice features as a browser to build first and read BLFS with while you build the GTK2 and Firefox ziggurat. I'll put a wiki page together for it later too. R. -- http://linuxfromscratch.org/mailman/listinfo/blfs-dev FAQ: http://www.linuxfromscratch.org/blfs/faq.html Unsubscribe: See the above information page ----- End forwarded message -----

March 31, 2008

[patch] scroll cleanup

by jcid＠dillo.org

On Sun, Mar 30, 2008 at 09:24:20PM +0000, place wrote: > Johannes wrote: > > I hope I have not reintroduced the widget scrolling bug place has > > just fixed. Can you verify this? > > It works! Committed. -- Cheers Jorge.-

March 31, 2008

[patch] scroll cleanup

by place＠gobigwest.com

Johannes wrote: > I hope I have not reintroduced the widget scrolling bug place has > just fixed. Can you verify this? It works!

March 30, 2008

[patch] scroll cleanup

by Johannes.Hofmann＠gmx.de

Hello, as promised here comes my attempt to cleanup the scrolling code a bit. scrollTo () is now the real method and scroll () is just a helper. I think that is more natural than the other way round. I also moved the call to updateCanvasWidgets () out of the draw () method again as I think draw () should not modify things if possible. I hope I have not reintroduced the widget scrolling bug place has just fixed. Can you verify this? Cheers, Johannes

March 30, 2008

Re: patch: Cookies_parse_one()

by jcid＠dillo.org

On Thu, Mar 27, 2008 at 05:27:18PM +0000, place wrote: > I had to turn on cookies to try something, and the very first cookie I > saw threw the dpi into an infinite loop. > "TRK%5FLastLoginID=; expires=Fri, 27-Mar-2009 04:00:00 GMT; path=/" > > Instead of returning immediately on error, it eats its broken cookie up now. > And I added some dFree(attr)s. Good, thanks for the fixes; it's much simpler to debug functions that have a single return point. Committed. > > Oh, and the "catched" in Cookies_parse_string() should be "caught". > Should've put that in the patch, but I forgot. Committed. -- Cheers Jorge.-

March 29, 2008

Re: a_Url_cmp()

by jcid＠dillo.org

On Sat, Mar 29, 2008 at 04:25:42AM +0000, place wrote: > 1. I happened to run into a preexisting bug in a_Url_cmp(). > > I hooked up the dialog code as the others had done for https, and the > first URL I tried was a redirect that goes > http://something -> https://something. The urls are identical except for > the scheme. It broke because a_Url_cmp() has > > (st = URL_STR_FIELD_I_CMP(A->scheme, B->scheme) == 0))) > instead of > (st = URL_STR_FIELD_I_CMP(A->scheme, B->scheme)) == 0)) Committed. > 2. The mail I tried to send some days back from my new account(*) also > happened to be about a_Url_cmp(). When I was playing with file inputs, > I generated the URL file:///something, with file:/something already in > cache. Cache did not find it because the authority of one was NULL and > the authority of the other was "". URL_STR_FIELD_I_CMP thinks those are > different things. Which is possible. Knowing how weird the URL spec gets, > the code might reflect a genuine difference, but sounds more like an error. Yes, current URL handling follows the spec. The problem is that the rest of dillo is using URLs like file:/something freely, when they should be file:///something. It should be easy to switch the file server dpi to generate "file:///"-prefixed URLS, and the input location to also normalize file:/ prefixed ones. But, if they appear in an external html page, it may be better to make the URL code normalize it (or check what other browsers do). > That I should run into these two issues at the very same time that I'm > trying to change a_Url_cmp() for url->data is a strange coincidence. Peer reviewing is always an asset. > > * And it receives list mail just fine. Andreas seemed to think that > as long as I'm subscribed, I shouldn't have any moderation problems. > Strange. Out of my control, anyway. I gave a look at the list settings. Please let me know your new email address to find whether I can do something to enable it. BTW, with the new patch for "missing widgets", when I first went to http://lists.auriga.wearlab.de/cgi-bin/mailman/admin/dillo-dev the Password input widget was missing! (it worked the next tries). -- Cheers Jorge.-

March 29, 2008

patch: widget scrolling

by jcid＠dillo.org

On Fri, Mar 28, 2008 at 08:56:36PM +0000, place wrote: > > > Johannes, are there any unintended consequences to this fix? > > > > Your patch seems correct, but I'd like to cleanup the scrolling code > > a bit more. Anyway, I have no objections to commit this for now. > > Cool. Thanks! Committed. -- Cheers Jorge.-

March 29, 2008

patch: URL data as a Dstr

by jcid＠dillo.org

Hi, On Wed, Mar 26, 2008 at 05:15:49PM +0000, place wrote: > This is part one in a series for file inputs. > Parts two and three are written. Parts four and five > are contemplated. Maybe a part six if I feel like it. > Part three is the one that makes it at least appear to > work, though I'll need help in testing at that point. Committed with some changes: capi.c: made it test using flags for both POST & GET. url.c : made a_Url_set_data's second parameter a Dstr**. url.c, dlib.c: changed Url_dstr_cmp for Dstr_cmp. changed the implementation too. dlib.c: made dStr_sized_new allocate sz+1 bytes (to avoid a realloc). Please check them, because I've done little testing. > HTTPS note: > If https does remain a dpi, somebody will have to decide what they want > to do with Capi_dpi_build_cmd() if http_query can contain NULLs. OK. -- Cheers Jorge.-

March 29, 2008

patch: widget scrolling

by place＠gobigwest.com

> > Johannes, are there any unintended consequences to this fix? > > Your patch seems correct, but I'd like to cleanup the scrolling code > a bit more. Anyway, I have no objections to commit this for now. Cool. Thanks!

March 28, 2008

patch: widget scrolling

by Johannes.Hofmann＠gmx.de

On Fri, Mar 28, 2008 at 05:14:48PM +0000, place wrote: > I've had lots of trouble with widgets disappearing because my > machine is too slow to keep up. But today I had the good fortune > to happen to stumble upon updateCanvasWidgets()... Excellent that you have found this bug. I had seen this problem once using dillo via remote X11 but could not reproduce it at home. > > Johannes, are there any unintended consequences to this fix? > Your patch seems correct, but I'd like to cleanup the scrolling code a bit more. Anyway, I have no objections to commit this for now. Cheers, Johannes > diff -pur dw2/dw/fltkviewport.cc dw2-cur/dw/fltkviewport.cc > --- dw2/dw/fltkviewport.cc 2008-02-29 18:26:27.000000000 +0000 > +++ dw2-cur/dw/fltkviewport.cc 2008-03-28 16:55:57.000000000 +0000 > @@ -186,6 +186,7 @@ void FltkViewport::draw () > > if (d & DAMAGE_SCROLL) { > set_damage (DAMAGE_SCROLL); > + updateCanvasWidgets (scrollDX, scrollDY); > scrollrect(cr, -scrollDX, -scrollDY, draw_area, this); > d &= ~DAMAGE_SCROLL; > set_damage (d); > @@ -377,7 +378,6 @@ void FltkViewport::scroll (int dx, int d > > adjustScrollbarValues (); > redraw (DAMAGE_SCROLL); > - updateCanvasWidgets (oldScrollX, oldScrollY); > theLayout->scrollPosChanged (this, scrollX, scrollY); > } > > @@ -400,16 +400,16 @@ void FltkViewport::setViewportSize (int > vscrollbar->hide (); > } > > -void FltkViewport::updateCanvasWidgets (int oldScrollX, int oldScrollY) > +void FltkViewport::updateCanvasWidgets (int dx, int dy) > { > for(Iterator <TypedPointer < ::fltk::Widget> > it > = canvasWidgets->iterator (); > it.hasNext (); ) { > ::fltk::Widget *widget = it.getNext()->getTypedValue (); > - if (oldScrollX != scrollX) > - widget->x (widget->x () - scrollX + oldScrollX); > - if (oldScrollY != scrollY) > - widget->y (widget->y () - scrollY + oldScrollY); > + if (dx) > + widget->x (widget->x () - dx); > + if (dy) > + widget->y (widget->y () - dy); > } > } > > _______________________________________________ > Dillo-dev mailing list > Dillo-dev(a)dillo.org > http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev

March 28, 2008