- Dillo-dev - lists.mailman3.com

patch: image inputs

by corvid＠lavabit.com

It works on the sites I tried, and the data sent looks right for other cases, but: - To get click position, I used event_x() and event_y() in fltkui.cc because they happened to have the right values in them and I didn't know the proper place to look for this information. - If the image could not be loaded and you click on the alt text, the click position is sent, even though it's not meaningful. - I don't prevent the image from being loaded even when automatic image loading is disabled (but I'm the only person who would notice anyway). (I would have to be able to get button 3 to bring up the image menu.)

April 14, 2008

[patch] make ComplexButton work

by jcid＠dillo.org

On Sun, Apr 13, 2008 at 09:24:35PM +0200, Johannes Hofmann wrote: > Hi, > > this patch fixes ComplexButton - at least it works here now :-) > The patch includes the ComplexButton destructor proposed by place > and enables the ComplexButton code in dw-ui-test. > It requires my last FltkViewBase::draw() patch. OK. Committed both. -- Cheers Jorge.-

April 14, 2008

[patch] cleanup FltkViewBase::draw

by jcid＠dillo.org

On Sun, Apr 13, 2008 at 09:05:35PM +0200, Johannes Hofmann wrote: > Hi, > > here comes a cleanup of FltkViewBase::draw(). It had grown too > complicated... > This patch also fixes two issues with nested views as they will > exist with ComplexButtons. Committed. -- Cheers Jorge.-

April 13, 2008

[patch] make ComplexButton work

by corvid＠lavabit.com

Johannes wrote: > this patch fixes ComplexButton - at least it works here now :-) It's working for me, too! :)

April 13, 2008

[patch] make ComplexButton work

by Johannes.Hofmann＠gmx.de

Hi, this patch fixes ComplexButton - at least it works here now :-) The patch includes the ComplexButton destructor proposed by place and enables the ComplexButton code in dw-ui-test. It requires my last FltkViewBase::draw() patch. Cheers, Johannes

April 13, 2008

[patch] cleanup FltkViewBase::draw

by Johannes.Hofmann＠gmx.de

Hi, here comes a cleanup of FltkViewBase::draw(). It had grown too complicated... This patch also fixes two issues with nested views as they will exist with ComplexButtons. Cheers, Johannes

April 13, 2008

Re: patch: reset input

by jcid＠dillo.org

Hi, Committed -- Cheers Jorge.-

April 13, 2008

Re: patch: ISINDEX

by jcid＠dillo.org

On Sun, Apr 13, 2008 at 02:33:00AM +0000, corvid wrote: > Yeah, so very important... > > An isindex page: http://www.math.ncu.edu.tw/~shann/bcc16/7/html/isindex.cgi > Committed! Mmmm, ISINDEX, an old method that brings me back good memories. -- Cheers Jorge.-

April 13, 2008

Re: patch: file input

by corvid＠lavabit.com

Jorge wrote: > On Fri, Apr 11, 2008 at 09:21:16PM +0000, corvid wrote: > > Jorge wrote: > > > On Thu, Apr 10, 2008 at 04:13:56PM +0000, corvid wrote: > > > > If I read in a file, delete that file, and try to read it in again > > > > (uses E2EReload), the submit will send the (now empty) file because > > > > a_Capi_get_buf() finds the (now empty) entry in cache. > > > > So I'll have to find out where an a_Cache_entry_remove_by_url() should go. > > > > > > Yes. > > > > It looks like I'd have to figure out CCC for this, which would > > likely be more trouble than it's worth. > > OK, I'll allocate some time to give it a look. Cool. Sort of on topic, what do you think of reviving use of the bug tracker for the various little things that are easy to forget about?

April 12, 2008

Re: patch: file input

by jcid＠dillo.org

On Fri, Apr 11, 2008 at 09:21:16PM +0000, corvid wrote: > Jorge wrote: > > On Thu, Apr 10, 2008 at 04:13:56PM +0000, corvid wrote: > > > If I read in a file, delete that file, and try to read it in again > > > (uses E2EReload), the submit will send the (now empty) file because > > > a_Capi_get_buf() finds the (now empty) entry in cache. > > > So I'll have to find out where an a_Cache_entry_remove_by_url() should go. > > > > Yes. > > It looks like I'd have to figure out CCC for this, which would > likely be more trouble than it's worth. OK, I'll allocate some time to give it a look. -- Cheers Jorge.-

April 12, 2008