- Dillo-dev - lists.mailman3.com

Icon for Dillo window

by onepoint＠starurchin.org

On Thu, Sep 25, 2008 at 06:04:07PM +0200, Johannes Hofmann wrote: > Maybe you know that already, but the fltk2 method from the > test/image.cxx example also sets the _NET_WM_ICON hint: No, I missed that. Thanks for pointing it out! It seems that window.icon() sets the hint. I don't know what to do if you wanted to set _NET_WM_ICON to a list of icons (of different sizes) rather than just one. But maybe that's not necessary: test/image specifies a large icon (64x64) so perhaps it's relying on the desktop to scale it down as necessary. IIRC the freedesktop.org docs say that the window manager MAY do that. BTW, how do fltk::Window::xclass() and fltk::Window::icon() work? All they do is set private variables. Somewhere those variables must be sent to X11 so that something actually happens on the desktop, but I'm darned if I can see where the FLTK code does it. It seems to be happening by voodoo. Are we meddling with forces that humanity was not meant to wield? :-) Regards, Jeremy Henty

Sept. 25, 2008

Icon for Dillo window

by Johannes.Hofmann＠gmx.de

On Thu, Sep 25, 2008 at 06:05:37PM +0100, Jeremy Henty wrote: > > Replying to myself: > > On Thu, Sep 25, 2008 at 04:33:57PM +0100, Jeremy Henty wrote: > > On Thu, Sep 25, 2008 at 04:14:48PM +0200, Johannes Hofmann wrote: > > > On Thu, Sep 25, 2008 at 03:11:55PM +0100, Jeremy Henty wrote: > > > > > > > > If we're concerned about dillo2 playing properly with X11 and > > > > window managers then I'd say that it should set WM_CLASS to > > > > '"Dillo2", "dillo2"' on general principle. > > > > > > Yes that sounds right. > > > > I'll propose a patch later today for comments. > > Heh, it's a one liner. I HAZ DILLLO EICONZ NAOW!!! > Cool! But perhaps it should even be "Dillo" instead of "Dillo2". It's still dillo after all. Cheers, Johannes

Sept. 25, 2008

Icon for Dillo window

by onepoint＠starurchin.org

Replying to myself: On Thu, Sep 25, 2008 at 04:33:57PM +0100, Jeremy Henty wrote: > On Thu, Sep 25, 2008 at 04:14:48PM +0200, Johannes Hofmann wrote: > > On Thu, Sep 25, 2008 at 03:11:55PM +0100, Jeremy Henty wrote: > > > > > > If we're concerned about dillo2 playing properly with X11 and > > > window managers then I'd say that it should set WM_CLASS to > > > '"Dillo2", "dillo2"' on general principle. > > > > Yes that sounds right. > > I'll propose a patch later today for comments. Heh, it's a one liner. I HAZ DILLLO EICONZ NAOW!!! Jeremy Henty

Sept. 25, 2008

Icon for Dillo window

by Johannes.Hofmann＠gmx.de

On Thu, Sep 25, 2008 at 04:33:57PM +0100, Jeremy Henty wrote: > On Thu, Sep 25, 2008 at 04:14:48PM +0200, Johannes Hofmann wrote: > > On Thu, Sep 25, 2008 at 03:11:55PM +0100, Jeremy Henty wrote: > > > > That doesn't work on my system (my window manager is icewm). For > > > me test/image gets the standard X icon in its window frame and in > > > its taskbar box when miminised (icewm doesn't use desktop icons). > > > Does it work with any other window managers? > > > > It worked for me with fvwm. > > OK, then it's worth doing even if it doesn't work everywhere > (especially since the FLTK docs make it clear that nothing will work > everywhere). > > > > If we're concerned about dillo2 playing properly with X11 and > > > window managers then I'd say that it should set WM_CLASS to > > > '"Dillo2", "dillo2"' on general principle. > > > > Yes that sounds right. > > I'll propose a patch later today for comments. > > > > Also, the _NET_WM_ICON hint has the advantage that it can provide > > > a list of icons of different sizes so that window managers can use > > > a larger icon eg. when switching between applications with > > > Alt+Tab. > > > > Hm, no idea what is currently the best way to do this. > > Any X11 specialists here? > > I already have code to set the _NET_WM_ICON hint. It's very > straightforward (I just modified the sample code from one of the bug > reports I linked to earlier). I can verify (using xprop) that the > hint is but I can't check that it will actually affect the icon > (because icewm ignores the hint), and I haven't figured out how to > translate images into the right format. The freedesktop.org > documentation is not completely specific about this. Maybe you know that already, but the fltk2 method from the test/image.cxx example also sets the _NET_WM_ICON hint: from xprop: WM_COMMAND(STRING) = { "./image" } WM_HINTS(WM_HINTS): Client accepts input or input focus: True _NET_WM_ICON(CARDINAL) = 64, 64, 0, 0, 0, 0, 0 ... Regards, Johannes

Sept. 25, 2008

patch: show_msg=NO disable debug messages

by corvid＠lavabit.com

tried turning off show_msg and saw how dillo is still somewhat chatty thanks to DEBUG_MSG. (Or would you prefer a show_debug_messages pref as suggested in dillo2rc? Hmm... thinking about the sentence "Generic messages (mainly for debugging specific parts)", I'd have to say that we use MSG for plenty of debugging messages and DEBUG_MSG for plenty of of-more-general-interest messages.)

Sept. 25, 2008

Icon for Dillo window

by onepoint＠starurchin.org

On Thu, Sep 25, 2008 at 04:14:48PM +0200, Johannes Hofmann wrote: > On Thu, Sep 25, 2008 at 03:11:55PM +0100, Jeremy Henty wrote: > > That doesn't work on my system (my window manager is icewm). For > > me test/image gets the standard X icon in its window frame and in > > its taskbar box when miminised (icewm doesn't use desktop icons). > > Does it work with any other window managers? > > It worked for me with fvwm. OK, then it's worth doing even if it doesn't work everywhere (especially since the FLTK docs make it clear that nothing will work everywhere). > > If we're concerned about dillo2 playing properly with X11 and > > window managers then I'd say that it should set WM_CLASS to > > '"Dillo2", "dillo2"' on general principle. > > Yes that sounds right. I'll propose a patch later today for comments. > > Also, the _NET_WM_ICON hint has the advantage that it can provide > > a list of icons of different sizes so that window managers can use > > a larger icon eg. when switching between applications with > > Alt+Tab. > > Hm, no idea what is currently the best way to do this. > Any X11 specialists here? I already have code to set the _NET_WM_ICON hint. It's very straightforward (I just modified the sample code from one of the bug reports I linked to earlier). I can verify (using xprop) that the hint is but I can't check that it will actually affect the icon (because icewm ignores the hint), and I haven't figured out how to translate images into the right format. The freedesktop.org documentation is not completely specific about this. Regards, Jeremy Henty

Sept. 25, 2008

patch: Re: [Dillo-dev] what's next

by Johannes.Hofmann＠gmx.de

On Thu, Sep 25, 2008 at 03:16:30PM +0000, corvid wrote: > Johannes wrote: > > On Thu, Sep 25, 2008 at 03:24:55AM +0000, corvid wrote: > > > Johannes wrote (way back in June!): > > > > * The cursor is not always updated properly when over a link. This > > > > happens while page is rendered and also when drag-scrolling with > > > > the middle mouse button. > > > > > > How about updating it from layout()? > > > > > > > Yes, I think something like that is necessary. I also worked a bit on > > that problem (see attached patch), but got confused about how > > to handle multiple views. > > The mouse could be over a link in one view and somewhere else in > > another one (with overlapping windows). > > Is the mouse pointer a per view or a per platform thing? > > Oh yeah, multiple views... > Multiple views are hard to think about when we don't know how they're > supposed to behave, can't make them, and don't know whether there's > any real need/use for them. Maybe we should enable that fltkpreview stuff somehow - just to verify that we don't break the multiple view feature. And making a Postscript view for printing could be fun! Cheers, Johannes

Sept. 25, 2008

patch: Re: [Dillo-dev] what's next

by corvid＠lavabit.com

Johannes wrote: > On Thu, Sep 25, 2008 at 03:24:55AM +0000, corvid wrote: > > Johannes wrote (way back in June!): > > > * The cursor is not always updated properly when over a link. This > > > happens while page is rendered and also when drag-scrolling with > > > the middle mouse button. > > > > How about updating it from layout()? > > > > Yes, I think something like that is necessary. I also worked a bit on > that problem (see attached patch), but got confused about how > to handle multiple views. > The mouse could be over a link in one view and somewhere else in > another one (with overlapping windows). > Is the mouse pointer a per view or a per platform thing? Oh yeah, multiple views... Multiple views are hard to think about when we don't know how they're supposed to behave, can't make them, and don't know whether there's any real need/use for them.

Sept. 25, 2008

patch: Re: [Dillo-dev] what's next

by Johannes.Hofmann＠gmx.de

On Thu, Sep 25, 2008 at 03:24:55AM +0000, corvid wrote: > Johannes wrote (way back in June!): > > * The cursor is not always updated properly when over a link. This > > happens while page is rendered and also when drag-scrolling with > > the middle mouse button. > > How about updating it from layout()? > Yes, I think something like that is necessary. I also worked a bit on that problem (see attached patch), but got confused about how to handle multiple views. The mouse could be over a link in one view and somewhere else in another one (with overlapping windows). Is the mouse pointer a per view or a per platform thing? Anyway, attached patch solves the problem with the mouse pointer ending up over a link after loading has finished. Other corner cases do not yet work. Cheers, Johannes

Sept. 25, 2008

Icon for Dillo window

by Johannes.Hofmann＠gmx.de

On Thu, Sep 25, 2008 at 03:11:55PM +0100, Jeremy Henty wrote: > On Thu, Sep 25, 2008 at 12:12:26PM +0200, Johannes Hofmann wrote: > > -------- Original-Nachricht -------- > > > Datum: Thu, 25 Sep 2008 08:03:52 +0100 > > > Von: Jeremy Henty <onepoint(a)starurchin.org> > > > An: dillo-dev(a)dillo.org > > > Betreff: Re: [Dillo-dev] Icon for Dillo window > > > > > On Wed, Sep 24, 2008 at 06:48:17PM -0400, Jorge Arellano Cid wrote: > > > > > > > I was thinking it'd be good to provide an icon for the WM to > > > > use. Does anybody know how to do it with FLTK2? > > > > > > It appears not to be possible. In X Windows you set the > > > _NET_WM_ICON hint > > > > test/image.cxx has from the fltk2 tarball shows how to do it. > > That doesn't work on my system (my window manager is icewm). For me > test/image gets the standard X icon in its window frame and in its > taskbar box when miminised (icewm doesn't use desktop icons). Does it > work with any other window managers? It worked for me with fvwm. > > Icewm sets icons by reading the WM_CLASS hint, interpreting it as the > root of the icon file names and searching for the files in its icon > directories. Unfortunately dillo2 sets WM_CLASS to '"Fltk", "fltk"'. > If it set it to '"Dillo2", "dillo2"' I could configure its icons. > > If we're concerned about dillo2 playing properly with X11 and window > managers then I'd say that it should set WM_CLASS to '"Dillo2", > "dillo2"' on general principle. Yes that sounds right. > > (The weird thing is that my icewm finds the right Firefox icons, yet I > can't find any Firefox icon files in the icon directories. I'm still > trying to figure out where it gets them from.) > > Also, the _NET_WM_ICON hint has the advantage that it can provide a > list of icons of different sizes so that window managers can use a > larger icon eg. when switching between applications with Alt+Tab. Hm, no idea what is currently the best way to do this. Any X11 specialists here? Regards, Johannes

Sept. 25, 2008