- Dillo-dev - lists.mailman3.com

patch: Re: [Dillo-dev] cut off word ends with italic fonts

by corvid＠lavabit.com

Johannes wrote: > somtimes the end of italic words get cut off e.g. in > > <html> > <body> > <i><a href="foo">FUU</a>BAR</i> > </body> > </html> > > when seen with vw_fontname="helvetica". > > This is due to a change in html.cc (I think it was introduced with > rev 1.36). This change sets the backgroundColor for all words which > means that for each word, the bounding box get's drawn before the > actual text. This obviously has a performance impact too. > > I'm not sure how to get back to the original behaviour > (backgroundColor == NULL for normal words) without breaking anything. > Can someone please have a look? This - reverts all of the style->backgroundColor to current_bg_color - sets backgroundColor for fltk widgets because NULL is already taken to mean standard_widget_colors - sets backgroundColor for image inputs and <button>s since they use a new Layout. - changes table_cell_style's backgroundColor at the bottom of Html_tag_open_tr() if the TR specifies one. I don't know why the original code didn't need that. Maybe it was broken. I wasn't feeling too sure about doing this before release, but Johannes says "currently an unnecessary XFillRectangle() command is sent to the X Server for every word" and I haven't had problems running on it so far, so it seems worthy of putting on the list for consideration. PS How do you monitor X to get an idea of what a client might be spending too much time on?

Sept. 25, 2008

patch: Re: [Dillo-dev] what's next

by Johannes.Hofmann＠gmx.de

On Thu, Sep 25, 2008 at 02:11:09PM -0400, Jorge Arellano Cid wrote: > On Thu, Sep 25, 2008 at 04:25:20PM +0200, Johannes Hofmann wrote: > > On Thu, Sep 25, 2008 at 03:24:55AM +0000, corvid wrote: > > > Johannes wrote (way back in June!): > > > > * The cursor is not always updated properly when over a link. This > > > > happens while page is rendered and also when drag-scrolling with > > > > the middle mouse button. > > > > > > How about updating it from layout()? > > > > > > > Yes, I think something like that is necessary. I also worked a bit on > > that problem (see attached patch), but got confused about how > > to handle multiple views. > > Is this patch ready for CVS? > No, it isn't. Cheers, Johannes

Sept. 25, 2008

Icon for Dillo window

by jcid＠dillo.org

On Thu, Sep 25, 2008 at 06:57:48PM +0100, Jeremy Henty wrote: > On Thu, Sep 25, 2008 at 07:04:05PM +0200, Johannes Hofmann wrote: > > On Thu, Sep 25, 2008 at 06:05:37PM +0100, Jeremy Henty wrote: > > > > > > Heh, it's a one liner. I HAZ DILLLO EICONZ NAOW!!! > > > > Cool! But perhaps it should even be "Dillo" instead of "Dillo2". > > It's still dillo after all. > > I thought about that, then I decided that since we now use dillo2rc I > would go with dillo2 for consistency. But it's no big deal, I'd be as > happy with "dillo" as "dillo2" because icewm can map any given value > of WM_CLASS to any icon name. > > Incidentally, we could alternatively call fltk::Window::show() with > argc and argv as arguments (it's overloaded). That would do the > default thing of taking WM_CLASS from argv[0], so we would get > "dillo-fltk". I decided not to because it means passing argc and argv > from main() in dillo.cc to the call to fltk::Window::show() in > uicmd.cc and I wanted the shortest patch that could possibly work. > But maybe there's a case for doing it that way. (Perhaps it's time to > rename the executable to dillo2, or even dillo?) I don't care as long > as we change WM_CLASS from the default of "fltk" to *something* that I > can map to the dillo icons in my icewm configuration. Yes, it's time to change the binary name. I like dillo2 because that way it's possible to have dillo1 and dillo2 installed without trouble. OTOH, dillo2 is still dillo and dillo1 is obsolete. Maybe "dillo" is the best option. What do others think? -- Cheers Jorge.-

Sept. 25, 2008

patch: Re: [Dillo-dev] what's next

by jcid＠dillo.org

On Thu, Sep 25, 2008 at 04:25:20PM +0200, Johannes Hofmann wrote: > On Thu, Sep 25, 2008 at 03:24:55AM +0000, corvid wrote: > > Johannes wrote (way back in June!): > > > * The cursor is not always updated properly when over a link. This > > > happens while page is rendered and also when drag-scrolling with > > > the middle mouse button. > > > > How about updating it from layout()? > > > > Yes, I think something like that is necessary. I also worked a bit on > that problem (see attached patch), but got confused about how > to handle multiple views. Is this patch ready for CVS? > The mouse could be over a link in one view and somewhere else in > another one (with overlapping windows). > Is the mouse pointer a per view or a per platform thing? I don't know. -- Cheers Jorge.-

Sept. 25, 2008

Icon for Dillo window

by jcid＠dillo.org

On Thu, Sep 25, 2008 at 07:04:05PM +0200, Johannes Hofmann wrote: > On Thu, Sep 25, 2008 at 06:05:37PM +0100, Jeremy Henty wrote: > > > > Replying to myself: > > > > On Thu, Sep 25, 2008 at 04:33:57PM +0100, Jeremy Henty wrote: > > > On Thu, Sep 25, 2008 at 04:14:48PM +0200, Johannes Hofmann wrote: > > > > On Thu, Sep 25, 2008 at 03:11:55PM +0100, Jeremy Henty wrote: > > > > > > > > > > If we're concerned about dillo2 playing properly with X11 and > > > > > window managers then I'd say that it should set WM_CLASS to > > > > > '"Dillo2", "dillo2"' on general principle. > > > > > > > > Yes that sounds right. > > > > > > I'll propose a patch later today for comments. > > > > Heh, it's a one liner. I HAZ DILLLO EICONZ NAOW!!! > > > > Cool! But perhaps it should even be "Dillo" instead of "Dillo2". > It's still dillo after all. Yes, it can be "Dillo". BTW, where does the WM get the icon from? -- Cheers Jorge.-

Sept. 25, 2008

patch: show_msg=NO disable debug messages

by jcid＠dillo.org

On Thu, Sep 25, 2008 at 03:53:22PM +0000, corvid wrote: > tried turning off show_msg and saw how dillo is still somewhat > chatty thanks to DEBUG_MSG. > > (Or would you prefer a show_debug_messages pref as suggested in dillo2rc? > Hmm... thinking about the sentence "Generic messages (mainly for debugging > specific parts)", I'd have to say that we use MSG for plenty of debugging > messages and DEBUG_MSG for plenty of of-more-general-interest messages.) > This is a good question that I don't have a solid answer for. In the beginning, we thought of DEBUG_MSG and its levels as a good platform. OTOH, through the years, MSG has proved to be all I need. YMMV. In other words, for me, its OK to get rid of DEBUG_MSG unless somebody else finds good use for it. -- Cheers Jorge.-

Sept. 25, 2008

Icon for Dillo window

by onepoint＠starurchin.org

On Thu, Sep 25, 2008 at 07:04:05PM +0200, Johannes Hofmann wrote: > On Thu, Sep 25, 2008 at 06:05:37PM +0100, Jeremy Henty wrote: > > > > Heh, it's a one liner. I HAZ DILLLO EICONZ NAOW!!! > > Cool! But perhaps it should even be "Dillo" instead of "Dillo2". > It's still dillo after all. I thought about that, then I decided that since we now use dillo2rc I would go with dillo2 for consistency. But it's no big deal, I'd be as happy with "dillo" as "dillo2" because icewm can map any given value of WM_CLASS to any icon name. Incidentally, we could alternatively call fltk::Window::show() with argc and argv as arguments (it's overloaded). That would do the default thing of taking WM_CLASS from argv[0], so we would get "dillo-fltk". I decided not to because it means passing argc and argv from main() in dillo.cc to the call to fltk::Window::show() in uicmd.cc and I wanted the shortest patch that could possibly work. But maybe there's a case for doing it that way. (Perhaps it's time to rename the executable to dillo2, or even dillo?) I don't care as long as we change WM_CLASS from the default of "fltk" to *something* that I can map to the dillo icons in my icewm configuration. Regards, Jeremy Henty

Sept. 25, 2008

patch: Re: [Dillo-dev] what's next

by jcid＠dillo.org

On Thu, Sep 25, 2008 at 05:24:57PM +0200, Johannes Hofmann wrote: > On Thu, Sep 25, 2008 at 03:16:30PM +0000, corvid wrote: > > Johannes wrote: > > > On Thu, Sep 25, 2008 at 03:24:55AM +0000, corvid wrote: > > > > Johannes wrote (way back in June!): > > > > > * The cursor is not always updated properly when over a link. This > > > > > happens while page is rendered and also when drag-scrolling with > > > > > the middle mouse button. > > > > > > > > How about updating it from layout()? > > > > > > > > > > Yes, I think something like that is necessary. I also worked a bit on > > > that problem (see attached patch), but got confused about how > > > to handle multiple views. > > > The mouse could be over a link in one view and somewhere else in > > > another one (with overlapping windows). > > > Is the mouse pointer a per view or a per platform thing? > > > > Oh yeah, multiple views... > > Multiple views are hard to think about when we don't know how they're > > supposed to behave, can't make them, and don't know whether there's > > any real need/use for them. > > Maybe we should enable that fltkpreview stuff somehow - just to > verify that we don't break the multiple view feature. > And making a Postscript view for printing could be fun! That would be amazing! Well, I've read that FLTK2 can use cairo for images, and that text and clipping are the missing link to full cairo output. If we can use this to be able to print, it'd be great. -- Cheers Jorge.-

Sept. 25, 2008

Icon for Dillo window

by Johannes.Hofmann＠gmx.de

On Thu, Sep 25, 2008 at 06:28:38PM +0100, Jeremy Henty wrote: > On Thu, Sep 25, 2008 at 06:04:07PM +0200, Johannes Hofmann wrote: > > > Maybe you know that already, but the fltk2 method from the > > test/image.cxx example also sets the _NET_WM_ICON hint: > > No, I missed that. Thanks for pointing it out! It seems that > window.icon() sets the hint. I don't know what to do if you wanted to > set _NET_WM_ICON to a list of icons (of different sizes) rather than > just one. But maybe that's not necessary: test/image specifies a > large icon (64x64) so perhaps it's relying on the desktop to scale it > down as necessary. IIRC the freedesktop.org docs say that the window > manager MAY do that. > > BTW, how do fltk::Window::xclass() and fltk::Window::icon() work? All > they do is set private variables. Somewhere those variables must be > sent to X11 so that something actually happens on the desktop, but I'm > darned if I can see where the FLTK code does it. It seems to be > happening by voodoo. Are we meddling with forces that humanity was > not meant to wield? :-) They hide that stuff in deep in their source tree. It's in src/x11/run.cxx ;-) Johannes

Sept. 25, 2008

Icon for Dillo window

by jcid＠dillo.org

On Thu, Sep 25, 2008 at 03:11:55PM +0100, Jeremy Henty wrote: > On Thu, Sep 25, 2008 at 12:12:26PM +0200, Johannes Hofmann wrote: > > -------- Original-Nachricht -------- > > > Datum: Thu, 25 Sep 2008 08:03:52 +0100 > > > Von: Jeremy Henty <onepoint(a)starurchin.org> > > > An: dillo-dev(a)dillo.org > > > Betreff: Re: [Dillo-dev] Icon for Dillo window > > > > > On Wed, Sep 24, 2008 at 06:48:17PM -0400, Jorge Arellano Cid wrote: > > > > > > > I was thinking it'd be good to provide an icon for the WM to > > > > use. Does anybody know how to do it with FLTK2? > > > > > > It appears not to be possible. In X Windows you set the > > > _NET_WM_ICON hint > > > > test/image.cxx has from the fltk2 tarball shows how to do it. > > That doesn't work on my system (my window manager is icewm). For me > test/image gets the standard X icon in its window frame and in its > taskbar box when miminised (icewm doesn't use desktop icons). Does it > work with any other window managers? It doesn't work here with XFCE. > Icewm sets icons by reading the WM_CLASS hint, interpreting it as the > root of the icon file names and searching for the files in its icon > directories. Unfortunately dillo2 sets WM_CLASS to '"Fltk", "fltk"'. > If it set it to '"Dillo2", "dillo2"' I could configure its icons. Could be. > If we're concerned about dillo2 playing properly with X11 and window > managers then I'd say that it should set WM_CLASS to '"Dillo2", > "dillo2"' on general principle. > > (The weird thing is that my icewm finds the right Firefox icons, yet I > can't find any Firefox icon files in the icon directories. I'm still > trying to figure out where it gets them from.) > > Also, the _NET_WM_ICON hint has the advantage that it can provide a > list of icons of different sizes so that window managers can use a > larger icon eg. when switching between applications with Alt+Tab. If you know a good way to do it, please go ahead. -- Cheers Jorge.-

Sept. 25, 2008