- Dillo-dev - lists.mailman3.com

patch: changeLinkColor

by corvid＠lavabit.com

I just took the 0.8.6 version and replaced everything in it with dillo2 versions. (well, then had to add in the widget part) The fact that it seems to be working is kind of shocking. As for whether this is still the right way to do it, I leave this matter for the experts. The registerName is because html.cc needs to have that working in order to call changeLinkColor.

Sept. 28, 2008

what crashes remain?

by corvid＠lavabit.com

Johannes wrote: > On Sat, Sep 27, 2008 at 05:29:28PM +0000, corvid wrote: > > I can't think of any other crashes, but I don't remember whether > > Johannes still gets bus errors. > > No, they got fixed with > http://lists.auriga.wearlab.de/pipermail/dillo-dev/2008-July/004649.html > > The only issues I'm seeing are the 128 tabs limit from fltk and the > redraw storms related to the MenuTabPager. Playing with the file menu, I see that Alt-W, Alt-E, Alt-X, Alt-C all segfault. I thought somebody said something (that I didn't pay attention to) about the file menu since tabs were added, but if so, I can't find that mail.

Sept. 28, 2008

what crashes remain?

by corvid＠lavabit.com

Jorge wrote: > On Sat, Sep 27, 2008 at 05:29:28PM +0000, corvid wrote: > > It's still possible to crash dillo if you click on a remote link and > > quickly click on some images to load them. Doesn't crash every time, > > but typically within four tries or so. I had assumed it was the same > > thing as whatever was wrong with the menu crash, so I'd ignored it. > > > > If I stick > > a_Bw_stop_clients(bw, BW_Img); > > in the DilloHtml destructor, I can no longer get it to crash, but > > I randomly got a "Cache_process_queue Caught busy!!!" while browsing > > earlier today, so there's something wrong with just doing that. > > (Assuming it's related; I'm not in the habit of getting that MSG.) > > That message means big trouble: the event loop stepped over itself... > > I've tried several different ways but can't get to crash it. > > Does the attached patch help? Seems to be working well so far. Is there any danger in adding something like a_Nav_cancel_expect to a_UIcmd_stop()? PS Stop should have a keyboard shortcut, I think. I long had a reflex of hitting ESC from the netscape/mozilla days, but of course ESC would be inconsistent for dillo.

Sept. 28, 2008

what crashes remain?

by jcid＠dillo.org

On Sat, Sep 27, 2008 at 05:29:28PM +0000, corvid wrote: > It's still possible to crash dillo if you click on a remote link and > quickly click on some images to load them. Doesn't crash every time, > but typically within four tries or so. I had assumed it was the same > thing as whatever was wrong with the menu crash, so I'd ignored it. > > If I stick > a_Bw_stop_clients(bw, BW_Img); > in the DilloHtml destructor, I can no longer get it to crash, but > I randomly got a "Cache_process_queue Caught busy!!!" while browsing > earlier today, so there's something wrong with just doing that. > (Assuming it's related; I'm not in the habit of getting that MSG.) That message means big trouble: the event loop stepped over itself... I've tried several different ways but can't get to crash it. Does the attached patch help? -- Cheers Jorge.-

Sept. 27, 2008

Dillo in OSX

by jcid＠dillo.org

On Sat, Sep 27, 2008 at 09:33:59PM +0200, Johannes Hofmann wrote: > On Thu, Sep 04, 2008 at 04:09:30PM -0400, Jorge Arellano Cid wrote: > > On Wed, Sep 03, 2008 at 06:28:49PM +0200, Johannes Hofmann wrote: > > > On Tue, Sep 02, 2008 at 09:20:03AM -0400, Jorge Arellano Cid wrote: > > > > On Mon, Sep 01, 2008 at 01:42:26PM +0200, Johannes Hofmann wrote: > > > > > Hi Jorge, > > > > > > > > > > how did You setup the OSX box to get a compiler and header files? > > > > > Did You install that huge XCode stuff, or is there another way? > > > > > I may get access to an OSX box to try dillo on it. > > > > > > > > How do I disable the double-buffer? > > > > > > Use the --disable-doublebuffer option when configuring dw2. > > > > Oh, yes, I forgot... > > (tried running ./configure --help in dillo2 not dw2) > > > > > > I tried dillo "as is" with clear_double_buffer() and without it, > > > > and the result is the same... > > > > > > Yeah, dw2 implements doublebuffering internally, so that does not > > > make a difference. > > > > I'll have access to that machine again sarting on September 12. > > > > Just tried current dillo on OSX with --disable-doublebuffer. It > works ok with some issues: > > * Some of the buttens disapear from time to time (Back > button for example). > > * The font size seems a bit too large so that there is not enough > space between words and lines. > > * Incoming data does not reliably trigger a page update. An > additional event like a mouse movement is necessary. > > Apart from that it's quite nice. Tabs are working fine. Oh, sorry, I forgot to tell you. That's exactly what I saw when testing without double buffer. -- Cheers Jorge.-

Sept. 27, 2008

SEGFAULT with mouse click

by jcid＠dillo.org

On Sat, Sep 27, 2008 at 07:59:11PM +0000, corvid wrote: > Is that middle-click crash gone as well now? Yes! The problematic middle-click was generating a button 1 and 2 press, not middle (similar to fast clicking them). -- Cheers Jorge.-

Sept. 27, 2008

SEGFAULT with mouse click

by corvid＠lavabit.com

Is that middle-click crash gone as well now?

Sept. 27, 2008

Dillo in OSX

by Johannes.Hofmann＠gmx.de

On Thu, Sep 04, 2008 at 04:09:30PM -0400, Jorge Arellano Cid wrote: > On Wed, Sep 03, 2008 at 06:28:49PM +0200, Johannes Hofmann wrote: > > On Tue, Sep 02, 2008 at 09:20:03AM -0400, Jorge Arellano Cid wrote: > > > On Mon, Sep 01, 2008 at 01:42:26PM +0200, Johannes Hofmann wrote: > > > > Hi Jorge, > > > > > > > > how did You setup the OSX box to get a compiler and header files? > > > > Did You install that huge XCode stuff, or is there another way? > > > > I may get access to an OSX box to try dillo on it. > > > > > > How do I disable the double-buffer? > > > > Use the --disable-doublebuffer option when configuring dw2. > > Oh, yes, I forgot... > (tried running ./configure --help in dillo2 not dw2) > > > > I tried dillo "as is" with clear_double_buffer() and without it, > > > and the result is the same... > > > > Yeah, dw2 implements doublebuffering internally, so that does not > > make a difference. > > I'll have access to that machine again sarting on September 12. > Just tried current dillo on OSX with --disable-doublebuffer. It works ok with some issues: * Some of the buttens disapear from time to time (Back button for example). * The font size seems a bit too large so that there is not enough space between words and lines. * Incoming data does not reliably trigger a page update. An additional event like a mouse movement is necessary. Apart from that it's quite nice. Tabs are working fine. Cheers, Johannes

Sept. 27, 2008

SEGFAULT with mouse click

by jcid＠dillo.org

On Fri, Sep 26, 2008 at 09:29:00PM +0000, corvid wrote: > I wrote: > > Jorge wrote: > > > This hinted me towards a timing issue and found this way to > > > crash dillo (most probably akin to the "middle-click" bug): > > > > > > 1.- Left click over a remote URL link > > > (to have some time while DNS is resolving) > > > 2.- Move the mouse pointer out of the link and right-click > > > to get the popup menu, before the new page starts downloading. > > > 3.- Once the new page starts to show, click again to get rid of > > > the popup, and it'll crash. > > > > What a coincidence! I finally got around to making a patch for that > > last night. (I'd known about that one for a while...) > > Here, you can give it a try. > > It took until yesterday to finally poke at it long enough to > find the problem because the backtrace you get is very misleading. > It dies down below Widget::buttonPress (EventButton *event), and of > course you just pressed the button to get rid of the popup -- but > it's really the old button press that popped up the menu. > First it went down buttonPressImpl and caused the popup, which doesn't > return until the menu goes away, and second it goes down > eventEmitter.emitButtonPress...but the widget and its emitter are gone. > > So I threw timeout at it and made copies of things in popup_*. > OK, committed with some minor changes and comments. Please check. After reading the patch, it seems the timeout helps to get rid of the events that popped it up, so they're not obsolete after a page change. This avoids the segfault, and also cuts the execute on button-release feature. I wondered what was the "FLTK-way" of doing it, and experimented a bit, but after finding this warning, I decided to commit: Menu_popup.cxx: // Implementation of popup menus. These are called by using the // Menu::popup and Menu::pulldown methods. See also the // Menu base class in Menu.cxx. Warning: this code is // quite a mess! Also, the classes defined here are private and // may change in the future! :-) BTW, It looks as though FLTK-1.3 may be a good option after all... -- Cheers Jorge.-

Sept. 27, 2008

what crashes remain?

by Johannes.Hofmann＠gmx.de

On Sat, Sep 27, 2008 at 05:29:28PM +0000, corvid wrote: > It's still possible to crash dillo if you click on a remote link and > quickly click on some images to load them. Doesn't crash every time, > but typically within four tries or so. I had assumed it was the same > thing as whatever was wrong with the menu crash, so I'd ignored it. > > If I stick > a_Bw_stop_clients(bw, BW_Img); > in the DilloHtml destructor, I can no longer get it to crash, but > I randomly got a "Cache_process_queue Caught busy!!!" while browsing > earlier today, so there's something wrong with just doing that. > (Assuming it's related; I'm not in the habit of getting that MSG.) > > > I can't think of any other crashes, but I don't remember whether > Johannes still gets bus errors. No, they got fixed with http://lists.auriga.wearlab.de/pipermail/dillo-dev/2008-July/004649.html The only issues I'm seeing are the 128 tabs limit from fltk and the redraw storms related to the MenuTabPager. Cheers, Johannes

Sept. 27, 2008