- Dillo-dev - lists.mailman3.com

Re: [PATCH] Add preference to toggle reverse mouse wheel tab scrolling

by Rodrigo Arias

Hi Alex, Please reply to the mailing list, so others can follow the conversation too. On Sat, Apr 06, 2024 at 12:05:21PM +0200, a1ex(a)dismail.de wrote: > >> The convention in dillorc is to set the defaults in comments > >Noted. For some reason I assumed its 'uncomment to enable'. > >> Wouldn't this be simpler? >> >> if (prefs.scroll_switches_tabs_reverse) >> dir = -dir; > >That does look simpler. I admit my beginner coding skills :) Check PR #123 [1,2], I added you as author based on your email and name. [1]: https://github.com/dillo-browser/dillo/pull/123 [2]: https://patch-diff.githubusercontent.com/raw/dillo-browser/dillo/pull/123.p… > >So, regarding the idea of a 'new tab page', here is a proof of concept. >It just opens bookmarks on a new tab right now, but if you agree this >is worth persuing, I can try to work on a preference to set this to >any url specified in dillorc. > >--- uicmd.cc Thu Apr 4 20:56:39 2024 >+++ uicmd.cc Sat Apr 6 11:58:09 2024 >@@ -775,6 +775,8 @@ > a_UIcmd_set_location_text(new_bw, URL_STR(url)); > BW2UI(new_bw)->focus_main(); > } else { >+ DilloUrl *url = a_Url_new("dpi:/bm/", NULL); >+ a_Nav_push(new_bw, url, NULL); > BW2UI(new_bw)->focus_location(); > a_UIcmd_set_buttons_sens(new_bw); > } > Thanks. I think is a useful feature, but we should allow the current behavior to be kept as it is. In particular, it should be possible to hit Ctrl-T and begin writing a new URL right away, without loading any page. As it will require some though, I will postpone this after 3.1.0. Feel free to work on it in the meanwhile if you are interested :-) Best, Rodrigo.

April 8, 2024

Re: [PATCH] Add preference to toggle reverse mouse wheel tab scrolling

by Rodrigo Arias

Hi Alex, On Fri, Apr 05, 2024 at 04:29:08PM +0200, a1ex(a)dismail.de wrote: >Hello friends, > >This patch adds a preference to toggle the direction of scrolling tabs >with the mouse wheel. I personally find it more intuitive reversed, >though others might disagree, thus now there can be a choice :) > >Regards, >Alex > > > > > >--- dillorc Sat Mar 9 18:43:51 2024 >+++ dillorc Fri Apr 5 15:30:32 2024 >@@ -384,6 +384,9 @@ > # If set to NO, the page will be scrolled instead. > #scroll_switches_tabs=YES > >+# Reverse the direction of tab scrolling with mouse wheel. >+#scroll_switches_tabs_reverse=YES The convention in dillorc is to set the defaults in comments, so this should be: #scroll_switches_tabs_reverse=NO >+ > # Mouse middle click by default drives drag-scrolling. > # To paste an URL into the window instead of scrolling, set it to NO. > # Note: You could always paste the URL onto the URL box clear button. > > >--- src/prefs.c Sat Mar 9 18:43:51 2024 >+++ src/prefs.c Fri Apr 5 15:32:45 2024 >@@ -79,6 +79,7 @@ > prefs.middle_click_opens_new_tab = TRUE; > prefs.right_click_closes_tab = TRUE; > prefs.scroll_switches_tabs = TRUE; >+ prefs.scroll_switches_tabs_reverse = FALSE; > prefs.no_proxy = dStrdup(PREFS_NO_PROXY); > prefs.panel_size = P_medium; > prefs.parse_embedded_css=TRUE; > > >--- src/prefs.h Sat Mar 9 18:43:51 2024 >+++ src/prefs.h Fri Apr 5 15:33:40 2024 >@@ -107,6 +107,7 @@ > bool_t middle_click_opens_new_tab; > bool_t right_click_closes_tab; > bool_t scroll_switches_tabs; >+ bool_t scroll_switches_tabs_reverse; > bool_t search_url_idx; > Dlist *search_urls; > char *save_dir; > > >--- src/prefsparser.cc Sat Mar 9 18:43:51 2024 >+++ src/prefsparser.cc Fri Apr 5 15:35:19 2024 >@@ -192,6 +192,7 @@ > PREFS_BOOL, 0 }, > { "right_click_closes_tab", &prefs.right_click_closes_tab, >PREFS_BOOL, 0 }, { "scroll_switches_tabs", &prefs.scroll_switches_tabs, >PREFS_BOOL, 0 }, >+ { "scroll_switches_tabs_reverse", >&prefs.scroll_switches_tabs_reverse, PREFS_BOOL, 0 }, { "no_proxy", >&prefs.no_proxy, PREFS_STRING, 0 }, { "panel_size", &prefs.panel_size, >PREFS_PANEL_SIZE, 0 }, { "parse_embedded_css", >&prefs.parse_embedded_css, PREFS_BOOL, 0 }, > >--- src/uicmd.cc Sat Mar 9 18:43:51 2024 >+++ src/uicmd.cc Fri Apr 5 15:41:30 2024 >@@ -254,7 +254,11 @@ > int dy = Fl::event_dy(); > int dir = dy ? dy : dx; Wouldn't this be simpler? if (prefs.scroll_switches_tabs_reverse) dir = -dir; > >- if (dir > 0) >+ if (dir > 0 && prefs.scroll_switches_tabs_reverse) >+ prev_tab(); >+ else if (dir > 0) >+ next_tab(); >+ else if (dir < 0 && prefs.scroll_switches_tabs_reverse) > next_tab(); > else if (dir < 0) > prev_tab(); > Thanks for the patch, I will merge it when I have a moment. Rodrigo.

April 5, 2024

[PATCH] Add preference to toggle reverse mouse wheel tab scrolling

by a1ex＠dismail.de

Hello friends, This patch adds a preference to toggle the direction of scrolling tabs with the mouse wheel. I personally find it more intuitive reversed, though others might disagree, thus now there can be a choice :) Regards, Alex --- dillorc Sat Mar 9 18:43:51 2024 +++ dillorc Fri Apr 5 15:30:32 2024 @@ -384,6 +384,9 @@ # If set to NO, the page will be scrolled instead. #scroll_switches_tabs=YES +# Reverse the direction of tab scrolling with mouse wheel. +#scroll_switches_tabs_reverse=YES + # Mouse middle click by default drives drag-scrolling. # To paste an URL into the window instead of scrolling, set it to NO. # Note: You could always paste the URL onto the URL box clear button. --- src/prefs.c Sat Mar 9 18:43:51 2024 +++ src/prefs.c Fri Apr 5 15:32:45 2024 @@ -79,6 +79,7 @@ prefs.middle_click_opens_new_tab = TRUE; prefs.right_click_closes_tab = TRUE; prefs.scroll_switches_tabs = TRUE; + prefs.scroll_switches_tabs_reverse = FALSE; prefs.no_proxy = dStrdup(PREFS_NO_PROXY); prefs.panel_size = P_medium; prefs.parse_embedded_css=TRUE; --- src/prefs.h Sat Mar 9 18:43:51 2024 +++ src/prefs.h Fri Apr 5 15:33:40 2024 @@ -107,6 +107,7 @@ bool_t middle_click_opens_new_tab; bool_t right_click_closes_tab; bool_t scroll_switches_tabs; + bool_t scroll_switches_tabs_reverse; bool_t search_url_idx; Dlist *search_urls; char *save_dir; --- src/prefsparser.cc Sat Mar 9 18:43:51 2024 +++ src/prefsparser.cc Fri Apr 5 15:35:19 2024 @@ -192,6 +192,7 @@ PREFS_BOOL, 0 }, { "right_click_closes_tab", &prefs.right_click_closes_tab, PREFS_BOOL, 0 }, { "scroll_switches_tabs", &prefs.scroll_switches_tabs, PREFS_BOOL, 0 }, + { "scroll_switches_tabs_reverse", &prefs.scroll_switches_tabs_reverse, PREFS_BOOL, 0 }, { "no_proxy", &prefs.no_proxy, PREFS_STRING, 0 }, { "panel_size", &prefs.panel_size, PREFS_PANEL_SIZE, 0 }, { "parse_embedded_css", &prefs.parse_embedded_css, PREFS_BOOL, 0 }, --- src/uicmd.cc Sat Mar 9 18:43:51 2024 +++ src/uicmd.cc Fri Apr 5 15:41:30 2024 @@ -254,7 +254,11 @@ int dy = Fl::event_dy(); int dir = dy ? dy : dx; - if (dir > 0) + if (dir > 0 && prefs.scroll_switches_tabs_reverse) + prev_tab(); + else if (dir > 0) + next_tab(); + else if (dir < 0 && prefs.scroll_switches_tabs_reverse) next_tab(); else if (dir < 0) prev_tab();

April 5, 2024

Re: [PATCH] Reverse scroll wheel tab switching

by a1ex＠dismail.de

> It should build with OpenSSL 3 and 1.1 and LibreSSL too. Just tested with LibreSSL and it works. I remember some time ago (many months) the build would error out, and had to resort to mbedtls. I guess it was fixed. Excellent :)

April 5, 2024

Re: [PATCH] Reverse scroll wheel tab switching

by Rodrigo Arias

Hi, >Hi Rodrigo, thanks for your reply! > >I agree that a configuration option for the scroll direction would be >ideal, and probably wouldn't take a huge effort to implement. I'm not >much of a coder, but will take a look to see it's something I can >manage. Thanks! >I did notice the new mailing list and hopefully it starts to get more >contributors/activity. It is however somewhat ironic that it requires >javascript to view the archives. I'm able to read the archives without JS in Dillo, as well as performing searches: $ dillo "https://lists.mailman3.com/hyperkitty/list/dillo-dev@mailman3.com/latest" $ dillo "https://lists.mailman3.com/hyperkitty/search?mlist=dillo-dev%40mailman3.com…" $ dillo "https://lists.mailman3.com/hyperkitty/list/dillo-dev@mailman3.com/thread/2S…" AFAIK, the only thing that requires JS is the "Recently active discussions" sections, but clicking on "All threads" works fine. It is non-ideal that it uses JS for some things, but they provide hosting for the ML free of charge. Maybe we can add the mailing list to other indexes that don't use JS. I contacted gmane.io for NNTP access but they didn't replied yet. >Another feature I would be interested in is setting a new tab >destination. For instance, it would be neat to show bookmarks >automatically when opening a new tab. Is this something which has been >looked at already? I don't think so, but it may be a good feature. It should be similar to adding a "start_page" or "home" option in dillorc, like "new_tab_page". For now you can do Ctrl+T and then Crtl+B to open the bookmarks. It should also allow Ctrl+T and begin typing an URL somhow, maybe we can pre-select the URL. >Really looking forward to the 3.1 release! I run OpenBSD, and the >version of Dillo in the packages is old and SSL doesn't work properly. >So I have to build from source on every install. Luckily it builds on >OpenBSD without problems (using mbedtls). Thanks! I'll probably do a release candidate before the final release, so it can be tested from the tarball. It should build with OpenSSL 3 and 1.1 and LibreSSL too. >Best regards, and thanks for keeping this project alive! Thanks :-) Rodrigo.

April 5, 2024

[PATCH] Reverse scroll wheel tab switching

by Rodrigo Arias

Hi Alex, We have a mailing list for patches at <dillo-dev(a)mailman3.com>, maybe I should add a comment to the README too. Regarding your patch, I find that behavior unintuitive :-) But we shouldn't expect people to agree on those, so I think this should be implemented as a configuration option. Check the PR of the tab switching[1] to see how to add another option yourself. [1]: https://github.com/dillo-browser/dillo/pull/62/files Otherwise I can work on it after the 3.1.0 release. I opened an issue: https://github.com/dillo-browser/dillo/issues/122 Best, Rodrigo. ----- Forwarded message from Alex ----- Hello, In my opinion the behavior of the mouse wheel tab switching is backwards. Scrolling up switches to the previous tab, and down goes to the next tab. This seems unintuitive and I find myself frequently scrolling in the wrong direction. Sorry I don't have a github account to do a pull request, but here is a diff that reverses the direction: --- uicmd.cc Fri Apr 5 10:59:06 2024 +++ uicmd.cc Fri Apr 5 10:59:21 2024 @@ -255,9 +255,9 @@ int dir = dy ? dy : dx; if (dir > 0) - next_tab(); - else if (dir < 0) prev_tab(); + else if (dir < 0) + next_tab(); ret = 1; } Dillo for life! Alex ----- End forwarded message -----

April 5, 2024

Doxygen documentation online

by Rodrigo Arias

Hi, I added the Doxygen documentation in the main website, with the Doxygen Awesome theme: https://dillo-browser.github.io/doxygen/index.html Here is the main overview: https://dillo-browser.github.io/doxygen/dw-overview.html It also includes the documentation of most C functions that was not being included due to "/*" comments instead of "/**" at the beginning of the functions. It is rendered directly from the Dillo git repository weekly, until I figure how to trigger a pipeline in a different repo. It seems Doxygen is injecting some Javascript for the index, but I think there may be a way to avoid it so it can be properly read in Dillo itself. For now I'm leaving it as-is. Best, Rodrigo.

March 9, 2024

Re: New mailing list for Dillo

by Rodrigo Arias

Hi, On Sun, Jan 28, 2024 at 07:57:05AM -0500, Charles E. Lehner wrote: >Excellent! Thanks Charles, I forgot to add a link to the list page in case you want to subscribe: https://lists.mailman3.com/postorius/lists/dillo-dev.mailman3.com/ The archives are here: https://lists.mailman3.com/hyperkitty/list/dillo-dev@mailman3.com/ Rodrigo.

Jan. 28, 2024

Re: New mailing list for Dillo

by Charles E. Lehner

Excellent! On January 28, 2024 7:04:19 AM EST, Rodrigo Arias <rodarima(a)gmail.com> wrote: >Hi all, > >The people at mailman3.com has agreed on hosting Dillo mailing list free of charge as part of their open-source program (thanks for the pointer Charles), for which I'm very grateful :-) > >With the help of Andreas, I have put together most of the mailing list archives I could gather from the old server, although there are some posts and attachments missing. > >The objective of this list is to continue the discussion for the development of Dillo[1] and related topics, in the same way dillo-dev was used before but with moderation to keep a friendly tone. > >[1]: https://dillo-browser.github.io/ > >The GitHub platform[2] is used for now to hold the repository, store issues and to run the CI tests, until a more suitable platform is available. > >[2]: https://github.com/dillo-browser/dillo > >I hope we can finally made the 3.1 release soon (as in the next month), so distributions can get the new release (after years) in their package repositories. > >Best regards, >Rodrigo.

Jan. 28, 2024

New mailing list for Dillo

by Rodrigo Arias

Hi all, The people at mailman3.com has agreed on hosting Dillo mailing list free of charge as part of their open-source program (thanks for the pointer Charles), for which I'm very grateful :-) With the help of Andreas, I have put together most of the mailing list archives I could gather from the old server, although there are some posts and attachments missing. The objective of this list is to continue the discussion for the development of Dillo[1] and related topics, in the same way dillo-dev was used before but with moderation to keep a friendly tone. [1]: https://dillo-browser.github.io/ The GitHub platform[2] is used for now to hold the repository, store issues and to run the CI tests, until a more suitable platform is available. [2]: https://github.com/dillo-browser/dillo I hope we can finally made the 3.1 release soon (as in the next month), so distributions can get the new release (after years) in their package repositories. Best regards, Rodrigo.

Jan. 28, 2024