- Dillo-dev - lists.mailman3.com

image memory leak

by jcid＠dillo.org

On Sat, Apr 25, 2009 at 01:18:19PM +0100, Jeremy Henty wrote: > On Fri, Apr 24, 2009 at 06:20:20PM +0200, Hofmann Johannes wrote: > > On Thu, Apr 23, 2009 at 09:36:23PM +0100, Jeremy Henty wrote: > > > > > > On Thu, Apr 23, 2009 at 06:01:56PM +0200, Hofmann Johannes wrote: > > > > > > > It turns out that memory related to aborted images is not released. > > > > > > What about the other way round, ie. memory being released and > > > then accessed? If you check the invalid read errors at the > > > valgrind logs page[1] for the past few days you will see they are > > > all due to reading freed image memory. Is this another aspect of > > > the same thing, or something else? > > > > I'd say it's something different. It's always a read of size 4, > > isn't it? I guess that's just one uninitialized pointer. > > I don't think that it's uninitialized pointers. If it were then you > would expect valgrind to complain that the address had never been > malloced or freed. That's not what we see. Eg. look at the first > instance of 'Jpeg_write: Invalid read of size 4'[1]. The freed memory > is a DilloImage structure. The line that does the invalid read is > reading ... a member of a DilloImage structure! The same is true for > the errors from dw::core::Widget::getLayout() , Png_datarow_callback > and Png_datainfo_callback . In every case the pointer refers to a > malloced structure of the right type. The problem is that the > structure has since been freed. I think it's pretty clear that the > problem is not uninitialised pointers, it's that the code is using > pointers after freeing them. > > It's probably significant that these errors all come from within image > callbacks (a_Jpeg_callback and a_Png_callback). It looks like a race > condition to me: callbacks are running after the image has been freed. > Does that make sense? Yes, it makes sense to me. Have you found a simplified test-case to reproduce it? Finally now I have some time to investigate this bug. I'll start with the problem Johannes described (large jpeg) because of the test-case. Let's start... -- Cheers Jorge.-

May 7, 2009

Dillo2 + FLTK2 + NxLib running on mips linux

by furaisanjin＠gmail.com

2009/5/7 corvid <corvid(a)lavabit.com>: > Wouldn't it be wrong to wrap after most multibyte chars? > (e.g., if you go to uk.wikipedia.org) No, but I thoght some people might concern the cost of utf8decode and more memory allocation/deallocation due to this patch. Regards, furaisanjin

May 7, 2009

Dillo2 + FLTK2 + NxLib running on mips linux

by corvid＠lavabit.com

furaisanjin wrote: > > ?BTW, ?AFAIR ?the ?patch ?for ?wrapping chinese is "basic". As I > > don't ?know ?anything ?about ?chinese ?it's ?very ?hard for me to > > evaluate. > > I think the patch for Html_write_raw is rather simple than I thought. > If I can give one comment, it's better to treat all multi byte UTF8 > characters in the same way (not only Chinese and Japanese) so that > more people would be happy. If some people don't want to add this > patch for pure ASCII only language, would you able to add prefs > control for multi byte UTF8 character languages? Wouldn't it be wrong to wrap after most multibyte chars? (e.g., if you go to uk.wikipedia.org)

May 7, 2009

Dillo2 + FLTK2 + NxLib running on mips linux

by corvid＠lavabit.com

Jorge wrote: > BTW, AFAIR the patch for wrapping chinese is "basic". As I > don't know anything about chinese it's very hard for me to > evaluate. > > Corvid: is it worth to push this patch to the repo? Hard for me to evaluate, too. To me, it seems like a good thing on the whole... furaisanjin said that doing this makes text in tables too narrow, but I'd imagine that's a smaller matter than the lack of wrapping would be. I think the current patch would fail to work if numeric entities are used to specify characters.

May 7, 2009

Dillo2 + FLTK2 + NxLib running on mips linux

by furaisanjin＠gmail.com

> ?BTW, ?AFAIR ?the ?patch ?for ?wrapping chinese is "basic". As I > don't ?know ?anything ?about ?chinese ?it's ?very ?hard for me to > evaluate. I think the patch for Html_write_raw is rather simple than I thought. If I can give one comment, it's better to treat all multi byte UTF8 characters in the same way (not only Chinese and Japanese) so that more people would be happy. If some people don't want to add this patch for pure ASCII only language, would you able to add prefs control for multi byte UTF8 character languages? Regards, furaisanjin

May 7, 2009

Code for Wikipedia searches

by jcid＠dillo.org

On Mon, May 04, 2009 at 05:06:26PM -0700, Freya wrote: > > > Hiya! > A big thanks to Corvid who helped me loads to get my new dillo compiled and working! > > I wanted to give a little back, so I did a load of reasearch and finally managed to work out the code to get dillo to do direct wikipedia searches. > Just add this to the dillorc file: > > search_url="http://www.wikipedia.org/wiki/Special:Search?search=%s" > > It would be good to include it with future dillo releases as it's not easy to find out how to do this! It's lots of fun tho, just enter your keywords and it takes you right to the wikipedia page! :) > > I'm a bit of a wikipedia fan as you may have noticed. > > Anyway I know it's not loads but I think it's groovy and adds something to dillo. Thanks for the URL. It was just committed in dillorc, so 2.1 will have it hinted there. -- Cheers Jorge.-

May 7, 2009

Dillo2 + FLTK2 + NxLib running on mips linux

by jcid＠dillo.org

On Thu, May 07, 2009 at 02:07:22AM +0800, ???? ?i wrote: > Hello All > > One years ago I had tried dillo + fltk + nxlib and unsuccessful. > Today, the dillo2 works. I'm so happy. > > Also I have record my building progress in my blog > http://tw.myblog.yahoo.com/stevegigijoe/article?mid=138&prev=-1&next=137 > > Thank you all. Good! Do you have a screenshot? BTW, AFAIR the patch for wrapping chinese is "basic". As I don't know anything about chinese it's very hard for me to evaluate. Corvid: is it worth to push this patch to the repo? Steve: what's your opinion on the patch? Can you improve it? and finally, how are the "sung" fonts installed? (to be able to render chinese here). -- Cheers Jorge.-

May 7, 2009

Dillo2 + FLTK2 + NxLib running on mips linux

by stevegigijoe＠yahoo.com.tw

>On Thu, May 07, 2009 at 02:07:22AM +0800, ?? ? wrote: >> Hello All >> >> One years ago I had tried dillo + fltk + nxlib and unsuccessful. >> Today, the dillo2 works. I'm so happy. >> >> Also I have record my building progress in my blog >>http://tw.myblog.yahoo.com/stevegigijoe/article?mid=138&prev=-1&next=137 >Nice! On what hardware do you run dillo? >Cheers, >Johannes Running on MIPS 4KEc CPU clock 162.5MHz 16MBytes flash, 32MBytes memory Steve ______________________________________________________________________________________________________ ¥I¶O€~®e¶qµL€W¡HYahoo!©_Œ¯¹q€l«Hœc2.0§K¶Oµ¹§A¡A«H¥ó¥Ã»·€£¥²§R¡I http://tw.mg0.mail.yahoo.com/dc/landing

May 7, 2009

change FLTK scheme for in dillo2

by akhilman＠gmail.com

Greetings. Can I change colours of dialogues and scrollbar in dillo2? I would like to gets something less bright. Even something like fluid2's -bg option will be ok. Thank you for great lightweight browser. -- ?????? ??????????? aka AkhIL ??? ??? 7 13:39:04 KRAST 2009 Thu May 7 05:39:04 UTC 2009 ---------------------------------- Visit my home page http://akhilman.blogspot.com/ jabber: akhil(a)jabber.ru ---------------------------------- ??? ????????? ????????? ????????? ??, ??? ?? ??????? ?????????, ?????? ?? ???? ????, ??? ?? ???????????? ??? ?????????. (?.?????????) ---------------------------------- Linux artstation 2.6.28-gentoo-r5 #1 SMP Sat May 2 18:40:24 KRAST 2009 x86_64 AMD Phenom(tm) 9550 Quad-Core Processor AuthenticAMD GNU/Linux up 4 days, 18:33, 4 users, load average: 0.48, 0.40, 0.37

May 7, 2009

image resize

by furaisanjin＠gmail.com

Hi, 2009/5/7 Johannes Hofmann <Johannes.Hofmann(a)gmx.de>: > Hi, > > On Wed, May 06, 2009 at 12:25:03PM +0900, furaisanjin wrote: >> Hi. >> >> I studied this issue a bit further and notice that style causes the >> problem. For example, >> >> <img width="120" height="100" src="http://img.news.goo.ne.jp/photo/gooeditor/typ >> hoon.jpg"/ style="border:1px solid #ccc;"> >> >> This resizing is something strange. However if I remove style >> definition from img tag, resizing works. > > I think I've fixed it in tip. Please give it a try. Thank you, the fix works very well. Regards, furaisanjin

May 7, 2009