- Dillo-dev - lists.mailman3.com

image inputs, height and width attrs

by corvid＠lavabit.com

Johannes wrote: > On Tue, May 19, 2009 at 01:21:40AM +0000, corvid wrote: > > I noticed that images in image inputs weren't scaling, > > but then I saw in the spec that INPUT isn't supposed > > to have height and width attrs anyway, so I don't know > > whether we should do anything about it. > > I can't find width and height as attributes either, but what is > supposed to happen if width and height are specified via CSS? In the css2.1 spec, it says "This property does not apply to non-replaced inline-level elements."

May 19, 2009

image inputs, height and width attrs

by Johannes.Hofmann＠gmx.de

On Tue, May 19, 2009 at 01:21:40AM +0000, corvid wrote: > I noticed that images in image inputs weren't scaling, > but then I saw in the spec that INPUT isn't supposed > to have height and width attrs anyway, so I don't know > whether we should do anything about it. I can't find width and height as attributes either, but what is supposed to happen if width and height are specified via CSS? Cheers, Johannes

May 19, 2009

--xid option

by Johannes.Hofmann＠gmx.de

On Tue, May 19, 2009 at 01:34:56PM -0400, Jorge Arellano Cid wrote: > On Mon, May 18, 2009 at 11:14:14PM +0200, Johannes Hofmann wrote: > > On Mon, May 18, 2009 at 01:48:43PM -0400, Jorge Arellano Cid wrote: > > > On Mon, May 18, 2009 at 01:18:11AM +0200, Johannes Hofmann wrote: > > > > Hi, > > > > > > > > attached patch tries to implement the missing --xid option that is > > > > used to embed dillo into the claws mailer. > > > > The right way to do this would probabely be to implement the > > > > complete XEMBED protocol which is also mentioned in > > > > doc/fltk-problems.doc. > > > > However a simple XReparentWindow() seems to work more or less here. > > > > Please test. > > > > > > It seems like you forgot to commit xembed.{hh,cc} to the repo. > > > e.g. hg add xembed.hh xembed.cc > > > > Oh yes. Should be fixed now. > > Btw. I managed to install the claws mail client including the dillo > > plugin and it seems to work fine now with dillo2. That's why I just > > committed the xembed stuff. > > This is very good. > > I'll have to dig for the sylpheed contact to let them know. > Does anybody here know the email? I already contacted them on irc (#claws on freenode). It would be good if this get's some testing as there seems to be some interaction with the WM in use. I now tested it successful on dwm, twm, and fvwm. Also there are probabely more elegant ways to do it, but for now I think it's better than nothing. Cheers, Johannes

May 19, 2009

--xid option

by corvid＠lavabit.com

Jorge wrote: > I'll have to dig for the sylpheed contact to let them know. > Does anybody here know the email? http://lists.auriga.wearlab.de/pipermail/dillo-dev/2008-October/005313.html gives paul at claws-mail.org

May 19, 2009

--xid option

by jcid＠dillo.org

On Mon, May 18, 2009 at 11:14:14PM +0200, Johannes Hofmann wrote: > On Mon, May 18, 2009 at 01:48:43PM -0400, Jorge Arellano Cid wrote: > > On Mon, May 18, 2009 at 01:18:11AM +0200, Johannes Hofmann wrote: > > > Hi, > > > > > > attached patch tries to implement the missing --xid option that is > > > used to embed dillo into the claws mailer. > > > The right way to do this would probabely be to implement the > > > complete XEMBED protocol which is also mentioned in > > > doc/fltk-problems.doc. > > > However a simple XReparentWindow() seems to work more or less here. > > > Please test. > > > > It seems like you forgot to commit xembed.{hh,cc} to the repo. > > e.g. hg add xembed.hh xembed.cc > > Oh yes. Should be fixed now. > Btw. I managed to install the claws mail client including the dillo > plugin and it seems to work fine now with dillo2. That's why I just > committed the xembed stuff. This is very good. I'll have to dig for the sylpheed contact to let them know. Does anybody here know the email? -- Cheers Jorge.-

May 19, 2009

Latest on invalid image callback references

by onepoint＠starurchin.org

The valgrind logs are still showing invalid memory accesses that happen when image callbacks refer to DilloImages that have been freed by a_Web_free(). This is after the imgref patch was applied, since when I've been running an essentially unpatched Dillo. My image tracing still shows that the image pipeline sometimes continues to run after a_Web_free() frees the image it is attached to. As far as I can tell there has been no recent change in the behaviour of this problem. I have just applied a patch I was considering earlier that makes a_Cache_stop_client() close the client. I've attached it for comments, but I won't suggest applying it until we can see whether it's made any difference. That will take a few days, as I still haven't found a reliable way to reproduce the bug so I will just have to wait a few days and see if it stops appearing in the logs. Please comment on whether this patch is the right way to fix this. Regards, Jeremy Henty PS. You'll probably notice fewer valgrind reports in my log pages in future because I just returned to full-time work so I won't be surfing from home nearly as much.

May 19, 2009

image inputs, height and width attrs

by corvid＠lavabit.com

I noticed that images in image inputs weren't scaling, but then I saw in the spec that INPUT isn't supposed to have height and width attrs anyway, so I don't know whether we should do anything about it.

May 19, 2009

--xid option

by Johannes.Hofmann＠gmx.de

On Mon, May 18, 2009 at 01:48:43PM -0400, Jorge Arellano Cid wrote: > On Mon, May 18, 2009 at 01:18:11AM +0200, Johannes Hofmann wrote: > > Hi, > > > > attached patch tries to implement the missing --xid option that is > > used to embed dillo into the claws mailer. > > The right way to do this would probabely be to implement the > > complete XEMBED protocol which is also mentioned in > > doc/fltk-problems.doc. > > However a simple XReparentWindow() seems to work more or less here. > > Please test. > > It seems like you forgot to commit xembed.{hh,cc} to the repo. > e.g. hg add xembed.hh xembed.cc Oh yes. Should be fixed now. Btw. I managed to install the claws mail client including the dillo plugin and it seems to work fine now with dillo2. That's why I just committed the xembed stuff. Cheers, Johannes

May 18, 2009

--xid option

by jcid＠dillo.org

On Mon, May 18, 2009 at 01:18:11AM +0200, Johannes Hofmann wrote: > Hi, > > attached patch tries to implement the missing --xid option that is > used to embed dillo into the claws mailer. > The right way to do this would probabely be to implement the > complete XEMBED protocol which is also mentioned in > doc/fltk-problems.doc. > However a simple XReparentWindow() seems to work more or less here. > Please test. It seems like you forgot to commit xembed.{hh,cc} to the repo. e.g. hg add xembed.hh xembed.cc -- Cheers Jorge.-

May 18, 2009

patch: MSG* macros (Re: patch: default home dir)

by corvid＠lavabit.com

I wrote: > +#define MSG(...) MSG_INNARDS(, __VA_ARGS__) Even though the gnu cpp info page made it ever so clear that this was just fine -- without saying anything about it being an extension -- I see some discussion around on the web that makes it seem either undefined or wrong in C90, all right in C99, and I'm not sure about C++. In any case, the sensible thing to do would be to stick a "" in there and be done with it.

May 18, 2009