- Dillo-dev - lists.mailman3.com

"Edit with" feature request

by obeythepenguin＠gmail.com

On Fri, 29 Apr 2011 10:53:24 -0400, Duke Normandin <dukeofperl(a)ml1.net> wrote: > I pulled the source code to my system using mercurial (for the first > time). If someone would point out the files that I need to hack, I > sure could try. Might be a way to learn C and the required tool-chain. Well, if you're feeling ambitious: - Add a "char *editor" value or similar to struct _DilloPrefs in src/prefs.h. - Initialize and free this value in a_Prefs_init() and a_Prefs_freeall(), respectively, in src/prefs.c. - Add an entry for this value in const SymNode_t symbols[] in src/prefsparser.cc. - Hack up a_UIcmd_view_page_source(BrowserWindow *bw, const DilloUrl *url) in src/uicmd.cc to check for the editor value, and if present, launch the editor. I'll leave this for you to figure out, but the exec(3) manpage might help ;-) (actually I don't mind helping, just email if you need anything) If you know Perl and PHP, C/C++ shouldn't be hard to figure out. PHP borrows a lot of C's syntax (I think Perl does, too, but I'm not a Perl programmer), so mostly it's just the type system and memory management. Dillo's actually a pretty good codebase to learn on, because it's fairly small and well-organized; I've learned quite a bit working on it myself. But don't worry about all that if you don't want to -- I was thinking of writing a patch anyway, once I finish with exams. I should probably update my code to 1.3... ~Benjamin

April 29, 2011

"Edit with" feature request

by dukeofperl＠ml1.net

On Fri, 29 Apr 2011, Benjamin Johnson wrote: > On Fri, 29 Apr 2011 09:54:02 -0400, Duke Normandin <dukeofperl(a)ml1.net> wrote: > > > How hard would it be to add a button or menu items that would allow > > for the editing of a page being currently viewed, the the option to > > declare an external editor in ~/.dillo/dillorc? > > Fairly easy -- there's only two things to consider: [snip the good stuff] :) It always looks "so easy" when you know what you're doing - doesn't it! I don't know C or C++ at all - just Perl, PHP, newLISP and some Ruby - but I'm willing to learn. > There are a couple other small details -- picking a reasonable default editor > (or maybe just internal "view source" if none specified?), and starting a > terminal emulator for console editors like vi, nano, emacs, etc. I would simply set up an "editor" option in "dillorc". If it's empty then "view source"; otherwise send the file to the preferred editor. > Besides that, you'd just need to write the code or get one of the developers > interested. As it happens, I've been thinking of implementing that feature > for a while now... :-) I pulled the source code to my system using mercurial (for the first time). If someone would point out the files that I need to hack, I sure could try. Might be a way to learn C and the required tool-chain. -- Duke

April 29, 2011

"Edit with" feature request

by obeythepenguin＠gmail.com

On Fri, 29 Apr 2011 09:54:02 -0400, Duke Normandin <dukeofperl(a)ml1.net> wrote: > How hard would it be to add a button or menu items that would allow > for the editing of a page being currently viewed, the the option to > declare an external editor in ~/.dillo/dillorc? Fairly easy -- there's only two things to consider: (1) It would need to get the page source to the editor somehow, probably using a temporary file. (2) Different platforms have different ways to start external applications: Unix uses fork() / exec(), while Windows uses CreateProcess(). Dillo already has the code for both. (1) is easy enough to accomplish, just use the existing "save to disk" function and instead of prompting the user, randomly generate a temporary filename. (2) is already needed for DPI, and it would be easy enough to write a "portability wrapper" similar to what I did with the sockets code in my Windows port. There are a couple other small details -- picking a reasonable default editor (or maybe just internal "view source" if none specified?), and starting a terminal emulator for console editors like vi, nano, emacs, etc. Besides that, you'd just need to write the code or get one of the developers interested. As it happens, I've been thinking of implementing that feature for a while now... :-) Cheers, ~Benjamin

April 29, 2011

"Edit with" feature request

by dukeofperl＠ml1.net

Hello folks ... This note may not be seen by too many Dillo aficionados, because most of you will no doubt be exercising your invitations to the British Royal Wedding. :) Please convey my best wishes to the Royal couple, and have a glass of "cold punch" on me! Now back to regularly scheduled programming ... How hard would it be to add a button or menu items that would allow for the editing of a page being currently viewed, the the option to declare an external editor in ~/.dillo/dillorc? -- Duke

April 29, 2011

1.3 port

by jcid＠dillo.org

On Wed, Apr 27, 2011 at 05:59:57PM -0300, Jorge Arellano Cid wrote: > On Wed, Apr 27, 2011 at 07:51:28PM +0000, corvid wrote: > > Jorge wrote: > > > On Sat, Apr 23, 2011 at 09:57:29AM +0200, Thomas Orgis wrote: > > > > [...] > > > > The behaviour of closing sub-windows / tabs (open files) with > > > > Ctrl+w works on vintage NEdit with Motif as well es with > > > > modern-day Firefox. It works the same way with mail view > > > > windows in Claws Mail. And: Ctrl+q closes the whole > > > > application. For all of them. > > > > > > Patch committed. > > > > > > Hereafter the default for close tab/window is ctrl-w. > > > > Will close-all change as well? > > I guess so. > > Even though hitting ctrl-q is automatic for some of us, there's > the multiple-open-tabs dialog protection, and if this is too much > Alt-q can be set in keysrc. e.g. > > <Alt>q = close-all Committed. Hereafter the new default for "close-all" is Ctrl-q For those of us brainwired with Ctrl-q, adding these lines to ~/.dillo/keysrc helps to retrain the neural network: <Ctrl>q = nop <Alt>q = close-all (Or you can set to whatever feels right for you ;). -- Cheers Jorge.-

April 29, 2011

Re: bg_color question

by dukeofperl＠ml1.net

On Thu, 28 Apr 2011, Duke Normandin wrote: > Hey ... > > I've set: > > allow_white_bg=NO > > #let's see if red does show up > bg_color=0xff0000 > > in ~/.dillo/dillorc > > I don't see no red anywhere - not that I want it ;) Just for > debugging. Turning off white, gives me a "yellowish" bg, but I thought > that setting bg_color would give me _anything but white_. Doesn't seem > to be how it works. What am I missing? I figured out the behaviour! Problem solved! Sorry for the noise. -- Duke

April 28, 2011

bg_color question

by dukeofperl＠ml1.net

Hey ... I've set: allow_white_bg=NO #let's see if red does show up bg_color=0xff0000 in ~/.dillo/dillorc I don't see no red anywhere - not that I want it ;) Just for debugging. Turning off white, gives me a "yellowish" bg, but I thought that setting bg_color would give me _anything but white_. Doesn't seem to be how it works. What am I missing? -- Duke

April 28, 2011

No probs - Dillo & Xubuntu 11.04

by dukeofperl＠ml1.net

Hey ... FYI Just got finished an "automatic" upgrade to Xubuntu 11.04! Dillo still works great! So anybody on Ubuntu et al, don't be shy. :) -- Duke

April 28, 2011

1.3 port

by thomas-forum＠orgis.org

Am Wed, 27 Apr 2011 16:07:37 -0300 schrieb Jorge Arellano Cid <jcid(a)dillo.org>: > Hereafter the default for close tab/window is ctrl-w. > > For those that have Ctrl-q hardwired in the brain, just: > > $ echo "<Ctrl>q = close-tab" >> ~/.dillo/keysrc Hey, thanks. I hope other users don't mind the changed default. Now... I guess it's really time to get around and add dillo 1.3 to my distro. I'll have to add fltk 1.3 first, though. Alrighty then, Thomas.

April 28, 2011

Settings Seg-fault

by dukeofperl＠ml1.net

On Wed, 27 Apr 2011, Jorge Arellano Cid wrote: > On Wed, Apr 27, 2011 at 08:35:36PM +0000, corvid wrote: > > I wrote: > > > Rob wrote: > > > > BTW, building the latest 1.3 version with -O0 makes the segfault disappear. > > > > > > Ah! I can reproduce this now with -O2. I'll see what's going on... > > I can also reproduce it with -O2. > > > Does the attached fix it for you? > > > diff -r 165b50e3f996 src/menu.cc > > --- a/src/menu.cc Wed Apr 27 19:56:21 2011 +0000 > > +++ b/src/menu.cc Wed Apr 27 20:34:25 2011 +0000 > > @@ -671,6 +671,7 @@ > > FL_MENU_RADIO|FL_MENU_DIVIDER,0,0,0,0}, > > {"small icons", 0,Menu_panel_change_cb,(void*)10, > > FL_MENU_TOGGLE,0,0,0,0}, > > + {0,0,0,0,0,0,0,0,0}, > > {0,0,0,0,0,0,0,0,0} > > }; > > > > Yes it does! Patch applied! and all is well. Thank you everyone! Niiice browser! -- Duke

April 28, 2011