- Dillo-dev - lists.mailman3.com

--local, reload, repush

by eocene＠gmx.com

BTW, when I was checking --local, I noticed that it will start to request images and stuff upon reload as expected, but then when there's a repush, SpamSafe is on again.

Nov. 27, 2014

what's currently broken in dillo

by eocene＠gmx.com

Jorge wrote: > On Thu, Nov 27, 2014 at 04:41:41PM +0000, eocene wrote: > > Seems to be working. Changes pushed. > > I'm guessing that 'hg update 3.0.4.1' may be necessary for you to switch from > > the 'default' branch after pulling. > > Can you push changeset: 3976:d6a45d54f49a to the default branch too? > (I don't know how to do it without making a new patch). Do you mean have a changeset be part of multiple branches? I don't think that can be done. My impression is that merging after we finish the branch won't be anything more than: hg update default hg merge 3.0.4.1 (and I see that hg commit comes with a '--close-branch' that people use when they're irritated by having too many old branches visible in hg branches, which doesn't sound like a problem for us at present)

Nov. 27, 2014

what's currently broken in dillo

by jcid＠dillo.org

On Thu, Nov 27, 2014 at 04:41:41PM +0000, eocene wrote: > Jorge wrote: > > On Tue, Nov 25, 2014 at 08:14:45PM +0000, eocene wrote: > > > After doing all of that just now, I was giving a little methodical testing > > > before pushing my changes, and I found that there's still a bug in the focus > > > fix. > > > > > > If the page has focus, and the cursor leaves the page and returns to it, it > > > seems to be fine. > > > If an input has focus, and the cursor leaves the page and returns to it, it > > > seems to be fine. > > > If an input has focus and you click on the page to give it focus instead, > > > and then the cursor leaves the page and returns to it, the input is given > > > focus instead. > > > > Right! > > > > Please try this patch: > > Seems to be working. Changes pushed. > I'm guessing that 'hg update 3.0.4.1' may be necessary for you to switch from > the 'default' branch after pulling. Can you push changeset: 3976:d6a45d54f49a to the default branch too? (I don't know how to do it without making a new patch). -- Cheers Jorge.-

Nov. 27, 2014

what's currently broken in dillo

by eocene＠gmx.com

Jorge wrote: > On Tue, Nov 25, 2014 at 08:14:45PM +0000, eocene wrote: > > After doing all of that just now, I was giving a little methodical testing > > before pushing my changes, and I found that there's still a bug in the focus > > fix. > > > > If the page has focus, and the cursor leaves the page and returns to it, it > > seems to be fine. > > If an input has focus, and the cursor leaves the page and returns to it, it > > seems to be fine. > > If an input has focus and you click on the page to give it focus instead, > > and then the cursor leaves the page and returns to it, the input is given > > focus instead. > > Right! > > Please try this patch: Seems to be working. Changes pushed. I'm guessing that 'hg update 3.0.4.1' may be necessary for you to switch from the 'default' branch after pulling.

Nov. 27, 2014

what's currently broken in dillo

by jcid＠dillo.org

On Tue, Nov 25, 2014 at 08:14:45PM +0000, eocene wrote: > I wrote: > > Jorge wrote: > > > On Wed, Nov 19, 2014 at 08:16:20PM +0000, eocene wrote: > > > > Jorge wrote: > > > > > I'd pack a 3.0.4.1 with the fix for FLTK-1.3.3. > > > > > > > > Looking at ChangeLog, I'd argue that if we're making any release, we > > > > should also have > > > > > > > > - Don't load background images in --local mode. > > > > > > > > and probably > > > > > > > > - Fix Makefile to pick up LIBJPEG_CPPFLAGS. > > > > > > > > and perhaps > > > > > > > > - Remove Fl_Printer stub that always gave problems compiling under OSX. > > > > > > +1 > > > > It looks like I'll be semi-busy through Monday or so, but if no one > > else feels like doing it, I'll look into creating a branch, committing > > changes, version number, splash verbiage, etc.... > > After doing all of that just now, I was giving a little methodical testing > before pushing my changes, and I found that there's still a bug in the focus > fix. > > If the page has focus, and the cursor leaves the page and returns to it, it > seems to be fine. > If an input has focus, and the cursor leaves the page and returns to it, it > seems to be fine. > If an input has focus and you click on the page to give it focus instead, > and then the cursor leaves the page and returns to it, the input is given > focus instead. Right! Please try this patch: diff -r fb02b8b26017 dw/fltkviewbase.cc --- a/dw/fltkviewbase.cc Fri Nov 21 21:58:27 2014 +0100 +++ b/dw/fltkviewbase.cc Thu Nov 27 10:10:22 2014 -0300 @@ -365,6 +365,8 @@ int FltkViewBase::handle (int event) // FLTK delivers UNFOCUS to the previously focused widget if (find(Fl::focus()) < children()) focused_child = Fl::focus(); // remember the focused child! + else if (Fl::focus() == this) + focused_child = NULL; // no focused child this time return 0; case FL_KEYBOARD: if (Fl::event_key() == FL_Tab) -- Cheers Jorge.-

Nov. 27, 2014

what's currently broken in dillo

by eocene＠gmx.com

I wrote: > Jorge wrote: > > On Wed, Nov 19, 2014 at 08:16:20PM +0000, eocene wrote: > > > Jorge wrote: > > > > I'd pack a 3.0.4.1 with the fix for FLTK-1.3.3. > > > > > > Looking at ChangeLog, I'd argue that if we're making any release, we > > > should also have > > > > > > - Don't load background images in --local mode. > > > > > > and probably > > > > > > - Fix Makefile to pick up LIBJPEG_CPPFLAGS. > > > > > > and perhaps > > > > > > - Remove Fl_Printer stub that always gave problems compiling under OSX. > > > > +1 > > It looks like I'll be semi-busy through Monday or so, but if no one > else feels like doing it, I'll look into creating a branch, committing > changes, version number, splash verbiage, etc.... After doing all of that just now, I was giving a little methodical testing before pushing my changes, and I found that there's still a bug in the focus fix. If the page has focus, and the cursor leaves the page and returns to it, it seems to be fine. If an input has focus, and the cursor leaves the page and returns to it, it seems to be fine. If an input has focus and you click on the page to give it focus instead, and then the cursor leaves the page and returns to it, the input is given focus instead. PS I was mistaken when I thought "Fix Makefile to pick up LIBJPEG_CPPFLAGS" related to a bug that made it into a release. The bug actually came from the float code that was merged in.

Nov. 25, 2014

what's currently broken in dillo

by eocene＠gmx.com

Jorge wrote: > On Wed, Nov 19, 2014 at 08:16:20PM +0000, eocene wrote: > > Jorge wrote: > > > I'd pack a 3.0.4.1 with the fix for FLTK-1.3.3. > > > > Looking at ChangeLog, I'd argue that if we're making any release, we > > should also have > > > > - Don't load background images in --local mode. > > > > and probably > > > > - Fix Makefile to pick up LIBJPEG_CPPFLAGS. > > > > and perhaps > > > > - Remove Fl_Printer stub that always gave problems compiling under OSX. > > +1 It looks like I'll be semi-busy through Monday or so, but if no one else feels like doing it, I'll look into creating a branch, committing changes, version number, splash verbiage, etc....

Nov. 21, 2014

Todo "dpid_idle_timeout variable to dpidrc" and config parsing generally

by james.from.wellington＠gmail.com

Hello all, In dpid/dpid.c at about line 204, there is a todo, that dpid_idle_timeout should be configurable. I looked at how to do this sympathetically with the existing code and blocked, because the configuration file is: - having its location calculated - being opened - being scanned into heap memory several times in the existing code. My over-response is to write a library to: - private memory-map it - parse it into a linked-list in the comments in the file and - have everyone who traversed the file now traverse the linked-list On the way, we get new functionality: - the ability to record the use of a configuration item - the ability to report on unused configuration items -- which are interesting because they're probably typos Parsing dillorc with the default options uncommented, this approach is about 4* faster than the existing approach. I think that it will also have a smaller VM footprint, because we are already paying for cooked disk buffers for the same amount of file, more times. The diff is 1400 lines, so I don't expect instant rejoicing :-) The attached file contains my test-cases, shell scripts to generate some of them, that are tricky, and the diff which inserts the code into revision b185e43. Regards, James.

Nov. 21, 2014

what's currently broken in dillo

by jcid＠dillo.org

On Wed, Nov 19, 2014 at 08:16:20PM +0000, eocene wrote: > Jorge wrote: > > I'd pack a 3.0.4.1 with the fix for FLTK-1.3.3. > > Looking at ChangeLog, I'd argue that if we're making any release, we > should also have > > - Don't load background images in --local mode. > > and probably > > - Fix Makefile to pick up LIBJPEG_CPPFLAGS. > > and perhaps > > - Remove Fl_Printer stub that always gave problems compiling under OSX. +1 -- Cheers Jorge.-

Nov. 19, 2014

what's currently broken in dillo

by eocene＠gmx.com

Jorge wrote: > I'd pack a 3.0.4.1 with the fix for FLTK-1.3.3. Looking at ChangeLog, I'd argue that if we're making any release, we should also have - Don't load background images in --local mode. and probably - Fix Makefile to pick up LIBJPEG_CPPFLAGS. and perhaps - Remove Fl_Printer stub that always gave problems compiling under OSX.

Nov. 19, 2014