- Dillo-dev - lists.mailman3.com

Re: [Dillo-dev] [PATCH] Better-looking and -behaving message window

by Stephen Lewis

On Thu, 3 Apr 2003 15:29:51 -0800 Chris Palmer <chris(a)nodewarrior.org> wrote: > To see this message window in action, apply the patch to cache.c, > below. Rather than have cache.c set the status bar label, I pop up a > message window. I think users might not notice the status bar, and > wonder why Dillo didn't respond when they tried to visit (e.g.) an FTP > URL. IMHO it's better as it is - while the status bar might not be noticed, popping up a message window is extremely intrusive. My own preference for failure notification in a web browser is the sort of thing you get if you're using a proxy server - a web page telling you when, and what went wrong, and giving you the URI you were working on. -- Stephen Lewis slewis(a)paradise.net.nz

April 4, 2003

Fix for bug 330 ("URL box should get input focus")

by Chris Palmer

Hello, To cause the location box to get focus when a new window is created and after a URL is loaded, add this line gtk_widget_grab_focus(bw->location); to the end of the functions a_Interface_entry_open_url (last thing) and a_Interface_browser_window_new (just before the return statement at the end). -- Chris music is what numbers feel like San Francisco, CA

April 4, 2003

Re: [Dillo-dev] Suggestion

by Victor Sahlstedt

On Thu, 3 Apr 2003 14:48:24 -0800 Chris Palmer <chris(a)nodewarrior.org> wrote: > I disagree, because users should not have to learn the meaning of new > icons all the time. The fewer sets of icons there are, the easier Dillo > will be for non-expert users to learn. I find the meaning of Dillo's icons pretty obvious but sure; they could be a bit more self-explicative (especially the bookmarks-icon). Still, it's not reason enough to just use the looks of another well-known browser (e.g. Ximian). Again, Dillo should have a personality of it's own which includes - among other things - a custom look (and with that icons). I'm repeating myself but i'd really prefer a set of new, self-explicative icons with a Dillo'ish touch. - Victor

April 3, 2003

[PATCH] Better-looking and -behaving message window

by Chris Palmer

Hello, Rather than give it in diff -pru form, here is a new a_Interface_message_window function. I am giving it to you like this because it's easier for me (and probably you) -- my interface.c is extremely hacked right now. This function resembles the old one but is re-organized, has more comments, and produces a prettier message window. The OK button stays the same size no matter how big the window is, which I think is important. To see this message window in action, apply the patch to cache.c, below. Rather than have cache.c set the status bar label, I pop up a message window. I think users might not notice the status bar, and wonder why Dillo didn't respond when they tried to visit (e.g.) an FTP URL. Like all of what I've sent so far, these modifications affect the overall "polish" of Dillo -- its appearance and the organization of the code. If these are not wanted (my first two patches were ignored), please let me know why. Thanks. === /* * A general-purpose message window. */ void a_Interface_message_window(const char *title, const char *format, ... ) { GtkAccelGroup *accel_group; GtkWidget *window, *label, *button, *vbox, *hbox; static char msg[1024]; va_list argp; va_start(argp, format); vsnprintf(msg, 1024, format, argp); va_end(argp); /* Create the message window. */ window = gtk_window_new(GTK_WINDOW_DIALOG); gtk_window_set_wmclass(GTK_WINDOW(window), "message_dialog", "dillo"); gtk_window_set_title(GTK_WINDOW(window), title); gtk_window_set_position(GTK_WINDOW(window), GTK_WIN_POS_CENTER); gtk_container_border_width(GTK_CONTAINER(window), 5); gtk_signal_connect_object(GTK_OBJECT(window), "delete_event", (GtkSignalFunc)gtk_widget_destroy, (void*)window); /* Create the accel_group. */ accel_group = gtk_accel_group_new(); gtk_window_add_accel_group(GTK_WINDOW(window), accel_group); /* Create the label. */ label = gtk_label_new(msg); gtk_label_set_justify(GTK_LABEL(label), GTK_JUSTIFY_FILL); gtk_misc_set_padding(GTK_MISC(label), 20, 20); /* Create the OK button and its hbox. */ button = gtk_button_new_with_label(" OK "); gtk_signal_connect_object(GTK_OBJECT(button), "clicked", (GtkSignalFunc)gtk_widget_destroy, (void*)window); gtk_widget_add_accelerator(button, "clicked", accel_group, GDK_Escape, 0, GTK_ACCEL_LOCKED); hbox = gtk_hbox_new(FALSE, 0); gtk_box_pack_end(GTK_BOX(hbox), button, FALSE, FALSE, 0); /* Create and pack the vbox to put the label and the hbox in. */ vbox = gtk_vbox_new(FALSE, 5); gtk_box_pack_start(GTK_BOX(vbox), label, TRUE, TRUE, 0); gtk_box_pack_start(GTK_BOX(vbox), hbox, FALSE, FALSE, 0); gtk_container_add(GTK_CONTAINER(window), vbox); /* Show all the widgets. */ gtk_widget_show(label); gtk_widget_show(button); gtk_widget_show(hbox); gtk_widget_show(vbox); gtk_widget_grab_focus(button); gtk_widget_show(window); } === --- cache.c Thu Apr 3 15:22:59 2003 +++ cache.c.crp Thu Apr 3 15:22:39 2003 @@ -369,7 +369,9 @@ static gint Cache_open_url(DilloWeb *Web a_Cache_ccc, BCK, cccFunct, 1, 1); a_Chain_bcb(OpStart, entry->CCCQuery, (void *)entry->Url, Web); } else { - a_Interface_msg(Web->bw, "ERROR: unsupported protocol"); + a_Interface_message_window("Protocol Not Supported", + "Protocol \"%s\" is not supported.", + Url->scheme); a_Cache_ccc(OpAbort, 1, FWD, entry->CCCQuery, NULL, NULL); ClientKey = 0; /* aborted */ } Best, -- Chris music is what numbers feel like San Francisco, CA

April 3, 2003

Re: [Dillo-dev] Suggestion

by Chris Palmer

Victor Sahlstedt writes: > Good idea. What about ./configure --with-icon-set=xyz? I thought of that, but I didn't mention it because people would expect a patch if I did. :) Frankly, Automake/Autoconf and friends scare me, and I don't want to touch them. > Dillo should resemble Dillo and not Konqueror, Netscape or XYZ. > Having that said i'd love to see new, more professional-looking icons. I disagree, because users should not have to learn the meaning of new icons all the time. The fewer sets of icons there are, the easier Dillo will be for non-expert users to learn. Maybe the Ximian icons should be used as the default, since Dillo is a Gtk application. GNOME users are likely to have seen them before. Best, -- Chris music is what numbers feel like San Francisco, CA

April 3, 2003

Re: [Dillo-dev] Suggestion

by Victor Sahlstedt

On Thu, 3 Apr 2003 13:31:13 -0800 Chris Palmer <chris(a)nodewarrior.org> wrote: > The icons available at http://dillo.auriga.wearlab.de/Icons/ are nifty. > I suggest they be shipped with Dillo, and that the INSTALL file tell > users how to use them. Good idea. What about ./configure --with-icon-set=xyz? > It might also be a good idea to replace the default icons with one of > the other sets (I like the Konqueror ones). The rest look much better, > imo. I don't care much for the default icons either but imo it isn't a good idea to replace them with the default icons of another browser. Dillo should resemble Dillo and not Konqueror, Netscape or XYZ. Having that said i'd love to see new, more professional-looking icons. - Victor

April 3, 2003

Suggestion

by Chris Palmer

Hello, The icons available at http://dillo.auriga.wearlab.de/Icons/ are nifty. I suggest they be shipped with Dillo, and that the INSTALL file tell users how to use them. It might also be a good idea to replace the default icons with one of the other sets (I like the Konqueror ones). The rest look much better, imo. Best, -- Chris music is what numbers feel like San Francisco, CA

April 3, 2003

[PATCH] Move progress indicators to the status bar

by Chris Palmer

Hello, This patch moves the progress indicator box to the status bar, where I think most users expect it. Also I think it looks better and uses screen space more effectively. Let me know if you have any trouble applying it. It's pretty simple, and it makes the code smaller (which is always good!). Best, -- Chris music is what numbers feel like San Francisco, CA

April 3, 2003

Terminology change for "full screen mode"

by Chris Palmer

Hello, I propose changing the terms used to describe the button that hides or shows the control panel. This feature is great, btw! "Full screen" means to me that when I press the button, the browser window will grow to the size of the display, and possibly hide its window manager elements (frame, title bar, buttons, et c.). It doesn't mean to me that the control panel will be hidden. In my copy of the source, I've changed the tooltips for this button to "Show controls" and "Hide controls". But also, the names of the variables and functions that are related to this button should change, for easy readability. Do people agree with me that "hide/show controls" is better than "full screen on/off"? If so, I will create and submit a patch to change the variable and function names. Best, -- Chris music is what numbers feel like San Francisco, CA

April 3, 2003

[PATCH] New patch for to use $sysconfdir for etc directory

by Patrice Mandin

Hello Dillo developpers, Here is a small patch that should end problems with dealing with the etc directory. I found this (elegant, imho) stuff in the sylpheed mail client sources. -- Patrice Mandin WWW: http://membres.lycos.fr/pmandin/ Programmeur Linux, Atari Spécialité: Développement, jeux

April 3, 2003