- Dillo-dev - lists.mailman3.com

Re: [Dillo-dev] [PATCH] Tabbed version of Dillo

by Frank de Lange

Frank de Lange wrote: > Raphael Barabas wrote: > >> On Tue, Jun 17, 2003 at 12:43:30AM +0200, Frank de Lange wrote: >> >>> You decide. >> >> >> >> i love it. it's just what i've been waiting for. >> i know, i know. tabbing should be done by the window manager. but >> until every window manager (or at least, my favorite) has implemented >> tabbing, i will enjoy this patch. browsing the web is the only thing >> where i really want tabbing anyway. >> >> oh, and i just noticed it segfaults when i middle-click a link. :) > > > Hm, yeah it does. Did not used to do that. Must have messed something up > somewhere. Well, that is why I sent the patch around of course... > > Will look into that when I am less sleepy... > > Cheers//Frank I see what has gone wrong, I missed a small piece of the patch. Will include it in a new version tomorrow... If you want to fix it by hand, just change line 257 of html.c from: - a_Commands_open_link_nw_callback(NULL, lb->dd); + a_Commands_open_link_nw_callback(NULL, lb->dd->bw); and it should work again. Sorry for the inconvenience... Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]

June 17, 2003

Re: [Dillo-dev] [PATCH] Tabbed version of Dillo, now available on geocities

by Frank de Lange

Todd Slater wrote: > On Tue, 17 Jun 2003 02:07:20 +0200 > Frank de Lange <frank(a)unternet.org> wrote: > > >>Todd Slater wrote: > > >>>This is great, Frank! How does one apply the patch? >>>Todd >> >>First, take a chicken... >> >>Well, no, skip the chicken, get the CVS version of Dillo instead (see >>the Dillo website for how to do this). Go to the base directory >>(/usr/src/dillo-cvs/dillo or something like that), and apply the patch >>using something like zcat name_of_gzipped_patch_file|patch -p1. If >>everything went allright, you now have a patched version of Dillo. >> >>So: >> get CVS version of Dillo >> get patch >> cd /to/where/you/put/dillo >> zcat /where/you/put/dillo-20030615-tabs.patch.gz | patch -p1 >> >> ./autogen.sh (this rebuilds the auto*tools files) >> ./configure (with the usual options like --prefix=, etc) >> (if you want to DISABLE tabs, use --disable-tabs after configure) >> make >> su -c 'make uninstall && make install' >> >>But, err, you already knew that, or you would not be subscribed to a >>developers list, right? >> >>It is late, I should sleep now. >> >>Go'Natt//Frank > > > I was looking forward to the chicken! > > I thought that's what I was supposed to do; however, I get this: > > [todd@clevername dillo]$ zcat ../dillo-20030615-tabs.patch.gz | patch > -p1 > patching file ChangeLog > can't find file to patch at input line 21 > Perhaps you used the wrong -p or --strip option? > The text leading up to this was: > -------------------------- > |diff -pruN dillo/configure dillot/configure > |--- dillo/configure 2003-05-26 14:08:02.000000000 +0200 > |+++ dillot/configure 2003-06-13 19:38:12.000000000 +0200 > -------------------------- > File to patch: > > Do I need to specify the file, or is something else wrong? > > BTW, I'm in the dillo directory when I do this, not the src directory. > Correct? > > Sorry for being such a bonehead! > > Todd You need to run ./autogen.sh on the CVS version of Dillo first (this creates the configure file, and other files), or just skip this file (and the others it might complain about). I might remove the 'generated' files from the next version of the patch - which will result in people asking why they do not get the new configure options (because they forgot to run ./autogen.sh after applying the patch...) Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]

June 17, 2003

Re: [Dillo-dev] [PATCH] Tabbed version of Dillo

by Frank de Lange

Raphael Barabas wrote: > On Tue, Jun 17, 2003 at 12:43:30AM +0200, Frank de Lange wrote: > >>You decide. > > > i love it. it's just what i've been waiting for. > > i know, i know. tabbing should be done by the window manager. but > until every window manager (or at least, my favorite) has implemented > tabbing, i will enjoy this patch. browsing the web is the only thing > where i really want tabbing anyway. > > oh, and i just noticed it segfaults when i middle-click a link. :) Hm, yeah it does. Did not used to do that. Must have messed something up somewhere. Well, that is why I sent the patch around of course... Will look into that when I am less sleepy... Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]

June 17, 2003

Re: [Dillo-dev] [PATCH] Tabbed version of Dillo

by Raphael Barabas

On Tue, Jun 17, 2003 at 12:43:30AM +0200, Frank de Lange wrote: > You decide. i love it. it's just what i've been waiting for. i know, i know. tabbing should be done by the window manager. but until every window manager (or at least, my favorite) has implemented tabbing, i will enjoy this patch. browsing the web is the only thing where i really want tabbing anyway. oh, and i just noticed it segfaults when i middle-click a link. :) thanks, raphael

June 17, 2003

Tabbed version of Dillo, remarks

by Frank de Lange

One last thing before I go to sleep... As already stated in the documentation (doc/DilloDoc.txt, but who reads documentation anyway?), the tabbed version of Dillo sometimes (to be specific, when loading a tab in the background) produces Gdk_CRITICAL messages on stderr. Like these: Gdk-CRITICAL **: file gdkwindow.c: line 1274 (gdk_window_set_cursor): assertion `window != NULL' failed. These messages come from deep within dw_widget (line 706), and seem to be caused by an error/a bug in the widget. What seems to happen is that the widget tries to reset the cursor for a non-existing window (gdk_window_set_cursor (GTK_LAYOUT(viewport)->bin_window, NULL while the viewport does not yes have a bin_window defined). Sebastian, any input on this? Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]

June 17, 2003

Re: [Dillo-dev] [PATCH] Tabbed version of Dillo, now available on geocities

by Frank de Lange

Todd Slater wrote: > On Tue, 17 Jun 2003 01:21:34 +0200 > Frank de Lange <frank(a)unternet.org> wrote: > > >>Hiya! >> >>I put my patch for a tabbed version of Dillo on a geocities page, so >>if you are quick you might be able to download it before Yahoo? shuts >>it down because the site has exceeded its puny transfer allowance. >> >>Get it here: >> >>http://www.geocities.com/ikbenfrank/dillo-20030615-tabs.patch.gz >> >>md5sum: dae3cc4bb8c6c31050abaf8013a7e973 >> >>As said, this patch applies to today's (well, yesterday's) CVS version >>of Dillo. >> >>Good Luck//Frank > > > This is great, Frank! How does one apply the patch? > Todd > > _______________________________________________ > Dillo-dev mailing list > Dillo-dev(a)lists.auriga.wearlab.de > http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev First, take a chicken... Well, no, skip the chicken, get the CVS version of Dillo instead (see the Dillo website for how to do this). Go to the base directory (/usr/src/dillo-cvs/dillo or something like that), and apply the patch using something like zcat name_of_gzipped_patch_file|patch -p1. If everything went allright, you now have a patched version of Dillo. So: get CVS version of Dillo get patch cd /to/where/you/put/dillo zcat /where/you/put/dillo-20030615-tabs.patch.gz | patch -p1 ./autogen.sh (this rebuilds the auto*tools files) ./configure (with the usual options like --prefix=, etc) (if you want to DISABLE tabs, use --disable-tabs after configure) make su -c 'make uninstall && make install' But, err, you already knew that, or you would not be subscribed to a developers list, right? It is late, I should sleep now. Go'Natt//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]

June 17, 2003

Re: [Dillo-dev] [PATCH] Tabbed version of Dillo, now available on geocities

by Todd Slater

On Tue, 17 Jun 2003 01:21:34 +0200 Frank de Lange <frank(a)unternet.org> wrote: > Hiya! > > I put my patch for a tabbed version of Dillo on a geocities page, so > if you are quick you might be able to download it before Yahoo? shuts > it down because the site has exceeded its puny transfer allowance. > > Get it here: > > http://www.geocities.com/ikbenfrank/dillo-20030615-tabs.patch.gz > > md5sum: dae3cc4bb8c6c31050abaf8013a7e973 > > As said, this patch applies to today's (well, yesterday's) CVS version > of Dillo. > > Good Luck//Frank This is great, Frank! How does one apply the patch? Todd

June 16, 2003

[PATCH] Tabbed version of Dillo, now available on geocities

by Frank de Lange

Hiya! I put my patch for a tabbed version of Dillo on a geocities page, so if you are quick you might be able to download it before Yahoo? shuts it down because the site has exceeded its puny transfer allowance. Get it here: http://www.geocities.com/ikbenfrank/dillo-20030615-tabs.patch.gz md5sum: dae3cc4bb8c6c31050abaf8013a7e973 As said, this patch applies to today's (well, yesterday's) CVS version of Dillo. Good Luck//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]

June 16, 2003

[PATCH] Tabbed version of Dillo

by Frank de Lange

FYI As promised, I now have a patch ready which implements tabbed browsing. The patch is quite big (173586 bytes, 42305 gzipped), so I think it is not a good idea to send it to the mailing list. As I currently do not have a webserver handy I can not put it on my site like I used to do when times were good and broadband was available (1-0 for The Netherlands - Sweden). Why is the patch so big? Well, it touches many files (37 source and header files, 6 other files) in Dillo, as it moves around some code and adds some more. The moving around is mostly due to the fact that, to implement tabs, I had to split 'document' from 'interface' logic in Dillo. In the current (non-patched) version of Dillo, the 'document' (everything related to a single browsing session in a single window) code is spread out over several files (interface.c, nav.c, web.c, html.c, plain.c, etc...). For tabs (and, later, frames) this does not work well, since a single browser window can contain several individual browsing sessions (tabs, frames (when implemented)). I solved this by putting all document-related stuff in a new abstraction, the 'DilloDoc' (defined in browser.h). DilloDoc contains the document-related stuff from BrowserWindow, progress data and document state info (the 'ready' bit) and - currently - the document-specific widgets (docwin, pagemark menu). Tab-specific stuff can be found in src/tab.c|h. As I know that not everybody wants to have tab functionality in the browser - it can also be implemented at the window manager level - I made the tabbed feature optional. To compile Dillo without tabs, use the --disable-tabs option, and there will be no tab-specific code in your binary. I did some tests with regard to 'code bloat' on the current, new (tabs disabled) en new (tabs enabled) versions of Dillo, which show a binary code size increase of about 7500 bytes for the tab feature. This is not to bad I think. The results of these tests can be found in the doc/Browser_Tabs.txt document (which comes with the patch). So, list, tell me what to do... Do you want your mailboxes to overflow, shall I send the patch to a select few, shall I wrap it in tar paper and bury it? I have already sent it to Jorge and the individuals who expressed interest in having a look at it, but I have had several requests from people on the list to send the patch to the list as well. As I have only a puny modem line here in Sweden, I do not relish the prospect of having to send the patch to loads of individuals. You decide. Oh, and I will be off-line between the 23d of june and the 13th of juli, so please let me know beforehand... Also, as the patch is against today's CVS version of Dillo, it has a relatively short shelf life. So, let me know, or (Jorge) apply it to CVS so others can have a go at it. Go'natt//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]

June 16, 2003

Suggestion for a next dillo version

by Manuel Serrano

Hello there, first of all, many thanks for making Dillo available. I'm using it on a daily basis. It does almost anything I want of my web browser (nearly may be CSS2 but this is not the purpose of this mail :-). I like the new feature of 0.7.2 that enables to hide the navigation bar. I was wondering if it could be possible to have an automatic hidden bar such as in many window manager (fluxbox, kde, gnone, ...). That is the navigation bar is automatically hidden until the mouse fly over the very top lines. If the mouse fly over these lines, it automatically appears... Do you think that it would be difficult to implement this feature in a coming version? Many thanks in advance and one more time, thanks for making Dillo available. -- Manuel

June 16, 2003