- Dillo-dev - lists.mailman3.com

Re: [Dillo-dev] Re: Keybd 3 patch

by Frank de Lange

Paul Pelzl wrote: >On Tue, Nov 11, 2003 at 02:58:43PM +0100, Frank de Lange wrote: > > >>[ LIST: please give keyboard navigation, on either version of the >>patch, a workout. This needs some testing if it is to be part of >>mainstream Dillo. Try it in frame sites, try navigatin between frames >>with Tab/Shift-Tab, try the keyboard bindings, etc. ] >> >> > >With tab/frame/keynav patch v14, I've been able to get segfaults pretty >easily just by moving between links. Here are some sample sites: > >http://memepool.com (there is a long link on the current page that causes problems) > > Fixed, was caused by Dw_page_construct_iterator() always returning iterators with mask=DW_CONTENT_ALL. This caused links which contain breaks (<br>) to segfault. I changed Dw_page_construct_iterator() to allow the caller to set a mask. >http://notlong.com/links/ (the links in the table appear to be problematic) > > I see what you mean, but this is not that easy to fix. Links are sorted on y.x order using the coordinates for the first word in the link. If you look at the table, you'll notice that 'makeashorterlink.com' starts half a line above all the other links in the table row, while 'ek.dk' starts half a line after the others. This causes those links to appear in this order: makeashorterlink (link DOWN)-> one of the links to the left of it (link DOWN)-> ek.dk I'll see if I can find a simple solution to this problem (use a median coordinate? use a coordinate range?), but I do not think this will be fixed in the next patch. >http://cruel.com (a link about halfway down the current page) > > Same problem as memepool.com, fixed >http://vikings.com (one of the first links in the main frame) > > Same problem as memepool.com, fixed >Also, here is an example of a site where the algorithm for determining >the direction of the next link breaks down: > http://linkfilter.net >At the end of each post there are a set of icons which get selected in >a non-intuitive order. > > More or less the same problem as notlong.com, but a slighly different cause. The author of the page did not use width/height tags on one of the icon links (the Stats link), this makes Dillo render the links's alt-text half a line lower. This causes the link shuffle effect you noticed. I might be able to fix this one though by adding another focusable_allocate for images. Might be fixed in next patch. Thanks fo the feedback... Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]

Nov. 12, 2003

Re: [Dillo-dev] Re: Keybd 3 patch

by Andreas Schweitzer

Hi > [ LIST: please give keyboard navigation, on either version of the > patch, a workout. This needs some testing if it is to be part of > mainstream Dillo. Try it in frame sites, try navigatin between frames > with Tab/Shift-Tab, try the keyboard bindings, etc. ] Here comes a bit of feedback. I haven't found anything new (only cut-n-paste and the history) but only some user issues : - I know this has been discussed before, but the use of Ctrl-Shift-L versus Ctrl-L confuses me almost every time I want to enter a URL manually. I slowly get used to it - damn old habits :-) ... but my point is : how many other users will be confused by this ? Eventually, this will not matter, because all shortcuts can be customized, IIRC. - One thing I love about dillo is/was that it did not open up new windows when the author deemed it necesarry. Now, on some stupid pages I get window after window, just because the author does know nothing about good web design. I realize that it's the strict adherence to the _blank target. I read on the HTML Standard, and I found two points : - they are all "should" rules (6.16). The client should do this and that. - in the Target semantics (16.3.2) the standard allows for the client to override the target. so, IMHO, I would treat _blank (and probably every unknown target) just like _top, unless the user allows dillo via a preference option (in fact I already did this in my personal version of the frames version ;-) ...). This is the same argument as above : keep the current behaviour. Oh, and since I use the same argument twice : I am not saying that new behaviour is bad, just that thinking about keeping the old does not hurt either. Otherwise : so many more pages work now much more pleasantly with the frames support : thanks ! :) Cheers, Andreas -- **************************** NEW ADDRESS ****************************** Hamburger Sternwarte Universitaet Hamburg Gojenbergsweg 112 Tel. ++49 40 42891 4016 D-21029 Hamburg, Germany Fax. ++49 40 42891 4198

Nov. 12, 2003

[PATCH] cleanup of URL_ILLEGAL_CHARS

by Frank de Lange

Jorge, Skip that last patch I sent you, here is a new one which also touches html.c... Please apply ASAP... Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ] diff -pruN dillo/src/html.c dillo_patched/src/html.c --- dillo/src/html.c 2003-11-11 21:45:01.947370344 +0100 +++ dillo_patched/src/html.c 2003-11-12 09:01:46.119597904 +0100 @@ -152,7 +152,7 @@ static DilloUrl *Html_url_new(DilloHtml url_str, (use_base_url) ? base_url : URL_STR_(html->linkblock->base_url), flags, pos); - if ((n_ic = URL_ILLEGAL_CHARS(url)) != 0) + if ((n_ic = URL_ILLEGAL_CHARS_(url)) != 0) MSG_HTML("URL has %d illegal character%s (00-1F, 7F or space)\n", n_ic, (n_ic) > 1 ? "s" : ""); return url; diff -pruN dillo/src/url.h dillo_patched/src/url.h --- dillo/src/url.h 2003-11-11 21:45:02.153339032 +0100 +++ dillo_patched/src/url.h 2003-11-12 08:16:28.038808992 +0100 @@ -57,7 +57,7 @@ #define URL_ALT_(u) u->alt #define URL_POS_(u) u->scrolling_position #define URL_STR_(u) a_Url_str(u) -#define URL_ILLEGAL_CHARS(u) url->illegal_chars +#define URL_ILLEGAL_CHARS_(u) url->illegal_chars /* * Access methods that always return a string: @@ -77,7 +77,7 @@ #define URL_ALT(u) NPTR2STR(URL_ALT_(u)) #define URL_POS(u) URL_POS_(u) #define URL_STR(u) NPTR2STR(URL_STR_(u)) - +#define URL_ILLEGAL_CHARS(u) NPTR2STR(URL_ILLEGAL_CHARS_(u)) /* URL-camp compare methods */

Nov. 12, 2003

Re: [Dillo-dev] [RFC] Quo Vadis Dillo

by Frank de Lange

Paul Pelzl wrote: >On Tue, Nov 11, 2003 at 03:05:17PM +0100, Frank de Lange wrote: > >>Talking about my patch, what does need improvement? >>Some ideas: >>- select contents of location bar/search field when they are focused >> (DONE, in next version) >> > >Heh, I made that change myself about six months ago. > Hm, you should have shared your patch then, ey? I use hooks to grab-focus (->select all) and focus-out-event (->deselect all). What was your solution? >Using the location bar is nice, but I think the Mozilla Firebird >approach presents a more consistent interface. It has a separate >(small) search box to the right of the location bar. Ctrl-L takes you >to the location bar, Ctrl-K takes you to the search bar. > I use Phoenixbird as well (for those few pages which Dillo does not handle good enough). I think the search bar has both advantages and disadvantages. Advantage is that is is a more consistent user interface, disadvantage is that it is small. I'm also not that keen on the combination of page and web search in one dialog: even though they are both 'search' functions, they do conceptually different things. One leads to the loading of a new page, the other does not. I prefer to have the page-loading stuff (locbar, maybe web search bar) separate from non-page-loading stuff. I also think that having a special search bar just for web search is a bit of a waste of screen real estate. The location bar is big enough for even complex search terms, it is always there (will make it popup when pressing CTRL-L in full-screen mode for next patch, just like the search/status bar does now when popup_dialogs=NO). So, I'm not that sure about Firebird's search box. Anyone care to comment on this? >>- more key bindings (replacing current key handling where applicable) >>- remove compile options for tabs and frames, make tabs/frames standard? >> [ PDA/embedded developers: is this OK with you? ] >>- ??? >> > - i-search support within the "View Source" window would be helpful. > The whole 'View Source' window needs an overhaul. Best thing to do would be to implement a (sane, no 'notepad popup spam' like Microsoft products manage to produce) version of the 'view-source' protocol, so source is viewed in a normal window/tab/frame/... That way you get all facilities, for 'free'. This can be implemented in many ways, as a plugin (but I'm not that keen on plugins as they are implemented now...), in the current code, as a dlopen() library (not there yet...), etc. Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]

Nov. 12, 2003

Re: [Dillo-dev] Re: Keybd 3 patch

by Frank de Lange

Paul Pelzl wrote: > With tab/frame/keynav patch v14, I've been able to get segfaults pretty > >easily just by moving between links. Here are some sample sites: > >http://memepool.com (there is a long link on the current page that causes problems) >http://notlong.com/links/ (the links in the table appear to be problematic) >http://cruel.com (a link about halfway down the current page) >http://vikings.com (one of the first links in the main frame) > >Also, here is an example of a site where the algorithm for determining >the direction of the next link breaks down: > http://linkfilter.net >At the end of each post there are a set of icons which get selected in >a non-intuitive order. > >Paul > > I'll look into these problems... Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]

Nov. 12, 2003

Re: [Dillo-dev] HTTPS Patch

by Frank de Lange

Patrick Shanahan wrote: > Ok, I'm knock-kneed, back-handed and generally challenged. The ssl > >patch will work against the cvs from 11-11, but not from 11-10 (thats >month-day) and the tabs patch will work against 11-10 and not 11-11. > >Kind of a quandary, eh.... > > Sigh... I'll put out a new version of my patches RSN.. I have also found a small error in Jorge's patch to url.h, so I'll try to get that committed to CVS before I produce my patch set - otherwise you'll get yet another reject once CVS is updated. Jorge, please apply the attached patch to CVS ASAP, so it does not cause rejects with my forthcoming patches... It fixes the error in the macro definition for URL_ILLEGAL_CHARS(u) and adds the missing URL_ILLEGAL_CHARS_(u). Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ] --- dillo/src/url.h 2003-11-11 21:45:02.153339032 +0100 +++ dillo_patched/src/url.h 2003-11-12 08:16:28.038808992 +0100 @@ -57,7 +57,7 @@ #define URL_ALT_(u) u->alt #define URL_POS_(u) u->scrolling_position #define URL_STR_(u) a_Url_str(u) -#define URL_ILLEGAL_CHARS(u) url->illegal_chars +#define URL_ILLEGAL_CHARS_(u) url->illegal_chars /* * Access methods that always return a string: @@ -77,7 +77,7 @@ #define URL_ALT(u) NPTR2STR(URL_ALT_(u)) #define URL_POS(u) URL_POS_(u) #define URL_STR(u) NPTR2STR(URL_STR_(u)) - +#define URL_ILLEGAL_CHARS(u) NPTR2STR(URL_ILLEGAL_CHARS_(u)) /* URL-camp compare methods */

Nov. 12, 2003

Re: [Dillo-dev] HTTPS Patch

by Frank de Lange

Kelson Vibber wrote: > At 04:20 AM 11/11/2003, Paul Pelzl wrote: > >> Perhaps some enterprising individual (not me) would be interested in >> hosting some sort of Dillo Wiki. Any patch authors could then post >> links on the wiki without having to bother website maintainers... > > > I might be able to set something up on my site. Can anyone recommend > some good Wiki software? The lists at Freshmeat.net and Wikipedia are > extremely long, and while I'm inclined to look at MediaWiki, it looks > like it would be overkill for this purpose. I have used twiki (www.twiki.org) with great success. WIsh I had broadband here in Sweden, I would be running it now... Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]

Nov. 12, 2003

Re: [Dillo-dev] [RFC] Quo Vadis Dillo

by Paul Pelzl

On Tue, Nov 11, 2003 at 03:05:17PM +0100, Frank de Lange wrote: > Talking about my patch, what does need improvement? > Some ideas: > - select contents of location bar/search field when they are focused > (DONE, in next version) Heh, I made that change myself about six months ago. > - make the 'search the web' popup disappear when popup_dialogs=NO, > replace it with a non_popup version or use the location bar for > search (like several other browsers do) Using the location bar is nice, but I think the Mozilla Firebird approach presents a more consistent interface. It has a separate (small) search box to the right of the location bar. Ctrl-L takes you to the location bar, Ctrl-K takes you to the search bar. > - more key bindings (replacing current key handling where applicable) > - remove compile options for tabs and frames, make tabs/frames standard? > [ PDA/embedded developers: is this OK with you? ] > - ??? - i-search support within the "View Source" window would be helpful. Paul

Nov. 12, 2003

Re: [Dillo-dev] Re: Keybd 3 patch

by Paul Pelzl

On Tue, Nov 11, 2003 at 02:58:43PM +0100, Frank de Lange wrote: > [ LIST: please give keyboard navigation, on either version of the > patch, a workout. This needs some testing if it is to be part of > mainstream Dillo. Try it in frame sites, try navigatin between frames > with Tab/Shift-Tab, try the keyboard bindings, etc. ] With tab/frame/keynav patch v14, I've been able to get segfaults pretty easily just by moving between links. Here are some sample sites: http://memepool.com (there is a long link on the current page that causes problems) http://notlong.com/links/ (the links in the table appear to be problematic) http://cruel.com (a link about halfway down the current page) http://vikings.com (one of the first links in the main frame) Also, here is an example of a site where the algorithm for determining the direction of the next link breaks down: http://linkfilter.net At the end of each post there are a set of icons which get selected in a non-intuitive order. Paul

Nov. 12, 2003

Re: [Dillo-dev] HTTPS Patch

by Patrick Shanahan

* Patrick Shanahan <paka(a)MyRealBox.com> [11-11-03 21:56]: > * Indan Zupancic <indan(a)nul.nu> [11-11-03 19:28]: > > > > I updated the https patch, it should work with the current cvs now. I > > didn't change anything, it's no real update, only to keep the > > impatient happy. ;) > > > > It's a quick fix, real update will come later. > > Thanks, but: > > pat@wahoo:/dillo.cvs.1110> patch -p1 <dillo-ssl.diff > patching file configure.in > Hunk #1 succeeded at 26 with fuzz 2 (offset 2 lines). > Hunk #2 succeeded at 177 (offset 8 lines). > Hunk #3 succeeded at 225 (offset 22 lines). > patching file src/IO/IO.c > patching file src/IO/IO.h > patching file src/IO/Url.c > patching file src/IO/http.c > patching file src/capi.c > Hunk #1 FAILED at 255. > 1 out of 1 hunk FAILED -- saving rejects to file src/capi.c.rej > > pat@wahoo:/dillo.cvs.1110> cat src/capi.c.rej > *************** > *** 255,266 **** > a_Capi_dpi_send_cmd(web, web->bw, cmd, "ftp", 1); > g_free(cmd); > > } else if (g_strncasecmp(url_str, "https:/", 7) == 0 && !Call && > (a_Capi_url_read(web->url, &sz) == NULL || > (URL_FLAGS(web->url) & URL_E2EReload)) ) { > cmd = g_strdup_printf("<dpi cmd='open_url' url='%s'>", url_str); > a_Capi_dpi_send_cmd(web, web->bw, cmd, "https", 1); > g_free(cmd); > > } else { > return a_Cache_open_url(web, Call, CbData); > --- 255,268 ---- > a_Capi_dpi_send_cmd(web, web->bw, cmd, "ftp", 1); > g_free(cmd); > > + #ifndef HTTPS > } else if (g_strncasecmp(url_str, "https:/", 7) == 0 && !Call && > (a_Capi_url_read(web->url, &sz) == NULL || > (URL_FLAGS(web->url) & URL_E2EReload)) ) { > cmd = g_strdup_printf("<dpi cmd='open_url' url='%s'>", url_str); > a_Capi_dpi_send_cmd(web, web->bw, cmd, "https", 1); > g_free(cmd); > + #endif > > } else { > return a_Cache_open_url(web, Call, CbData); > > it fixes three of the four failures I rec'd. ??? > Ok, I'm knock-kneed, back-handed and generally challenged. The ssl patch will work against the cvs from 11-11, but not from 11-10 (thats month-day) and the tabs patch will work against 11-10 and not 11-11. Kind of a quandary, eh.... -- Patrick Shanahan Registered Linux User #207535 http://wahoo.no-ip.org @ http://counter.li.org

Nov. 12, 2003