- Dillo-dev - lists.mailman3.com

Re: [patch] improve scroll performance of dillo-fltk

by Matthias Franz

On Tue, Oct 09, 2007 at 08:09:48PM +0200, Johannes Hofmann wrote: > On Tue, Oct 09, 2007 at 07:29:46PM +0200, Matthias Franz wrote: > > On Tue, Oct 09, 2007 at 05:25:09PM +0200, Johannes Hofmann wrote: > > > Does it also happen, when you keep the arrow on the scrollbar > > > pressed? > > > > Yes. It happens as well when you move the scrollbar with the mouse > > (while pressing the left mouse button). > > Here it gets down to 10% idle when keeping the arrow pressed with > vanilla dillo-fltk. > With my patch it stays at 99% idle. > It might have to do with your X11 installation or Xft configuration. > Do you see antialiased fonts? I didn't have the development files for Xft installed!!! I've installed them, and now dillo-fltk uses antialiased fonts. The problem still remains, though. Heavy CPU load for scrolling or just moving the pointer across links. No difference between vanilla dillo-fltk and the patched version. Massive difference to the old dillo. -- Matthias Franz

Oct. 9, 2007

Re: character entity references produce garbage

by Matthias Franz

On Tue, Oct 09, 2007 at 09:10:09PM +0200, Johannes Hofmann wrote: > I don't see any artefacts here. I see dotted squares (which I guess means undefined characters); sometimes also other, random-looking characters come up. Looks like an off-by-one error. > Are you sure you compiled against the fltk2-tarball that Jorge > provided and not against some previously installed one? Well, pretty much. I've deleted an older version, and after linking dillo-fltk the access times of the files /usr/local/lib/libfltk2.a and /usr/local/lib/libfltk2_images.a (which have the same length as the ones in fltk-2.0.x-r5917/lib) change. -- Matthias Franz

Oct. 9, 2007

Re: [Dillo-dev] character entity references produce garbage

by Johannes Hofmann

Hi, On Tue, Oct 09, 2007 at 09:04:39PM +0200, Matthias Franz wrote: > Hi, > > I've observed that in dillo-fltk character entity references produce > garbage after the word they are contained in. Here is an example: > > <html> > <title>character entity references produce garbage</title> > no artefact > > one ärtefact > > two ärtéfacts > > three ärtéfâcts > </html> I don't see any artefacts here. Are you sure you compiled against the fltk2-tarball that Jorge provided and not against some previously installed one? > > Since I'm currently very busy with other (less interesting, but more > important) things, so I can only contribute to Dillo by reporting bugs > and testing solutions right now. I hope that this will change sometime > so that I can again write patches myself. Testing is very welcome as well! Johannes > > Cheers, > -- > Matthias Franz > > _______________________________________________ > Dillo-dev mailing list > Dillo-dev(a)dillo.org > http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev

Oct. 9, 2007

character entity references produce garbage

by Matthias Franz

Hi, I've observed that in dillo-fltk character entity references produce garbage after the word they are contained in. Here is an example: <html> <title>character entity references produce garbage</title> no artefact one ärtefact two ärtéfacts three ärtéfâcts </html> Since I'm currently very busy with other (less interesting, but more important) things, so I can only contribute to Dillo by reporting bugs and testing solutions right now. I hope that this will change sometime so that I can again write patches myself. Cheers, -- Matthias Franz

Oct. 9, 2007

Re: [Dillo-dev] Re: [patch] improve scroll performance of dillo-fltk

by Johannes Hofmann

On Tue, Oct 09, 2007 at 07:29:46PM +0200, Matthias Franz wrote: > On Tue, Oct 09, 2007 at 05:25:09PM +0200, Johannes Hofmann wrote: > > On Mon, Oct 08, 2007 at 10:23:22PM +0200, Matthias Franz wrote: > > > Fine! Only using the arrow keys is quite slow and consumes all CPU time > > > on my machine. In contrast, srolling with the old Dillo was quick and > > > produced almost no CPU load. > > > > It is slow, because the default linesize (the amount a scrollbar > > scrolls when pushing on the arrow is 1. I could change that, but > > what would be a reasonable value? > > Apart from that it should not consume all CPU time. It doesn't > > here. On which html page do you test? > > It occurs on any page where you can scroll. > > > Is it in a remote X11 session? > > no > > > It might perhaps depend on the keyboard repeat rate. > > I think my keyboard rate is normal. > > > Does it also happen, when you keep the arrow on the scrollbar > > pressed? > > Yes. It happens as well when you move the scrollbar with the mouse > (while pressing the left mouse button). Here it gets down to 10% idle when keeping the arrow pressed with vanilla dillo-fltk. With my patch it stays at 99% idle. This is on a Pentium-M forced down to 600MHz. > > Today I noticed that other features of dillo-fltk are also slower > than before. For example, I get approximately a 50% CPU load just > by moving the pointer repeatedly back and forth over a link so > that the pointer constantly changes from the "arrow" shape to the > "hand" shape and back. When I do this with the old dillo the CPU > load remains around zero. (I have an AMD Athlon prcessor running > at 660 MHz.) I don't know whether this is a problem with dillo, > fltk or just with my machine (Debian Etch). It might have to do with your X11 installation or Xft configuration. Do you see antialiased fonts? > > Do other people observe this problem as well? > > Cheers, > -- > Matthias Franz > > _______________________________________________ > Dillo-dev mailing list > Dillo-dev(a)dillo.org > http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev

Oct. 9, 2007

Re: [patch] improve scroll performance of dillo-fltk

by Matthias Franz

On Tue, Oct 09, 2007 at 05:25:09PM +0200, Johannes Hofmann wrote: > On Mon, Oct 08, 2007 at 10:23:22PM +0200, Matthias Franz wrote: > > Fine! Only using the arrow keys is quite slow and consumes all CPU time > > on my machine. In contrast, srolling with the old Dillo was quick and > > produced almost no CPU load. > > It is slow, because the default linesize (the amount a scrollbar > scrolls when pushing on the arrow is 1. I could change that, but > what would be a reasonable value? > Apart from that it should not consume all CPU time. It doesn't > here. On which html page do you test? It occurs on any page where you can scroll. > Is it in a remote X11 session? no > It might perhaps depend on the keyboard repeat rate. I think my keyboard rate is normal. > Does it also happen, when you keep the arrow on the scrollbar > pressed? Yes. It happens as well when you move the scrollbar with the mouse (while pressing the left mouse button). Today I noticed that other features of dillo-fltk are also slower than before. For example, I get approximately a 50% CPU load just by moving the pointer repeatedly back and forth over a link so that the pointer constantly changes from the "arrow" shape to the "hand" shape and back. When I do this with the old dillo the CPU load remains around zero. (I have an AMD Athlon prcessor running at 660 MHz.) I don't know whether this is a problem with dillo, fltk or just with my machine (Debian Etch). Do other people observe this problem as well? Cheers, -- Matthias Franz

Oct. 9, 2007

Re: fix for links within lists

by Matthias Franz

On Mon, Oct 08, 2007 at 09:42:53PM +0000, place wrote: > this seems to fix the problem for me: Yes, that seems to work. Thanks! -- Matthias Franz

Oct. 9, 2007

Re: [Dillo-dev] Re: [patch] improve scroll performance of dillo-fltk

by Johannes Hofmann

On Mon, Oct 08, 2007 at 10:23:22PM +0200, Matthias Franz wrote: > On Mon, Oct 08, 2007 at 08:01:14PM +0200, Johannes Hofmann wrote: > > * Hotkey bindings for arrow keys, Home- and EndKey. > > Fine! Only using the arrow keys is quite slow and consumes all CPU time > on my machine. In contrast, srolling with the old Dillo was quick and > produced almost no CPU load. It is slow, because the default linesize (the amount a scrollbar scrolls when pushing on the arrow is 1. I could change that, but what would be a reasonable value? Apart from that it should not consume all CPU time. It doesn't here. On which html page do you test? Is it in a remote X11 session? It might perhaps depend on the keyboard repeat rate. Does it also happen, when you keep the arrow on the scrollbar pressed? > > A question: Would it be difficult to add mouse wheel support as well? > On my machine that does not work. (Or is thia a configuration issue > regarding FLTK?) No it's just some missing code. Johannes > > Thanks in advance, > -- > Matthias Franz > > _______________________________________________ > Dillo-dev mailing list > Dillo-dev(a)dillo.org > http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev

Oct. 9, 2007

Re: [Dillo-dev] fix for links within lists

by place

> On Sat, Oct 06, 2007 at 02:51:50PM +0000, place wrote: > > just one line. If you add: > > > > Html_connect_signals(html, list_item); > > > > to Html_tag_open_li() > > > > (after the item_style->unref(); seemed like a nice place), > > then links inside lists will work. > > Unfortunately, I have to report this patch improves the situation > substiantially, but does not solve it completely. It seems that the > status line at the bottom is not always updated. When you move the > pointer over a link and then, without clicking, move the pointer > _upwards_ so that it leaves the link area, the link URL remains in > the status line. (Moving in other directions is ok.) Moreover, when > you move the pointer across several links, the status line sometimes > remains empty even if the pointer is over a link. > > Cheers, > -- > Matthias Franz I think when the pointer leaves by going up, it's getting enter/leave events instead of motion events, due to the link going right to the top of the textblock. I'm not positive about that, but this seems to fix the problem for me: --- textblock.cc 2007-10-08 21:27:10.000000000 +0000 +++ textblock.cc.new 2007-10-08 21:27:52.000000000 +0000 @@ -483,10 +483,12 @@ void Textblock::enterNotifyImpl (core::EventCrossing *event) { + hoverLink = -1; } void Textblock::leaveNotifyImpl (core::EventCrossing *event) { + (void) emitLinkEnter (-1, -1, -1); } /**

Oct. 8, 2007

Re: [patch] improve scroll performance of dillo-fltk

by Matthias Franz

On Mon, Oct 08, 2007 at 08:01:14PM +0200, Johannes Hofmann wrote: > * Hotkey bindings for arrow keys, Home- and EndKey. Fine! Only using the arrow keys is quite slow and consumes all CPU time on my machine. In contrast, srolling with the old Dillo was quick and produced almost no CPU load. A question: Would it be difficult to add mouse wheel support as well? On my machine that does not work. (Or is thia a configuration issue regarding FLTK?) Thanks in advance, -- Matthias Franz

Oct. 8, 2007