- Dillo-dev - lists.mailman3.com

Re: patch: images: working menu, deferred loading; page menu works

by jcid＠dillo.org

On Thu, Nov 01, 2007 at 04:53:48PM +0000, place wrote: > > Note that with the current patch, images that are also links > > are not working (i.e. clicking on them loads the image but > > doesn't follow the link). I understand that left-clicking to load > > an image is quite handy. Now, FLTK2 has a nice feature with > > popups and it's that they can remember a menuitem position. If we > > make the right click popup remember the "load image" item, the > > same easeness of user interface may be attained (you may look in > > the test/menu program inside fltk2 sources). > > Oops! Images that are links work in my personal tree, but I overlooked > in when making the patch... The first click loads the image, and subsequent > ones follow the link. > > Are you saying that you would prefer that it be moved to the menu anyway? > I've been using left click to load for years now, and I would find > it significantly less convenient to use the menu for every image... The point is that it may be handy to follow an image-link without loading the image (I'm not sure how useful though). The idea is to try how does it work with the right-click-popup + item preselection. This is you right click (don't move the mouse), and the "load image" item is right there, and thus you can just right-click to load an image and also right click + move mouse for other options. If this is not as useful as the former, we can go back (or make it a preference), but I see some value in trying, because that way, the orthogonality of the UI, as a whole, is preserved. -- Cheers Jorge.-

Nov. 1, 2007

Re: patch: images: working menu, deferred loading; page menu works

by place＠gobigwest.com

> Note that with the current patch, images that are also links > are not working (i.e. clicking on them loads the image but > doesn't follow the link). I understand that left-clicking to load > an image is quite handy. Now, FLTK2 has a nice feature with > popups and it's that they can remember a menuitem position. If we > make the right click popup remember the "load image" item, the > same easeness of user interface may be attained (you may look in > the test/menu program inside fltk2 sources). Oops! Images that are links work in my personal tree, but I overlooked in when making the patch... The first click loads the image, and subsequent ones follow the link. Are you saying that you would prefer that it be moved to the menu anyway? I've been using left click to load for years now, and I would find it significantly less convenient to use the menu for every image...

Nov. 1, 2007

Re: patch: images: working menu, deferred loading; page menu works

by jcid＠dillo.org

Hi, On Mon, Oct 29, 2007 at 11:18:21PM +0000, place wrote: > (I could have sworn that I sent you a patch making the page menu work, > but since I didn't realize that it wasn't in the main tree until I > was preparing this patch, it's included here. I'll likely end > up separating it out as we go through the process of refining the rest > of this patch...) > > This has an extra argument in the link signals, as you recommended, > instead of the array of image handlers that my previous version used. > > I had to add an x_img to style. > > The link block stores the Image and the url until loading is requested. Great! I made an extensive revision of the patch and commited it with some minor changes (attached so you can review and sync more easily). Urbi et orbi, this patch set more or less is: - Added code for the image menu and hooked it to dw2 signals. - Hooked the page and link menus. - Added code for optional image loading (nice interface) very advanced! - Fixed the position of the Bug Meter popup menu. - Added an extra argument in the link signals - Aded an x_img camp to style (an image array index, like x_link). > Although there's no placeholder, if there's anything to click on, left click > loads instances of that image and middle click loads all images on the page. > The latter should probably be in the page menu instead. The patch is very advanced and here go my comments: Yes, a place holder is the next step (sometimes image size is provided as attributes in the IMG element, some others not; in which case we can use a standard size). Note that with the current patch, images that are also links are not working (i.e. clicking on them loads the image but doesn't follow the link). I understand that left-clicking to load an image is quite handy. Now, FLTK2 has a nice feature with popups and it's that they can remember a menuitem position. If we make the right click popup remember the "load image" item, the same easeness of user interface may be attained (you may look in the test/menu program inside fltk2 sources). I also agree that "load all images" naturally belongs to the page menu. BTW, with regard to the toggle button, in the past I thought of a toolbox icon with a popup holding things like: "Load images" // toggle item "Force my colors" // toggle item "Restrict width" // toggle item ... It looks lilke a good idea to me, but I don't know whether in practice this is as convenient as it looks. Comments welcomed. -- Cheers Jorge.-

Nov. 1, 2007

Test: are my posting problems fixed

by onepoint＠starurchin.org

Just checking whether Jorge has fixed whatever was stopping my messages getting through. Regards, Jeremy Henty

Nov. 1, 2007

Crashes on OpenBSD

by Christian.Kellermann＠nefkom.net

* Jorge Arellano Cid <jcid(a)dillo.org> [071029 23:20]: > > Good timing you have (as Yoda says). > > I've been working on this a couple of days. Just test latest CVS and > let me know if it works for you (same for Jan S.). AH! Yes, dillo has become usable now. Sites are rendered (and redrawn alot but this is another issue to be addressed) but the race condition seems to be gone now. Thanks! Another thing: Actually what is the dw-testbed for? Will the code from there slowly merge into dillo2? Or am I missing something... Cheers, Christian -- You may use my gpg key for replies: pub 1024D/47F79788 2005/02/02 Christian Kellermann (C-Keen)

Oct. 30, 2007

Crashes on OpenBSD

by jcid＠dillo.org

On Mon, Oct 29, 2007 at 09:31:06PM +0100, Christian Kellermann wrote: > Dear List, > > this project seems to gain some speed again and I am very happy > seeing the patches flowing around. I won't step back. Good! > For I am running on a BSD I configured dillo2 with > --disable-threaded-dns. > > This won't compile because of this typo: > > RCS file: /sfhome/cvs/dillo/dillo2/src/dns.c,v > retrieving revision 1.2 > diff -b -u -p -r1.2 dns.c > --- dns.c 11 Oct 2007 18:55:13 -0000 1.2 > +++ dns.c 29 Oct 2007 20:32:04 -0000 > @@ -316,7 +316,7 @@ static void Dns_blocking_server(void) > { > int channel = 0; > struct hostent *host = NULL; > - dList *hosts = dList_new(2); > + Dlist *hosts = dList_new(2); > #ifdef LIBC5 > int h_err; > #endif Commited. > > Also I experience crashes every time I try to open a URL. See the > backtrace attached to this message. In this example I am using a > privoxy http proxy. The crashes occur independendly from this. Can > someone point me to the right direction? I am using the stock > dillorc2 and OpenBSD-4.1 on a i386. > > Thanks for your hints! > > Thank you Jorge! Good timing you have (as Yoda says). I've been working on this a couple of days. Just test latest CVS and let me know if it works for you (same for Jan S.). -- Cheers Jorge.-

Oct. 29, 2007

Crashes on OpenBSD

by Christian.Kellermann＠nefkom.net

Skipped content of type multipart/mixed

Oct. 29, 2007

some more bugs

by jcid＠dillo.org

On Mon, Oct 29, 2007 at 06:02:22PM +0100, Matthias Franz wrote: > On Sat, Oct 27, 2007 at 08:13:11PM +0200, Matthias Franz wrote: > > - Pressing "@" anytime quits Dillo immediately. > > (I guess that was made on purpose during development.) > > On my (German) keyboard I have to press AltGr + "q" to get "@". > Alt + "q" quits dillo as well. (I didn't know that before.) > Could that be an unintended interference? Fixed in CVS! I have a keyboard with '@' in the same key combination, now quit is restricted to LeftAltKey. -- Cheers Jorge.-

Oct. 29, 2007

some more bugs

by matthias.franz＠ujf-grenoble.fr

On Sat, Oct 27, 2007 at 08:13:11PM +0200, Matthias Franz wrote: > - Pressing "@" anytime quits Dillo immediately. > (I guess that was made on purpose during development.) On my (German) keyboard I have to press AltGr + "q" to get "@". Alt + "q" quits dillo as well. (I didn't know that before.) Could that be an unintended interference? -- Matthias Franz

Oct. 29, 2007

Re: yet another patch: forms. activateReceiver

by jcid＠dillo.org

Hi, After a rescue operation (and re-trainning of my bogofilter), there were this emails/patches in the SPAM bin: place (5.6K) patch: just the not-hooked-up image menu place (6.8K) patch: image loading toggle button + preference place (4.2K) patch: plain page menu place (2.6K) yet another patch: forms. activateReceiver All of them were commited with only minor changes. > I assumed I was going to have to _understand_ forms or resources, and here > I find out that all I have to do is hook A to B. At least to make the forms > I use regularly work... I wonder whether you guys left the easy stuff for > whoever comes along just so that it would be easy for them to feel rewarded > for their efforts... :-) We were trying with Sebastian to check that FLTK2, was providing everything we needed to complete the port. Thus, if something worked, but needed lots of hooks thorough the code, only the first one was made (and the rest left for the future), so we could advance to the next case. In the case of forms, while I was porting the html parser the resources for forms were not yet developed, so I had to comment and skip some hooks to make it compile. Later I started joining some dots... > I didn't patch the rc to mention the preference, though. I did. > A slavish copy of linkblock, which, since there certainly weren't any links > involved, ended up named 'eventdata'... In general, do you plan to make the rest of the patches (e.g. hook the image menu, the image loading toggle), or want some help here? BTW, with regard to the linkblock (and my past comments on it), I can try to check how it looks without linkblock, and decide what to make of it afterwards while you work on the part II of the above patches. Just let me know. -- Cheers Jorge.-

Oct. 29, 2007