- Dillo-dev - lists.mailman3.com

Re: Colspan and table percentages

by jcid＠dillo.org

Hi, On Mon, Dec 24, 2007 at 06:56:26AM +0000, place wrote: > I've noticed that sometimes people will make a table with two columns > for the purpose of indenting their text, specifying only the > width of the first column as some percentage. > > When they do this, dillo squishes everything to the right. > > Tiny example: > > <html><head><title></title></head><body> > <table width=500 border=3> > <tr> > <td width="50%">Is explicitly 50%</td> > <td>should be 50%</td> > </tr> > </table> > </body></html> This has uncovered a whole family of bugs! After experimenting with new algorithms and a different way to compute tables, it works in most of my tests. Making it work in all of them may need major changes also. This is a very complex area so I'm taking my time to try to fix it. -- Cheers Jorge.-

Jan. 2, 2008

[patch] segfault when closing window while it is loading

by jcid＠dillo.org

On Tue, Jan 01, 2008 at 12:44:55PM +0100, Johannes Hofmann wrote: > Happy new year! 8-) > Below is a small patch to fix a crash that happens when I open > a new window (e.g. with the middle mouse button) and close it > immediately while it is still loading the page. > > Johannes > > --- a/src/uicmd.cc Mon Dec 31 22:49:02 2007 +0100 > +++ b/src/uicmd.cc Tue Jan 01 12:38:14 2008 +0100 > @@ -125,6 +125,7 @@ void a_UIcmd_close_bw(void *vbw) > Layout *layout = (Layout*)bw->render_layout; > > MSG("a_UIcmd_close_bw\n"); > + a_Bw_stop_clients(bw, BW_Root + BW_Img + Bw_Force); > ui->destroy(); > delete(layout); > a_Bw_free(bw); It looks OK, but I can't make mine crash... Do you have an example URL? -- Cheers Jorge.-

Jan. 2, 2008

hook up the limit_text_width pref

by jcid＠dillo.org

On Tue, Jan 01, 2008 at 02:41:48AM +0000, place wrote: > I'm not sure under what circumstances this pref. actually changes anything, > but here it is anyway. Committed. > (I didn't notice a difference when I enabled it in my old dillo either...) I'm also not sure of the internal state of this feature... -- Cheers Jorge.-

Jan. 2, 2008

patch: start_page and fullwindow_start prefs

by jcid＠dillo.org

Committed. -- Cheers Jorge.-

Jan. 2, 2008

patch: the position part of the geometry pref.

by jcid＠dillo.org

On Wed, Jan 02, 2008 at 02:55:14AM +0000, place wrote: > (That is, the X and Y of "geometry=WxH+X+Y") > > It appears that fltk just _guesses_ what the border size might be > rather than actually determining the value. > > So when I run this with no window mgr, it puts the window where it would be > if there were a 4-pixel-wide border and 21-pixel-high title bar. > Same with twm, which is suboptimal because twm doesn't use those dimensions. > As for fvwm2, which is the one I actually use -- and does appear to > have those dimensions -- somehow the window ends up eight pixels too far down. > But I'm regarding this as Not My Problem. Committed. -- Cheers Jorge.-

Jan. 2, 2008

[PATCH] image load graphics improvements

by jcid＠dillo.org

On Tue, Jan 01, 2008 at 05:08:38PM +0000, Jeremy Henty wrote: > > This patch tweaks the image load graphics: the spacing is nicer and > the 'G' in "IMG" is more legible. You can preview the changes at > http://starurchin.org/dillo/image_load/ . Committed. -- Cheers Jorge.-

Jan. 2, 2008

[PATCH] initialise Layout::scrollIdleNotInterrupted

by jcid＠dillo.org

On Tue, Jan 01, 2008 at 02:10:54PM +0000, Jeremy Henty wrote: > > This is another valgrind pacifier; it squashes an error "Conditional > jump or move depends on uninitialised value(s)" at > "dw::core::Layout::updateAnchor() (layout.cc:474)" from "valgrind > dw2-cur/test/dw-lists". Committed. -- Cheers Jorge.-

Jan. 2, 2008

Re: "de-exporting" prefs stuff

by jcid＠dillo.org

On Tue, Jan 01, 2008 at 01:25:01AM +0000, place wrote: > Inspired by the 'de-exporting' of all of the gunk that had been in html.hh > a couple of months ago. (plus a few new defines and a 'static const') Committed. -- Cheers Jorge.-

Jan. 2, 2008

patch: color shading

by jcid＠dillo.org

On Sun, Dec 30, 2007 at 05:37:14AM +0000, place wrote: > This should make shading better... > Committed. BTW, would you mind looking at this case? <table border=90> <tr> <td>1 2 3 4 <td>5 6 7 8 9 10 <td>A <tr> <td colspan="2" bgcolor=teal>cs=2 <td>B </table> It may use a bevel like firefox. On to another topic: Have you kept on working on the code to suport charset decoding when specified in the HEAD section? -- Cheers Jorge.-

Jan. 2, 2008

[patch] fix hanging stop button

by jcid＠dillo.org

On Sat, Dec 29, 2007 at 10:37:30AM +0100, Johannes Hofmann wrote: > Hello, > > when pressing the stop button, it get's deactivated properly, but > seems to get stuck in the pressed position. > The patch below fixes the problem here. For the back- and forward- > buttons it's not really necessary, because the url change seems to > cause the necessary redraw anyway. However I added it there too for > consistency. Committed. -- Cheers Jorge.-

Jan. 2, 2008