- Dillo-dev - lists.mailman3.com

[patch] fix size of select widgets

by jcid＠dillo.org

On Sat, Feb 02, 2008 at 07:27:20PM +0100, Johannes Hofmann wrote: > Here is a small patch to compute the size of select widgets similar > to the way it is computed for text input widgets. > The width is hardcoded to 10 * size of 'M' in the current font. I committed a different version that measures the string length (as dillo1 and FF). You can test with: http://www.dillo.org/bugtrack/Dinsert.html (adding a long string to a local copy is useful). I doubt that's the right way to do it, but at least it works. Please consider it experimental and give it a look. -- Cheers Jorge.-

Feb. 2, 2008

patch: Re: [Dillo-dev] an experiment in widget coloring (with code)

by place＠gobigwest.com

Johannes wrote: > BTW: have you tried opening that page in dillo1 - it takes ages :-) Wow... Measuring by clock time: dillo-fltk 0:07 /* clear_double_buffer(); */ dillo-fltk 1:03 clear_double_buffer(); dillo-0.8.1 2:20 firefox 2:35 Paging pretty hard the last 30 seconds. I did not dare to use the page after it finished. This does not count the other 22 seconds it takes just to start up for me.

Feb. 2, 2008

patch: Re: [Dillo-dev] an experiment in widget coloring (with code)

by Johannes.Hofmann＠gmx.de

On Sat, Feb 02, 2008 at 05:37:51PM -0300, Jorge Arellano Cid wrote: > > Funny how with that page I get serious problems with redrawing > widgets. If I load the page and left click the non-widget area, > the widgets dissapear under the bgcolor. If I click on the widgets, > partial redraws are got. > > I'm not yet testing with the latest drawing patch. > > Johannes: would you mind checking this? I see this as well. I will take a look at that. Here it even crashes with: Core was generated by `dillo-fltk'. Program terminated with signal 11, Segmentation fault. #0 0x08063df5 in Html_submit_form2 (html=0x28540b00, form=0x29865380, e_input_idx=1) at html.cc:3923 3923 if (DataStr->str[DataStr->len - 1] == '&') (gdb) bt #0 0x08063df5 in Html_submit_form2 (html=0x28540b00, form=0x29865380, e_input_idx=1) at html.cc:3923 #1 0x0808a88c in dw::core::ui::ButtonResource::ClickedEmitter::emitToReceiver (this=0x287ea310, receiver=0x287ee520, signalNo=0, argc=2, argv=0xbfbff32c) at ui.cc:165 #2 0x0808f771 in loutsignal::Emitter::emitVoid (this=0x287ea310, signalNo=0, argc=2, argv=0xbfbff32c) at signal.cc:81 #3 0x0808af58 in dw::core::ui::ButtonResource::ClickedEmitter::emitClicked (this=0x287ea310, resource=0x287ea300, buttonNo=1) at ui.cc:175 #4 0x0807d79a in dw::core::ui::ButtonResource::emitClicked (this=0x287ea300, buttonNo=1) at ui.hh:348 #5 0x08052c34 in fltk::Widget::do_callback (this=0x287ea340) at /home/hofmann/include/fltk/Widget.h:125 #6 0x08097e6c in fltk::Button::handle (this=0x287ea340, event=2, rectangle=@0xbfbff3e4) at Button.cxx:121 #7 0x080980d4 in fltk::Button::handle (this=0x287ea340, event=2) at Button.cxx:77 #8 0x080e6c2a in fltk::Widget::send (this=0x287ea340, event=2) at Widget.cxx:805 #9 0x080c44a6 in fltk::handle (event=2, window=0x28541000) at run.cxx:1258 #10 0x080caa68 in fltk::handle () at x11/run.cxx:1947 #11 0x080caaac in do_queued_events () at x11/run.cxx:396 #12 0x080cadc6 in fl_wait (time_to_wait=1.00000002e+20) at x11/run.cxx:456 #13 0x080cae61 in fltk::wait (time_to_wait=1.00000002e+20) at run.cxx:457 #14 0x080caf78 in fltk::run () at run.cxx:393 #15 0x0804eaf1 in main (argc=4096, argv=0xbfbff94c) at dillo.cc:106 (gdb) p DataStr->len $1 = 0 (gdb) Johannes BTW: have you tried opening that page in dillo1 - it takes ages :-) > > > -- > Cheers > Jorge.- > > _______________________________________________ > Dillo-dev mailing list > Dillo-dev(a)dillo.org > http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev

Feb. 2, 2008

patch: Re: [Dillo-dev] an experiment in widget coloring (with code)

by jcid＠dillo.org

On Sat, Feb 02, 2008 at 07:59:53PM +0000, place wrote: > Jorge wrote: > > BTW, Why when in the bookmarks' modify page, checking a section > > gives a white mark while checking a URL gives a black one? > > > > I prefer the black one. It offers higher contrast. > > The > > int32_t c = bg->colors[FltkColor::SHADING_NORMAL]; > int r = (c >> 24) & 0xff, g = (c >> 16) & 0xff, b = (c >> 8) & 0xff; > bool light = r + g + b > 0x230; > > in FltkResource::setWidgetStyle() needs tweaking. I see. > Let's see... On my display, a test something like > bool light = (r + g >= 0x150) || (r + g + b >= 0x180) > might be about right. That's probably not the most > mathematically concise way to describe that, but anyway... > > /* I'm too rusty at scripting languages, so: */ > > #include <stdio.h> > int main(int argc, char **argv) { > int red, green, blue; > printf("<table>\n\n"); > for (red = 0; red < 0x100; red += 0x10) { > for (green = 0; green < 0x100; green += 0x10) { > for (blue = 0; blue < 0x100; blue += 0x10) { > printf("<tr bgcolor=#%02x%02x%02x> <td>\n", red, green, blue); > printf("<form>\n"); > printf("<input type=\"text\" value=\"%02x%02x%02x 0x%x\">\n", > red,green,blue, red+green+blue); > printf("</form>\n"); > } > } > } > printf("</table>\n"); > return 0; > } Funny how with that page I get serious problems with redrawing widgets. If I load the page and left click the non-widget area, the widgets dissapear under the bgcolor. If I click on the widgets, partial redraws are got. I'm not yet testing with the latest drawing patch. Johannes: would you mind checking this? -- Cheers Jorge.-

Feb. 2, 2008

patch: Re: [Dillo-dev] an experiment in widget coloring (with code)

by place＠gobigwest.com

Jorge wrote: > BTW, Why when in the bookmarks' modify page, checking a section > gives a white mark while checking a URL gives a black one? > > I prefer the black one. It offers higher contrast. The int32_t c = bg->colors[FltkColor::SHADING_NORMAL]; int r = (c >> 24) & 0xff, g = (c >> 16) & 0xff, b = (c >> 8) & 0xff; bool light = r + g + b > 0x230; in FltkResource::setWidgetStyle() needs tweaking. Let's see... On my display, a test something like bool light = (r + g >= 0x150) || (r + g + b >= 0x180) might be about right. That's probably not the most mathematically concise way to describe that, but anyway... /* I'm too rusty at scripting languages, so: */ #include <stdio.h> int main(int argc, char **argv) { int red, green, blue; printf("<table>\n\n"); for (red = 0; red < 0x100; red += 0x10) { for (green = 0; green < 0x100; green += 0x10) { for (blue = 0; blue < 0x100; blue += 0x10) { printf("<tr bgcolor=#%02x%02x%02x> <td>\n", red, green, blue); printf("<form>\n"); printf("<input type=\"text\" value=\"%02x%02x%02x 0x%x\">\n", red,green,blue, red+green+blue); printf("</form>\n"); } } } printf("</table>\n"); return 0; }

Feb. 2, 2008

[patch] fix size of select widgets

by jcid＠dillo.org

On Sat, Feb 02, 2008 at 07:27:20PM +0100, Johannes Hofmann wrote: > Here is a small patch to compute the size of select widgets similar > to the way it is computed for text input widgets. > The width is hardcoded to 10 * size of 'M' in the current font. OK. It'd be good to use the length of the longest string (as dillo1 and FF). -- Cheers Jorge.-

Feb. 2, 2008

[patch] fix size of select widgets

by Johannes.Hofmann＠gmx.de

Here is a small patch to compute the size of select widgets similar to the way it is computed for text input widgets. The width is hardcoded to 10 * size of 'M' in the current font. Regards, Johannes PS: The colored widgets are nice! diff -r 68ee0a55704c dw/fltkui.cc --- a/dw/fltkui.cc Sat Feb 02 18:36:32 2008 +0100 +++ b/dw/fltkui.cc Sat Feb 02 19:20:16 2008 +0100 @@ -1048,10 +1048,21 @@ void FltkOptionMenuResource::widgetCallb void FltkOptionMenuResource::sizeRequest (core::Requisition *requisition) { - /** \bug Random values. */ - requisition->width = 100; - requisition->ascent = 18; - requisition->descent = 5; + if (style) { + FltkFont *font = (FltkFont*)style->font; + ::fltk::setfont(font->font,font->size); + requisition->width = + (int)::fltk::getwidth ("M", 1) * 10 + + 2 * RELIEF_X_THICKNESS; + requisition->ascent = + font->ascent + RELIEF_Y_THICKNESS; + requisition->descent = + font->descent + RELIEF_Y_THICKNESS; + } else { + requisition->width = 1; + requisition->ascent = 1; + requisition->descent = 0; + } }

Feb. 2, 2008

a couple of patches: referer and image_off

by jcid＠dillo.org

On Fri, Feb 01, 2008 at 11:18:30PM +0000, place wrote: > Jorge wrote: > > On Fri, Feb 01, 2008 at 07:38:45PM +0000, place wrote: > > > > In brief, using the same URI, the three options offer good > > > > privacy (because no new information is sent), and if we ever > > > > enable using the referring page, the old comments apply. > > > > > > Whew. > > > > > > See, I ran on the equivalent of "host" for > > > at least a year, and then have been using the > > > equivalent of "path" for at least a year, so > > > the idea that I had somehow been doing something > > > wrong was alarming :) > > > > :-) > > > > Well, in that case you can provide good advice on which is > > better as a default. > > Well, I tried "path" one day when "host" didn't work for > some site, and I had the impression that "path" worked more > consistently, but I wasn't being very scientific about it. It looks like we may default to "path". > Nowadays, if I bother to look at why an image doesn't want > to load, it usually turns out that it was a redirection. > I'd been sort of curious why dillo doesn't follow redirections > for non-root urls, but hadn't gotten around to asking... Non-root redirected images are mainly advertising! :-) -- Cheers Jorge.-

Feb. 2, 2008

patch: Re: [Dillo-dev] an experiment in widget coloring (with code)

by jcid＠dillo.org

On Sat, Feb 02, 2008 at 02:52:18AM +0000, place wrote: > Jorge wrote: > > I like the idea, even the look of coloured widgets, but some people may > > prefer the old look. > > > > Would you implement this as a dillorc2 preference? e.g. > > > > # When set to yes, form elements follow the color style of the page. > > widget_colors=YES > > I ended up calling the pref standard_widget_colors, which > allows the toolkit to use its default colors. > > old behavior: current text color on light grey. > standard_widget_colors=YES: black on light grey. > standard_widget_colors=NO: current text color on current background color. Good! Committed. I left a default to standard when not present in dillorc2, but set it to use the new colors in the example dillorc2. Those reading the list, please test and comment. BTW, Why when in the bookmarks' modify page, checking a section gives a white mark while checking a URL gives a black one? I prefer the black one. It offers higher contrast. -- Cheers Jorge.-

Feb. 2, 2008

patch: Re: [Dillo-dev] an experiment in widget coloring (with code)

by place＠gobigwest.com

Jorge wrote: > I like the idea, even the look of coloured widgets, but some people may > prefer the old look. > > Would you implement this as a dillorc2 preference? e.g. > > # When set to yes, form elements follow the color style of the page. > widget_colors=YES I ended up calling the pref standard_widget_colors, which allows the toolkit to use its default colors. old behavior: current text color on light grey. standard_widget_colors=YES: black on light grey. standard_widget_colors=NO: current text color on current background color.

Feb. 2, 2008