- Dillo-dev - lists.mailman3.com

two warnings in table.cc

by jcid＠dillo.org

On Mon, Mar 03, 2008 at 07:03:57PM +0100, Johannes Hofmann wrote: > Hi, > > here are two more warnings like this: > > table.cc: In member function 'void dw::Table::forceCalcColumnExtremes()': > table.cc:778: warning: 'wMin' may be used uninitialized in this function > table.cc: In member function 'void dw::Table::forceCalcCellSizes()': > table.cc:483: warning: 'totalWidth' may be used uninitialized in this function One bug, one false positive. Fixes committed. These warnings are really helpful. -- Cheers Jorge.-

March 3, 2008

two warnings in table.cc

by Johannes.Hofmann＠gmx.de

Hi, here are two more warnings like this: table.cc: In member function 'void dw::Table::forceCalcColumnExtremes()': table.cc:778: warning: 'wMin' may be used uninitialized in this function table.cc: In member function 'void dw::Table::forceCalcCellSizes()': table.cc:483: warning: 'totalWidth' may be used uninitialized in this function Cheers, Johannes

March 3, 2008

patch: Re: [Dillo-dev] segfault in Html_submit_form2()

by place＠gobigwest.com

Jorge wrote: > The question is, do you want me to commit the API change too? It doesn't matter to me.

March 3, 2008

segfault in Html_submit_form2()

by jcid＠dillo.org

On Mon, Mar 03, 2008 at 05:48:47PM +0000, place wrote: > Johannes wrote: > > It was crashing on every form submit I tried (e.g. www.google.com) > > Hmm. Too bad I'm still on old Linux. > (I looked at DragonflyBSD some months ago, by the way, and was disappointed > that I couldn't install from a file on the hard drive. I don't even have a > CD writer.) > > > I also got a compiler warning: > > > > html.cc:3945: warning: 'boundary' may be used uninitialized in this function > > I wasn't getting a warning, but this brings up something I've been meaning > to ask: Jorge, what do you think of -Werror? So far as I can recall, the > only warning on the dillo2/ side currently is Html_input_image. > It would save me the trouble of monitoring compilation... I use: make|grep : quite handy! -- Cheers Jorge.-

March 3, 2008

segfault in Html_submit_form2()

by jcid＠dillo.org

On Mon, Mar 03, 2008 at 06:14:29PM +0100, Johannes Hofmann wrote: > Hi Jorge, > > On Mon, Mar 03, 2008 at 02:04:25PM -0300, Jorge Arellano Cid wrote: > > Hi Johannes, > > > > On Mon, Mar 03, 2008 at 05:16:51PM +0100, Johannes Hofmann wrote: > > > Hi, > > > > > > after updating to latest CVS, I got the following segfault when > > > submitting a simple form: > > > > > [...] > > > I think the problem is, that boundary only gets initialized if > > > form->enc == DILLO_HTML_ENC_MULTIPART. > > > > It doesn't segfault for me. Anyway I committed a small fix. > > Please test and post the URL that was triggering the bug. > > Yes, that fixes it. Good! > It was crashing on every form submit I tried (e.g. www.google.com) > I also got a compiler warning: > > html.cc:3945: warning: 'boundary' may be used uninitialized in this function Funny how it worked OK here for google, linuxpackages and our bug track engine. Even more, I don't get a compiler warning with: gcc version 4.1.2 20061115 (prerelease) (Debian 4.1.1-21) -- Cheers Jorge.-

March 3, 2008

segfault in Html_submit_form2()

by place＠gobigwest.com

Johannes wrote: > It was crashing on every form submit I tried (e.g. www.google.com) Hmm. Too bad I'm still on old Linux. (I looked at DragonflyBSD some months ago, by the way, and was disappointed that I couldn't install from a file on the hard drive. I don't even have a CD writer.) > I also got a compiler warning: > > html.cc:3945: warning: 'boundary' may be used uninitialized in this function I wasn't getting a warning, but this brings up something I've been meaning to ask: Jorge, what do you think of -Werror? So far as I can recall, the only warning on the dillo2/ side currently is Html_input_image. It would save me the trouble of monitoring compilation...

March 3, 2008

patch: Re: [Dillo-dev] segfault in Html_submit_form2()

by jcid＠dillo.org

Hi, On Mon, Mar 03, 2008 at 05:28:36PM +0000, place wrote: > > after updating to latest CVS, I got the following segfault when > > submitting a simple form: > > Oops! Thanks, Johannes. Patch attached. > I had the code doing the right thing at some point in the past after it > crashed once on me, but then I forgot why I'd made the change and undid it :( FWIW, this patch changes the API of Html_append_input: - Html_append_input(DilloHtmlEnc encoding, const char *boundary, Dstr *url, + Html_append_input(DilloHtmlEnc encoding, Dstr *boundary, Dstr *url, Current CVS has a different patch that fixes the segfault. The question is, do you want me to commit the API change too? -- Cheers Jorge.-

March 3, 2008

patch: Re: [Dillo-dev] segfault in Html_submit_form2()

by place＠gobigwest.com

> after updating to latest CVS, I got the following segfault when > submitting a simple form: Oops! Thanks, Johannes. Patch attached. I had the code doing the right thing at some point in the past after it crashed once on me, but then I forgot why I'd made the change and undid it :( What was the URL?

March 3, 2008

segfault in Html_submit_form2()

by Johannes.Hofmann＠gmx.de

Hi Jorge, On Mon, Mar 03, 2008 at 02:04:25PM -0300, Jorge Arellano Cid wrote: > Hi Johannes, > > On Mon, Mar 03, 2008 at 05:16:51PM +0100, Johannes Hofmann wrote: > > Hi, > > > > after updating to latest CVS, I got the following segfault when > > submitting a simple form: > > > [...] > > I think the problem is, that boundary only gets initialized if > > form->enc == DILLO_HTML_ENC_MULTIPART. > > It doesn't segfault for me. Anyway I committed a small fix. > Please test and post the URL that was triggering the bug. Yes, that fixes it. It was crashing on every form submit I tried (e.g. www.google.com) I also got a compiler warning: html.cc:3945: warning: 'boundary' may be used uninitialized in this function Cheers, Johannes > > TIA. > > -- > Cheers > Jorge.- > > _______________________________________________ > Dillo-dev mailing list > Dillo-dev(a)dillo.org > http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev

March 3, 2008

segfault in Html_submit_form2()

by jcid＠dillo.org

Hi Johannes, On Mon, Mar 03, 2008 at 05:16:51PM +0100, Johannes Hofmann wrote: > Hi, > > after updating to latest CVS, I got the following segfault when > submitting a simple form: > [...] > I think the problem is, that boundary only gets initialized if > form->enc == DILLO_HTML_ENC_MULTIPART. It doesn't segfault for me. Anyway I committed a small fix. Please test and post the URL that was triggering the bug. TIA. -- Cheers Jorge.-

March 3, 2008