- Dillo-dev - lists.mailman3.com

[PATCH]: a_Dpiapi_dialog should call a_Dialog_choice3 with 3 parameters

by onepoint＠starurchin.org

To clarify, this patch is a fix to Christian Kellermann's https patch, so it naturally depends on it. Jeremy Henty

March 15, 2008

[PATCH]: Fixing https step 1: Have a basic dpi dialog window working again

by onepoint＠starurchin.org

On Sat, Mar 15, 2008 at 09:45:40AM +0100, Christian Kellermann wrote: > I am not sure whether I should stop beating this dead horse or > continue. What's your advice? I would really like to see this working. What's the next step? Regards, Jeremy Henty

March 15, 2008

[PATCH]: a_Dpiapi_dialog should call a_Dialog_choice3 with 3 parameters

by onepoint＠starurchin.org

a_Dpiapi_dialog() calls a_Dialog_choice3() with 2 parameters instead of 3. This causes the dialog to pop up a third button with a garbage label, and valgrind reports 'Conditional jump or move depends on uninitialised value(s)' from inside FLTK. Patch attached. This bug slipped through because dpiapi.c does not include dialog.hh to get the prototype of a_Dialog_choice3() . I'm not sure how to fix this: should a C source file be including a C++ header? If not, how else can dpiapi.c get the prototype? Regards, Jeremy Henty

March 15, 2008

[PATCH]: Fixing https step 1: Have a basic dpi dialog window working again

by Christian.Kellermann＠nefkom.net

Skipped content of type multipart/mixed

March 15, 2008

https plugin status

by Christian.Kellermann＠nefkom.net

Hi, nevermind the last post the dpid_tag _is_ syntactically correct. Why should http_query be missing though? Shouldn't it at least be the same as url? Kind regards, Christian -- You may use my gpg key for replies: pub 1024D/47F79788 2005/02/02 Christian Kellermann (C-Keen)

March 15, 2008

https plugin status

by Christian.Kellermann＠nefkom.net

* Jeremy Henty <onepoint(a)starurchin.org> [080315 05:58]: > On Sat, Mar 15, 2008 at 01:22:09AM +0000, Jeremy Henty (ie. me) wrote: > > > I was wrong, the https filter dpi *is* starting. But, its debugging > > messages don't appear because it sends them to stdout, which dpid > > redirects to the DPI socket. This feels ... somehow ... wrong. > > And so it is! (Patch submitted in a new thread.) After redirecting > the debugging messages to stderr I see: > > [https dpi]: {In https.filter.dpi} > [https dpi]: ***Value of cmd, url or http_query is NULL - cannot continue > [https dpi]: { exiting https.dpi} > If you add an additional MSG output you see something like this: [https dpi]: {In https.filter.dpi} [https dpi]: dpip_tag <cmd='open_url' url='https://www.ccc.de' '> [https dpi]: ***Value of cmd, url or http_query is NULL - cannot continue [https dpi]: { exiting https.dpi} dpid_tag looks like there is a missing '. I added Index: dpi/https.c =================================================================== RCS file: /sfhome/cvs/dillo/dillo2/dpi/https.c,v retrieving revision 1.1.1.1 diff -b -u -p -r1.1.1.1 https.c --- dpi/https.c 6 Oct 2007 22:36:34 -0000 1.1.1.1 +++ dpi/https.c 15 Mar 2008 07:51:29 -0000 @@ -191,6 +191,9 @@ static void yes_ssl_support(void) /*Get the network address and command to be used*/ dpip_tag = sock_handler_read(sh); + + MSG("dpip_tag %s\n",dpip_tag); + cmd = a_Dpip_get_attr(dpip_tag, strlen(dpip_tag), "cmd"); url = a_Dpip_get_attr(dpip_tag, strlen(dpip_tag), "url"); http_query = a_Dpip_get_attr(dpip_tag, strlen(dpip_tag), "query"); I am not sure whether this is really save, is this tag \0 terminated? Nonetheless something is lost on the way... Kind regards, Christian -- You may use my gpg key for replies: pub 1024D/47F79788 2005/02/02 Christian Kellermann (C-Keen)

March 15, 2008

https plugin status

by onepoint＠starurchin.org

On Sat, Mar 15, 2008 at 02:18:27AM +0000, place wrote: > It appears that Capi_dpi_build_cmd() needs to test for "proto.https" > instead of "https"... Or maybe Capi_url_uses_dpi() should be checking for "https" and *not* adding the "proto." prefix? I'm just guessing here, I'm still figuring out this code. Regards, Jeremy Henty

March 15, 2008

https plugin status

by place＠gobigwest.com

Jeremy wrote: > On Sat, Mar 15, 2008 at 01:22:09AM +0000, Jeremy Henty (ie. me) wrote: > > > I was wrong, the https filter dpi *is* starting. But, its debugging > > messages don't appear because it sends them to stdout, which dpid > > redirects to the DPI socket. This feels ... somehow ... wrong. > > And so it is! (Patch submitted in a new thread.) After redirecting > the debugging messages to stderr I see: > > [https dpi]: {In https.filter.dpi} > [https dpi]: ***Value of cmd, url or http_query is NULL - cannot continue > [https dpi]: { exiting https.dpi} > > which at least gives some idea of what is going wrong. It appears that Capi_dpi_build_cmd() needs to test for "proto.https" instead of "https"...

March 15, 2008

https plugin status

by onepoint＠starurchin.org

On Sat, Mar 15, 2008 at 01:22:09AM +0000, Jeremy Henty (ie. me) wrote: > I was wrong, the https filter dpi *is* starting. But, its debugging > messages don't appear because it sends them to stdout, which dpid > redirects to the DPI socket. This feels ... somehow ... wrong. And so it is! (Patch submitted in a new thread.) After redirecting the debugging messages to stderr I see: [https dpi]: {In https.filter.dpi} [https dpi]: ***Value of cmd, url or http_query is NULL - cannot continue [https dpi]: { exiting https.dpi} which at least gives some idea of what is going wrong. Jeremy Henty

March 15, 2008

[PATCH]: send the https dpi plugin debug messages to the right place

by onepoint＠starurchin.org

The https DPI plugin sends its debug messages to stdin. This is wrong because the DPI daemon dups the plugin's stdin to the DPI socket. This patch redirects the debug messages to stderr. Jeremy Henty

March 15, 2008