- Dillo-dev - lists.mailman3.com

patch: multipart/form-data CRLF

by place＠gobigwest.com

Happened to notice in the RFC that multipart types must use CRLF between body parts. PS It was a bit annoying to figure out that http.c needed to be changed, which suggests that it would have been better for me to store the boundary string in DilloUrl somewhere after all.

March 15, 2008

https plugin status

by onepoint＠starurchin.org

On Sat, Mar 15, 2008 at 03:31:52PM -0400, Jorge Arellano Cid wrote: > > [Jeremey wrote] > > Or maybe Capi_url_uses_dpi() should be checking for "https" and > > *not* adding the "proto." prefix? > > "proto.https" is the right patch. OK, what about my patch to redirect MSG debugging messages from stdout to stderr? Is that correct? Regards, Jeremy Henty

March 15, 2008

[patch] don't restart scanning from start in Html_parse_entities ()

by Johannes.Hofmann＠gmx.de

Hi, below is a small optinization to Html_parse_entities (). Cheers, Johannes diff -r bd486ec2a522 src/html.cc --- a/src/html.cc Sat Mar 15 19:41:01 2008 +0100 +++ b/src/html.cc Sat Mar 15 20:23:03 2008 +0100 @@ -1397,13 +1397,14 @@ static char * { const char *esc_set = "&\xE2\xC2"; char *new_str, buf[4]; - int i, j, k, n, isocode, entsize; + int i, j, k, n, s, isocode, entsize; new_str = dStrndup(token, toksize); - if (new_str[strcspn(new_str, esc_set)] == 0) + s = strcspn(new_str, esc_set); + if (new_str[s] == 0) return new_str; - for (i = j = 0; i < toksize; i++) { + for (i = j = s; i < toksize; i++) { if (token[i] == '&' && (isocode = Html_parse_entity(html, token+i, toksize-i, &entsize)) >= 0) {

March 15, 2008

[patch] further reduce redraws from resizing tables

by Johannes.Hofmann＠gmx.de

Hi Jorge, On Fri, Mar 14, 2008 at 06:53:08PM -0400, Jorge Arellano Cid wrote: > Hi Johannes, > > On Tue, Mar 11, 2008 at 07:27:01PM +0100, Johannes Hofmann wrote: > > Hi, > > > > below is another patch to reduce the redraws caused by resizing > > tables. A new method Layout::queueDrawExcept(), that requests the > > drawing of a rectangle except another rectangle is added. > > It is then used in widget.cc to redraw the area that was previously > > occupied by a widget, but is no longer occupied after a resize or move. > > This makes it possible to redraw less when a table resizes. > > All in all it should reduce the flicker a bit when loading table > > based pages. > > On the topic of reducing the flicker, I'm far of an expert and > please correct me if I'm wrong. AFAIU, the current design draws > the background color before the widget content. > > This is: if you have an html page as big table, in dillo, it > will become a table inside a textblock. When the textblock is > asked to redraw, it will _erase_ the table with its background > color and ask its child (the table) to redraw. Causing flicker. Yes, that's true. In addition, before anything is drawn, the rectangle to be drawn is already cleared with the background color in FltkViewBase::draw() (the fillrect () calls). > > If this is true, a big gain could come from a different > approach: just draw the surroundings of the widgets and ask the > child widgets to redraw. > > This way widgets aren't erased beforehand, and can also decide > not to redraw themselves when nothing has changed. > > I have worked a bit on this idea, and the attached patch mocks > the idea hackishly. It draws the "padding" area of the CSS box > (see the picture in namespacedw_1_1core_1_1style.html in dw docs) > > Please give it a review and share your comments, > corrections and thoughts. I've been thinking about something similar as well, but I don't think it will work out generally. The main problem is text drawing and maybe transparent widgets (don't know whether they exist already). Anyway, for drawing text, you need to erase the area first. Just comment out the fillrect () calls in FltkViewBase::draw() to see what I mean :-) Therefore, we will always have flicker, when drawing text. The good news is that all the flicker can be avoided easily with some double buffering technique. And from dillo1 we even know that this is not necessarily slow :-) So for me the flicker itself is not that much of a problem. It may be an indicator for unnecessary redraws, which should be avoided to save CPU power. But I think current cvs is already pretty good in this regard. So I would propose to start to think about efficient double buffering similar to what I had posted in http://lists.auriga.wearlab.de/pipermail/dillo-dev/2007-November/003379.html but platform independent using fltk2 support. Cheers, Johannes

March 15, 2008

[PATCH]: Fixing https step 1: Have a basic dpi dialog window working again

by Christian.Kellermann＠nefkom.net

Hi Jorge, * Jorge Arellano Cid <jcid(a)dillo.org> [080315 18:58]: > Sorry for the late answer, but I've had little spare time, > and several topics to answer. > > Probably you have already read: > > http://lists.auriga.wearlab.de/pipermail/dillo-dev/2007-September/003211.ht… > > an got some info from there. Yes, thanks for the hint, it was insightful. I have spend a few thoughts on the SSL issue and I'd like to hear your opinion on it. The most work that still needs to be done is to handle certificates and the user interaction required to make it usable. The user needs to add trust values to certificates and to add or remove them offline. I think this can fit well into a server dpi. Adding and deleting bookmarks could be done similar to handling bookmarks. Which might be a bit rough but is independent on fltk widgets. I do think that we already have enough dialog types in dillo. Hard coding the certificate handling would not make the situation any better. Also I can imagine this plugin to handle client certificates which I do believe will become a more common requirement for certain applications in the future. Adding secure storage capabilities will be easy. Also people will have the chance to write some "bridging" plugin that extracts the needed data from existing storage sources elsewhere, i.e. certificate servers,... Handling this all internally means that we put functionality into dillo that are needed for, but basically have nothing to do with browsing. As I have grasped the spirit of this project this may not be the way to go. A nice thing about handling https internally is the opportunity to reuse an established connection for more than one request, which might speed up transfers significantly. But on the other hand couldn't this be done by dpid for all filter plugins? Dpid can keep them alive as long as the following requests belong to the same URL, then closing the connection after a timeout? I am sorry if this has been already decided on before. These thoughts were rumaging aroung my head all day now... Kind regards, Christian -- You may use my gpg key for replies: pub 1024D/47F79788 2005/02/02 Christian Kellermann (C-Keen)

March 15, 2008

https plugin status

by jcid＠dillo.org

Hi, Just a follow up on https dpi: > [place wrote] > It appears that Capi_dpi_build_cmd() needs to test for "proto.https" instead > of "https"... Yes this is a bug from the latest big dpi upgrade (generic dpi protos). > [Jeremey wrote] > Or maybe Capi_url_uses_dpi() should be checking for "https" and *not* > adding the "proto." prefix? "proto.https" is the right patch. > [Christian wrote] > But what is supposed to be working atm? Really basic, if you can see: https://www.rapidssl.com/test/rapidssl.htm that's all. BTW, with place's patch, I can also see: https://www.ccc.de > [Jeremey wrote] > Getting https working would greatly reduce the number of times I run > Firefox! I thought many https sites needed javascript to work. _Please_ correct me if I'm wrong. :-) > [...] With regard to the missing dialog function, you may get a very good idea by looking at its implementation in dillo-0.8.6. That's what I'd do to answer if I had the time now. -- Cheers Jorge.-

March 15, 2008

[PATCH]: Fixing https step 1: Have a basic dpi dialog window working again

by jcid＠dillo.org

Hi Christian, Sorry for the late answer, but I've had little spare time, and several topics to answer. Probably you have already read: http://lists.auriga.wearlab.de/pipermail/dillo-dev/2007-September/003211.ht… an got some info from there. On Sat, Mar 15, 2008 at 02:02:07PM +0100, Christian Kellermann wrote: > * Christian Kellermann <Christian.Kellermann(a)nefkom.net> [080315 09:49]: > > Dear list, > > > > In order to fix the https plugin I have stumbled upon the fact, > > that the former dialog code seems to be removed from cvs. To see > > what's goign on further down the code I have added a basic Yes/No > > popup using the existing a_Dialog_choice3 function. For this the > > numbering of the buttons have changed also in https. Dialogs with > > more than two alternatives will have the additional choices dropped > > silently. This is good for now but I really like to have it done > > right. Which function should get used instead of a_Dialog_choice3? > > > > Also what's the real purpose of http_request? At the moment I cheat > > and set it to url in case it is empty. Which value is to be expected > > when calling the document root in a URL? "/"? "/index.html"? or am > > I getting this all wrong? > > > > Whith this patch I can bypass the "certificate could not get verified" > > case but not much further. Also cancelling the dialog seems to leave > > some data behind, another call of https URLs won't do anything. But > > this is a bit better than it has been before... > > > > I am not sure whether I should stop beating this dead horse or > > continue. What's your advice? > > > > Ignore the http_request part I figured it out. > > Ok, I have changed the proto comparison from "https" -> "proto.https" > and I am able to view https sites again. This module still needs a > lot of cleanup. As a next step I want to implement simple certificate > caching so accepted certificates won't get prompted again. This > will be memory only at first, making the certificate valid (or > invalid) as long as the dpid lives. > > The updated patch is attached below. A long time ago, browsing was mainly fetching pages and images. It made a lot of sense to use an external tool (as wget) to grab https pages. Implementing this idea with dpi was also simple. Now, it may be not the case. You have to keep track of certificates, sessions, sometimes keep an open connection, etc. Years ago SSL wasn't widespread, today is an everyday need, so it may make sense to consider having it inside dillo. It can take some design time at the beginning but will be easier to maintain and extend than to have it living in an external dpi. Developers is what we need, so if you want to work on https, you're more than welcome. Lack of manpower is our biggest problem! "place" implemented gzip decoding in dillo2, he may help you with ideas on how to add an extra layer/decoding-stage for SSL. (With regard to your specific questions about https, you'll have to wait some time until I can look at it again in depth. IIRC there was a five option dialog requested through dpip that sent the answer back on what to do. It was removed from the code while porting, delayed for future implementation). Again, my suggestion is to consider an internal implementation. -- Cheers Jorge.-

March 15, 2008

[PATCH]: a_Dpiapi_dialog should call a_Dialog_choice3 with 3 parameters

by onepoint＠starurchin.org

On Sat, Mar 15, 2008 at 02:04:32PM +0100, Christian Kellermann wrote: > Ah thanks! I add it to step 2 :) In the meantime you need to apply > this again to my updated version of step 1. OK, here's an updated fix for your updated step 1. Regards, Jeremy Henty

March 15, 2008

[PATCH]: a_Dpiapi_dialog should call a_Dialog_choice3 with 3 parameters

by Christian.Kellermann＠nefkom.net

* Jeremy Henty <onepoint(a)starurchin.org> [080315 13:54]: > > a_Dpiapi_dialog() calls a_Dialog_choice3() with 2 parameters instead > of 3. This causes the dialog to pop up a third button with a garbage > label, and valgrind reports 'Conditional jump or move depends on > uninitialised value(s)' from inside FLTK. Patch attached. > > This bug slipped through because dpiapi.c does not include dialog.hh > to get the prototype of a_Dialog_choice3() . I'm not sure how to fix > this: should a C source file be including a C++ header? If not, how > else can dpiapi.c get the prototype? > Ah thanks! I add it to step 2 :) In the meantime you need to apply this again to my updated version of step 1. You were faster than me :) Kind regards, Christian -- You may use my gpg key for replies: pub 1024D/47F79788 2005/02/02 Christian Kellermann (C-Keen)

March 15, 2008

[PATCH]: Fixing https step 1: Have a basic dpi dialog window working again

by Christian.Kellermann＠nefkom.net

Skipped content of type multipart/mixed

March 15, 2008