- Dillo-dev - lists.mailman3.com

I figured out why charset handling has been all broken lately.

by Johannes.Hofmann＠gmx.de

On Thu, Apr 24, 2008 at 01:57:41AM +0000, corvid wrote: > The top of Nav_open_url has > > bool_t ForceReload = (URL_FLAGS(url) & > (URL_E2EReload + URL_ReloadFromCache)); > > When repushing URLs, URL_FLAGS contains URL_ReloadFromCache, > which is 0x100. And remember how Jorge changed bool_t from > int to unsigned char? I'd forgotten about it, too, which meant > I wasted some time looking in the wrong places for this bug. Ouch, this must have been fun to debug :-)

April 24, 2008

I figured out why charset handling has been all broken lately.

by corvid＠lavabit.com

The top of Nav_open_url has bool_t ForceReload = (URL_FLAGS(url) & (URL_E2EReload + URL_ReloadFromCache)); When repushing URLs, URL_FLAGS contains URL_ReloadFromCache, which is 0x100. And remember how Jorge changed bool_t from int to unsigned char? I'd forgotten about it, too, which meant I wasted some time looking in the wrong places for this bug.

April 24, 2008

dillo-fltk on x86_64

by corvid＠lavabit.com

[it seems like everybody on this list has a name starting with J] Justus wrote: > With my three patches applied dillo compiles and runs fine, however I > had to create ~/.dillo and manually start dpid. Did I miss something here? Was dillo unable to find dpid, or was it just not working right somehow? Looking in dillo2/src/IO/dpi.c, dpid has to be either in ~/.dillo/ or $PATH. I put it in my path.

April 24, 2008

dillo-fltk on x86_64

by 4winter＠informatik.uni-hamburg.de

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Joerg Sonnenberger wrote: > On Wed, Apr 23, 2008 at 11:53:24PM +0200, Justus Winter wrote: >> [...] >> somewhere on the net, don't know if this is too hacky. > Please cast to (u)intptr_t instead. Like this? Justus - -- gpg key fingerprint: C82D 382A AB38 1A54 5290 19D6 A0F9 B035 686C 6996 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFID7bfoPmwNWhsaZYRAuaeAJ4q16SFUnUIVnPhJlczP9Dft6WW1gCaA8+T ZoqvRZq/4X4Qoxjw/UrMuA0= =SxsP -----END PGP SIGNATURE-----

April 24, 2008

dillo-fltk on x86_64

by joerg.sonnenberger＠web.de

On Wed, Apr 23, 2008 at 11:53:24PM +0200, Justus Winter wrote: > dialog.cc:249: error: cast from ?void*? to ?int? loses precision > > A parameter of type void* for a callback is used to carry a small > integer (most likely the number of the button pressed or something). I > solved this one by first casting to long and then to int. I saw this > somewhere on the net, don't know if this is too hacky. Please cast to (u)intptr_t instead. Joerg

April 24, 2008

dillo-fltk on x86_64

by 4winter＠informatik.uni-hamburg.de

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hey@all :) I ran into some issues compiling dillo. I solved / worked around them, patches are attached. Here are my findings and my interpretations (let me know in case I am way off somewhere): dw2 === gcc-4.2 on linux/x86_64 complained about two casts in lout/object.cc: object.cc:118: error: cast from ?void*? to ?int? loses precision I felt it was nonsense to check the size of void* at runtime and used the preprocessor to choose which instruction to use based on the value of SIZEOF_VOID_P. dillo2 ====== There was another complaint by gcc: dialog.cc:249: error: cast from ?void*? to ?int? loses precision A parameter of type void* for a callback is used to carry a small integer (most likely the number of the button pressed or something). I solved this one by first casting to long and then to int. I saw this somewhere on the net, don't know if this is too hacky. dillo2/dpi ========== downloads.cc failed to compile since gcc couldn't find the fltk includes (I chose not to install them to /usr/local/lib), so I poked around in dpi/Makefile.am and managed to include LIBFLTK_CXXFLAGS into cxxflags (/me is an automake n00b). With my three patches applied dillo compiles and runs fine, however I had to create ~/.dillo and manually start dpid. Did I miss something here? Cheers, Justus - -- gpg key fingerprint: C82D 382A AB38 1A54 5290 19D6 A0F9 B035 686C 6996 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFID6/ToPmwNWhsaZYRApgwAJsENlC0vsniya14RBTU8yrXVVjVyACff2HD GLM/iKxXf3UjBA6+GFOSE78= =JuDE -----END PGP SIGNATURE-----

April 24, 2008

dillo-fltk exits on SIGPIPE

by onepoint＠starurchin.org

On Wed, Apr 23, 2008 at 05:24:01PM +0000, corvid wrote: > Johannes wrote: > > do you also see exits on SIGPIPE e.g. on: > > http://daily.daemonnews.org > > dillo 1 had signal(SIGPIPE, SIG_IGN); > > which dillo-fltk is missing. > > No, I just get: > > ** WARNING **: IO_write, closing with pending data not sent I see the same thing as corvid . (Details: Linux 2.6.25 , gcc 3.4.3 , glibc 2.3.4 .) Regards, Jeremy Henty

April 23, 2008

patch: motionNotify when scrolling (Re: patch: Re: [Dillo-dev] start on image maps (dw-part))

by corvid＠lavabit.com

Johannes wrote: > On Wed, Apr 23, 2008 at 06:08:27AM +0000, corvid wrote: > > Johannes wrote: > > > On Tue, Apr 22, 2008 at 02:05:43PM +0000, corvid wrote: > > > > Speaking of motionNotify, the other day I was looking into getting the > > > > link in the status bar to change when scrolling. I'd gotten as far as > > > > figuring out that maybe *checks notes* Layout::scrollPosChanged could call > > > > Layout::motionNotify, but then I got stuck because I didn't know where to > > > > get current cursor coordinates from. > > > > > > In fltk one can call get_mouse(int &x, int &y). But I'm not sure > > > how to wrap this properly. Perhaps adding a similar method to > > > Platform? What about different views, can they all have separate > > > pointer devices? > > > Just checked dillo1. It handles at least the scrolling case > > > properly. > > > > Ah, indeed. It turns out that old dillo sets viewport->mouse_[xy] in > > Dw_gtk_viewport_motion_notify() > > and then has a > > static void Dw_gtk_viewport_adj_changed (GtkAdjustment *adj, > > GtkDwViewport *viewport) > > { > > Dw_gtk_viewport_mouse_event (GTK_WIDGET (viewport), > > viewport->mouse_x, viewport->mouse_y, NULL); > > } > > > > Attached is a patch similar to this. > > > > It works for scrolling and when I close a window that had been > > obscuring the viewport (it gets ENTER and FOCUS. I chose ENTER). > > It does not work when I page around with my window manager because the only > > event the viewport handler sees is KEYUP, and I didn't like the idea > > of using KEYUP for this. > > Nice! But there is still other cases, like going back with > <Backspace> such that the cursor ends up over a link. > Or incremental rendering such that the cursor ends up over a link ( > (to reproduce go to a slow page, move the cursor over a link and > press <Ctrl>-r to reload). > > I'm not sure how to handle these cases where the movement is > initiated by the layout rather than the view. I ignored it at the time because I figured it was probably hard to deal with. It also incorrectly shows links when text searching causes scrolling. I have this case fixed in my copy now. And it could be made to deal with moving into scrollbars, although that's probably for a separate patch at some point (with cursor resetting as well). > I'd like to have a general mechanism like > Layout::canvasMousePosChanged () that can be called in all these > cases. I'll at least try to figure out something...

April 23, 2008

dillo-fltk exits on SIGPIPE

by corvid＠lavabit.com

Johannes wrote: > do you also see exits on SIGPIPE e.g. on: > http://daily.daemonnews.org > dillo 1 had signal(SIGPIPE, SIG_IGN); > which dillo-fltk is missing. No, I just get: ** WARNING **: IO_write, closing with pending data not sent

April 23, 2008

patch: motionNotify when scrolling (Re: patch: Re: [Dillo-dev] start on image maps (dw-part))

by Johannes.Hofmann＠gmx.de

On Wed, Apr 23, 2008 at 06:08:27AM +0000, corvid wrote: > Johannes wrote: > > On Tue, Apr 22, 2008 at 02:05:43PM +0000, corvid wrote: > > > Speaking of motionNotify, the other day I was looking into getting the > > > link in the status bar to change when scrolling. I'd gotten as far as > > > figuring out that maybe *checks notes* Layout::scrollPosChanged could call > > > Layout::motionNotify, but then I got stuck because I didn't know where to > > > get current cursor coordinates from. > > > > In fltk one can call get_mouse(int &x, int &y). But I'm not sure > > how to wrap this properly. Perhaps adding a similar method to > > Platform? What about different views, can they all have separate > > pointer devices? > > Just checked dillo1. It handles at least the scrolling case > > properly. > > Ah, indeed. It turns out that old dillo sets viewport->mouse_[xy] in > Dw_gtk_viewport_motion_notify() > and then has a > static void Dw_gtk_viewport_adj_changed (GtkAdjustment *adj, > GtkDwViewport *viewport) > { > Dw_gtk_viewport_mouse_event (GTK_WIDGET (viewport), > viewport->mouse_x, viewport->mouse_y, NULL); > } > > Attached is a patch similar to this. > > It works for scrolling and when I close a window that had been > obscuring the viewport (it gets ENTER and FOCUS. I chose ENTER). > It does not work when I page around with my window manager because the only > event the viewport handler sees is KEYUP, and I didn't like the idea > of using KEYUP for this. Nice! But there is still other cases, like going back with <Backspace> such that the cursor ends up over a link. Or incremental rendering such that the cursor ends up over a link ( (to reproduce go to a slow page, move the cursor over a link and press <Ctrl>-r to reload). I'm not sure how to handle these cases where the movement is initiated by the layout rather than the view. I'd like to have a general mechanism like Layout::canvasMousePosChanged () that can be called in all these cases. Johannes

April 23, 2008