- Dillo-dev - lists.mailman3.com

[PATCH]: lout::misc::min

by jcid＠dillo.org

On Sun, Apr 27, 2008 at 12:15:05AM +0100, Jeremy Henty wrote: > > I mean, this *has* to be a typo, right? Fix committed. -- Cheers Jorge.-

April 27, 2008

patch: Re: patch: Re: [Dillo-dev] start on image maps (dw-part)

by jcid＠dillo.org

On Sat, Apr 26, 2008 at 07:27:18PM +0000, corvid wrote: > Johannes wrote: > > What about deleting coords earlier? I think they are no longer > > needed once the shape has been constructed. > > attached. > Committed. -- Cheers Jorge.-

April 27, 2008

[PATCH]: lout::misc::min

by jcid＠dillo.org

Hi, On Sun, Apr 27, 2008 at 12:30:18AM +0100, Jeremy Henty wrote: > > Followup: the dillo source doesn't use the 3-argument min, only the > 3-argument max, so this bug didn't break anything. Probably it wasn't worth calling it after all... :-) -- Cheers Jorge.-

April 27, 2008

[PATCH]: lout::misc::min

by onepoint＠starurchin.org

Followup: the dillo source doesn't use the 3-argument min, only the 3-argument max, so this bug didn't break anything. Jeremy Henty > diff -pru -- 00_pre/lout/misc.hh 01_post/lout/misc.hh > --- 00_pre/lout/misc.hh 2008-04-26 21:42:59.000000000 +0100 > +++ 01_post/lout/misc.hh 2008-04-27 00:03:02.000000000 +0100 > @@ -20,7 +20,7 @@ template <class T> inline T max (T a, T > > template <class T> inline T min (T a, T b, T c) > { > - return (min (a, max (b, c))); > + return (min (a, min (b, c))); > } > template <class T> inline T max (T a, T b, T c) > {

April 27, 2008

[PATCH]: lout::misc::min

by onepoint＠starurchin.org

I mean, this *has* to be a typo, right? Jeremy Henty

April 27, 2008

Docs question: dw::core::ui::ListResource::SelectionMode::SELECTION_AT_MOST_ONE

by onepoint＠starurchin.org

On Sat, Apr 26, 2008 at 03:08:21PM -0400, Jorge Arellano Cid wrote: > On Sat, Apr 26, 2008 at 10:46:26AM +0100, Jeremy Henty wrote: > > > > That's my guess too. If someone comfirms this I'll make a patch. > > Committed! Gosh, I appear to have developed the magical super-power to cause patches to appear merely by thinking about them! :-) (Thinks: tabs, tabs, tabs...) Regards, Jeremy Henty

April 27, 2008

dillo-fltk on x86_64

by jcid＠dillo.org

Hi Justus, > It's hard to get anything past you guys... revised patches are attached. :-) No, you just had bad luck. 64bit is a complex matter that looks simple. BTW, I'm quite happy that a few patches made dillo2 run on 64bit. On Wed, Apr 23, 2008 at 11:53:24PM +0200, Justus Winter wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Hey@all :) > > I ran into some issues compiling dillo. I solved / worked around them, > patches are attached. Here are my findings and my interpretations (let > me know in case I am way off somewhere): > > dw2 > === > gcc-4.2 on linux/x86_64 complained about two casts in lout/object.cc: > > object.cc:118: error: cast from ???void*??? to ???int??? loses precision > > I felt it was nonsense to check the size of void* at runtime and used > the preprocessor to choose which instruction to use based on the value > of SIZEOF_VOID_P. After reviewing the thread, and a head scratching phase, I committed the following code. please test it: +/* For some unknown reason, this doesn't compile on some 64bit platforms: + * + * if (sizeof (int) == sizeof (void*)) + * return (int)value; + * else + * return ((int*)value)[0] ^ ((int*)value)[1]; + */ +#if SIZEOF_VOID_P == 4 + return (int)value; +#else + return ((int*)value)[0] ^ ((int*)value)[1]; +#endif > dillo2 > ====== > There was another complaint by gcc: > > dialog.cc:249: error: cast from ???void*??? to ???int??? loses precision > > A parameter of type void* for a callback is used to carry a small > integer (most likely the number of the button pressed or something). I > solved this one by first casting to long and then to int. I saw this > somewhere on the net, don't know if this is too hacky. Committed as: + choice5_answer = VOIDP2INT(number); > dillo2/dpi > ========== > downloads.cc failed to compile since gcc couldn't find the fltk includes > (I chose not to install them to /usr/local/lib), so I poked around in > dpi/Makefile.am and managed to include LIBFLTK_CXXFLAGS into cxxflags > (/me is an automake n00b). Yeah, auto* is not simple. Does it work for you with a: +downloads_dpi_CXXFLAGS = @LIBFLTK_CXXFLAGS@ instead? (CVS has this tentative patch). > > With my three patches applied dillo compiles and runs fine, however I > had to create ~/.dillo and manually start dpid. Did I miss something here? No, I forgot porting the creation of ~/.dillo from dillo1 to dillo2! (as we all run dillo1 before, ~/.dillo was there :-) dpid didn't start because it most probably wasn't in your path. With regard to a missing SSL, yes, it'd be good not to try to compile https the. Patches are welcomed! :-) -- Cheers Jorge.-

April 26, 2008

[patch] phrase search

by Johannes.Hofmann＠gmx.de

On Sat, Apr 26, 2008 at 01:10:46PM -0400, Jorge Arellano Cid wrote: > Hi, > > Committed. > > On Tue, Apr 22, 2008 at 06:12:55PM +0200, Johannes Hofmann wrote: > > Hi, > > > > attached is a patch that make phrase search work. I'm not 100% sure > > about the CharIterator::prev() change. CharIterator::next() returned > > \0 between words, prev() didn't. So something was wrong. > > I decided to go with current next() behaviour and made prev() return > > \0 as word separator too. > > It looks reasonable. > > BTW, while working on fixing the parsing of " " (a not yet > committed work), I found that it's not clear how non-breaking > whitespace is handled/represented. Currently we have a parser/dw > mix that tries to render it "right" for HTML. The idea is to > decide how to render inside the HTML parser and to use dw for > that. Now there's some HTML logic built in dw, which would be > good not to have (an idea we talked with Sebastian long ago). > > For instance dillo1 handles NBSP better in some cases and worse > in others than dillo2. > > I think it'll have to wait until I find some time to dig into > it... > > > > > Also the current implementation only works if one enters exactly one > > blank between words in the search dialog. Should we collapse multiple > > blanks into one automatically? > > As a workaround, I don't see why not. > > BTW, the phrase search doesn't work with text wrapped by the > PRE element. This probably is related to a whole sentence/line > stored as a single dw word. Ah yes. I totally forgot about PRE. In normal text spaces are encoded using the "space" flag in Content. In PRE there is a separate Content object for each space. I think I will revert my change to CharIterator and make prev() work as next() originally did (i.e. not return any '\0'). Instead CharIterator will generate a ' ' if the space flag is set in a Content object. This way CharIterator will always create a stream of chars (no '\0's) with words in normal text separated by blanks. Then phrase search should work for PRE sections too. And it should even be possible to search for something like three blanks in a row within PRE sections. Patch will follow... Cheers, Johannes

April 26, 2008

patch: Re: patch: Re: [Dillo-dev] start on image maps (dw-part)

by corvid＠lavabit.com

Johannes wrote: > What about deleting coords earlier? I think they are no longer > needed once the shape has been constructed. attached.

April 26, 2008

Docs question: dw::core::ui::ListResource::SelectionMode::SELECTION_AT_MOST_ONE

by jcid＠dillo.org

On Sat, Apr 26, 2008 at 10:46:26AM +0100, Jeremy Henty wrote: > On Sat, Apr 26, 2008 at 10:31:51AM +0200, Johannes Hofmann wrote: > > On Sat, Apr 26, 2008 at 09:27:01AM +0100, Jeremy Henty wrote: > > > > > > The description of > > > dw::core::ui::ListResource::SelectionMode::SELECTION_AT_MOST_ONE > > > does not make sense. Should "The user may not the only selected > > > item." read "The user may unselect the only selected item."? > > > > I guess so. Maybe the comment was copied from > > SELECTION_EXACTLY_ONE_BY_USER and "unselect" was deleted instead of > > "not"? > > That's my guess too. If someone comfirms this I'll make a patch. Committed! -- Cheers Jorge.-

April 26, 2008