- Dillo-dev - lists.mailman3.com

Uncluttering dillo, part II: the findbar

by jcid＠dillo.org

On Wed, May 21, 2008 at 05:43:05PM +0200, Johannes Hofmann wrote: > Hi Justus, > > On Wed, May 21, 2008 at 12:02:14AM +0200, Justus Winter wrote: > > -----BEGIN PGP SIGNED MESSAGE----- > > Hash: SHA1 > > > > Hey everyone :) > > > > attached is a patch that transforms dillos find in page dialog box into > > a firefox style toolbar. There are some issues that I cannot put my > > finger on... see the comments in the event handler. Maybe there's some > > magic about fltks event model that I did not fully understand... then > > again it might be fltks fault. Anyway, I'd be happy for some hints. > > This is really nice! For text search the popup menus are even more > annoying than for entering an url. > > One minor thing. You can make the CheckButton and Input members of > Findbar private if you use static methods for the callbacks instead > of functions. Yes, I agree. -- Cheers Jorge.-

May 22, 2008

Uncluttering dillo, part II: the findbar

by jcid＠dillo.org

On Wed, May 21, 2008 at 12:02:14AM +0200, Justus Winter wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Hey everyone :) Hi there! > attached is a patch that transforms dillos find in page dialog box into > a firefox style toolbar. Nice! Committed with some changes. See below. > There are some issues that I cannot put my > finger on... see the comments in the event handler. Maybe there's some > magic about fltks event model that I did not fully understand... then > again it might be fltks fault. Anyway, I'd be happy for some hints. Ok, the comment says: > /* BUG: this is acting funny > * > * 1. figure out why the first EscapeKey is only > * sent to the input widget if it is focused at the time > * 2. ctrl-f ; type foo ; select foo and type bar ; press esc > * => foo is inserted into the input box > */ Fixed both in the committed version. FLTK2 sends the event to handle() and its return value tells whether the event was handled or not. Here, the input widget was handling the event (and making the selection empty) so there was no need to propagate the event upwards, but when the selected text was already empty (second time) there was nothing to do and the event was propagated upwards. The patch was the same as for the location bar. A custom input widget that handles keys in a slightly different way that the native Input widget. In this case (MyInput) we don't handle the escape key and let FLTK pass it upwards, and thus get the desired effect. > Jorge, could you update your coding conventions with respect to c++ > specific language features? Oh yes. I need to find some time though. I've been giving priority to pending patches. The coding conventions, are clearly out of date. At least the C++ part. In this regard we're currently following dw2's style. Can you write a few rules down and send them to me to update the page. The idea is not to be pedantic on style issues, but to define a common style that we can adhere to. -- Cheers Jorge.-

May 22, 2008

memory statistics

by Johannes.Hofmann＠gmx.de

Hi, to see which part of dillo consumes which amount of memory, I hacked together a version of dlib.c that counts memory that was allocated via dMalloc(). A malloc_tag allows to assign the mallocs to specific parts in the code. In the patch below I use malloc_tag = 1 for cache stuff, malloc_tag = 2 for text strings that are passed dw2 and malloc_tag = 0 for everything else. It's fun to see how memory get's allocated and free'd while loading. Here is the output once the huge mysql manual page is loaded: ====> malloc size 5185114 26967623 6602392 0 So that's 6M for text strings, 26M cache and 5M other. Of course there is also all the dw2 stuff that is not taken into account here. BTW, textblock delete's the text strings that are allocated using malloc(). That's not allowed and might cause unexpected behaviour on some platforms. Cheers, Johannes

May 22, 2008

RFC: human interface guidelines

by jcid＠dillo.org

On Tue, May 20, 2008 at 11:55:59PM +0200, Justus Winter wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Hey everyone :) > > I was thinking about improving the dillo experience by adding some > functionality / shortcuts people have come to expect. But what people > expect is influenced by their background, their choice of desktop > environment and platform. True. > We could pick one / some user interface guideline(s) ([1] lists some) > and try to adhere to it / them. Or we could pick one popular browser and > copy its 'feel'. Some people love dillo's bindings! :-) The canonical solution is to provide configurable keybindings for the most used functions. Maybe worth trying? ;) -- Cheers Jorge.-

May 21, 2008

[patch] minor memory reduction

by jcid＠dillo.org

On Wed, May 21, 2008 at 05:14:25PM +0200, Johannes Hofmann wrote: > Ok, here comes a second attempt. It works with your test page and > avoids the memore leak. Please test. Committed. -- Cheers Jorge.-

May 21, 2008

Uncluttering dillos UI - getting rid of the dialog boxes

by jcid＠dillo.org

On Wed, May 21, 2008 at 10:10:59AM +0200, Justus Winter wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Justus Winter wrote: > > Jorge Arellano Cid wrote: > >> On Sat, May 17, 2008 at 05:46:26PM +0200, Justus Winter wrote: > >>> -----BEGIN PGP SIGNED MESSAGE----- > >>> Hash: SHA1 > >>> > >>> I thought about dillos fullscreen mode, which is not a fullscreen mode > >>> at all but a "get rid of those panels"-mode. So I decided to rename > >>> those functions and variables accordingly (00-*) > >> Committed. > > > >> With the addition that when the Location is already focused, > >> the text is also selected. This helps as a visual clue and also > >> to quickly get rid of the old URL. > > > >> Note: I used a trick in ::handle() to do it. If you know a > >> better way, please send a patch. > > > > Yes, that's a nice feature indeed. Reading the fltk documentation I came > > up with the attached patch. I am pretty sure that strlen is the wrong > > function when dealing with utf-8 character data, but you get the idea. > > > > Justus > > Looking at the fltk source I realized that Input::size() does exactly > what we want and is also much more efficient. Revised patch is attached. Committed (with the comment). -- Cheers Jorge.-

May 21, 2008

Keyboard shortcuts & fullscreen button

by jcid＠dillo.org

On Tue, May 20, 2008 at 11:28:54PM +0200, Justus Winter wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Jorge Arellano Cid wrote: > > On Sat, May 17, 2008 at 06:09:19PM +0200, Justus Winter wrote: > >> Also I noticed, that the way events are handled is somewhat lax with > >> respect to modifier keys. The code just checks if ctrl is pressed, not > >> if ctrl but none of the other modifiers are pressed. This makes ctrl-l > >> equivalent with ctrl-shift-alt-l. I'd like to hear your opinions, is > >> this a bug or a feature? > > > > Bug I think. > > > > The UI was coded in a hurry to get it running. Lax parts need > > polish. > > The attached patch addresses modifier issue. Committed. -- Cheers Jorge.-

May 21, 2008

Uncluttering dillo, part II: the findbar

by Johannes.Hofmann＠gmx.de

Hi Justus, On Wed, May 21, 2008 at 12:02:14AM +0200, Justus Winter wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Hey everyone :) > > attached is a patch that transforms dillos find in page dialog box into > a firefox style toolbar. There are some issues that I cannot put my > finger on... see the comments in the event handler. Maybe there's some > magic about fltks event model that I did not fully understand... then > again it might be fltks fault. Anyway, I'd be happy for some hints. This is really nice! For text search the popup menus are even more annoying than for entering an url. One minor thing. You can make the CheckButton and Input members of Findbar private if you use static methods for the callbacks instead of functions. Cheers, Johannes

May 21, 2008

[patch] minor memory reduction

by Johannes.Hofmann＠gmx.de

Ok, here comes a second attempt. It works with your test page and avoids the memore leak. Please test. Cheers, Johannes On Tue, May 20, 2008 at 05:50:35PM -0400, Jorge Arellano Cid wrote: > On Tue, May 20, 2008 at 07:16:45PM +0200, Johannes Hofmann wrote: > > Hi, > > > > attached is a small patch to improve memory usage. It creates a > > single word for a sequence of spaces in PRE mode instead of one word > > per character. > > Good idea, but it's not the same rendering. Check the offsets > with the attached file. > > BTW, there's a memory leak when len=0 (bacause Dstr allocates > for the string). While reviewing I thought why not just count the > spaces and use dStrnfill(num_spc, ' '). > > -- > Cheers > Jorge.- > <html> > <pre> > Bla bla bla. Blabla blabla bla blala bla > bla. Blabla blabla bla bla. > > Blala bla. Blabla blabla bla blaba bla bla. Bla > blabla bla bla. > > Blilly blilly bla bla bla. Blabla > blabla bla bla. > <HR> > Lallyla layllaylay layla layla lally lally. > </pre> > </html> > _______________________________________________ > Dillo-dev mailing list > Dillo-dev(a)dillo.org > http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev

May 21, 2008

[patch] minor memory reduction

by Johannes.Hofmann＠gmx.de

On Tue, May 20, 2008 at 05:50:35PM -0400, Jorge Arellano Cid wrote: > On Tue, May 20, 2008 at 07:16:45PM +0200, Johannes Hofmann wrote: > > Hi, > > > > attached is a small patch to improve memory usage. It creates a > > single word for a sequence of spaces in PRE mode instead of one word > > per character. > > Good idea, but it's not the same rendering. Check the offsets > with the attached file. Ouch! Do you think this is a general problem or should I try to get this working somehow? > > BTW, there's a memory leak when len=0 (bacause Dstr allocates > for the string). While reviewing I thought why not just count the > spaces and use dStrnfill(num_spc, ' '). Yes, that would be better. Cheers, Johannes > > -- > Cheers > Jorge.- > <html> > <pre> > Bla bla bla. Blabla blabla bla blala bla > bla. Blabla blabla bla bla. > > Blala bla. Blabla blabla bla blaba bla bla. Bla > blabla bla bla. > > Blilly blilly bla bla bla. Blabla > blabla bla bla. > <HR> > Lallyla layllaylay layla layla lally lally. > </pre> > </html> > _______________________________________________ > Dillo-dev mailing list > Dillo-dev(a)dillo.org > http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev

May 21, 2008