- Dillo-dev - lists.mailman3.com

[BUG]: Redirect to previous page + Reload crashes

by onepoint＠starurchin.org

On Sat, May 24, 2008 at 03:22:10AM +0000, corvid wrote: > Jeremy wrote: > > Dillo crashes as follows: > > * Point Dillo at http://starurchin.org:8080/dillo/here > > * Click the "There" link. Dillo is redirected back to the "Here" > > page. > > * Click the "Reload" button. > > * Dillo crashes inside a_Nav_reload() (nav.c) at the line "if > > (URL_FLAGS(url) & URL_Post) {" because url is NULL. > > The problem went away when I tried the attached change, > but I may be treating the symptom rather than the disease. > diff -pur dillo2/src/nav.c dillo2-cur/src/nav.c > --- dillo2/src/nav.c 2008-05-10 20:02:22.000000000 +0000 > +++ dillo2-cur/src/nav.c 2008-05-24 03:03:50.000000000 +0000 > @@ -185,6 +185,8 @@ static void Nav_stack_clean(BrowserWindo > void *data = dList_nth_data (bw->nav_stack, i - 1); > dList_remove_fast (bw->nav_stack, data); > dFree(data); > + if (bw->nav_stack_ptr >= a_Nav_stack_size(bw)) > + bw->nav_stack_ptr = a_Nav_stack_size(bw) - 1; > } > } > I think this addresses the real problem, which is that bw->nav_stack_ptr is an index into bw->nav_stack , so if we modify the latter we must ensure the former is valid. Reviewing the rest of nav.c I think there is a similar potential problem with Nav_stack_insert() , which also modifies bw->nav_stack . Shouldn't it increment bw->nav_stack_ptr if it is after the insertion point? Otherwise the displayed item might change unexpectedly. Regards, Jeremy Henty

May 24, 2008

Profiling works!

by jcid＠dillo.org

On Sat, May 24, 2008 at 05:15:40PM +0100, Jeremy Henty wrote: > On Sat, May 24, 2008 at 05:03:31PM +0100, Jeremy Henty wrote: > > > [Dillo] puts [gmon.prof] in /tmp (perhaps that's why it didn't seem > > to be working). Dillo also dumps its core to /tmp ... > > Well, duh, after writing that I thought to check the source, and > main() calls a_Dir_init() which calls chdir("/tmp") . No wonder > everything ends up in /tmp ! LOL! :-) Even more, I downloaded the profile data posted by Johannes to /tmp, so it was no surprise to find a gprof data file there. -- Cheers Jorge.-

May 24, 2008

patch: trim Local_Buf

by jcid＠dillo.org

On Fri, May 23, 2008 at 05:31:30PM +0200, Johannes Hofmann wrote: > Hey that's cool! I thought about doing something like this, but > didn't find a good way. I thought it would grow much more complicated. Committed with some changes. Note that this may help when fetching a huge page through the network (i.e. in chunks). When it comes from the cache, it's one big chunk of data. -- Cheers Jorge.-

May 24, 2008

Profiling works!

by onepoint＠starurchin.org

On Sat, May 24, 2008 at 05:03:31PM +0100, Jeremy Henty wrote: > [Dillo] puts [gmon.prof] in /tmp (perhaps that's why it didn't seem > to be working). Dillo also dumps its core to /tmp ... Well, duh, after writing that I thought to check the source, and main() calls a_Dir_init() which calls chdir("/tmp") . No wonder everything ends up in /tmp ! Regards, Jeremy Henty

May 24, 2008

Profiling works!

by onepoint＠starurchin.org

I added -pg to LDFLAGS, CFLAGS and CXXFLAGS and dillo generated a nice gmon.prof ! However, it puts it in /tmp (perhaps that's why it didn't seem to be working). Dillo also dumps its core to /tmp when it crashes, perhaps for the same reason? Regards, Jeremy Henty

May 24, 2008

Uncluttering dillo, part II: the findbar

by jcid＠dillo.org

On Fri, May 23, 2008 at 07:01:51PM +0200, Johannes Hofmann wrote: > On Thu, May 22, 2008 at 12:32:07PM -0400, Jorge Arellano Cid wrote: > > On Wed, May 21, 2008 at 05:43:05PM +0200, Johannes Hofmann wrote: > > > Hi Justus, > > > > > > On Wed, May 21, 2008 at 12:02:14AM +0200, Justus Winter wrote: > > > > -----BEGIN PGP SIGNED MESSAGE----- > > > > Hash: SHA1 > > > > > > > > Hey everyone :) > > > > > > > > attached is a patch that transforms dillos find in page dialog box into > > > > a firefox style toolbar. There are some issues that I cannot put my > > > > finger on... see the comments in the event handler. Maybe there's some > > > > magic about fltks event model that I did not fully understand... then > > > > again it might be fltks fault. Anyway, I'd be happy for some hints. > > > > > > This is really nice! For text search the popup menus are even more > > > annoying than for entering an url. > > > > > > One minor thing. You can make the CheckButton and Input members of > > > Findbar private if you use static methods for the callbacks instead > > > of functions. > > > > Yes, I agree. > > Patch attached. Committed. -- Cheers Jorge.-

May 24, 2008

[patch] dw2 memory reduction

by Johannes.Hofmann＠gmx.de

Hi, attached is patch to reduce the memory usage of dw2: * Styles are now reused if they are equal. This brings down the number of Style objects on the mysql page from around 180000 to 23000 and reduces memory usage by about 25M at the cost of an additional HashTable. Maybe the hash table should be part of fltkplatform as the hash tables for Color and Font? There would be even more sharing of styles possible, if x_link would not be part of style. On the other hand about 3M for styles on the huge mysql page is pretty ok. * Size of struct Word is reduced by 4 integers by using shorts. I know that this is questionable, but I think in the case of struct Word that can be allocated a lot it is worth the hassle. Please check whether my assumption that space lengths and word lengths can be stored in shorts are valid in general. * SimpleVector no longer preallocates memory if it's not necessary. This actually saves some megabytes here! With these changes memory usage on the mysql page is 179M here. Cheers, Johannes

May 24, 2008

Uncluttering dillo, part II: the findbar

by jcid＠dillo.org

On Sat, May 24, 2008 at 03:34:38AM +0000, corvid wrote: > Justus wrote: > > Corvid spotted two spelling errors. Patch is attached. > > (I thought he was going to be the next one touching findbar.cc, > so I thought I could keep list traffic down. Sorry.) > Anyway... > > > - _MSG("findbar NewInput: catched EscapeKey\n"); > > + _MSG("findbar NewInput: cought EscapeKey\n"); > > ..it's "caught". Committed. BTW, corvidspell works great for me! :-) -- Cheers Jorge.-

May 24, 2008

RFC: removing the search dialog

by corvid＠lavabit.com

Justus wrote: > I hacked up opera (at least I _think_ they do it this way) style search > engine handling. In my dream world, web browsers would have command lines instead of location bars.

May 24, 2008

Uncluttering dillo, part II: the findbar

by 4winter＠informatik.uni-hamburg.de

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 corvid wrote: > Justus wrote: >> Corvid spotted two spelling errors. Patch is attached. > > (I thought he was going to be the next one touching findbar.cc, > so I thought I could keep list traffic down. Sorry.) > Anyway... > >> - _MSG("findbar NewInput: catched EscapeKey\n"); >> + _MSG("findbar NewInput: cought EscapeKey\n"); > > ..it's "caught". Damn! Is there a free syntax and api aware spell checker around? I found some non free software for this purpose, and {i,a}spell has way too many false positives... oh well, maybe I should just avoid complicated things like spell checking when I'm tired :) Justus - -- gpg key fingerprint: C82D 382A AB38 1A54 5290 19D6 A0F9 B035 686C 6996 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFIN820oPmwNWhsaZYRAsKBAKCv1sSxuX45TmKn0K7NIl9zjHeveACfWxQH iC6P9GKWOuXsNopM5HzUUqE= =WPvC -----END PGP SIGNATURE-----

May 24, 2008