- Dillo-dev - lists.mailman3.com

[patch] move highlighting data into Textblock

by corvid＠lavabit.com

Jorge wrote: > On Fri, Jun 20, 2008 at 12:18:12AM +0200, Johannes Hofmann wrote: > > I only have the Euro sign on my keyboard :-) Searching for it works > > fine. Do you know how I can enter the Yen sign? > > No, but I'm talking of the string "yen sign" fed to find text! :-) Not entirely on topic, then, but: compose worked well enough for my configuration once I went to fltk::compose() and put the // See if they type the compose prefix key: if (i == RightCtrlKey || i == 0xff20/* Multi-Key */) { compose_state = 1; return true; } ahead of the // Alt+letters are reserved for shortcuts. But alt+foreign letters // has to be allowed, because some key layouts require alt to be held // down in order to type them... if ((e_state & (ALT|META)) && !(ascii & 128)) return false; (my hazy recollection is that Multi_Key turned on META in e_state) Their site wouldn't let me register to bring up the matter, although it probably wouldn't have made any difference anyway (I note that recent talk about 2.0 in fltk.development has a lot of "somebody should" but nobody wants to be that somebody.)

June 20, 2008

[patch] move highlighting data into Textblock

by Johannes.Hofmann＠gmx.de

On Thu, Jun 19, 2008 at 06:28:26PM -0400, Jorge Arellano Cid wrote: > On Fri, Jun 20, 2008 at 12:18:12AM +0200, Johannes Hofmann wrote: > > On Thu, Jun 19, 2008 at 03:16:38PM -0400, Jorge Arellano Cid wrote: > > > On Thu, Jun 19, 2008 at 04:32:31PM +0200, Johannes Hofmann wrote: > > > > Hi, > > > > > > > > as promised here comes a patch to move highlighting information from > > > > struct Word into Textblock to save memory. > > > > I had to change the semantics of the highlighting API slightly (see > > > > comments) to ensure that the highlighted part is always contiguous. > > > > > > > > Here are some measurements (with load_images=NO): > > > > > > > > Page dillo-fltk patched_dillo-fltk dillo1 firefox > > > > ============================================================== > > > > splash 7240K 7236K > > > > xslt [1] 15016K 14220K > > > > freebsd [2] 70264K 58084K > > > > mysql [3] 186M 148M 232M 200M > > > > > > > > Obviously the difference is mostly visible on large pages. And > > > > firefox is pretty close regarding memory usage. However it needed more > > > > than 3 minutes to load the local mysql page compared to 6 seconds > > > > for dillo-fltk! > > > > > > > > Please look out for possible highlight related regressions. > > > > > > With the same msql page: > > > > > > http://downloads.mysql.com/docs/refman-6.0-en.html.tar.gz > > > > > > and HUGE_FILESIZE set to 15MB, search for "yen sign". After > > > the fourth match, strange highlights become to happen. > > > > I only have the Euro sign on my keyboard :-) Searching for it works > > fine. Do you know how I can enter the Yen sign? > > No, but I'm talking of the string "yen sign" fed to find text! :-) Ah, I see :-). I can reproduce it now. I will have a look at it. Cheers, Johannes > > > Can you try whether this issue is new with my patch? > > I did. > > -- > Cheers > Jorge.- > > _______________________________________________ > Dillo-dev mailing list > Dillo-dev(a)dillo.org > http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev

June 20, 2008

[patch] move highlighting data into Textblock

by jcid＠dillo.org

On Fri, Jun 20, 2008 at 12:18:12AM +0200, Johannes Hofmann wrote: > On Thu, Jun 19, 2008 at 03:16:38PM -0400, Jorge Arellano Cid wrote: > > On Thu, Jun 19, 2008 at 04:32:31PM +0200, Johannes Hofmann wrote: > > > Hi, > > > > > > as promised here comes a patch to move highlighting information from > > > struct Word into Textblock to save memory. > > > I had to change the semantics of the highlighting API slightly (see > > > comments) to ensure that the highlighted part is always contiguous. > > > > > > Here are some measurements (with load_images=NO): > > > > > > Page dillo-fltk patched_dillo-fltk dillo1 firefox > > > ============================================================== > > > splash 7240K 7236K > > > xslt [1] 15016K 14220K > > > freebsd [2] 70264K 58084K > > > mysql [3] 186M 148M 232M 200M > > > > > > Obviously the difference is mostly visible on large pages. And > > > firefox is pretty close regarding memory usage. However it needed more > > > than 3 minutes to load the local mysql page compared to 6 seconds > > > for dillo-fltk! > > > > > > Please look out for possible highlight related regressions. > > > > With the same msql page: > > > > http://downloads.mysql.com/docs/refman-6.0-en.html.tar.gz > > > > and HUGE_FILESIZE set to 15MB, search for "yen sign". After > > the fourth match, strange highlights become to happen. > > I only have the Euro sign on my keyboard :-) Searching for it works > fine. Do you know how I can enter the Yen sign? No, but I'm talking of the string "yen sign" fed to find text! :-) > Can you try whether this issue is new with my patch? I did. -- Cheers Jorge.-

June 20, 2008

[patch] move highlighting data into Textblock

by Johannes.Hofmann＠gmx.de

On Thu, Jun 19, 2008 at 03:16:38PM -0400, Jorge Arellano Cid wrote: > On Thu, Jun 19, 2008 at 04:32:31PM +0200, Johannes Hofmann wrote: > > Hi, > > > > as promised here comes a patch to move highlighting information from > > struct Word into Textblock to save memory. > > I had to change the semantics of the highlighting API slightly (see > > comments) to ensure that the highlighted part is always contiguous. > > > > Here are some measurements (with load_images=NO): > > > > Page dillo-fltk patched_dillo-fltk dillo1 firefox > > ============================================================== > > splash 7240K 7236K > > xslt [1] 15016K 14220K > > freebsd [2] 70264K 58084K > > mysql [3] 186M 148M 232M 200M > > > > Obviously the difference is mostly visible on large pages. And > > firefox is pretty close regarding memory usage. However it needed more > > than 3 minutes to load the local mysql page compared to 6 seconds > > for dillo-fltk! > > > > Please look out for possible highlight related regressions. > > With the same msql page: > > http://downloads.mysql.com/docs/refman-6.0-en.html.tar.gz > > and HUGE_FILESIZE set to 15MB, search for "yen sign". After > the fourth match, strange highlights become to happen. I only have the Euro sign on my keyboard :-) Searching for it works fine. Do you know how I can enter the Yen sign? Can you try whether this issue is new with my patch? Cheers, Johannes > > -- > Cheers > Jorge.- > > _______________________________________________ > Dillo-dev mailing list > Dillo-dev(a)dillo.org > http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev

June 20, 2008

form.cc: more refactoring

by onepoint＠starurchin.org

On Wed, Jun 18, 2008 at 08:35:57AM -0400, Jorge Arellano Cid wrote: > Committed, except 00 and 05. > > 00: The stash buffer may hold a script, in that case parse_stash is not > as clear as parse_entities. Would a better name make the change acceptable? For instance, Html_parse_stash_entries() ? > 05: gives compilation errors: > [...] > form.cc: In function 'void Html_option_finish(DilloHtml*)': > form.cc:184: error: 'lout::misc::SimpleVector<DilloHtmlOption*>* > DilloHtmlSelect::options' is private > form.cc:1918: error: within this context > form.cc:184: error: 'lout::misc::SimpleVector<DilloHtmlOption*>* > DilloHtmlSelect::options' is private > form.cc:1918: error: within this context That's because not committing 00 breaks one of the chunks in 04 so you still have an explicit ->inputs which should have been replaced by a call to getCurrentOption() . I'm appending the missing chunk of 04 and resubmitting 05 . Regards, Jeremy Henty

June 19, 2008

[patch] move highlighting data into Textblock

by jcid＠dillo.org

On Thu, Jun 19, 2008 at 04:32:31PM +0200, Johannes Hofmann wrote: > Hi, > > as promised here comes a patch to move highlighting information from > struct Word into Textblock to save memory. > I had to change the semantics of the highlighting API slightly (see > comments) to ensure that the highlighted part is always contiguous. > > Here are some measurements (with load_images=NO): > > Page dillo-fltk patched_dillo-fltk dillo1 firefox > ============================================================== > splash 7240K 7236K > xslt [1] 15016K 14220K > freebsd [2] 70264K 58084K > mysql [3] 186M 148M 232M 200M > > Obviously the difference is mostly visible on large pages. And > firefox is pretty close regarding memory usage. However it needed more > than 3 minutes to load the local mysql page compared to 6 seconds > for dillo-fltk! > > Please look out for possible highlight related regressions. With the same msql page: http://downloads.mysql.com/docs/refman-6.0-en.html.tar.gz and HUGE_FILESIZE set to 15MB, search for "yen sign". After the fourth match, strange highlights become to happen. -- Cheers Jorge.-

June 19, 2008

[patch] fix FltkPlatform destructor

by jcid＠dillo.org

On Thu, Jun 19, 2008 at 05:10:43PM +0200, Johannes Hofmann wrote: > Hi, > > this fixes a small memory leak in FltkPlatform. Committed. -- Cheers Jorge.-

June 19, 2008

[patch] move highlighting data into Textblock

by jcid＠dillo.org

On Thu, Jun 19, 2008 at 04:32:31PM +0200, Johannes Hofmann wrote: > Hi, > > as promised here comes a patch to move highlighting information from > struct Word into Textblock to save memory. > I had to change the semantics of the highlighting API slightly (see > comments) to ensure that the highlighted part is always contiguous. > > Here are some measurements (with load_images=NO): > > Page dillo-fltk patched_dillo-fltk dillo1 firefox > ============================================================== > splash 7240K 7236K > xslt [1] 15016K 14220K > freebsd [2] 70264K 58084K > mysql [3] 186M 148M 232M 200M > > Obviously the difference is mostly visible on large pages. And > firefox is pretty close regarding memory usage. However it needed more > than 3 minutes to load the local mysql page compared to 6 seconds > for dillo-fltk! > > Please look out for possible highlight related regressions. Nice work! Committed. I made some tests here and it looks OK. Now it's in CVS for more testing. -- Cheers Jorge.-

June 19, 2008

Splitting html.cc: what next?

by jcid＠dillo.org

On Wed, Jun 11, 2008 at 06:49:39PM +0100, Jeremy Henty wrote: > On Wed, Jun 11, 2008 at 12:13:13PM -0400, Jorge Arellano Cid wrote: > > > I'd say go with table... > > ...and that's it. > > :-( I was looking forward to more slicing and dicing! ;-) You can keep on polishing! It's just we _may_ need to change some of the parser structure in the future and I didn't want you to polish it throughly and then see it re-structured into something different. -- Cheers Jorge.-

June 19, 2008

[patch] fix FltkPlatform destructor

by Johannes.Hofmann＠gmx.de

Hi, this fixes a small memory leak in FltkPlatform. Johannes

June 19, 2008