- Dillo-dev - lists.mailman3.com

[patch] Configurable key bindings

by corvid＠lavabit.com

Diego wrote: > - If the number of key bindings increase much another config file can > be convenient. With another config file some example files can be > suplied (vim keys, firefox keys, ...) and end user only need to copy > the prefered file. That's a good point.

Feb. 24, 2009

[patch] Configurable key bindings

by darkspirit5000＠gmail.com

I disagree about changing the dillorc format: - This change is not backwards compatible. Do not read old dillorc format and it is a big inconvenience for users. - Can delete some meta info stored in dillorc. - There are compatible ways to add this preferences (key_save = "...", key_find = "CTRL + f", ...) - If the number of key bindings increase much another config file can be convenient. With another config file some example files can be suplied (vim keys, firefox keys, ...) and end user only need to copy the prefered file. I do not known what other option is best, but i think that this format change is not needed. Diego. 2009/2/24, corvid <corvid(a)lavabit.com>: > I think I'd feel better if it could be used like prefs, > that is, isPressed testing bindings.reload instead of > looking for the binding associated with the "reload" string. > > > > _______________________________________________ > Dillo-dev mailing list > Dillo-dev(a)dillo.org > http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev >

Feb. 24, 2009

[patch] Configurable key bindings

by corvid＠lavabit.com

I think I'd feel better if it could be used like prefs, that is, isPressed testing bindings.reload instead of looking for the binding associated with the "reload" string.

Feb. 24, 2009

[patch] Configurable key bindings

by corvid＠lavabit.com

Tim wrote: > > looking in events.h, I think > > (event_state() & (SHIFT | CTRL)) would work. > > Good idea. It does not work as expected though. But this does: > ((event_state() & (SHIFT | CTRL)) == (SHIFT + CTRL)) err, yes :) or probably event_state() == (SHIFT | CTRL) in this case. > Now that we know how to check for multiple modifiers, does somebody > want to implement it? I lean toward not adding features to this patch yet. (Continuing to add features before getting anything into the tree caused dillo not to get frames support, and that was an unfortunate incident all around.)

Feb. 23, 2009

[patch] Configurable key bindings

by tim.nieradzik＠gmx.de

> looking in events.h, I think > (event_state() & (SHIFT | CTRL)) would work. Good idea. It does not work as expected though. But this does: ((event_state() & (SHIFT | CTRL)) == (SHIFT + CTRL)) Now that we know how to check for multiple modifiers, does somebody want to implement it? --Tim

Feb. 23, 2009

[patch] Configurable key bindings

by corvid＠lavabit.com

Tim wrote: > > - I'm sure that Jorge isn't going to want exception handling. > > Why not? Exceptions are more flexible when it comes to longer and > more complicated functions. Of course, we could also return an > integer status code but sometimes it is necessary to return > non-integer values. My Jorge-simulator might be imperfect, but we'll see. (When I did most of my C++, the compiler didn't even have exceptions yet, so I can't claim bitter experience, but they've always looked a bit like gotos to me when it comes to maintainability.) > > PS Are you sure that fltk doesn't allow modifiers to be combined? > > Grepping through fltk/test, it looks like they're combining them > > in menubar.cxx. > > It looks like this is possible indeed. However, I used > event_state(SHIFT & CTRL) to check whether it recognizes a combined > Shift and Ctrl but this did not work for me. Any ideas? looking in events.h, I think (event_state() & (SHIFT | CTRL)) would work.

Feb. 23, 2009

[patch] Configurable key bindings

by tim.nieradzik＠gmx.de

> - I haven't looked at this in any detail yet -- this is just my > paging-through-the-patch response -- but I notice a_Nav_push_forced > in there. Patches should be kept separate. The smaller they are, > the better for review. Yes, it contains my other three patches partially because they were related. > - Lines should not be longer than 79 chars. Okay, I configured VIM appropriately. > - I'm sure that Jorge isn't going to want exception handling. Why not? Exceptions are more flexible when it comes to longer and more complicated functions. Of course, we could also return an integer status code but sometimes it is necessary to return non-integer values. > PS Are you sure that fltk doesn't allow modifiers to be combined? > Grepping through fltk/test, it looks like they're combining them > in menubar.cxx. It looks like this is possible indeed. However, I used event_state(SHIFT & CTRL) to check whether it recognizes a combined Shift and Ctrl but this did not work for me. Any ideas? --Tim

Feb. 23, 2009

[patch] Configurable key bindings

by corvid＠lavabit.com

Wow that was quick! - I personally am open to the idea of changing the dillorc format for existing options, but we'll see what the consensus is. - I haven't looked at this in any detail yet -- this is just my paging-through-the-patch response -- but I notice a_Nav_push_forced in there. Patches should be kept separate. The smaller they are, the better for review. - Lines should not be longer than 79 chars. - I'm sure that Jorge isn't going to want exception handling. I'll add something about that last point to the website, since it's not mentioned currently. PS Are you sure that fltk doesn't allow modifiers to be combined? Grepping through fltk/test, it looks like they're combining them in menubar.cxx.

Feb. 23, 2009

Holiday week

by Hole.destructor＠gmx.de

Hello Jorge, > [ ] https dialog bombing issue. BUG#868 > When enabled, multiple https requests to the same site result > in dialog bombing. The https dpi is disabled by default in > Dillo. Anyway, in Debian, there's a security warning against > dillo for not checking certificates (I don't know what > version of dillo they use, nor why they enable https.) Debian (and Ubuntu) uses a strongly modified version of Dillo-0.8.6, which one can get officially from http://teki.jpn.ph/pc/software/index-e.shtml On the splash screen of debians Dillo it says, that Kiyo <webmaster[at]teki.jpn.ph> is the one to report problems to, so I guess he is the package maintainer or so. Best, Alexander.

Feb. 23, 2009

[patch] Configurable key bindings

by tim.nieradzik＠gmx.de

It took longer to write this patch than I expected. You will find it in the attachment but I do not recommend using it before somebody else has verified it (I am new to C/C++). I had to re-implement the parsing routine. This is mainly because a new line format was introduced which allows you to configure key bindings in your dillorc. Otherwise we would have needed unnecessarily a second file. This is the only thing that changes for the user. The new format looks like this: "set option value" For backward compatibility you can also use an equal sign before the value: "set option=value" so that you only have to put a ``set'' to the beginning of each line in your old dillorc. But more interesting is the support for configurable keys. The corresponding keyword for bindings is called ``bind''. The second parameter of a binding line represents the key combination and the third one its action. Thus, to allow reloading with a single `r' (instead of Ctrl-r), you can simply write: "bind r reload" But you can also do more complex things like setting modifiers (Ctrl, Alt, Left mouse click, etc.). A line mapping the backward action to Ctrl-p looks like this: "bind <Ctrl>p backward" There are some limitations, though: Unfortunately, FLTK does not enable us to combine modifiers in order to set even more key combinations. Because FLTK is C++-only and we need one of its header files, I had to realize this part of the parser in C++, as well. The line parser is written in C because there are too many functions which access an array in which it puts the parsed preferences. We should port everything to C++ as this would help us keeping the code clean. Note that not only alpha-numeric characters but also ``special characters'' such as "Backspace", "Enter", "Tab" and a few others are supported. To get a full list, please refer to src/keys.cc which also contains all modifiers and the default key bindings. I have not figured out yet how to implement scrolling hooks. Hence, it would be nice if someone could implement the symbols "scroll-top", "scroll-bottom", "scroll-left", "scroll-right", "scroll-up" and "scroll-down" as I want to use VIM-like key bindings (h, j, k, l for movement) in Dillo. The downside of this patch is that currently there is an issue with the line parser, which claims to find syntax errors even though the lines look alright for me. This needs to be fixed before this patch can go into mainline. --Tim

Feb. 23, 2009