- Dillo-dev - lists.mailman3.com

Holiday week

by jcid＠dillo.org

On Wed, Mar 11, 2009 at 06:28:22PM +0100, Hofmann Johannes wrote: > On Sat, Feb 21, 2009 at 11:47:56AM -0300, Jorge Arellano Cid wrote: > > Hi there, > > > > I happen to be enjoying a much needed holiday week! :-) > > > > The plan is to come back around near wednesday 25. > > > > In the meanwhile, I leave you with the following issues lurking > > in my list to be considered. Maybe all of them can be left to the > > release after 2.1, but maybe not: > > > > [ ] https dialog bombing issue. BUG#868 > > When enabled, multiple https requests to the same site result > > in dialog bombing. The https dpi is disabled by default in > > Dillo. Anyway, in Debian, there's a security warning against > > dillo for not checking certificates (I don't know what > > version of dillo they use, nor why they enable https.) > > > > [ ] Jump to #anchor doesn't work correctly. > > The idle timeout doesn't work reliably (an old bug). > > > > [ ] Implement @import statement in STYLE element. > > > > [ ] What will we do with xhtml? FF doesn't validate. BUG#732 > > This would be interesting to define. > > (already suggested as discussion material in another thread). > > > > [ ] "-fno-rtti -fno-exceptions" gcc: 64KB less. > > Enabling this switches reduces the binary size. > > > > [ ] dpi for "view page source" (it re-uses search capability). > > Waiting since a long time... > > Do we really need a dpi for this? As long as we don't do syntax > highlighting (which would be nice) we could also do it in dillo > directly. The "View Stylesheets" code is really minimal. As far as I > can see we would need a way to force a certain mime type > (text/plain in this case). Any ideas how to do this? Yes, the dpi can easily add line numbers which are very handy to have. The extra code inside dillo is very small and the dpi too. -- Cheers Jorge.-

March 11, 2009

Holiday week

by Johannes.Hofmann＠gmx.de

On Sat, Feb 21, 2009 at 11:47:56AM -0300, Jorge Arellano Cid wrote: > Hi there, > > I happen to be enjoying a much needed holiday week! :-) > > The plan is to come back around near wednesday 25. > > In the meanwhile, I leave you with the following issues lurking > in my list to be considered. Maybe all of them can be left to the > release after 2.1, but maybe not: > > [ ] https dialog bombing issue. BUG#868 > When enabled, multiple https requests to the same site result > in dialog bombing. The https dpi is disabled by default in > Dillo. Anyway, in Debian, there's a security warning against > dillo for not checking certificates (I don't know what > version of dillo they use, nor why they enable https.) > > [ ] Jump to #anchor doesn't work correctly. > The idle timeout doesn't work reliably (an old bug). > > [ ] Implement @import statement in STYLE element. > > [ ] What will we do with xhtml? FF doesn't validate. BUG#732 > This would be interesting to define. > (already suggested as discussion material in another thread). > > [ ] "-fno-rtti -fno-exceptions" gcc: 64KB less. > Enabling this switches reduces the binary size. > > [ ] dpi for "view page source" (it re-uses search capability). > Waiting since a long time... Do we really need a dpi for this? As long as we don't do syntax highlighting (which would be nice) we could also do it in dillo directly. The "View Stylesheets" code is really minimal. As far as I can see we would need a way to force a certain mime type (text/plain in this case). Any ideas how to do this? Cheers, Johannes

March 11, 2009

My valgrind logs, for all to see.

by Johannes.Hofmann＠gmx.de

On Wed, Mar 11, 2009 at 01:54:00PM +0000, Jeremy Henty wrote: > On Wed, Mar 11, 2009 at 02:10:21PM +0100, Hofmann Johannes wrote: > > Hi Jeremy, > > > > in your valgrind there are still these massive DilloImage related > > leaks. > > My apologies, the version of your patch that I was using failed to > apply after a recent pull so I dropped it and never got round to > fixing it. So it's not been in my local Dillo for the past few days. > > > Can you please make sure that you are running the latest version of > > my img_ref patch (attached)? > > I just merged it. Thanks very much! Ah ok. Let's see if it helps. Cheers, Johannes

March 11, 2009

My valgrind logs, for all to see.

by onepoint＠starurchin.org

On Wed, Mar 11, 2009 at 02:10:21PM +0100, Hofmann Johannes wrote: > Hi Jeremy, > > in your valgrind there are still these massive DilloImage related > leaks. My apologies, the version of your patch that I was using failed to apply after a recent pull so I dropped it and never got round to fixing it. So it's not been in my local Dillo for the past few days. > Can you please make sure that you are running the latest version of > my img_ref patch (attached)? I just merged it. Thanks very much! Regards, Jeremy Henty

March 11, 2009

My valgrind logs, for all to see.

by Johannes.Hofmann＠gmx.de

Hi Jeremy, in your valgrind there are still these massive DilloImage related leaks. Can you please make sure that you are running the latest version of my img_ref patch (attached)? I add added prints to a_Image_new() and Image_free() and recorded them in a logfile. With the patch the numbers seem to match fine here. Cheers, Johannes

March 11, 2009

Holiday week

by jcid＠dillo.org

On Mon, Mar 09, 2009 at 01:16:10AM +0000, corvid wrote: > Jorge wrote: > > [ ] "-fno-rtti -fno-exceptions" gcc: 64KB less. > > Enabling this switches reduces the binary size. > > Is there more to this than the following: Not that I remember (my patch got lost somehow, it had some test for those options being already set, but maybe it's not worth doing it after all). Committed. @all: after this patch the binary size is smaller. e.g. -rwxr-xr-x 1 jcid jcid 983092 2009-03-11 09:11 dillo -- Cheers Jorge.-

March 11, 2009

[PATCH 0 of 3] tweaking the dillo ui for embedded devices

by jcid＠dillo.org

On Tue, Mar 10, 2009 at 02:12:56AM +0100, Justus Winter wrote: > Hofmann Johannes wrote: >> Hi Justus, >> >> On Mon, Mar 09, 2009 at 05:59:31PM +0100, Justus Winter wrote: >>> Hey folks :) >>> >>> I've got a new toy (the Neo FreeRunner) and dillo2 runs quite nicely >>> on that little device, but there are some problems: >>> >>> * there is no way to create bookmarks >> >> What about the context menus in general? Is there no way to simulate >> a right mouse click? dillo uses context menus in many cases so we >> probabely need a general solution for this. > There is a module for gtk2 (libgtkstylus.so) that simulates a right > click when the user holds the left mouse button, that works quite nicely > in practice. Andreas suggestd the same, and it looks like a good solution. Even more if handheld users are accustomed to it. > That was actually what I wanted to implement at first. I looked through > the fltk2 event handling code (most thoroughly with respect to the > button widget) [...] Maybe something like what's used for tooltip can be of help. This has to be asked in fltk general before discarding it. If there's no way, a right-click button may be of help. This is left-click on RCB and the next left-click will be processed as a right click. The idea is to try to reuse the UI as much as possible, and to just code the necessary hooks for it. Please contact Andreas K., he may have good ideas for handheld related issues. -- Cheers Jorge.-

March 11, 2009

[PATCH 0 of 3] tweaking the dillo ui for embedded devices

by 4winter＠informatik.uni-hamburg.de

Hofmann Johannes wrote: > Hi Justus, > > On Mon, Mar 09, 2009 at 05:59:31PM +0100, Justus Winter wrote: >> Hey folks :) >> >> I've got a new toy (the Neo FreeRunner) and dillo2 runs quite nicely >> on that little device, but there are some problems: >> >> * there is no way to create bookmarks > > What about the context menus in general? Is there no way to simulate > a right mouse click? dillo uses context menus in many cases so we > probabely need a general solution for this. There is a module for gtk2 (libgtkstylus.so) that simulates a right click when the user holds the left mouse button, that works quite nicely in practice. That was actually what I wanted to implement at first. I looked through the fltk2 event handling code (most thoroughly with respect to the button widget) and I am convinced that this behavior cannot be implemented without patching fltk2 since the widgets do not call the callback when the button is pressed but only when it's released. I prototyped a solution that abuses the DRAG events to detect PUSH events, but that didn't work very well since DRAG events are only emitted when the cursor moves. Patching fltk2 to also call the callback function on PUSH events is problematic since (at least in dillo2) many callback functions do not test properly whether they are actually interested in that particular event and just assume that it must have been a RELEASE event. >> Adressed in the second patch which adds an add bookmark button to >> the main toolbar. > > What about a dillorc option to make it optional like the other > buttons? Sure thing, that would be great. It shouldn't be too hard to make the toolbar content configurable. >> * the scrollbars are unusable without a stylus >> >> A more natural way of scrolling on embedded devices with touchscreens >> is finger scrolling. A proof of concept is attached as the third patch. > > Didn't look at the code yet, but the concept seems nice. > Maybe we could ship a "dillorc.handheld" or something like that... The changes are actually quite small since a similar functionality was already present, namely panning via the middle mouse button. My patch just adds a configuration option to do so with the left button and to fiddle with the event handling code (you have to pass some events to the page content or you end up with a browser with non functional links :)). Note that this is just a mockup that needs some cleanups (works only for the first tab, need to adjust the open tab functionality in uicmd, text selection works fine with a mouse but is next to impossible on the moko due to double click tolerances (at least thats what I think)). And the text selection part is not configurable at the moment, that's the most problematic part. Any thoughts on how to make dw configurable at runtime while keeping it implementation agnostic with respect to the frontend? Justus

March 10, 2009

[PATCH 0 of 3] tweaking the dillo ui for embedded devices

by Johannes.Hofmann＠gmx.de

Hi Justus, On Mon, Mar 09, 2009 at 05:59:31PM +0100, Justus Winter wrote: > Hey folks :) > > I've got a new toy (the Neo FreeRunner) and dillo2 runs quite nicely > on that little device, but there are some problems: > > * there is no way to create bookmarks What about the context menus in general? Is there no way to simulate a right mouse click? dillo uses context menus in many cases so we probabely need a general solution for this. > > Adressed in the second patch which adds an add bookmark button to > the main toolbar. What about a dillorc option to make it optional like the other buttons? > > * the scrollbars are unusable without a stylus > > A more natural way of scrolling on embedded devices with touchscreens > is finger scrolling. A proof of concept is attached as the third patch. Didn't look at the code yet, but the concept seems nice. Maybe we could ship a "dillorc.handheld" or something like that... > > Acceleration would be a nice feature for big pages. > > * buttons on dialogs are too small > > Proposed solution: There is code for creating dialogs in src/dialog.cc > for a_Dialog_choice5 that creates the dialog window without relying on > fltks choice(). We could generalize that and use it for all dialogs. That would be a good thing anyway so that all dialogs share a consistent look. > > This way we could resize the buttons and stack them vertically on top > of each other. Why not, if that's better for mobile devices and if it's configurable. Cheers, Johannes

March 9, 2009

[PATCH 2 of 3] Add a bookmark button to the toolbar

by 4winter＠informatik.uni-hamburg.de

# HG changeset patch # User Justus Winter <justus.winter(a)informatik.uni-hamburg.de> # Date 1236615692 -3600 # Node ID 78c0fa261c84df53da7f69cc8f33dc85fa152f9c # Parent 9638f05098cf2687dbb863f47fd82461c5417403 Add a bookmark button to the toolbar This is useful for embedded devices with touch screens which lack a proper keyboard and the ability to generate right click events. diff -r 9638f05098cf -r 78c0fa261c84 src/pixmaps.h --- a/src/pixmaps.h Mon Mar 09 17:17:51 2009 +0100 +++ b/src/pixmaps.h Mon Mar 09 17:21:32 2009 +0100 @@ -789,6 +789,34 @@ " . . "}; /* XPM */ +static const char * bm_add_xpm[] = { +"22 22 2 1", +" c None", +". c #FF0000", +" ", +" ", +" ", +" ... ", +" ... ", +" ... ", +" ... ", +" ... ", +" ... ", +" ............... ", +" ............... ", +" ............... ", +" ... ", +" ... ", +" ... ", +" ... ", +" ... ", +" ... ", +" ", +" ", +" ", +" "}; + +/* XPM */ static const char *const tools_xpm[] = { "22 22 25 1", " c #None", @@ -1373,6 +1401,28 @@ " .v. wx. "}; /* XPM */ +static const char * bm_add_s_xpm[] = { +"16 16 2 1", +" c None", +". c #FF0000", +" ", +" ", +" .. ", +" .. ", +" .. ", +" .. ", +" .. ", +" ........... ", +" ........... ", +" .. ", +" .. ", +" .. ", +" .. ", +" ", +" ", +" "}; + +/* XPM */ static const char *const tools_s_xpm[] = { "16 16 45 1", " c #7B127D1C7D08", diff -r 9638f05098cf -r 78c0fa261c84 src/ui.cc --- a/src/ui.cc Mon Mar 09 17:17:51 2009 +0100 +++ b/src/ui.cc Mon Mar 09 17:21:32 2009 +0100 @@ -28,6 +28,7 @@ #include "ui.hh" #include "msg.h" #include "timeout.hh" +#include "html_common.hh" // for DilloHtml using namespace fltk; @@ -38,7 +39,7 @@ struct iconset { Image *ImgMeterOK, *ImgMeterBug, - *ImgHome, *ImgReload, *ImgSave, *ImgBook, *ImgTools, + *ImgHome, *ImgReload, *ImgSave, *ImgBook, *ImgBookAdd, *ImgTools, *ImgClear,*ImgSearch; MultiImage *ImgLeftMulti, *ImgRightMulti, *ImgStopMulti; }; @@ -50,6 +51,7 @@ new xpmImage(reload_xpm), new xpmImage(save_xpm), new xpmImage(bm_xpm), + new xpmImage(bm_add_xpm), new xpmImage(tools_xpm), new xpmImage(new_s_xpm), new xpmImage(search_xpm), @@ -68,6 +70,7 @@ new xpmImage(reload_s_xpm), new xpmImage(save_s_xpm), new xpmImage(bm_s_xpm), + new xpmImage(bm_add_s_xpm), new xpmImage(tools_s_xpm), new xpmImage(new_s_xpm), standard_icons.ImgSearch, @@ -324,6 +327,12 @@ a_UIcmd_book(a_UIcmd_get_bw_by_widget(wid)); } break; + case UI_BOOK_ADD: + if (k == 1) { + BrowserWindow *bw = a_UIcmd_get_bw_by_widget(wid); + a_UIcmd_add_bookmark(bw, ((DilloHtml *) a_Bw_get_current_doc(bw))->page_url); + } + break; case UI_TOOLS: if (k == 1 || k == 3) { a_UIcmd_tools(a_UIcmd_get_bw_by_widget(wid), wid); @@ -416,6 +425,12 @@ b->callback(b1_cb, (void *)UI_BOOK); b->clear_tab_to_focus(); + Bookmarks = b = new HighlightButton(xpos, 0, bw, bh, (lbl) ? "Add" : 0); + b->image(icons->ImgBookAdd); + b->tooltip("Add bookmark"); + b->callback(b1_cb, (void *)UI_BOOK_ADD); + b->clear_tab_to_focus(); + Tools = b = new HighlightButton(xpos, 0, bw, bh, (lbl) ? "Tools" : 0); b->image(icons->ImgTools); b->tooltip("Settings"); diff -r 9638f05098cf -r 78c0fa261c84 src/ui.hh --- a/src/ui.hh Mon Mar 09 17:17:51 2009 +0100 +++ b/src/ui.hh Mon Mar 09 17:21:32 2009 +0100 @@ -26,6 +26,7 @@ UI_SAVE, UI_STOP, UI_BOOK, + UI_BOOK_ADD, UI_TOOLS, UI_CLEAR, UI_SEARCH

March 9, 2009