- Dillo-dev - lists.mailman3.com

HTTP header whitespace (Re: [Dillo-dev] img'es from funny redirecting urls aren't displayed)

by corvid＠lavabit.com

Andreas wrote: > there is also > > http://www.estofex.org/cgi-bin/polygon/showforecast.cgi?listvalid=yes > > The map images on that page give a 30x redirect. > If I select "isolate image", dillo sends > GET /forecasts/tempmap/2010022606_201002241505_1_stormforecast.xml.png%20 > HTTP/1.1 > > The Location: URL in the 30x HTTP-Header contains a trailing whitespace > as an additional problem, > Is dillo wrong here or is the server side wrong? Common sense says that > spaces should be ignored. Dillo is wrong. In RFC 2616, section 4.2: The field-content does not include any leading or trailing LWS: linear white space occurring before the first non-whitespace character of the field-value or after the last non-whitespace character of the field-value. Such leading or trailing LWS MAY be removed without changing the semantics of the field value. I'll fix this.

Feb. 25, 2010

Re: fullwindow_start=YES config doesn't work with 2.2

by Johannes.Hofmann＠gmx.de

On Wed, Feb 24, 2010 at 02:47:26PM -0500, Dennis Nezic wrote: > On Wed, 24 Feb 2010 14:22:01 -0300, Jorge Arellano Cid wrote: > > On Wed, Feb 24, 2010 at 10:24:02AM -0500, Dennis Nezic wrote: > > > When dillorc's fullwindow_start=YES (which is supposed to hide the > > > widget panels on startup), it doesn't actually do this. (It does > > > hide it after you click on a link or type in a url.) My guess is it > > > was assumed that the first thing you want to do when opening a > > > browser is to type in a url (or click a bookmark link, etc) -- but > > > this is not true. (Many times I want to simply load a single page > > > and then close it.) > > > > It's a bug! > > > > Please check how the patch in current repository works for you. > > Works great! Thanks! I see an issue with the current fix. It never focusses location in fullscreen mode for new windows. So when opening a new empty window (e.g. Ctrl-N) in fullscreen mode, the location bar is not focussed. Jorge, what do you think about the alternative fix below. It sticks to the principle stated in the comment in UIcmd_open_url_nbw(). diff -r 5d2db34381f9 src/uicmd.cc --- a/src/uicmd.cc Thu Feb 25 18:17:48 2010 +0100 +++ b/src/uicmd.cc Thu Feb 25 18:22:21 2010 +0100 @@ -471,8 +471,7 @@ win->callback(win_cb, DilloTabs); - if (new_ui->get_panelmode() != UI_HIDDEN) - new_ui->focus_location(); + new_ui->focus_location(); return new_bw; } @@ -617,6 +616,8 @@ void a_UIcmd_open_url(BrowserWindow *bw, const DilloUrl *url) { a_Nav_push(bw, url); + if (BW2UI(bw)->get_panelmode() == UI_TEMPORARILY_SHOW_PANELS) + BW2UI(bw)->set_panelmode(UI_HIDDEN); a_UIcmd_focus_main_area(bw); } Cheers, Johannes

Feb. 25, 2010

img'es from funny redirecting urls aren't displayed

by andreas＠kemnade.info

Skipped content of type multipart/mixed

Feb. 25, 2010

Re: fullwindow_start=YES config doesn't work with 2.2

by Johannes.Hofmann＠gmx.de

On Wed, Feb 24, 2010 at 06:07:48PM -0500, Dennis Nezic wrote: > On Wed, 24 Feb 2010 23:57:12 +0100, Johannes Hofmann wrote: > > On Wed, Feb 24, 2010 at 05:14:30PM +0000, corvid wrote: > > > Dennis wrote: > > > > When dillorc's fullwindow_start=YES (which is supposed to hide the > > > > widget panels on startup), it doesn't actually do this. (It does > > > > hide it after you click on a link or type in a url.) My guess is > > > > it was assumed that the first thing you want to do when opening a > > > > browser is to type in a url (or click a bookmark link, etc) -- > > > > but this is not true. (Many times I want to simply load a single > > > > page and then close it.) > > > > > > I think it was an oversight because there are lots of preferences > > > and we don't all use them (I'm thinking of the Havoc Pennington > > > articles on preferences and UI that Jorge has brought up on > > > occasion). > > > > > > So I guess we should > > > - continue to focus_location when open url was selected by key > > > combination or menu. > > > - check the pref first for the other cases. > > > > > > Johannes, does that sound right? > > > > Hm, in case we have a URL from the command line, there is no need to > > focus_location obviously. > > What do we do if fullwindow_start=YES is set and no url is given on > > the command line? > > No panel, as per the preferences description :b. > > Which is somewhat related to another problem I'm still having ... when > fullwindow_start=YES and I Ctrl-L to go to the location bar, but don't > Ctrl-space to toggle fullscreen-mode, it works (shows the location bar) > only for the first tab -- but not in any other tabs I open (Ctrl-T). > > Ctrl-L should automatically de-fullscreen the tab, n'est-ce pas? That's just another bug. I have just committed a fix. Please give it a try. Cheers, Johannes

Feb. 25, 2010

Re: fullwindow_start=YES config doesn't work with 2.2

by corvid＠lavabit.com

Dennis wrote: > Which is somewhat related to another problem I'm still having ... when > fullwindow_start=YES and I Ctrl-L to go to the location bar, but don't > Ctrl-space to toggle fullscreen-mode, it works (shows the location bar) > only for the first tab -- but not in any other tabs I open (Ctrl-T). > > Ctrl-L should automatically de-fullscreen the tab, n'est-ce pas? Would you expect this for new windows that you ^N into existence as well?

Feb. 25, 2010

img'es from funny redirecting urls aren't displayed

by francis＠daoine.org

On Wed, Feb 24, 2010 at 06:42:23PM -0500, Dennis Nezic wrote: Hi there, that's working as designed. (Unless the design has changed since I last looked.) > For example, opening a simple page with: > > <html> > <body> > <img src="http://imgur.com/N2XcD.png" /> > </body> > </html> > > ... the image is not displayed. Dillo simply says: > > Dns_server [0]: imgur.com is 72.251.206.98 The HTTP response is a 301 redirection. For images within a page, dillo doesn't follow them. (It was the case that enough redirected images were ads, trackers, or other probably-unwanted content. It likely still is the case.) > BUT opening "dillo http://imgur.com/N2XcD.png" works: > > Dns_server [0]: imgur.com is 72.251.206.98 > Connecting to 72.251.206.98 > Nav_open_url: new url='http://i.imgur.com/N2XcD.png' > Dns_server [0]: i.imgur.com is 208.122.28.2 208.122.28.3 208.122.28.4 > 208.122.28.10 208.122.28.11 208.122.28.12 208.122.28.13 208.122.28.18 > 208.122.28.20 208.122.28.21 208.122.28.26 208.122.28.27 208.122.28.29 > 208.122.28.30 Connecting to 208.122.28.2 It's still a HTTP 301 response, but here you requested the image url, and dillo does follow redirections for requested urls. f -- Francis Daly francis(a)daoine.org

Feb. 25, 2010

img'es from funny redirecting urls aren't displayed

by dennisn＠dennisn.dyndns.org

For example, opening a simple page with: <html> <body> <img src="http://imgur.com/N2XcD.png" /> </body> </html> ... the image is not displayed. Dillo simply says: Dns_server [0]: imgur.com is 72.251.206.98 BUT opening "dillo http://imgur.com/N2XcD.png" works: Dns_server [0]: imgur.com is 72.251.206.98 Connecting to 72.251.206.98 Nav_open_url: new url='http://i.imgur.com/N2XcD.png' Dns_server [0]: i.imgur.com is 208.122.28.2 208.122.28.3 208.122.28.4 208.122.28.10 208.122.28.11 208.122.28.12 208.122.28.13 208.122.28.18 208.122.28.20 208.122.28.21 208.122.28.26 208.122.28.27 208.122.28.29 208.122.28.30 Connecting to 208.122.28.2

Feb. 25, 2010

Re: fullwindow_start=YES config doesn't work with 2.2

by dennisn＠dennisn.dyndns.org

On Wed, 24 Feb 2010 23:57:12 +0100, Johannes Hofmann wrote: > On Wed, Feb 24, 2010 at 05:14:30PM +0000, corvid wrote: > > Dennis wrote: > > > When dillorc's fullwindow_start=YES (which is supposed to hide the > > > widget panels on startup), it doesn't actually do this. (It does > > > hide it after you click on a link or type in a url.) My guess is > > > it was assumed that the first thing you want to do when opening a > > > browser is to type in a url (or click a bookmark link, etc) -- > > > but this is not true. (Many times I want to simply load a single > > > page and then close it.) > > > > I think it was an oversight because there are lots of preferences > > and we don't all use them (I'm thinking of the Havoc Pennington > > articles on preferences and UI that Jorge has brought up on > > occasion). > > > > So I guess we should > > - continue to focus_location when open url was selected by key > > combination or menu. > > - check the pref first for the other cases. > > > > Johannes, does that sound right? > > Hm, in case we have a URL from the command line, there is no need to > focus_location obviously. > What do we do if fullwindow_start=YES is set and no url is given on > the command line? No panel, as per the preferences description :b. Which is somewhat related to another problem I'm still having ... when fullwindow_start=YES and I Ctrl-L to go to the location bar, but don't Ctrl-space to toggle fullscreen-mode, it works (shows the location bar) only for the first tab -- but not in any other tabs I open (Ctrl-T). Ctrl-L should automatically de-fullscreen the tab, n'est-ce pas?

Feb. 25, 2010

fullwindow_start=YES config doesn't work with 2.2

by Johannes.Hofmann＠gmx.de

On Wed, Feb 24, 2010 at 05:14:30PM +0000, corvid wrote: > Dennis wrote: > > When dillorc's fullwindow_start=YES (which is supposed to hide the > > widget panels on startup), it doesn't actually do this. (It does hide > > it after you click on a link or type in a url.) My guess is it was > > assumed that the first thing you want to do when opening a browser is > > to type in a url (or click a bookmark link, etc) -- but this is not > > true. (Many times I want to simply load a single page and then close > > it.) > > I think it was an oversight because there are lots of preferences and > we don't all use them (I'm thinking of the Havoc Pennington articles on > preferences and UI that Jorge has brought up on occasion). > > So I guess we should > - continue to focus_location when open url was selected by key combination > or menu. > - check the pref first for the other cases. > > Johannes, does that sound right? Hm, in case we have a URL from the command line, there is no need to focus_location obviously. What do we do if fullwindow_start=YES is set and no url is given on the command line?

Feb. 24, 2010

openmoko packages for dillo

by corvid＠lavabit.com

Andreas wrote: > I have updated the openmoko packages for dillo at > http://misc.andi.de1.cc/dillo Added to website :)

Feb. 24, 2010