- Dillo-dev - lists.mailman3.com

patch: implement white-space: pre-wrap for vsource

by corvid＠lavabit.com

Johannes wrote: > On Tue, Mar 30, 2010 at 06:00:26AM +0000, corvid wrote: > > Just a thought I had. The web is filled with horrible generated html > > with lines a thousand characters long. With this (and parse_embedded_css), > > those lines become more tolerable. > > Very nice! > > > > > I would commit it in two pieces, of course. > > Please go ahead - at least for the CSS / dw part. I don't know > whether it's ok to use it for source view. I've read that it's in CSS 2.1 and 3, but not 1 or 2. 2 is a "recommendation", but 2.1 is a "candidate recommendation". Are we aiming more in the direction of 2 or 2.1 (or their intersection)?

March 30, 2010

patch: implement white-space: pre-wrap for vsource

by Johannes.Hofmann＠gmx.de

On Tue, Mar 30, 2010 at 09:57:08PM +0200, Johannes Hofmann wrote: > On Tue, Mar 30, 2010 at 06:00:26AM +0000, corvid wrote: > > Just a thought I had. The web is filled with horrible generated html > > with lines a thousand characters long. With this (and parse_embedded_css), > > those lines become more tolerable. > > Very nice! > > > > > I would commit it in two pieces, of course. > > Please go ahead - at least for the CSS / dw part. I don't know > whether it's ok to use it for source view. In any case we could add an id like this: <body id="dillo_sv"> to the source view page, so people can adjust it in style.css, e.g: body#dillo_sv pre {white-space: pre-wrap}

March 30, 2010

patch: implement white-space: pre-wrap for vsource

by Johannes.Hofmann＠gmx.de

On Tue, Mar 30, 2010 at 06:00:26AM +0000, corvid wrote: > Just a thought I had. The web is filled with horrible generated html > with lines a thousand characters long. With this (and parse_embedded_css), > those lines become more tolerable. Very nice! > > I would commit it in two pieces, of course. Please go ahead - at least for the CSS / dw part. I don't know whether it's ok to use it for source view. Cheers, Johannes

March 30, 2010

patch: implement white-space: pre-wrap for vsource

by corvid＠lavabit.com

Just a thought I had. The web is filled with horrible generated html with lines a thousand characters long. With this (and parse_embedded_css), those lines become more tolerable. I would commit it in two pieces, of course.

March 30, 2010

Problem using "Textblock" Class.

by Johannes.Hofmann＠gmx.de

On Fri, Mar 26, 2010 at 02:03:08AM +0000, corvid wrote: > Johannes wrote: <snip> > > > > Ok, I made a very rough patch to demonstrate the concept (see > > attachment). > > The main problem - apart from code style - is how to restore the > > original color of the link once anotherone has been selected. This > > is not working properly with this patch, but it's a start. > > Maybe the focused link can use a highlighting layer in Textblock > to show it in inverse video rather than dealing with html and link colors. That would be an easy alternative, but I'm investigating how much effort it would be to properly implement the CSS dynmic pseudo classes (:hover, :active, :focus). :focus basically defines how a selected element should look like. E.g: <html> <head> <style type="text/css"> :focus {border: 1px solid green} </style> </head> <body> <a href="foo">foo</a> <a href="bar">bar</a> </body> works in firefox and shows a green border around the currently selected link. With :active anything in the style can be changed, not just the colors.

March 26, 2010

Problem using "Textblock" Class.

by corvid＠lavabit.com

Johannes wrote: > On Thu, Mar 25, 2010 at 05:28:04PM +0100, Johannes Hofmann wrote: > > On Thu, Mar 25, 2010 at 03:56:31PM +0000, corvid wrote: > > > Johannes wrote: > > > > On Wed, Mar 24, 2010 at 04:49:09PM +0000, corvid wrote: > > > > > Johannes wrote: > > > > > > On Wed, Mar 24, 2010 at 02:34:13PM +0530, Rajesh Marathe wrote: > > > > > > > Hello Corvid, > > > > > > > > > > > > > > You hit the nail on its head. > > > > > > > I will definitely use iterators to iterate on the words on a page. I do have > > > > > > > the code with me which is based on findtext.cc as mentioned by Johannes. > > > > > > > But, using iterators I can move to a word on a page. But to get its style, I > > > > > > > still need to access the "x_link" variable which is in the class Textblock. > > > > > > > Therefore, my understanding was to use both iterator class and the Textblock > > > > > > > class as well. > > > > > > > > > > > > > > However, after seeing your email I get a feeling that my understanding might > > > > > > > be incorrect. > > > > > > > So, right now, my problem is not in using iterators (Which I intend to do > > > > > > > anyways) but getting the x_link variable which is in Textblock class. Please > > > > > > > let me know where am I wrong. > > > > > > > > > > > > Ah, I think I see your problem now. Iterators have the getContent() > > > > > > method, but Content does not include the style and therefore not the > > > > > > x_link. > > > > > > I'd say we should enhance the Iterator interface to make it possible > > > > > > to get the style somehow. However I don't know yet what would be the > > > > > > best way to do it. > > > > > > corvid, what do you think? > > > > > > > > > > Ah, in my earlier mail, I was imagining there being a getFocusable() in our > > > > > new iterator that gave back a Widget and a linkNo in the same way that the char > > > > > iterator has getChar(), but now I see that the base iterator already has a > > > > > getWidget(), so I guess we would just need a getLinkNo(). > > > > > > > > Right, either that, or a bit more general a getStyle() method, that > > > > would return the style at the current position (including x_link). > > > > > > Maybe. I don't think I have a strong opinion on 'general' vs. > > > 'unnecessary exposure' on this issue yet. > > > > Good point. Let's start with getLinkNo() and switch to getStyle() > > once we actually need another style member. > > Ok, I made a very rough patch to demonstrate the concept (see > attachment). > The main problem - apart from code style - is how to restore the > original color of the link once anotherone has been selected. This > is not working properly with this patch, but it's a start. Maybe the focused link can use a highlighting layer in Textblock to show it in inverse video rather than dealing with html and link colors.

March 26, 2010

Problem using "Textblock" Class.

by Johannes.Hofmann＠gmx.de

On Thu, Mar 25, 2010 at 05:28:04PM +0100, Johannes Hofmann wrote: > On Thu, Mar 25, 2010 at 03:56:31PM +0000, corvid wrote: > > Johannes wrote: > > > On Wed, Mar 24, 2010 at 04:49:09PM +0000, corvid wrote: > > > > Johannes wrote: > > > > > On Wed, Mar 24, 2010 at 02:34:13PM +0530, Rajesh Marathe wrote: > > > > > > Hello Corvid, > > > > > > > > > > > > You hit the nail on its head. > > > > > > I will definitely use iterators to iterate on the words on a page. I do have > > > > > > the code with me which is based on findtext.cc as mentioned by Johannes. > > > > > > But, using iterators I can move to a word on a page. But to get its style, I > > > > > > still need to access the "x_link" variable which is in the class Textblock. > > > > > > Therefore, my understanding was to use both iterator class and the Textblock > > > > > > class as well. > > > > > > > > > > > > However, after seeing your email I get a feeling that my understanding might > > > > > > be incorrect. > > > > > > So, right now, my problem is not in using iterators (Which I intend to do > > > > > > anyways) but getting the x_link variable which is in Textblock class. Please > > > > > > let me know where am I wrong. > > > > > > > > > > Ah, I think I see your problem now. Iterators have the getContent() > > > > > method, but Content does not include the style and therefore not the > > > > > x_link. > > > > > I'd say we should enhance the Iterator interface to make it possible > > > > > to get the style somehow. However I don't know yet what would be the > > > > > best way to do it. > > > > > corvid, what do you think? > > > > > > > > Ah, in my earlier mail, I was imagining there being a getFocusable() in our > > > > new iterator that gave back a Widget and a linkNo in the same way that the char > > > > iterator has getChar(), but now I see that the base iterator already has a > > > > getWidget(), so I guess we would just need a getLinkNo(). > > > > > > Right, either that, or a bit more general a getStyle() method, that > > > would return the style at the current position (including x_link). > > > > Maybe. I don't think I have a strong opinion on 'general' vs. > > 'unnecessary exposure' on this issue yet. > > Good point. Let's start with getLinkNo() and switch to getStyle() > once we actually need another style member. Ok, I made a very rough patch to demonstrate the concept (see attachment). The main problem - apart from code style - is how to restore the original color of the link once anotherone has been selected. This is not working properly with this patch, but it's a start. You can switch from one link to the next with <Tab>. Cheers, Johannes

March 25, 2010

Problem using "Textblock" Class.

by Johannes.Hofmann＠gmx.de

On Thu, Mar 25, 2010 at 03:56:31PM +0000, corvid wrote: > Johannes wrote: > > On Wed, Mar 24, 2010 at 04:49:09PM +0000, corvid wrote: > > > Johannes wrote: > > > > On Wed, Mar 24, 2010 at 02:34:13PM +0530, Rajesh Marathe wrote: > > > > > Hello Corvid, > > > > > > > > > > You hit the nail on its head. > > > > > I will definitely use iterators to iterate on the words on a page. I do have > > > > > the code with me which is based on findtext.cc as mentioned by Johannes. > > > > > But, using iterators I can move to a word on a page. But to get its style, I > > > > > still need to access the "x_link" variable which is in the class Textblock. > > > > > Therefore, my understanding was to use both iterator class and the Textblock > > > > > class as well. > > > > > > > > > > However, after seeing your email I get a feeling that my understanding might > > > > > be incorrect. > > > > > So, right now, my problem is not in using iterators (Which I intend to do > > > > > anyways) but getting the x_link variable which is in Textblock class. Please > > > > > let me know where am I wrong. > > > > > > > > Ah, I think I see your problem now. Iterators have the getContent() > > > > method, but Content does not include the style and therefore not the > > > > x_link. > > > > I'd say we should enhance the Iterator interface to make it possible > > > > to get the style somehow. However I don't know yet what would be the > > > > best way to do it. > > > > corvid, what do you think? > > > > > > Ah, in my earlier mail, I was imagining there being a getFocusable() in our > > > new iterator that gave back a Widget and a linkNo in the same way that the char > > > iterator has getChar(), but now I see that the base iterator already has a > > > getWidget(), so I guess we would just need a getLinkNo(). > > > > Right, either that, or a bit more general a getStyle() method, that > > would return the style at the current position (including x_link). > > Maybe. I don't think I have a strong opinion on 'general' vs. > 'unnecessary exposure' on this issue yet. Good point. Let's start with getLinkNo() and switch to getStyle() once we actually need another style member.

March 25, 2010

Problem using "Textblock" Class.

by corvid＠lavabit.com

Johannes wrote: > On Wed, Mar 24, 2010 at 04:49:09PM +0000, corvid wrote: > > Johannes wrote: > > > On Wed, Mar 24, 2010 at 02:34:13PM +0530, Rajesh Marathe wrote: > > > > Hello Corvid, > > > > > > > > You hit the nail on its head. > > > > I will definitely use iterators to iterate on the words on a page. I do have > > > > the code with me which is based on findtext.cc as mentioned by Johannes. > > > > But, using iterators I can move to a word on a page. But to get its style, I > > > > still need to access the "x_link" variable which is in the class Textblock. > > > > Therefore, my understanding was to use both iterator class and the Textblock > > > > class as well. > > > > > > > > However, after seeing your email I get a feeling that my understanding might > > > > be incorrect. > > > > So, right now, my problem is not in using iterators (Which I intend to do > > > > anyways) but getting the x_link variable which is in Textblock class. Please > > > > let me know where am I wrong. > > > > > > Ah, I think I see your problem now. Iterators have the getContent() > > > method, but Content does not include the style and therefore not the > > > x_link. > > > I'd say we should enhance the Iterator interface to make it possible > > > to get the style somehow. However I don't know yet what would be the > > > best way to do it. > > > corvid, what do you think? > > > > Ah, in my earlier mail, I was imagining there being a getFocusable() in our > > new iterator that gave back a Widget and a linkNo in the same way that the char > > iterator has getChar(), but now I see that the base iterator already has a > > getWidget(), so I guess we would just need a getLinkNo(). > > Right, either that, or a bit more general a getStyle() method, that > would return the style at the current position (including x_link). Maybe. I don't think I have a strong opinion on 'general' vs. 'unnecessary exposure' on this issue yet. > But then how would we implement visual feedback? We probabely want > to highlight the currently selected link somehow. > We could for now use changeLinkColor(). What do you think? All right.

March 25, 2010

Problem using "Textblock" Class.

by Johannes.Hofmann＠gmx.de

On Wed, Mar 24, 2010 at 04:49:09PM +0000, corvid wrote: > Johannes wrote: > > On Wed, Mar 24, 2010 at 02:34:13PM +0530, Rajesh Marathe wrote: > > > Hello Corvid, > > > > > > You hit the nail on its head. > > > I will definitely use iterators to iterate on the words on a page. I do have > > > the code with me which is based on findtext.cc as mentioned by Johannes. > > > But, using iterators I can move to a word on a page. But to get its style, I > > > still need to access the "x_link" variable which is in the class Textblock. > > > Therefore, my understanding was to use both iterator class and the Textblock > > > class as well. > > > > > > However, after seeing your email I get a feeling that my understanding might > > > be incorrect. > > > So, right now, my problem is not in using iterators (Which I intend to do > > > anyways) but getting the x_link variable which is in Textblock class. Please > > > let me know where am I wrong. > > > > Ah, I think I see your problem now. Iterators have the getContent() > > method, but Content does not include the style and therefore not the > > x_link. > > I'd say we should enhance the Iterator interface to make it possible > > to get the style somehow. However I don't know yet what would be the > > best way to do it. > > corvid, what do you think? > > Ah, in my earlier mail, I was imagining there being a getFocusable() in our > new iterator that gave back a Widget and a linkNo in the same way that the char > iterator has getChar(), but now I see that the base iterator already has a > getWidget(), so I guess we would just need a getLinkNo(). Right, either that, or a bit more general a getStyle() method, that would return the style at the current position (including x_link). But then how would we implement visual feedback? We probabely want to highlight the currently selected link somehow. We could for now use changeLinkColor(). What do you think?

March 25, 2010