- Dillo-dev - lists.mailman3.com

[patch]: html.cc: re-indent Html_tag_open_q() for consistency

by onepoint＠starurchin.org

The wise say you shouldn't sweat the small stuff, but when one function in a file is indented by 4 spaces and all the rest are indented by 3, well... Regards, Jeremy Henty

Sept. 6, 2010

[bug]: <pre> element respects color but not background-color

by Johannes.Hofmann＠gmx.de

On Mon, Sep 06, 2010 at 07:18:52AM +0100, Jeremy Henty wrote: > > Johannes Hofmann wrote: > > > Correct. All Html_tag_open_*() functions that don't add a widget > > (e.g. a textblock or an image) must call > > html->styleEngine->inheritBackgroundColor() to make background-color > > work. Unfortunately this is just a hack that doesn't solve all > > problems. E.g. <pre style="border: 1px solid black">foo</pre> will > > still not work. For now, I would just add inheritBackgroundColor() > > where necessary. > > OK, patch attached. Please review carefully - I am not familiar with > the Dillo CSS implementation so this is really a request for comments. > (Although it does fix the page that first highlighted the problem.) Thanks! I commited a slightly modified version. Cheers, Johannes

Sept. 6, 2010

[bug]: <pre> element respects color but not background-color

by onepoint＠starurchin.org

Johannes Hofmann wrote: > Correct. All Html_tag_open_*() functions that don't add a widget > (e.g. a textblock or an image) must call > html->styleEngine->inheritBackgroundColor() to make background-color > work. Unfortunately this is just a hack that doesn't solve all > problems. E.g. <pre style="border: 1px solid black">foo</pre> will > still not work. For now, I would just add inheritBackgroundColor() > where necessary. OK, patch attached. Please review carefully - I am not familiar with the Dillo CSS implementation so this is really a request for comments. (Although it does fix the page that first highlighted the problem.) And thanks for the explanation of the CSS workings! Regards, Jeremy Henty

Sept. 6, 2010

[patch]: consistent screaming quotes

by Johannes.Hofmann＠gmx.de

On Sun, Sep 05, 2010 at 09:53:05AM +0100, Jeremy Henty wrote: > > A small cleanup. I noticed the ugly unbalanced quotes in the '>>> > a_Nav_repush <<<<' message so I did a quick grep and fixed all similar > messages to have the same formatting. Committed! Cheers, Johannes

Sept. 5, 2010

[bug]: <pre> element respects color but not background-color

by Johannes.Hofmann＠gmx.de

Hi Jeremy, On Sun, Sep 05, 2010 at 12:52:02PM +0100, Jeremy Henty wrote: > > The problem is that Html_tag_open_pre() does not call > html->styleEngine->inheritBackgroundColor() before calling > HT2TB(html)->addParbreak(). But several other Html_tag_open_*() > functions have the same problem, eg. Html_tag_open_{dt,dl}(). Should > we fix them one by one or is there a better way? Correct. All Html_tag_open_*() functions that don't add a widget (e.g. a textblock or an image) must call html->styleEngine->inheritBackgroundColor() to make background-color work. Unfortunately this is just a hack that doesn't solve all problems. E.g. <pre style="border: 1px solid black">foo</pre> will still not work. For now, I would just add inheritBackgroundColor() where necessary. > > Also, I wonder if more of the Html_tag_open_*() functions should call > html->styleEngine->setNonCssHints(), but I don't understand the CSS > engine well enough to be sure. setNonCssHints() in contrast is not a hack :-) It is used to pass style information from (deprecated) non-CSS HTML attributes like bgColor, align and so on to StyleEngine. This style information from HTML attributes has to be handled specially as described in http://www.w3.org/TR/CSS2/cascade.html#preshint So for all HTML-attributes that we want to support and that change the style there should be a corresponding setNonCssHints() call. Regards, Johannes

Sept. 5, 2010

[bug]: <pre> element respects color but not background-color

by onepoint＠starurchin.org

The problem is that Html_tag_open_pre() does not call html->styleEngine->inheritBackgroundColor() before calling HT2TB(html)->addParbreak(). But several other Html_tag_open_*() functions have the same problem, eg. Html_tag_open_{dt,dl}(). Should we fix them one by one or is there a better way? Also, I wonder if more of the Html_tag_open_*() functions should call html->styleEngine->setNonCssHints(), but I don't understand the CSS engine well enough to be sure. Regards, Jeremy Henty

Sept. 5, 2010

[bug]: <pre> element respects color but not background-color

by onepoint＠starurchin.org

<html> <head> <style type="text/css"> pre { background-color:#222; color:#fff; } </style> </head> <body> <pre>Blah, blah, blah</pre> </body> </html> Dillo renders the above as white text on the default background, which is almost illegible. Firefox renders it white on black, as intended. If you apply the style to the body element instead of the pre element then Dillo renders it correctly. The pre element respects the color style parameter but not the background-color. This bug is visible at http://jeffkreeftmeijer.com/2010/the-mighty-reflog-and-the-amazing-bisect/ Regards, Jeremy Henty

Sept. 5, 2010

[patch]: consistent screaming quotes

by onepoint＠starurchin.org

A small cleanup. I noticed the ugly unbalanced quotes in the '>>> a_Nav_repush <<<<' message so I did a quick grep and fixed all similar messages to have the same formatting. (I am still thinking about the "parse missing attribute close quotes like Firefox" patch, but it's taking me a little while to get familiar with html.cc again.) Regards, Jeremy Henty

Sept. 5, 2010

Fwd: your dillo win32 build ....

by obeythepenguin＠gmail.com

Received this earlier today, and figured I should share with the people who deserve real credit :-) ~Benjamin ------- Forwarded message ------- From: "a.r. ramakrishnan" <srizbf(a)gmail.com> To: obeythepenguin(a)gmail.com Cc: Subject: your dillo win32 build .... Date: Fri, 03 Sep 2010 12:40:54 -0400 Hello Benjamin jhonson, congrats for your attempt on dillo for windows. i have tested your 20100902 binary. your building dillo for win9x is exceptional. and it is working under windows98. there are some layout problems in webpages. but barring that you have given the fast browser for normal use . thank you once again expecting many more from you 3rdsep2010 -- Using Opera's revolutionary e-mail client: http://www.opera.com/mail/

Sept. 4, 2010

Another (native) Dillo-Win32 patch

by obeythepenguin＠gmail.com

All right, I have it running on Windows 95! Screenshots: http://dillo-win32.sourceforge.net/screenshots/dillo-win95.png http://dillo-win32.sourceforge.net/screenshots/dillo-wikipedia-win95.png It's still a little glitchy (FLTK issues, not Dillo per se), but now Dillo can truly run on any Windows system, for all practical purposes. [Of course, if you can prove people still use Win3.11...] Here's the latest patch: http://dillo-win32.sourceforge.net/files/dillo-r1698-win32-20100902.diff I've also got a full installer up on the SourceForge page, if anyone has a Windows machine and wants to take it for a spin. I've been using it quite a bit myself the last few days, including three straight hours the other night. As long as you don't need DPI, it's quite usable. Speaking of which... there's going to be a few complications, mainly because on Windows, file and socket handles are NOT interchangable. DPI seems to rely heavily on dup2(), for which there's no direct Windows equivalent. I've written up a full description of the problem here: http://dillo-win32.sourceforge.net/dpi.html This is where I'm going to need your expert advice. Jorge, if you have the time, I'd especially like to hear your opinion -- I know you're quite busy, and not a personal fan of the Windows platform, but I feel a well-executed port would ultimately help the project far more than it would hurt anything. Thanks again & cheers, ~Benjamin

Sept. 3, 2010