- Dillo-dev - lists.mailman3.com

[patch]: ignore unknown @-rules in CSS

by onepoint＠starurchin.org

Currently Dillo tries to parse every @-rule in the same way (with CssParser::parseImport()). This causes problems, particularly with @media. Here[1] part of the style is missing so that the line size is smaller than the text. I have also attached a small test case where a @media rule causes the red style to go missing. So, here are two patches that make Dillo ignore @-rules that it does not recognise. The first patch just moves the test for the import keyword from CssParser::parseImport() into the main parser loop. Because it changes indentation it looks much more radical than it is. The second patch reworks the main parser loop so that CssParser::parseImport() is only called for @import and other @-rules are skipped. Please review and comment. I will push the patches if you think they are good. Regards, Jeremy Henty [1]http://johannhari.com//2010/11/19/we-should-not-tolerate-religious-excuse…

Nov. 20, 2010

patch: text-indent

by Johannes.Hofmann＠gmx.de

On Fri, Nov 19, 2010 at 06:15:45PM +0000, corvid wrote: > I wrote: > > However, with > > <div style="text-indent: 1em; border: 1px solid"> > > <table border=1> > > <tr><td>I'm<td>a<td>table > > </table> > > text > > </div> > > firefox doesn't indent the text in the cells, and I don't know why > > not. The property inherits. Guess I have some deeper spec reading > > in my immediate future. > > Ah, http://davidwalsh.name/firefox-internal-rendering-css > shows > table { > .. > text-indent: 0; > } Yeah tables seem to reset some CSS values traditionally. There is already a related comment in css.cc with the following link: http://developer.mozilla.org/En/Fixing_Table_Inheritance_in_Quirks_Mode Cheers, Johannes

Nov. 19, 2010

patch: text-indent

by corvid＠lavabit.com

I wrote: > However, with > <div style="text-indent: 1em; border: 1px solid"> > <table border=1> > <tr><td>I'm<td>a<td>table > </table> > text > </div> > firefox doesn't indent the text in the cells, and I don't know why > not. The property inherits. Guess I have some deeper spec reading > in my immediate future. Ah, http://davidwalsh.name/firefox-internal-rendering-css shows table { .. text-indent: 0; }

Nov. 19, 2010

patch: text-indent

by corvid＠lavabit.com

Committed a change. I see that tables still don't work properly with it. <table border=1 style="text-indent: 1em"> <tr><td>I'm<td>a<td>table </table> doesn't make the cells big enough, but that's simply because I haven't looked into it yet. However, with <div style="text-indent: 1em; border: 1px solid"> <table border=1> <tr><td>I'm<td>a<td>table </table> text </div> firefox doesn't indent the text in the cells, and I don't know why not. The property inherits. Guess I have some deeper spec reading in my immediate future.

Nov. 19, 2010

fatal error while compiling fltk

by lolveley＠yahoo.fr

fine! I compiled fltk without the text "glut" near DIRS, and then dillo, all this without errors. and now I have HTML support in claws-mail. thanks! olivier Le Thu, 18 Nov 2010 19:25:48 +0000, James Lovejoy <jameslovejoy(a)tiscali.co.uk> a ?crit : > Right, well it seems to me it's just building tests. So open > "Makefile" and delete the word "glut" from the DIRS variable. I > haven't tested it but it should work. > > On 18 Nov 2010, at 19:05, olivier SAINT-EVE <lolveley(a)yahoo.fr> wrote: > > > Hello, > > > > here is the result of the compilation of fltk: > > ******************************************************************** > > lolveley@linux-f5pi:~/bin/claws/fltk-2.0.x-r7725> make > > === making src === > > === making images/libjpeg === > > === making images/libpng === > > === making images === > > === making OpenGL === > > === making fluid === > > === making glut === > > Linking glpuzzle... > > glpuzzle.o: In function `redraw()': > > glpuzzle.cxx:(.text+0xbe7): undefined reference to `gluPerspective' > > glpuzzle.o: In function `selectPiece(int, int)': > > glpuzzle.cxx:(.text+0x12a6): undefined reference to `gluPickMatrix' > > glpuzzle.cxx:(.text+0x12da): undefined reference to `gluPerspective' > > collect2: ld returned 1 exit status > > make[1]: *** [glpuzzle] Erreur 1 > > make: *** [all] Erreur 2 > > ******************************************************************* > > I tried to compile glut and I have an error too. > > can give you this if you want. > > > > olivier > > > > Le 18/11/2010 19:56, James Lovejoy a ?crit : > >> Hi, > >> > >> Could you post the error because I think I got this error when > >> compiling fltk but I can't remember how I fixed it. Maybe it will > >> jog my memory. > >> > >> James > >> > >> On 18 Nov 2010, at 16:45, olivier SAINT-EVE <lolveley(a)yahoo.fr> > >> wrote: > >> > >> > >>> well, I tried to install mesa, but it is already installed, and > >>> the compilation with "--disable-gl" fails with an error while > >>> compiling glut. > >>> > >>> seems I will have HTML support in a long time, if so! > >>> > >>> olivier > >>> > >>> Le Thu, 18 Nov 2010 11:21:20 -0300, > >>> Jorge Arellano Cid <jcid(a)dillo.org> a ?crit : > >>> > >>> > >>>> On Thu, Nov 18, 2010 at 12:32:49PM +0100, Joerg Sonnenberger > >>>> wrote: > >>>> > >>>>> On Thu, Nov 18, 2010 at 12:16:40PM +0100, olivier SAINT-EVE > >>>>> wrote: > >>>>> > >>>>>> sounds like GLU is missing, but an internet search didn't help > >>>>>> me to find libglu-mesa, or libglu, or glu, in a rpm format. > >>>>>> > >>>>> Try Mesa. > >>>>> > >>>> You can install mesa GL, or you may try: > >>>> > >>>> ./configure --disable-gl ... > >>>> > >>>> when compiling FLTK. > >>>> > >>>> Disclaimer: I haven't tried it, but assume it should work. > >>>> > >>>> > >>> > >>> _______________________________________________ > >>> Dillo-dev mailing list > >>> Dillo-dev(a)dillo.org > >>> http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev > >>> > >> > >

Nov. 18, 2010

patch: text-indent

by Johannes.Hofmann＠gmx.de

On Thu, Nov 18, 2010 at 06:44:57PM +0000, corvid wrote: > Johannes wrote: > > -----Urspr?ngliche Nachricht----- > > An: dillo-dev(a)dillo.org; > > Von: corvid <corvid(a)lavabit.com> > > Gesendet: Do 11.11.2010 02:43 > > Betreff: Re: [Dillo-dev] patch: text-indent > > > Johannes wrote: > > > > We probabely want some isBlockLevelWidget() function... > > > > > > Using Widget::Flags, perhaps, or would you think it best generally > > > to save the flags for state that changes during a widget's life? > > > > > > > I was just thinking about something simple like > > > > bool isBlockLevelWidget(Widget *w) { > > return widget->instanceOf (Textblock::CLASS_ID) || widget->instanceOf (Table::CLASS_ID) ... ); > > } > > > > in textblock.cc to explain to the code reader why we are testing > > for exactly these widget types. > > Plus we might have to reuse at some point. > > Textblock doesn't know what Table and Ruler are, though. Hm, I see. In that case your proposal of using the widget flags sounds just fine to me. Cheers, Johannes

Nov. 18, 2010

fatal error while compiling fltk

by lolveley＠yahoo.fr

Le 18/11/2010 20:05, olivier SAINT-EVE a ?crit : > Hello, > > here is the result of the compilation of fltk: > ******************************************************************** > lolveley@linux-f5pi:~/bin/claws/fltk-2.0.x-r7725> make > === making src === > === making images/libjpeg === > === making images/libpng === > === making images === > === making OpenGL === > === making fluid === > === making glut === > Linking glpuzzle... > glpuzzle.o: In function `redraw()': > glpuzzle.cxx:(.text+0xbe7): undefined reference to `gluPerspective' > glpuzzle.o: In function `selectPiece(int, int)': > glpuzzle.cxx:(.text+0x12a6): undefined reference to `gluPickMatrix' > glpuzzle.cxx:(.text+0x12da): undefined reference to `gluPerspective' > collect2: ld returned 1 exit status > make[1]: *** [glpuzzle] Erreur 1 > make: *** [all] Erreur 2 > ******************************************************************* > I tried to compile glut and I have an error too. > can give you this if you want. > > olivier > > Le 18/11/2010 19:56, James Lovejoy a ?crit : > >> Hi, >> >> Could you post the error because I think I got this error when compiling fltk but I can't remember how I fixed it. Maybe it will jog my memory. >> >> James >> >> On 18 Nov 2010, at 16:45, olivier SAINT-EVE <lolveley(a)yahoo.fr> wrote: >> >> >> >>> well, I tried to install mesa, but it is already installed, and the >>> compilation with "--disable-gl" fails with an error while compiling >>> glut. >>> >>> seems I will have HTML support in a long time, if so! >>> >>> olivier >>> >>> Le Thu, 18 Nov 2010 11:21:20 -0300, >>> Jorge Arellano Cid <jcid(a)dillo.org> a ?crit : >>> >>> >>> >>>> On Thu, Nov 18, 2010 at 12:32:49PM +0100, Joerg Sonnenberger wrote: >>>> >>>> >>>>> On Thu, Nov 18, 2010 at 12:16:40PM +0100, olivier SAINT-EVE wrote: >>>>> >>>>> >>>>>> sounds like GLU is missing, but an internet search didn't help me >>>>>> to find libglu-mesa, or libglu, or glu, in a rpm format. >>>>>> >>>>>> >>>>> Try Mesa. >>>>> >>>>> >>>> You can install mesa GL, or you may try: >>>> >>>> ./configure --disable-gl ... >>>> >>>> when compiling FLTK. >>>> >>>> Disclaimer: I haven't tried it, but assume it should work. >>>> >>>> >>>> >>> _______________________________________________ >>> Dillo-dev mailing list >>> Dillo-dev(a)dillo.org >>> http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev >>> >>> >> >> >

Nov. 18, 2010

fatal error while compiling fltk

by jcid＠dillo.org

On Thu, Nov 18, 2010 at 05:45:33PM +0100, olivier SAINT-EVE wrote: > well, I tried to install mesa, but it is already installed, and the > compilation with "--disable-gl" fails with an error while compiling > glut. > > seems I will have HTML support in a long time, if so! FWIW, in Ubuntu, I have: i A libgl1-mesa-dev - A free implementation of the OpenGL API -- i A libgl1-mesa-dri - A free implementation of the OpenGL API -- i A libgl1-mesa-glx - A free implementation of the OpenGL API -- i A libglu1-mesa - The OpenGL utility library (GLU) i libglu1-mesa-dev - The OpenGL utility library -- development i A mesa-common-dev - Developer documentation for Mesa -- Cheers Jorge.-

Nov. 18, 2010

patch: text-indent

by corvid＠lavabit.com

Johannes wrote: > -----Urspr?ngliche Nachricht----- > An: dillo-dev(a)dillo.org; > Von: corvid <corvid(a)lavabit.com> > Gesendet: Do 11.11.2010 02:43 > Betreff: Re: [Dillo-dev] patch: text-indent > > Johannes wrote: > > > We probabely want some isBlockLevelWidget() function... > > > > Using Widget::Flags, perhaps, or would you think it best generally > > to save the flags for state that changes during a widget's life? > > > > I was just thinking about something simple like > > bool isBlockLevelWidget(Widget *w) { > return widget->instanceOf (Textblock::CLASS_ID) || widget->instanceOf (Table::CLASS_ID) ... ); > } > > in textblock.cc to explain to the code reader why we are testing > for exactly these widget types. > Plus we might have to reuse at some point. Textblock doesn't know what Table and Ruler are, though.

Nov. 18, 2010

fatal error while compiling fltk

by lolveley＠yahoo.fr

well, I tried to install mesa, but it is already installed, and the compilation with "--disable-gl" fails with an error while compiling glut. seems I will have HTML support in a long time, if so! olivier Le Thu, 18 Nov 2010 11:21:20 -0300, Jorge Arellano Cid <jcid(a)dillo.org> a ?crit : > On Thu, Nov 18, 2010 at 12:32:49PM +0100, Joerg Sonnenberger wrote: > > On Thu, Nov 18, 2010 at 12:16:40PM +0100, olivier SAINT-EVE wrote: > > > sounds like GLU is missing, but an internet search didn't help me > > > to find libglu-mesa, or libglu, or glu, in a rpm format. > > > > Try Mesa. > > You can install mesa GL, or you may try: > > ./configure --disable-gl ... > > when compiling FLTK. > > Disclaimer: I haven't tried it, but assume it should work. >

Nov. 18, 2010