- Dillo-dev - lists.mailman3.com

white-space patch

by jcid＠dillo.org

On Wed, Oct 05, 2011 at 01:32:29PM +0200, Johannes Hofmann wrote: > On Tue, Oct 04, 2011 at 04:13:57PM -0300, Jorge Arellano Cid wrote: > > On Tue, Oct 04, 2011 at 01:57:05PM -0300, Jorge Arellano Cid wrote: > > > > > [...] > > > Attached goes a small and very interesting testcase. > > > (I had a hard time reducing google's page :-P). > > > > > > Compare with Firefox/Iceweasel rendering. > > > > There's a "min-width" CSS element that dillo doesn't support: > > > > #center_col{min-width:562px} > > > > Taking it out of the equation makes Firefox render the page > > quite similar to dillo; so maybe it is not a rewrap bug, but a > > lack of implementation of CSS' min-width. > > A colleague just found a simple test case, and the fix for it also > seems to fix the google case - but it needs some more testing. > > Testcase: > > <b>Hello World</b><div>Hello world</div> > > Notice how the first line breaks without need when narrowing the > window. Good testcase! Here, the first sentence is broken regardless the window size, and FWIW, this patch solves it: @@ -1825,6 +1825,7 @@ void Textblock::addParbreak (int space, word = addWord (0, 0, 0, style); word->content.type = core::Content::BREAK; + word->content.breakType = core::Content::BREAK_OK; word->content.breakSpace = space; wordWrap (words->size () - 1); } @@ -1846,6 +1847,7 @@ void Textblock::addLinebreak (core::styl word = addWord (0, 0, 0, style); word->content.type = core::Content::BREAK; + word->content.breakType = core::Content::BREAK_OK; word->content.breakSpace = 0; wordWrap (words->size () - 1); } (this patch doesn't solve the google testcase, so I thought it was better to let you know of it). -- Cheers Jorge.-

Oct. 5, 2011

white-space patch

by johannes.hofmann＠gmx.de

On Tue, Oct 04, 2011 at 04:13:57PM -0300, Jorge Arellano Cid wrote: > On Tue, Oct 04, 2011 at 01:57:05PM -0300, Jorge Arellano Cid wrote: > > > [...] > > Attached goes a small and very interesting testcase. > > (I had a hard time reducing google's page :-P). > > > > Compare with Firefox/Iceweasel rendering. > > There's a "min-width" CSS element that dillo doesn't support: > > #center_col{min-width:562px} > > Taking it out of the equation makes Firefox render the page > quite similar to dillo; so maybe it is not a rewrap bug, but a > lack of implementation of CSS' min-width. A colleague just found a simple test case, and the fix for it also seems to fix the google case - but it needs some more testing. Testcase: <b>Hello World</b><div>Hello world</div> Notice how the first line breaks without need when narrowing the window. Cheers, Johannes

Oct. 5, 2011

white-space patch

by jcid＠dillo.org

On Tue, Oct 04, 2011 at 04:13:57PM -0300, Jorge Arellano Cid wrote: > On Tue, Oct 04, 2011 at 01:57:05PM -0300, Jorge Arellano Cid wrote: > > > [...] > > Attached goes a small and very interesting testcase. > > (I had a hard time reducing google's page :-P). > > > > Compare with Firefox/Iceweasel rendering. > > There's a "min-width" CSS element that dillo doesn't support: > > #center_col{min-width:562px} > > Taking it out of the equation makes Firefox render the page > quite similar to dillo; so maybe it is not a rewrap bug, but a > lack of implementation of CSS' min-width. More precisely: 1.- Without min-width, Firefox shrinks the contents down to a thin column following the window width (similar to dillo) but 2.- Firefox keeps the width of the two innermost DIVs touching the right margin of the parent DIV (unlike dillo). The second point looks like a bug in dillo, and it happens with and without the patch. -- Cheers Jorge.-

Oct. 5, 2011

white-space patch

by jcid＠dillo.org

On Tue, Oct 04, 2011 at 01:57:05PM -0300, Jorge Arellano Cid wrote: > [...] > Attached goes a small and very interesting testcase. > (I had a hard time reducing google's page :-P). > > Compare with Firefox/Iceweasel rendering. There's a "min-width" CSS element that dillo doesn't support: #center_col{min-width:562px} Taking it out of the equation makes Firefox render the page quite similar to dillo; so maybe it is not a rewrap bug, but a lack of implementation of CSS' min-width. -- Cheers Jorge.-

Oct. 4, 2011

white-space patch

by jcid＠dillo.org

On Sat, Oct 01, 2011 at 01:11:05PM -0300, Jorge Arellano Cid wrote: > On Sat, Oct 01, 2011 at 11:03:18AM -0300, Jorge Arellano Cid wrote: > > On Fri, Sep 30, 2011 at 08:54:39AM +0200, Johannes Hofmann wrote: > > > On Wed, Sep 28, 2011 at 05:49:10PM -0300, Jorge Arellano Cid wrote: > > > > > [...] > > > > Please explain the non-deterministical behaviour at google. > > > > > > If I search for e.g. dillo on google, the first line (the link) of a > > > result entry is sometimes broken into two lines, sometimes not. > > > > Thanks for the explanation. > > > > After some time reviewing it and guessing, I succeeded to isolate > > a small testcase which I'm reviewing now. > > Sorry, it was not a reliable testcase... :-P Attached goes a small and very interesting testcase. (I had a hard time reducing google's page :-P). Compare with Firefox/Iceweasel rendering. -- Cheers Jorge.-

Oct. 4, 2011

white-space patch

by jcid＠dillo.org

On Sun, Oct 02, 2011 at 11:09:25AM +0200, Johannes Hofmann wrote: > On Sat, Oct 01, 2011 at 03:17:09PM -0300, Jorge Arellano Cid wrote: > > On Sat, Oct 01, 2011 at 04:45:52PM +0000, corvid wrote: > > > Jorge wrote: > > > > On Sat, Oct 01, 2011 at 11:03:18AM -0300, Jorge Arellano Cid wrote: > > > > > On Fri, Sep 30, 2011 at 08:54:39AM +0200, Johannes Hofmann wrote: > > > > > > On Wed, Sep 28, 2011 at 05:49:10PM -0300, Jorge Arellano Cid wrote: > > > > > > > > > > > [...] > > > > > > > Please explain the non-deterministical behaviour at google. > > > > > > > > > > > > If I search for e.g. dillo on google, the first line (the link) of a > > > > > > result entry is sometimes broken into two lines, sometimes not. > > > > > > > > > > Thanks for the explanation. > > > > > > > > > > After some time reviewing it and guessing, I succeeded to isolate > > > > > a small testcase which I'm reviewing now. > > > > > > > > Sorry, it was not a reliable testcase... :-P > > > > > > I haven't looked into this, but do you suppose it could have to do with the > > > part in html.cc that goes > > > > > > if (isspace(buf[buf_index])) { > > > /* whitespace: group all available whitespace */ > > > while (++buf_index < bufsize && isspace(buf[buf_index])) ; > > > Html_process_space(html, buf + token_start, buf_index - token_start); > > > token_start = buf_index; > > > } ... > > > > > > that is, sends off whatever it's accumulated at the end of a packet? > > > > Not sure, but I don't think so. > > > > Without the whitespace patch, dillo also doesn't seem to get > > right the available horizontal space for the link [1]. > > > > To me it looks related to the way ParMin propagates upwards in > > a textblock, but I'm just starting to look into it. > > Yes, I also think it's related to that. > Textblock::getExtremesImpl() starts from wrapRef and uses the > precomputed line->maxWordMin, line->maxParMax, line->parMin, and > line->parMax. From there it does compute the stuff on it's own. > > So if the computation of line->maxWordMin, line->maxParMax, > line->parMin, and line->parMax in wordWrap() doesn't agree with what > Textblock::getExtremesImpl() does afterwards, the result becomes > unreliable. FWIW, this old comment in the code (not present today) may be a good hint of what happens now: textblock.cc, Textblock::wordWrap() /* NOTE: Most code relies on that all values of nowrap are equal for all * words within one line. */ -- Cheers Jorge.-

Oct. 2, 2011

white-space patch

by Johannes.Hofmann＠gmx.de

On Sat, Oct 01, 2011 at 03:17:09PM -0300, Jorge Arellano Cid wrote: > On Sat, Oct 01, 2011 at 04:45:52PM +0000, corvid wrote: > > Jorge wrote: > > > On Sat, Oct 01, 2011 at 11:03:18AM -0300, Jorge Arellano Cid wrote: > > > > On Fri, Sep 30, 2011 at 08:54:39AM +0200, Johannes Hofmann wrote: > > > > > On Wed, Sep 28, 2011 at 05:49:10PM -0300, Jorge Arellano Cid wrote: > > > > > > > > > [...] > > > > > > Please explain the non-deterministical behaviour at google. > > > > > > > > > > If I search for e.g. dillo on google, the first line (the link) of a > > > > > result entry is sometimes broken into two lines, sometimes not. > > > > > > > > Thanks for the explanation. > > > > > > > > After some time reviewing it and guessing, I succeeded to isolate > > > > a small testcase which I'm reviewing now. > > > > > > Sorry, it was not a reliable testcase... :-P > > > > I haven't looked into this, but do you suppose it could have to do with the > > part in html.cc that goes > > > > if (isspace(buf[buf_index])) { > > /* whitespace: group all available whitespace */ > > while (++buf_index < bufsize && isspace(buf[buf_index])) ; > > Html_process_space(html, buf + token_start, buf_index - token_start); > > token_start = buf_index; > > } ... > > > > that is, sends off whatever it's accumulated at the end of a packet? > > Not sure, but I don't think so. > > Without the whitespace patch, dillo also doesn't seem to get > right the available horizontal space for the link [1]. > > To me it looks related to the way ParMin propagates upwards in > a textblock, but I'm just starting to look into it. Yes, I also think it's related to that. Textblock::getExtremesImpl() starts from wrapRef and uses the precomputed line->maxWordMin, line->maxParMax, line->parMin, and line->parMax. From there it does compute the stuff on it's own. So if the computation of line->maxWordMin, line->maxParMax, line->parMin, and line->parMax in wordWrap() doesn't agree with what Textblock::getExtremesImpl() does afterwards, the result becomes unreliable. Cheers, Johannes

Oct. 2, 2011

white-space patch

by jcid＠dillo.org

On Sat, Oct 01, 2011 at 04:45:52PM +0000, corvid wrote: > Jorge wrote: > > On Sat, Oct 01, 2011 at 11:03:18AM -0300, Jorge Arellano Cid wrote: > > > On Fri, Sep 30, 2011 at 08:54:39AM +0200, Johannes Hofmann wrote: > > > > On Wed, Sep 28, 2011 at 05:49:10PM -0300, Jorge Arellano Cid wrote: > > > > > > > [...] > > > > > Please explain the non-deterministical behaviour at google. > > > > > > > > If I search for e.g. dillo on google, the first line (the link) of a > > > > result entry is sometimes broken into two lines, sometimes not. > > > > > > Thanks for the explanation. > > > > > > After some time reviewing it and guessing, I succeeded to isolate > > > a small testcase which I'm reviewing now. > > > > Sorry, it was not a reliable testcase... :-P > > I haven't looked into this, but do you suppose it could have to do with the > part in html.cc that goes > > if (isspace(buf[buf_index])) { > /* whitespace: group all available whitespace */ > while (++buf_index < bufsize && isspace(buf[buf_index])) ; > Html_process_space(html, buf + token_start, buf_index - token_start); > token_start = buf_index; > } ... > > that is, sends off whatever it's accumulated at the end of a packet? Not sure, but I don't think so. Without the whitespace patch, dillo also doesn't seem to get right the available horizontal space for the link [1]. To me it looks related to the way ParMin propagates upwards in a textblock, but I'm just starting to look into it. BTW, adding these lines to style.css helps to visualize it: table {border: 1px solid red !important} td {border: 1px solid green !important} div {border: 1px solid black !important} [1] http://www.google.com/search?ie=UTF-8&oe=UTF-8&q=dillo -- Cheers Jorge.-

Oct. 1, 2011

white-space patch

by corvid＠lavabit.com

Jorge wrote: > On Sat, Oct 01, 2011 at 11:03:18AM -0300, Jorge Arellano Cid wrote: > > On Fri, Sep 30, 2011 at 08:54:39AM +0200, Johannes Hofmann wrote: > > > On Wed, Sep 28, 2011 at 05:49:10PM -0300, Jorge Arellano Cid wrote: > > > > > [...] > > > > Please explain the non-deterministical behaviour at google. > > > > > > If I search for e.g. dillo on google, the first line (the link) of a > > > result entry is sometimes broken into two lines, sometimes not. > > > > Thanks for the explanation. > > > > After some time reviewing it and guessing, I succeeded to isolate > > a small testcase which I'm reviewing now. > > Sorry, it was not a reliable testcase... :-P I haven't looked into this, but do you suppose it could have to do with the part in html.cc that goes if (isspace(buf[buf_index])) { /* whitespace: group all available whitespace */ while (++buf_index < bufsize && isspace(buf[buf_index])) ; Html_process_space(html, buf + token_start, buf_index - token_start); token_start = buf_index; } ... that is, sends off whatever it's accumulated at the end of a packet?

Oct. 1, 2011

white-space patch

by jcid＠dillo.org

On Sat, Oct 01, 2011 at 11:03:18AM -0300, Jorge Arellano Cid wrote: > On Fri, Sep 30, 2011 at 08:54:39AM +0200, Johannes Hofmann wrote: > > On Wed, Sep 28, 2011 at 05:49:10PM -0300, Jorge Arellano Cid wrote: > > > [...] > > > Please explain the non-deterministical behaviour at google. > > > > If I search for e.g. dillo on google, the first line (the link) of a > > result entry is sometimes broken into two lines, sometimes not. > > Thanks for the explanation. > > After some time reviewing it and guessing, I succeeded to isolate > a small testcase which I'm reviewing now. Sorry, it was not a reliable testcase... :-P -- Cheers Jorge.-

Oct. 1, 2011