- Dillo-dev - lists.mailman3.com

cleanup patches

by Hole.destructor＠gmx.de

Hi 123, why not introducing a macro like #define LENGTH(X) (sizeof (X) / sizeof (X)[0]) which could be used in all these for loops? I think this would make the code simpler and less error prone. Best, Alexander

May 26, 2012

cleanup patches

by Johannes.Hofmann＠gmx.de

On Sat, May 26, 2012 at 09:26:39AM -0400, Jorge Arellano Cid wrote: > On Sat, May 26, 2012 at 02:02:17PM +0200, Johannes Hofmann wrote: > > On Sat, May 26, 2012 at 03:02:24PM +0400, 123 wrote: > > > One patch for README, one for dFree (no need to check for NULL) and > > > one for sizeof usage. > > > > thanks, committed. > > BTW, why is it better to have sizeof this way? > > - (sizeof(Css_shorthand_info) / sizeof(CssShorthandInfo)) > + (sizeof(Css_shorthand_info) / sizeof(Css_shorthand_info[0])) This way it stays correct even if someone changes the type of Css_shorthand_info to say CssShorthandInfo2. Not a big improvement, but I like it being consistently done like that. Cheers, Johannes

May 26, 2012

src/colors.c cleanup

by p37sitdu＠lavabit.com

- Fixed indentation. - Added LEN macro. - Reimplemented binary search using bsearch(3). - Changed NOTE: colors can be in any case, they are compared with dStrAsciiCasecmp.

May 26, 2012

cleanup patches

by jcid＠dillo.org

On Sat, May 26, 2012 at 02:02:17PM +0200, Johannes Hofmann wrote: > On Sat, May 26, 2012 at 03:02:24PM +0400, 123 wrote: > > One patch for README, one for dFree (no need to check for NULL) and > > one for sizeof usage. > > thanks, committed. BTW, why is it better to have sizeof this way? - (sizeof(Css_shorthand_info) / sizeof(CssShorthandInfo)) + (sizeof(Css_shorthand_info) / sizeof(Css_shorthand_info[0])) -- Cheers Jorge.-

May 26, 2012

cleanup patches

by Johannes.Hofmann＠gmx.de

On Sat, May 26, 2012 at 03:02:24PM +0400, 123 wrote: > One patch for README, one for dFree (no need to check for NULL) and > one for sizeof usage. thanks, committed. Cheers, Johannes

May 26, 2012

cleanup patches

by iveqy＠iveqy.com

Sry, my bad. Never mind 2012/5/26 Fredrik Gustafsson <iveqy at iveqy.com> > Why isn't the NULL-check needed? free(NULL) has an undefinied behavior... > > /Fredrik > > 2012/5/26 123 <p37sitdu at lavabit.com> > >> One patch for README, one for dFree (no need to check for NULL) and >> one for sizeof usage. >> >> _______________________________________________ >> Dillo-dev mailing list >> Dillo-dev at dillo.org >> http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev >> > >

May 26, 2012

cleanup patches

by iveqy＠iveqy.com

Why isn't the NULL-check needed? free(NULL) has an undefinied behavior... /Fredrik 2012/5/26 123 <p37sitdu at lavabit.com> > One patch for README, one for dFree (no need to check for NULL) and > one for sizeof usage. > > _______________________________________________ > Dillo-dev mailing list > Dillo-dev at dillo.org > http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev >

May 26, 2012

cleanup patches

by p37sitdu＠lavabit.com

One patch for README, one for dFree (no need to check for NULL) and one for sizeof usage.

May 26, 2012

just a test msg

by jcid＠dillo.org

Hi there, For those of you wondering what all these tests are about, we were informed of problems with subscribing to dillo-dev by a new member, then we realized delivery was also not working, and today it seems things are starting to work again. More later... -- Cheers Jorge.-

May 25, 2012

just a test msg

by p37sitdu＠lavabit.com

test

May 25, 2012