- Dillo-dev - lists.mailman3.com

[patch] typedefs and identifiers with leading underscores

by p37sitdu＠lavabit.com

Updated patch to fix warning in jpeg.c.

June 3, 2012

[patch] downloads dpi progress bar

by p37sitdu＠lavabit.com

Now progress bar is implemented as custom widget on top of Fl_Widget class. But FLTK already has Fl_Progress class for the same thing. Progress bar looks the same with two exceptions: 1. No tooltip: it is not displayed for Fl_Progress even when set. Normally progress bars, labels and other widgets for status information don't have tooltips so I think it is ok. 2. When downloading file without Content-Length, progress bar is always empty. With current implementation it changes for one percent on every update and remains somewhere in the middle when download is finished. For me keeping it at zero looks better. Patch and python HTTP server for testing downloads without Content-Length attached.

June 3, 2012

[patch] dlib cleanup

by jcid＠dillo.org

Hi, On Sun, Jun 03, 2012 at 12:13:41AM +0400, 123 wrote: > malloc.diff: added perror calls for malloc and realloc errors > > dstr.diff: dStr* functions cleanup > > dlist.diff: replaced recursive QuickSort with qsort from stdlib.h. > Tested with file.dpi where it is used for sorting directory listing. There're different criteria to write code. In dlib, a few lines are preferred to a single contracted one to make it simpler to understand. In the same spirit, scattered return statements are avoided to make code path following simpler. For quick sort I remember having to implement it in dlib because stdlib's qsort varies among platforms. -- Cheers Jorge.-

June 2, 2012

[patch] dlib cleanup

by p37sitdu＠lavabit.com

malloc.diff: added perror calls for malloc and realloc errors dstr.diff: dStr* functions cleanup dlist.diff: replaced recursive QuickSort with qsort from stdlib.h. Tested with file.dpi where it is used for sorting directory listing.

June 2, 2012

[patch] typedefs and identifiers with leading underscores

by p37sitdu＠lavabit.com

There is no reason to have a name for structs when we just want to typedef them. BTW identifiers that begin with underscore are reserved. Attached patch fixes all typedefs.

June 2, 2012

Doxyfile

by Johannes.Hofmann＠gmx.de

On Sun, May 27, 2012 at 03:08:14AM +0400, 123 wrote: > By the way new Doxygen supports Markdown[1] and it is enabled by > default. It is easier to read and write than HTML. index.doc rewritten > using markdown is attached. Existing documentation (especially .txt > files) can be converted to markdown too. > > [1] http://daringfireball.net/projects/markdown/ I like the idea of using markdown for in source documentation and also your proposed cleanup of the Doxygen file looks nice, but I'm reluctant to touch the doxygen stuff. Sebastian was the one who put a lot of effort in the documentation and I don't want to break his work just for some cleanups. Cheers, Johannes

May 28, 2012

dillorc and src/keysrc

by Johannes.Hofmann＠gmx.de

On Sun, May 27, 2012 at 03:19:22PM +0400, 123 wrote: > By the way Scroogle is closed but it is still present in dillorc. > diff -r e77b384a9d4d dillorc > --- a/dillorc Sat May 26 13:58:42 2012 +0200 > +++ b/dillorc Sun May 27 15:18:33 2012 +0400 > @@ -113,7 +113,6 @@ > # You can enable multiple search_url strings at once and select from among > # them at runtime, with the first being the default. > search_url="http://duckduckgo.com/lite/?kp=-1&q=%s" > -search_url="Scroogle https://ssl.scroogle.org/cgi-bin/nbbwssl.cgi?Gw=%s" > search_url="Wikipedia http://www.wikipedia.org/w/index.php?search=%s&go=Go" > search_url="Free Dictionary http://www.thefreedictionary.com/%s" > search_url="Google http://www.google.com/search?ie=UTF-8&oe=UTF-8&q=%s" Thanks, committed. Cheers, Johannes

May 28, 2012

dillo.cc cleanup and bugfix

by p37sitdu＠lavabit.com

Reordered #includes. Fixed --geometry flag. It is --geometry in man page but -geometry in usage and only -geometry is recognized by program. Simplified getCmdOption. Removed State enum, it was overkill. It is also possible to remove support for mandatory arguments (opt_argc < 0) as it is not used, but it does not add LOC so I left it there. Removed check for about:blank as start_page, it is not a special case.

May 27, 2012

namespace comments in dw/*

by p37sitdu＠lavabit.com

Copied comments are almost in every source file.

May 27, 2012

Dillo working directory

by p37sitdu＠lavabit.com

In Paths::init Dillo changes working directory to /tmp. This way every time I try to open some page stored on the hard disk (Ctrl-O) I have to start in /tmp. What is the reason for changing WD to /tmp? BTW oldWorkingDir is not used anywhere.

May 27, 2012