- Dillo-dev - lists.mailman3.com

[patch] disable SSLv2 support

by p37sitdu＠lavabit.com

http://www.inventati.org/noname/dillo/https-no-SSLv2.patch I have found HTTPS server that Dillo was unable to connect to. After defining SILENT to 0 in https.c I found that SSL_connect failed. Adding ERR_print_errors_fp(stderr) showed error "SSL23_GET_SERVER_HELLO:unknown protocol". Disabling SSLv2 support fixed the problem for me. And SSLv2 is insecure so it must be disabled anyway.

Jan. 17, 2013

chain.c cleanup

by p37sitdu＠lavabit.com

http://www.inventati.org/noname/dillo/chain-cleanup.patch 1. Replaced dNew with dMalloc and dNew0 with dMalloc0. This way it is possible to use (sizeof *var) instead of repeating variable type. By the way, when 'count' is constant, dMalloc is easier to use, and when count is not constant, integer overflow can happen in dNew during multiplication. It looks like there are no such errors, but I think check should be added or, better, dCalloc can be introduced so libc checks for such cases. 2. Replaced #defines with enums and made them uppercase so it is easier to distinguish them from variables. This style is already used in most modules. IO should be fixed too, probably. 3. Moved duplicate code from a_Chain_fcb and a_Chain_bcb to Chain_cb. Anonymous structures for connections (forward or backward) are introduced in ChainLink structure for this purpose. 4. Removed unused a_Chain_unlink function. Chain links are just dFreed instead. Anyway, there is no function to connect existing links back, so disconnected link can only be dFreed. 5. Replaced AtoB_branch and BtoA_branch parameters of a_Chain_link_new with single Branch parameter. They were always equal anyway, and using different branch identifiers for one connection makes no sense, as branch ID is used to distinguish between Answer and Query chains. Branch parameter can be eliminated completely by separating existing CCC callbacks into answer and query callbacks. Currently instead of two functions we have one with if (Branch == 1) { ... } else { ... }

Jan. 17, 2013

CustChoice

by corvid＠lavabit.com

I was looking into why the search dialog would no longer let me tab to the search engine list and press down arrow to switch between them... It seems that, once Jorge added a CustChoice in fltkui.cc, the dialog code started to use _that_ one and not its own. (I would've expected something to complain about there being two CustChoice::handle()s in that case...) Would it be considered incorrect in any way if fltkui.cc's CustChoice and CustInput2 were put inside dw::fltk::ui?

Jan. 16, 2013

[patch] a_Dpip_send_cmd

by p37sitdu＠lavabit.com

I have fixed the patch and reread it. Link is the same: http://www.inventati.org/noname/dillo/dpip-send-cmd.patch

Jan. 15, 2013

tooltip in the way when typing

by corvid＠lavabit.com

With fltk's built-in tooltip system, Fl::handle_(), upon receipt of a FL_KEYBOARD event, calls Fl_Tooltip::enter((Fl_Widget*)0); to hide the tooltip. Once in a while, after giving a text input focus, I'm careless with the mouse, moving it away and then back over the input, putting a tooltip over what I'm typing. (And presumably textareas could have that happen as well...) Here's one way that it could be dealt with:

Jan. 15, 2013

dereferencing type-punned pointer warning

by Johannes.Hofmann＠gmx.de

Hi, line 135 in lout object.cc: return ((int*)&value)[0] ^ ((int*)&value)[1]; causes the following error on 64bit systems for me: warning: dereferencing type-punned pointer will break strict-aliasing rules Can we replace it like this: diff -r dd6f2d1eb15a lout/object.cc --- a/lout/object.cc Mon Jan 14 10:26:37 2013 -0300 +++ b/lout/object.cc Mon Jan 14 21:56:46 2013 +0100 @@ -21,6 +21,7 @@ #include "object.hh" #include <stdio.h> +#include <stdint.h> #include <config.h> namespace lout { @@ -132,7 +133,7 @@ // Combine both parts of the pointer value *itself*, not what it // points to, by first referencing it (operator "&"), then // dereferencing it again (operator "[]"). - return ((int*)&value)[0] ^ ((int*)&value)[1]; + return ((intptr_t)value >> 32) ^ ((intptr_t)value); #endif } Cheers, Johannes

Jan. 14, 2013

[patch] a_Dpip_send_cmd

by jcid＠dillo.org

Hi, On Sun, Jan 13, 2013 at 01:41:37AM +0400, p37sitdu at lavabit.com wrote: > http://www.inventati.org/noname/dillo/dpip-send-cmd.patch > > Patch adds a_Dpip_send_cmd and helper function a_Dpip_vbuild_cmd. > > This way common pattern > > d_cmd = a_Dpip_build_cmd(format, ...); > st = a_Dpip_dsh_write_str(sh, flush, d_cmd); > dFree(d_cmd); > > can be replaced with > > st = a_Dpip_send_cmd(sh, flush, format, ...); The idea looks good, and after applying it, the patch doesn't compile; the problem is trivial but it makes me hesitate. Please at least check the patch compiles, and that the functionality it changes/modifies works for every case, before submitting. TIA. -- Cheers Jorge.-

Jan. 14, 2013

mare patches for dpid

by jcid＠dillo.org

On Sat, Jan 12, 2013 at 10:39:54PM +0400, p37sitdu at lavabit.com wrote: > http://www.inventati.org/noname/dillo/dpid-dclose.patch > http://www.inventati.org/noname/dillo/dpid-no_dotfiles.patch Committed. -- Cheers Jorge.-

Jan. 14, 2013

Patch for xembed updated

by higuita7＠yahoo.co.uk

Hi > I don't know if the claws plugin is still used by anyone, but I > don't want to remove the code, that proved to be working. I use both dillo and claws-mail, where i load the dillo plugin... so, yes, it is still used, at least by me :) Thanks for dillo :) higuita -- Naturally the common people don't want war... but after all it is the leaders of a country who determine the policy, and it is always a simple matter to drag the people along, whether it is a democracy, or a fascist dictatorship, or a parliament, or a communist dictatorship. Voice or no voice, the people can always be brought to the bidding of the leaders. That is easy. All you have to do is tell them they are being attacked, and denounce the pacifists for lack of patriotism and exposing the country to danger. It works the same in every country. -- Hermann Goering, Nazi and war criminal, 1883-1946

Jan. 14, 2013

Patch for xembed updated

by Johannes.Hofmann＠gmx.de

On Fri, Jan 11, 2013 at 06:17:08PM +0100, podarcis wrote: > > > Please have a look at the enclosed diff 'xembed_removed_demo.diff', > > that removes the *WHOLE* xembed protocol implementation and only > > keeps the window creation. > > > > Still embedding with 'tabbed' works as before. This really makes me > > wonder... > > Update: > I just tested Claws Mail (writing this mail with it) from the Ubuntu > 12.04 distribution together with the 'Dillo_Viewer' plugin (which was > not so easy to get, because it is not longer in this distribution - I > had to take it from another distibution, openSuse-12.2) > > Result: > dillo with the *removed xembed support* (see previous posting) > integrates perfectly (including resizing) into the Claws Mail preview > window! > > Also does dillo with *my patch*. > > Just to let you know.. I know that it works partly with just simple reparenting, but it has problems. We went through all this see the thread starting with: http://lists.auriga.wearlab.de/pipermail/dillo-dev/2009-May/006453.html and the final success messages from claws-mail people here: http://lists.auriga.wearlab.de/pipermail/dillo-dev/2009-June/006533.html I don't know if the claws plugin is still used by anyone, but I don't want to remove the code, that proved to be working. Cheers, Johannes

Jan. 13, 2013