- Dillo-dev - lists.mailman3.com

Problems with bookmarks.dpi

by johannes.hofmann＠gmx.de

On Mon, Jan 25, 2016 at 12:44:22AM +0100, Sebastian Geerken wrote: > On So, Jan 24, 2016, Johannes Hofmann wrote: > > there is probabely something in your bm.txt that the current code > > doesn't expect. > > I tried to make the bookmarks file parser a bit safer (see attached > > patch). Could you please try if it fixes your case? > > Thanks, it worked. First, the list was empty, but as soon as I > bookmarked another page, all links were displayed again. (I believe > the section line ":s0: ..." got damaged when editing the file > directly.) > > Do you want to commit it to hg.dillo.org? It this case, I'll simply > merge it into dillo_grows. I plan to commit it to the main repository tonight. > > Sebastian > > PS: Still one problem left: cookies.dpi hangs sometimes. > _______________________________________________ > Dillo-dev mailing list > Dillo-dev at dillo.org > http://lists.dillo.org/cgi-bin/mailman/listinfo/dillo-dev

Jan. 25, 2016

Problems with bookmarks.dpi

by sgeerken＠dillo.org

On So, Jan 24, 2016, Johannes Hofmann wrote: > there is probabely something in your bm.txt that the current code > doesn't expect. > I tried to make the bookmarks file parser a bit safer (see attached > patch). Could you please try if it fixes your case? Thanks, it worked. First, the list was empty, but as soon as I bookmarked another page, all links were displayed again. (I believe the section line ":s0: ..." got damaged when editing the file directly.) Do you want to commit it to hg.dillo.org? It this case, I'll simply merge it into dillo_grows. Sebastian PS: Still one problem left: cookies.dpi hangs sometimes.

Jan. 24, 2016

Problems with bookmarks.dpi

by Johannes.Hofmann＠gmx.de

Hi Sebastian, there is probabely something in your bm.txt that the current code doesn't expect. I tried to make the bookmarks file parser a bit safer (see attached patch). Could you please try if it fixes your case? Cheers, Johannes On Sat, Jan 23, 2016 at 03:08:31PM +0100, Sebastian Geerken wrote: > Hi! > > As I wrote in a previois post, bookmarks do not work. It seems that > bookmarks.dpi crashes: > > ---------------------------------------------------------------------- > $ gdb /usr/local/lib/dillo/dpi/bookmarks/bookmarks.dpi core > GNU gdb (Debian 7.7.1+dfsg-5) 7.7.1 > Copyright (C) 2014 Free Software Foundation, Inc. > [...] > Reading symbols from /usr/local/lib/dillo/dpi/bookmarks/bookmarks.dpi...done. > [New LWP 5661] > Core was generated by `/usr/local/lib/dillo/dpi/bookmarks/bookmarks.dpi'. > Program terminated with signal SIGSEGV, Segmentation fault. > #0 Bms_load () at bookmarks.c:745 > 745 p = strchr(p, ' '); *p = 0; > (gdb) l > 740 if (buf[0] == 's') { > 741 /* get section, url and title */ > 742 section = strtol(buf + 1, NULL, 10); > 743 p = strchr(buf, ' '); *p = 0; > 744 url = ++p; > 745 p = strchr(p, ' '); *p = 0; > 746 title = ++p; > 747 p = strchr(p, '\n'); *p = 0; > 748 u_title = Unescape_html_str(title); > 749 Bms_add(section, url, u_title); > (gdb) p p > $1 = 0x1 <error: Cannot access memory at address 0x1> > (gdb) bt > #0 Bms_load () at bookmarks.c:745 > #1 Bms_cond_load () at bookmarks.c:792 > #2 Bmsrv_parse_token (Buf=0x1814280 "<cmd='open_url' url='dpi:/bm/' > '>", sh=0x1810200) at bookmarks.c:1605 > #3 main () at bookmarks.c:1746 > ---------------------------------------------------------------------- > > Sebastian > > _______________________________________________ > Dillo-dev mailing list > Dillo-dev at dillo.org > http://lists.dillo.org/cgi-bin/mailman/listinfo/dillo-dev

Jan. 24, 2016

Work on floats

by Johannes.Hofmann＠gmx.de

On Sat, Jan 23, 2016 at 02:45:31PM +0100, Sebastian Geerken wrote: > > On Sat, Jan 16, 2016 at 10:10:57PM +0100, Alexander Voigt wrote: > > > when I open my bookmarks site (dpi:/bm/) and move the mouse down over > > > some of my bookmark links, dillo crashes. I'm using commit > > > 4494:4f99dafc3e50. > > On Sa, Jan 16, 2016, Johannes Hofmann wrote: > > I can reproduce this with left mouse button pressed and moving > > around on bookmarks page. Here is my backtrace: > > > > 0x0000000800e07fc8 in kill () from /lib/libc.so.8 > > (gdb) bt > > #0 0x0000000800e07fc8 in kill () from /lib/libc.so.8 > > #1 0x0000000800868e89 in raise () from /usr/lib/libpthread.so.0 > > #2 0x0000000800e9b5f0 in abort () from /lib/libc.so.8 > > #3 0x00000000004276e3 in lout::misc::assertNotReached () at ../lout/misc.hh:38 > > #4 0x000000000044fde5 in dw::oof::OOFAwareWidget::getWidgetAtPointLevel ( > > this=<optimized out>, x=<optimized out>, y=<optimized out>, level=<optimized out>, > > context=<optimized out>) at oofawarewidget.cc:496 > > #5 0x000000000044fc68 in dw::oof::OOFAwareWidget::getWidgetAtPoint (this=0x801051f00, x=548, > > y=2569, context=0x7ffffffff000) at oofawarewidget.cc:465 > > #6 0x0000000000460a3e in dw::Textblock::getWidgetAtPointLevel (this=0x801863d80, x=548, > > ---Type <return> to continue, or q <return> to quit--- > > , level=<optimized out>, context=0x7ffffffff000) at textblock.cc:2823 > > For strange reasons, bookmarks do not work for me (I'll start another > thread). However, most probably this bug has been just fixed. Please > test again. Cool, seems to be fixed! Johannes

Jan. 24, 2016

Dillo MS Windows Port

by rogerx.oss＠gmail.com

I spent some time last night examining the Dillo Windows port, as well as the DPLus version. The DPlus version has multiple patches for extra (likely not-needed?) features atop of the Windows port. So further limited my research to the Dillo Windows port to see what was only needed for Dillo to be functionally compiled on Windows platforms under Mingw. Performing a "diff -urN" on the Windows port against the vanilla Dillo-1.3.0, showed at the very end some stuff concerning socks.h/winsock2.h portability. There were other modifications, but not sure if those were really needed. Would appear they performed a lot of work, and it's sad to see the work just being ignored. Would be nice to see some basic portability for Windows integrated. However, basic and standardized work that is clean and can be integrated within the main Dillo tree. Would appear the DPlus version work went further with extra features, and can easily understand why they were likely not wanted within the main Dillo tree. -- Roger http://rogerx.freeshell.org/

Jan. 23, 2016

Problems with bookmarks.dpi

by sgeerken＠dillo.org

Hi! As I wrote in a previois post, bookmarks do not work. It seems that bookmarks.dpi crashes: ---------------------------------------------------------------------- $ gdb /usr/local/lib/dillo/dpi/bookmarks/bookmarks.dpi core GNU gdb (Debian 7.7.1+dfsg-5) 7.7.1 Copyright (C) 2014 Free Software Foundation, Inc. [...] Reading symbols from /usr/local/lib/dillo/dpi/bookmarks/bookmarks.dpi...done. [New LWP 5661] Core was generated by `/usr/local/lib/dillo/dpi/bookmarks/bookmarks.dpi'. Program terminated with signal SIGSEGV, Segmentation fault. #0 Bms_load () at bookmarks.c:745 745 p = strchr(p, ' '); *p = 0; (gdb) l 740 if (buf[0] == 's') { 741 /* get section, url and title */ 742 section = strtol(buf + 1, NULL, 10); 743 p = strchr(buf, ' '); *p = 0; 744 url = ++p; 745 p = strchr(p, ' '); *p = 0; 746 title = ++p; 747 p = strchr(p, '\n'); *p = 0; 748 u_title = Unescape_html_str(title); 749 Bms_add(section, url, u_title); (gdb) p p $1 = 0x1 <error: Cannot access memory at address 0x1> (gdb) bt #0 Bms_load () at bookmarks.c:745 #1 Bms_cond_load () at bookmarks.c:792 #2 Bmsrv_parse_token (Buf=0x1814280 "<cmd='open_url' url='dpi:/bm/' '>", sh=0x1810200) at bookmarks.c:1605 #3 main () at bookmarks.c:1746 ---------------------------------------------------------------------- Sebastian

Jan. 23, 2016

Work on floats

by sgeerken＠dillo.org

> On Sat, Jan 16, 2016 at 10:10:57PM +0100, Alexander Voigt wrote: > > when I open my bookmarks site (dpi:/bm/) and move the mouse down over > > some of my bookmark links, dillo crashes. I'm using commit > > 4494:4f99dafc3e50. On Sa, Jan 16, 2016, Johannes Hofmann wrote: > I can reproduce this with left mouse button pressed and moving > around on bookmarks page. Here is my backtrace: > > 0x0000000800e07fc8 in kill () from /lib/libc.so.8 > (gdb) bt > #0 0x0000000800e07fc8 in kill () from /lib/libc.so.8 > #1 0x0000000800868e89 in raise () from /usr/lib/libpthread.so.0 > #2 0x0000000800e9b5f0 in abort () from /lib/libc.so.8 > #3 0x00000000004276e3 in lout::misc::assertNotReached () at ../lout/misc.hh:38 > #4 0x000000000044fde5 in dw::oof::OOFAwareWidget::getWidgetAtPointLevel ( > this=<optimized out>, x=<optimized out>, y=<optimized out>, level=<optimized out>, > context=<optimized out>) at oofawarewidget.cc:496 > #5 0x000000000044fc68 in dw::oof::OOFAwareWidget::getWidgetAtPoint (this=0x801051f00, x=548, > y=2569, context=0x7ffffffff000) at oofawarewidget.cc:465 > #6 0x0000000000460a3e in dw::Textblock::getWidgetAtPointLevel (this=0x801863d80, x=548, > ---Type <return> to continue, or q <return> to quit--- > , level=<optimized out>, context=0x7ffffffff000) at textblock.cc:2823 For strange reasons, bookmarks do not work for me (I'll start another thread). However, most probably this bug has been just fixed. Please test again. Sebastian

Jan. 23, 2016

Work on floats

by Johannes.Hofmann＠gmx.de

Hi, I can reproduce this with left mouse button pressed and moving around on bookmarks page. Here is my backtrace: 0x0000000800e07fc8 in kill () from /lib/libc.so.8 (gdb) bt #0 0x0000000800e07fc8 in kill () from /lib/libc.so.8 #1 0x0000000800868e89 in raise () from /usr/lib/libpthread.so.0 #2 0x0000000800e9b5f0 in abort () from /lib/libc.so.8 #3 0x00000000004276e3 in lout::misc::assertNotReached () at ../lout/misc.hh:38 #4 0x000000000044fde5 in dw::oof::OOFAwareWidget::getWidgetAtPointLevel ( this=<optimized out>, x=<optimized out>, y=<optimized out>, level=<optimized out>, context=<optimized out>) at oofawarewidget.cc:496 #5 0x000000000044fc68 in dw::oof::OOFAwareWidget::getWidgetAtPoint (this=0x801051f00, x=548, y=2569, context=0x7ffffffff000) at oofawarewidget.cc:465 #6 0x0000000000460a3e in dw::Textblock::getWidgetAtPointLevel (this=0x801863d80, x=548, ---Type <return> to continue, or q <return> to quit--- , level=<optimized out>, context=0x7ffffffff000) at textblock.cc:2823 #7 0x000000000044fc68 in dw::oof::OOFAwareWidget::getWidgetAtPoint (this=0x801863d80, x=548, y=2569, context=0x7ffffffff000) at oofawarewidget.cc:465 #8 0x0000000000456d9e in dw::Table::getWidgetAtPointLevel (this=0x801393720, x=6, y=7, level=<optimized out>, context=0x800e08148 <__sys_getpid+12>) at table.cc:440 #9 0x000000000044fc68 in dw::oof::OOFAwareWidget::getWidgetAtPoint (this=0x801393720, x=548, y=2569, context=0x7ffffffff000) at oofawarewidget.cc:465 #10 0x0000000000460a3e in dw::Textblock::getWidgetAtPointLevel (this=0x801867a40, x=548, y=2569, level=<optimized out>, context=0x7ffffffff000) at textblock.cc:2823 #11 0x000000000044fc68 in dw::oof::OOFAwareWidget::getWidgetAtPoint (this=0x801867a40, x=548, y=2569, context=0x7ffffffff000) at oofawarewidget.cc:465 #12 0x000000000047b09e in dw::core::Layout::getWidgetAtPoint (this=0x8013106c0, x=548, y=2569) at layout.cc:1115 #13 0x000000000047ad2b in dw::core::Layout::processMouseEvent (this=0x8013106c0, event=0x7ffffffff0f8, type=dw::core::Layout::MOTION_NOTIFY) at layout.cc:1248 #14 0x000000000047af7c in dw::core::Layout::motionNotify (this=0x8013106c0, view=<optimized out>, x=548, y=2590, state=<optimized out>) at layout.cc:1056 #15 0x0000000000473b22 in dw::fltk::FltkViewBase::handle (this=<optimized out>, event=<optimized out>) at fltkviewbase.cc:338 #16 0x00000008006ff187 in send(int, Fl_Widget*, Fl_Window*) [clone .constprop.30] () from /usr/local/lib/libfltk.so.1.3 #17 0x0000000800700b14 in Fl::handle_(int, Fl_Window*) () from /usr/local/lib/libfltk.so.1.3 #18 0x0000000800758dbb in do_queued_events() () from /usr/local/lib/libfltk.so.1.3 #19 0x000000080075918a in fl_wait(double) () from /usr/local/lib/libfltk.so.1.3 #20 0x0000000800700796 in Fl::wait(double) () from /usr/local/lib/libfltk.so.1.3 #21 0x00000008007007fd in Fl::run() () from /usr/local/lib/libfltk.so.1.3 #22 0x000000000040c4d6 in main (argc=<optimized out>, argv=0x7ffffffff5e0) at dillo.cc:578 (gdb) Cheers, Johannes On Sat, Jan 16, 2016 at 10:10:57PM +0100, Alexander Voigt wrote: > Hi Sebastian, > > when I open my bookmarks site (dpi:/bm/) and move the mouse down over > some of my bookmark links, dillo crashes. I'm using commit > 4494:4f99dafc3e50. > > Best, > Alex > > On Sun, Jan 10, 2016 at 01:31:34PM +0100, Sebastian Geerken wrote: > > Hi! > > > > In the repository at <http://flpsed.org/hgweb/dillo_grows>, I've > > recently worked on a new approach for floats (run doxygen and read > > html/dw-size-request-pos.html if you are interested), which fixes many > > problems we have with the code at <http://hg.dillo.org/dillo>. > > > > The new version seems to work quite stable, at least much more stable > > than the version in the main repository. For this reason, I'd like to > > merge soon, and hopefully, we'll eventually have a release supporting > > floats. > > > > There are some more developments at > > <http://flpsed.org/hgweb/dillo_grows>, positioned elements and > > stacking contexts (needed for the former), but these have been > > deactivated; work will continue after floats are complete. > > > > Sebastian > > _______________________________________________ > Dillo-dev mailing list > Dillo-dev at dillo.org > http://lists.dillo.org/cgi-bin/mailman/listinfo/dillo-dev

Jan. 16, 2016

Work on floats

by Hole.destructor＠gmx.de

Hi Sebastian, when I open my bookmarks site (dpi:/bm/) and move the mouse down over some of my bookmark links, dillo crashes. I'm using commit 4494:4f99dafc3e50. Best, Alex On Sun, Jan 10, 2016 at 01:31:34PM +0100, Sebastian Geerken wrote: > Hi! > > In the repository at <http://flpsed.org/hgweb/dillo_grows>, I've > recently worked on a new approach for floats (run doxygen and read > html/dw-size-request-pos.html if you are interested), which fixes many > problems we have with the code at <http://hg.dillo.org/dillo>. > > The new version seems to work quite stable, at least much more stable > than the version in the main repository. For this reason, I'd like to > merge soon, and hopefully, we'll eventually have a release supporting > floats. > > There are some more developments at > <http://flpsed.org/hgweb/dillo_grows>, positioned elements and > stacking contexts (needed for the former), but these have been > deactivated; work will continue after floats are complete. > > Sebastian

Jan. 16, 2016

Work on floats

by sgeerken＠dillo.org

On Mi, Jan 13, 2016, Fredrik Gustafsson wrote: > Great to see progress on this! > > I tried it on a really "horrible" site, that usually gives my chrome > browser some performance issues. Unfortunately dillo freezes and no > images are loaded. > > The dillo version in debian (stable) does not freeze and the site works > well (although is ugly since floats is missing...). > > Try http://www.familjeliv.se Thanks for the feedback. I've tested http://www.familjeliv.se, which does not hang infinitely, but actually shows after some time (just under a minute on my machine). I'll examine the gprof output. Also, this version seems to crash quite often; I've both a gdb stacktrace and some valgrind warnings for further analysis. Sebastian

Jan. 16, 2016